Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
To: "Kempke, Nils-Christian" <nils-christian.kempke@intel.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
Date: Mon, 04 Jul 2022 21:54:02 +0800	[thread overview]
Message-ID: <OS3P286MB21520289433A887DC3580905F0BE9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CY4PR1101MB2071023C22B49A125ADDFE91B8BE9@CY4PR1101MB2071.namprd11.prod.outlook.com>

Hi Nils,

A friendly reminder that it is not easy to review patches outside of
the threaded email.  It would be nice if you could reply "PING"
directly in the threaded email.  That way, others can see the patches
*directly* instead of searching through the mailing list.

Thanks,
Enze

On Mon, 2022-07-04 at 10:29 +0000, Kempke, Nils-Christian via Gdb-
patches wrote:
> Ping!
> 
> Thanks,
> Nils
> 
> > -----Original Message-----
> > From: Gdb-patches <gdb-patches-bounces+nils-
> > christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke,
> > Nils-
> > Christian via Gdb-patches
> > Sent: Monday, June 27, 2022 6:59 AM
> > To: gdb-patches@sourceware.org
> > Subject: [PING] [PATCH 0/4] Adapt Fortran testsuite for ifort
> > 
> > Ping!
> > 
> > Thanks, Nils
> > 
> > > -----Original Message-----
> > > From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > > Sent: Friday, June 10, 2022 5:45 PM
> > > To: gdb-patches@sourceware.org
> > > Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > > Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort
> > > 
> > > Hi,
> > > 
> > > there were a few places in the testsuite where ifort's behavior
> > > was
> > > FAILing the tests and where I think this is not the result of an
> > > ifort
> > > bug but rather of a testsuite not forgiving enough.
> > > 
> > > The attached patches should not change the behavior for any other
> > > compiler, and I could not find any regressions with gfortran/ifx
> > > (tested
> > > with unix, unix/m32, native-gdbserver and native-extended-
> > > gdbserver).
> > > 
> > > For ifort this series improves testsuite performance if compared
> > > to the
> > > current master:
> > > 
> > > master before series:
> > > 
> > >                 === gdb Summary ===
> > > 
> > >   # of expected passes            5771
> > >   # of unexpected failures        238
> > >   # of unknown successes          1
> > >   # of known failures             1
> > >   # of untested testcases         1
> > >   # of unresolved testcases       3
> > >   # of unsupported tests          5
> > >   # of duplicate test names       3
> > > 
> > > master after series:
> > > 
> > >                 === gdb Summary ===
> > > 
> > >   # of expected passes            5847
> > >   # of unexpected failures        161
> > >   # of known failures             1
> > >   # of untested testcases         1
> > >   # of unresolved testcases       3
> > >   # of unsupported tests          5
> > >   # of duplicate test names       3
> > > 
> > > 
> > > Any feedback is appreciated,
> > > 
> > > Cheers,
> > > Nils
> > > 
> > > Nils-Christian Kempke (4):
> > >   testsuite, fortran: make mixed-lang-stack less compiler
> > > dependent
> > >   testsuite, fortran: Remove self assignment non-statements
> > >   testsuite, fortran: adapt tests for ifort's 'start' behavior
> > >   testsuite, fortran: make kfail gfortran specific
> > > 
> > >  gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5 ++++-
> > >  gdb/testsuite/gdb.fortran/function-calls.exp      |  4 +++-
> > >  gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2 +-
> > >  gdb/testsuite/gdb.fortran/library-module-main.f90 |  2 +-
> > >  gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9 ++++++++-
> > >  gdb/testsuite/gdb.fortran/module.f90              | 11 ++++++---
> > > --
> > >  gdb/testsuite/gdb.fortran/vla-type.exp            |  5 +++--
> > >  7 files changed, 26 insertions(+), 12 deletions(-)
> > > 
> > > --
> > > 2.25.1
> > 
> > Intel Deutschland GmbH
> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> > Silva
> > Chairperson of the Supervisory Board: Nicole Lau
> > Registered Office: Munich
> > Commercial Register: Amtsgericht Muenchen HRB 186928
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> Silva  
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
> 


  reply	other threads:[~2022-07-04 13:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-04 10:29 Kempke, Nils-Christian via Gdb-patches
2022-07-04 13:54 ` Enze Li via Gdb-patches [this message]
2022-07-04 14:03   ` Kempke, Nils-Christian via Gdb-patches
2022-07-04 14:43     ` Kempke, Nils-Christian via Gdb-patches
2022-07-04 14:49       ` Bruno Larsen via Gdb-patches
2022-07-04 16:09         ` Kempke, Nils-Christian via Gdb-patches
2022-07-05 13:01           ` Enze Li via Gdb-patches
  -- strict thread matches above, loose matches on Subject: below --
2022-06-10 15:44 Nils-Christian Kempke via Gdb-patches
2022-07-04 15:59 ` [PING 2][PATCH " Kempke, Nils-Christian via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS3P286MB21520289433A887DC3580905F0BE9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
    --to=gdb-patches@sourceware.org \
    --cc=enze.li@hotmail.com \
    --cc=nils-christian.kempke@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox