From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8150 invoked by alias); 8 Jan 2009 12:53:43 -0000 Received: (qmail 8127 invoked by uid 22791); 8 Jan 2009 12:53:42 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from outdoor.onevision.de (HELO outdoor.onevision.de) (212.77.172.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Jan 2009 12:53:38 +0000 Received: from sanders.onevision.de (moonrace [212.77.172.62]) by outdoor.onevision.de (8.14.3/8.13.7/ROSCH/DDB) with ESMTP id n08CrUfK010931; Thu, 8 Jan 2009 13:53:35 +0100 In-Reply-To: <20090108111002.GT3664@adacore.com> To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] Reading coff-pe-read files MIME-Version: 1.0 Message-ID: From: Kai Tietz Date: Thu, 08 Jan 2009 12:53:00 -0000 Content-Type: multipart/mixed; boundary="=_mixed 0046CFB9C1257538_=" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00150.txt.bz2 --=_mixed 0046CFB9C1257538_= Content-Type: text/plain; charset="US-ASCII" Content-length: 2722 Hi Joel, Joel Brobecker wrote on 08.01.2009 12:10:02: > > Hmm, at home it isn't hard to do this, but at office I have to fight with > > Lotus. I'll see what can do. > > Thanks for doing that. Perhaps, if Lotus doesn't muck the contents > of your emails, one solution is to inline the patch inside the email > body rather than as an attachment. If, as I fear, Lotus does things > like breaking lines, etc, then the current approach at least allows > us to receive the patch intact, which is the most important. Anyway, > all this monologue just to say: Do your best :). > > > > Can you also provide a ChangeLog entry when submitting patches? > > > > I did in my first mail. I thought there is no new one necessary. > > Hmmm, I thought I double-checked before mentioning it, sorry. > > > 2009-01-08 Kai Tietz > > > > * coff-pe-read.c (read_pe_exported_syms): Enable read of PE+ > > export directory. > > Does "PE+" mean PE for 64bit? > > > > > + int be64 = 0; > > > > + int be32 = 0; > > > > > > Would you mind explaining what "be" stands for? > > > > the "be" from "to be, or not to be" ;) > > In that case, I'd really like to use a more meaningful name. > How about pe32_p and pe64_p? Or is_pe32 and is_pe64? Fine for me, I changed the attached patch. [...] > > I think that it would be clearer to use 108 in this case than > "92 + 16", because 92 in the PE+ case doesn't really mean anything, > does it? > > > > Same here. > > > > The same reason. Structure IMAGE_DATA_DIRECTORY hasn't changed in sizes, > > therefore just the delta is necessary. > > I also suggest the same as above, if you agree. Ok, done. > > AFAIC I have no write access (or write permissions) to gbd tree. I have > > already an account and write permissions for binutils. > > Given that this patch qualifies as a good patch (or will qualify as soon > as we agree on one version of it), you are eligible for receiving "Write > After Approval" priviledges. What you need to do next, in parallel to > this discussion, is ask overseers to adjust your priviledges. This is > what the account request on sourceware says about your case: > > Note that if you already have an account on sourceware.org or > gcc.gnu.org for CVS or Subversion write access, then do not use this > form. Instead send an email to the overseers mail account at this site > telling what project you want write access to and who approved that > access. > > You can list me as the approver. Thanks, I sent mail to the overseers. Cheers, Kai | (\_/) This is Bunny. Copy and paste Bunny | (='.'=) into your signature to help him gain | (")_(") world domination. --=_mixed 0046CFB9C1257538_= Content-Type: application/octet-stream; name="pe-coff-read.diff" Content-Disposition: attachment; filename="pe-coff-read.diff" Content-Transfer-Encoding: base64 Content-length: 2794 SW5kZXg6IHNyYy9nZGIvY29mZi1wZS1yZWFkLmMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gc3JjLm9yaWcvZ2RiL2NvZmYtcGUtcmVhZC5jCisrKyBz cmMvZ2RiL2NvZmYtcGUtcmVhZC5jCkBAIC0xOTEsNiArMTkxLDggQEAgcmVh ZF9wZV9leHBvcnRlZF9zeW1zIChzdHJ1Y3Qgb2JqZmlsZSAqbwogICB1bnNp Z25lZCBjaGFyICpleHBkYXRhLCAqZXJ2YTsKICAgdW5zaWduZWQgbG9uZyBu YW1lX3J2YXMsIG9yZGluYWxzLCBuZXhwLCBvcmRiYXNlOwogICBjaGFyICpk bGxfbmFtZTsKKyAgaW50IGlzX3BlNjQgPSAwOworICBpbnQgaXNfcGUzMiA9 IDA7CiAKICAgLyogQXJyYXkgZWxlbWVudHMgYXJlIGZvciB0ZXh0LCBkYXRh IGFuZCBic3MgaW4gdGhhdCBvcmRlcgogICAgICBJbml0aWFsaXphdGlvbiB3 aXRoIHN0YXJ0X3J2YSA+IGVuZF9ydmEgZ3VhcmFudGVlcyB0aGF0CkBAIC0y MDUsNyArMjA3LDExIEBAIHJlYWRfcGVfZXhwb3J0ZWRfc3ltcyAoc3RydWN0 IG9iamZpbGUgKm8KIAogICBjaGFyIGNvbnN0ICp0YXJnZXQgPSBiZmRfZ2V0 X3RhcmdldCAob2JqZmlsZS0+b2JmZCk7CiAKLSAgaWYgKChzdHJjbXAgKHRh cmdldCwgInBlLWkzODYiKSAhPSAwKSAmJiAoc3RyY21wICh0YXJnZXQsICJw ZWktaTM4NiIpICE9IDApKQorICBpc19wZTY0ID0gKChzdHJjbXAgKHRhcmdl dCwgInBlLXg4Ni02NCIpID09IDApCisgICAgICAgICB8fCAoKHN0cmNtcCAo dGFyZ2V0LCAicGVpLXg4Ni02NCIpID09IDApKTsKKyAgaXNfcGUzMiA9ICgo c3RyY21wICh0YXJnZXQsICJwZS1pMzg2IikgPT0gMCkKKyAgICAgICAgICB8 fCAoc3RyY21wICh0YXJnZXQsICJwZWktaTM4NiIpID09IDApKTsKKyAgaWYg KCFpc19wZTMyICYmICFpc19wZTY0KQogICAgIHsKICAgICAgIC8qIFRoaXMg aXMgbm90IGFuIGkzODYgZm9ybWF0IGZpbGUuIEFib3J0IG5vdywgYmVjYXVz ZSB0aGUgY29kZQogICAgICAgICAgaXMgdW50ZXN0ZWQgb24gYW55dGhpbmcg ZWxzZS4gKkZJWE1FKiB0ZXN0IG9uIGZ1cnRoZXIKQEAgLTIxNiwxNSArMjIy LDI2IEBAIHJlYWRfcGVfZXhwb3J0ZWRfc3ltcyAoc3RydWN0IG9iamZpbGUg Km8KICAgLyogR2V0IHBlX2hlYWRlciwgb3B0aW9uYWwgaGVhZGVyIGFuZCBu dW1iZXJzIG9mIGV4cG9ydCBlbnRyaWVzLiAgKi8KICAgcGVfaGVhZGVyX29m ZnNldCA9IHBlX2dldDMyIChkbGwsIDB4M2MpOwogICBvcHRoZHJfb2ZzID0g cGVfaGVhZGVyX29mZnNldCArIDQgKyAyMDsKLSAgbnVtX2VudHJpZXMgPSBw ZV9nZXQzMiAoZGxsLCBvcHRoZHJfb2ZzICsgOTIpOworICBpZiAoaXNfcGU2 NCkKKyAgICBudW1fZW50cmllcyA9IHBlX2dldDMyIChkbGwsIG9wdGhkcl9v ZnMgKyAxMDg7CisgIGVsc2UKKyAgICBudW1fZW50cmllcyA9IHBlX2dldDMy IChkbGwsIG9wdGhkcl9vZnMgKyA5Mik7CiAKICAgaWYgKG51bV9lbnRyaWVz IDwgMSkJCS8qIE5vIGV4cG9ydHMuICAqLwogICAgIHsKICAgICAgIHJldHVy bjsKICAgICB9CiAKLSAgZXhwb3J0X3J2YSA9IHBlX2dldDMyIChkbGwsIG9w dGhkcl9vZnMgKyA5Nik7Ci0gIGV4cG9ydF9zaXplID0gcGVfZ2V0MzIgKGRs bCwgb3B0aGRyX29mcyArIDEwMCk7CisgIGlmIChpc19wZTY0KQorICAgIHsK KyAgICAgIGV4cG9ydF9ydmEgPSBwZV9nZXQzMiAoZGxsLCBvcHRoZHJfb2Zz ICsgMTEyKTsKKyAgICAgIGV4cG9ydF9zaXplID0gcGVfZ2V0MzIgKGRsbCwg b3B0aGRyX29mcyArIDExNik7CisgICAgfQorICBlbHNlCisgICAgeworICAg ICAgZXhwb3J0X3J2YSA9IHBlX2dldDMyIChkbGwsIG9wdGhkcl9vZnMgKyA5 Nik7CisgICAgICBleHBvcnRfc2l6ZSA9IHBlX2dldDMyIChkbGwsIG9wdGhk cl9vZnMgKyAxMDApOworICAgIH0KICAgbnNlY3Rpb25zID0gcGVfZ2V0MTYg KGRsbCwgcGVfaGVhZGVyX29mZnNldCArIDQgKyAyKTsKICAgc2VjcHRyID0g KHBlX2hlYWRlcl9vZmZzZXQgKyA0ICsgMjAgKwogCSAgICBwZV9nZXQxNiAo ZGxsLCBwZV9oZWFkZXJfb2Zmc2V0ICsgNCArIDE2KSk7Cg== --=_mixed 0046CFB9C1257538_=--