From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31472 invoked by alias); 3 Aug 2007 15:01:40 -0000 Received: (qmail 31456 invoked by uid 22791); 3 Aug 2007 15:01:40 -0000 X-Spam-Check-By: sourceware.org Received: from outdoor.onevision.de (HELO outdoor.onevision.de) (212.77.172.51) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 15:01:35 +0000 Received: from sanders.onevision.de (moonrace [212.77.172.62]) by outdoor.onevision.de (8.13.7/8.13.7/ROSCH/DDB) with ESMTP id l73F1Hdu025724; Fri, 3 Aug 2007 17:01:22 +0200 In-Reply-To: To: Ian Lance Taylor Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org, binutils@sourceware.org Subject: patch: libiberty pex for _WIN64 MIME-Version: 1.0 X-Mailer: Lotus Notes Release 7.0.1 January 17, 2006 Message-ID: From: Kai Tietz Date: Fri, 03 Aug 2007 15:01:00 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00055.txt.bz2 SWFuLA0KDQpJIHByZXBhcmVkIGEgcGF0Y2ggZm9yIHBleCB1c2luZyBwaWRf dCBpbnN0ZWFkIG9mIHRoZSB0eXBlICdsb25nJyBmb3IgDQpzeXN0ZW0gaGFu ZGxlcy4gVGhpcyBpcyBuZWNlc3NhcnkgZm9yIF9XSU42NCwgYmVjYXVzZSB0 aGUgbG9uZyB0eXBlIGlzbid0IA0Kd2lkZSBlbm91Z3RoIHRvIGhvbGQgYSBw b2ludGVyIGZvciB0aGlzIEFCSSBUaGUgdHlwZSBwaWRfdCBpcyBhbHdheXMg DQpkZWZpbmVkIGJ5IHRoZSBjb25maWd1cmUgaW4gY29uZmlnLmggaWYgbm90 IGRlZmluZWQgYnkgdGhlIGhlYWRlci1zZXQuIA0KVGhlcmVmb3JlIGl0IHNl ZW1zIHRvIGJlIHRoZSBiZXN0IHdheSB0byBtYWtlIHRoaXMgcnVuLg0KDQpD aGFuZ2VMb2c6DQoNCjIwMDctMDgtMDMgIEthaSBUaWV0eiAgIDxrYWkudGll dHpAb25ldmlzaW9uLmNvbT4NCg0KICAgICAgICAqIHBleC1jb21tb24uaDog KHBleF9mdW5jcyk6IFJldHlwZWQgd2FpdCBhbmQgZXhlY19jaGlsZCB0byBw aWRfdC4NCiAgICAgICAgKiBwZXgtZGpncHAuYzogTGlrZXdpc2UuDQogICAg ICAgICogcGV4LW1zZG9zLmM6IExpa2V3aXNlLg0KICAgICAgICAqIHBleC11 bml4LmM6IExpa2V3aXNlLg0KICAgICAgICAqIHBleC13aW4zMi5jOiBMaWtl d2lzZS4NCg0KQ2hlZXJzLA0KIGkuQS4gS2FpIFRpZXR6DQoNCnwgIChcXy8p ICBUaGlzIGlzIEJ1bm55LiBDb3B5IGFuZCBwYXN0ZSBCdW5ueQ0KfCAoPScu Jz0pIGludG8geW91ciBzaWduYXR1cmUgdG8gaGVscCBoaW0gZ2Fpbg0KfCAo IilfKCIpIHdvcmxkIGRvbWluYXRpb24uDQoNCi0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KICBPbmVWaXNpb24gU29m dHdhcmUgRW50d2lja2x1bmdzIEdtYkggJiBDby4gS0cNCiAgRHIuLUxlby1S aXR0ZXItU3RyYcOfZSA5IC0gOTMwNDkgUmVnZW5zYnVyZw0KICBUZWw6ICs0 OS4oMCk5NDEuNzgwMDQuMCAtIEZheDogKzQ5LigwKTk0MS43ODAwNC40ODkg LSB3d3cuT25lVmlzaW9uLmNvbQ0KICBDb21tZXJ6YmFuayBSZWdlbnNidXJn IC0gQkxaIDc1MCA0MDAgNjIgLSBLb250byA2MDExMDUwDQogIEhhbmRlbHNy ZWdpc3RlcjogSFJBIDY3NDQsIEFtdHNnZXJpY2h0IFJlZ2Vuc2J1cmcNCiAg S29tcGxlbWVudMOkcmluOiBPbmVWaXNpb24gU29mdHdhcmUgRW50d2lja2x1 bmdzIFZlcndhbHR1bmdzIEdtYkgNCiAgRHIuLUxlby1SaXR0ZXItU3RyYcOf ZSA5IOKAkyA5MzA0OSBSZWdlbnNidXJnDQogIEhhbmRlbHNyZWdpc3Rlcjog SFJCIDg5MzIsIEFtdHNnZXJpY2h0IFJlZ2Vuc2J1cmcgLSBHZXNjaMOkZnRz ZsO8aHJlcjogDQpVbHJpa2UgRMO2aGxlciwgTWFudWVsYSBLbHVnZXINCg0K >From gdb-patches-return-50083-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Aug 03 15:07:56 2007 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 11295 invoked by alias); 3 Aug 2007 15:07:56 -0000 Received: (qmail 11256 invoked by uid 22791); 3 Aug 2007 15:07:55 -0000 X-Spam-Check-By: sourceware.org Received: from a.mail.sonic.net (HELO a.mail.sonic.net) (64.142.16.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Aug 2007 15:07:50 +0000 Received: from snyder (209-204-172-156.dsl.dynamic.sonic.net [209.204.172.156]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with SMTP id l73F72Bh002207; Fri, 3 Aug 2007 08:07:02 -0700 Message-ID: <004901c7d5df$376d9420$677ba8c0@sonic.net> Reply-To: "Michael Snyder" From: "Michael Snyder" To: "Daniel Jacobowitz" Cc: "Eli Zaretskii" , References: <10431.12.7.175.2.1186103684.squirrel@webmail.sonic.net> <20070803013005.GA22901@caradoc.them.org> <006901c7d587$db360400$677ba8c0@sonic.net> <001301c7d5db$d5702880$677ba8c0@sonic.net> <20070803145142.GA25941@caradoc.them.org> Subject: Re: [PATCH] symfile.c, find_separate_debug_file Date: Fri, 03 Aug 2007 15:07:00 -0000 X-Mailer: Microsoft Outlook Express 6.00.2800.1437 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2007-08/txt/msg00056.txt.bz2 Content-length: 959 ----- Original Message ----- From: "Daniel Jacobowitz" To: "Michael Snyder" Cc: "Eli Zaretskii" ; Sent: Friday, August 03, 2007 7:51 AM Subject: Re: [PATCH] symfile.c, find_separate_debug_file > On Fri, Aug 03, 2007 at 07:37:35AM -0700, Michael Snyder wrote: > > Yes, I understood exactly what Daniel meant. I was saying, > > the existing code uses the literal '/' instead of the symbolic > > DIR_SEPARATOR. > > > > I offered to have another go at the code and clean up the literals, > > but as a separate patch to this one. > > You added two lines: > > ! if (debugfile[strlen (debugfile) - 1] != '/' && dir[0] != '/') > ! strcat (debugfile, "/"); > > I think you're talking about the second one, which adds a "/". That's > fine, but the first line isn't. Other places in that function which > compare against '/' use IS_DIR_SEPARATOR already. Fair enough. ;-)