From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15722 invoked by alias); 18 Aug 2009 12:24:07 -0000 Received: (qmail 15698 invoked by uid 22791); 18 Aug 2009 12:24:05 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_20,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 18 Aug 2009 12:23:58 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.14.3/8.13.8) with ESMTP id n7ICNQFD609886 for ; Tue, 18 Aug 2009 12:23:26 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7ICNQUm2572428 for ; Tue, 18 Aug 2009 14:23:26 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7ICNQal006075 for ; Tue, 18 Aug 2009 14:23:26 +0200 Received: from d12ml069.megacenter.de.ibm.com (d12ml069.megacenter.de.ibm.com [9.149.167.186]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n7ICNPvo006069; Tue, 18 Aug 2009 14:23:26 +0200 In-Reply-To: <8ac60eac0908171415m47d28495t5311a0d2c7616922@mail.gmail.com> To: Paul Pluzhnikov Cc: gdb-patches ml , Tom Tromey MIME-Version: 1.0 Subject: Re: [patch] Speed up find_pc_section From: Ulrich Weigand Message-ID: Date: Tue, 18 Aug 2009 13:48:00 -0000 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00275.txt.bz2 Paul Pluzhnikov wrote on 08/17/2009 11:15:20 PM: > On Mon, Aug 17, 2009 at 12:54 PM, Ulrich Weigand=20 wrote: >=20 > > Section can partially overlap with overlays ... >=20 > Yes, the same thing also is happening on Darwin; some discussion here: > http://sourceware.org/ml/gdb-patches/2009-08/msg00201.html >=20 > The thing is: when the assumptions are violated, (AFAICT)=20 find_pc_section > couldn't have worked correctly before my patch, except by accident. Which assumptions? For overlay sections, find_pc_section would delegate its work to find_pc_mapped_section anyway: s =3D find_pc_mapped_section (pc); if (s) return s; so the rest of find_pc_section does not need to handle overlay sections=20 ... It just shouldn't abort simply because overlays are present anywhere. > What is the simplest way to test overlays? The only target with overlays I know to test is the SPU. (Apparently,=20 d10v and m32r also support overlays, but I don't know how to test those.) I'd be happy to test patches on the SPU ... Mit freundlichen Gruessen / Best Regards Ulrich Weigand --=20 Dr. Ulrich Weigand | Phone: +49-7031/16-3727 STSM, GNU compiler and toolchain for Linux on System z and Cell/B.E. IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter | Gesch=E4ftsf=FChrung: Eri= ch=20 Baier Sitz der Gesellschaft: B=F6blingen | Registergericht: Amtsgericht=20 Stuttgart, HRB 243294