From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XCTOOU7aZmFrAwAAWB0awg (envelope-from ) for ; Wed, 13 Oct 2021 09:08:30 -0400 Received: by simark.ca (Postfix, from userid 112) id DCA5A1F0BB; Wed, 13 Oct 2021 09:08:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A480F1ECEB for ; Wed, 13 Oct 2021 09:08:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 04C5F3858437 for ; Wed, 13 Oct 2021 13:08:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 04C5F3858437 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634130509; bh=di/pPXzBGNpXcUAWJpNumBWruaE1M5HFRYhvMVTp/Fo=; h=In-Reply-To:Subject:To:Date:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=p7Y+ckl+lxrmImjgj5tWXZmZx7OrxcaZMcaeJcDRIfjHHQsfs9URJqnvvPm2JeG3G DuRBxzJHLhnbDNeM/r3XJG84KOs38L+J5qn0Q7z/7MQ4XvciD/s481yFSnglG0f8hp NsgC1jbZ9kTIL02cjVi7K/aG6a22aMVeX1kpM7xk= Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id CA3783858C3A for ; Wed, 13 Oct 2021 13:08:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA3783858C3A Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19DCMcRR022225 for ; Wed, 13 Oct 2021 09:08:10 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3bns3f9b34-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 13 Oct 2021 09:08:10 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 19DD3R9s006497 for ; Wed, 13 Oct 2021 13:08:09 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma01dal.us.ibm.com with ESMTP id 3bnm3adgu2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 13 Oct 2021 13:08:09 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 19DD87B438339018 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Oct 2021 13:08:07 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BAFD2BE056; Wed, 13 Oct 2021 13:08:07 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A6ACBBE051; Wed, 13 Oct 2021 13:08:07 +0000 (GMT) Received: from mww0272.dal12m.mail.ibm.com (unknown [9.208.64.29]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTPS; Wed, 13 Oct 2021 13:08:07 +0000 (GMT) MIME-Version: 1.0 In-Reply-To: <9bf3148807544fd7b83ec9334e9c18cf7b9bee81.camel@us.ibm.com> Subject: Re: [PATCH] Powerpc: Add support for openat and fstatat syscalls To: "Carl Love" Message-ID: Date: Wed, 13 Oct 2021 15:08:05 +0200 References: <22a9ea816266f1b9e6948a396a1dc45cb5f8f153.camel@us.ibm.com> <287929e6460980eb4e0d12a52593689ebf4f309a.camel@us.ibm.com> <9bf3148807544fd7b83ec9334e9c18cf7b9bee81.camel@us.ibm.com> X-KeepSent: 8D70D176:67629273-C125876D:00479F81; name=$KeepSent; type=4 X-Mailer: IBM Notes Release 9.0.1FP7 Octobe4, 2013 X-Disclaimed: 4919 X-MIMETrack: CD-MIME by Router on MWW0272/03/M/IBM at 10/13/2021 13:08:07, CD-MIME complete at 10/13/2021 13:08:07,Itemize by Router on MWW0272/03/M/IBM at 10/13/2021 13:08:07 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: iqkz890nPR94mu14IN-uqKC5yXJNs07C X-Proofpoint-ORIG-GUID: iqkz890nPR94mu14IN-uqKC5yXJNs07C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-13_05,2021-10-13_02,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=737 spamscore=0 bulkscore=0 phishscore=0 adultscore=0 clxscore=1015 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110130088 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Ulrich Weigand via Gdb-patches Reply-To: Ulrich Weigand Cc: Rogerio Alves , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" "Carl Love" wrote on 12.10.2021 21:13:43: > So, it says to me that calling newfstatat for both, as Ulrich said, is > fine. I do think this is all rather convoluted. I guess it is one of > those things that evolved over time into something more convoulted and > confusing then it should be. > > So as you said "...there is not a significant difference between the > two syscalls". The two syscalls are similar, but not identical. In particular, they differ in the amount of memory that is accessed: sys=5Fnewfstatat accesses a "struct stat" (144 bytes on 64-bit / 88 bytes on 32-bit) sys=5Ffstatat64 accesses a "struct stat64" (104 bytes on both 64-bit and 32-bit) Since this affects the memory being recorded, it would actually be preferable to use the correct system call depending on ABI. Note that in general, there are more cases of syscall numbers refering to different system calls depending on the ABI (64-bit vs. 32-bit), so it would make sense to add support for that in general. As an example, you may want to look s390=5Fcanonicalize=5Fsyscall, which does make the distinction between 64-bit and 32-bit ABI. Bye, Ulrich