Jim Blandy ะดำฺ 2006-12-06 04:00:46: > > bjgnu@sunnorth.com.cn writes: > > I'v ported GDB-6.5.90 to Score target and SunNorth has assigned the forms > > to the FSF. > > The following is a patch adding Score target to GDB and i hope i could be > > the Score maintainer. > > I'v posted the patch to gdb@sourceware.org on 2006.12.4, but get no reply, > > maybe it's a wrong place. > > Could anyone help me checking my patch? I really appreciate your help. > > I've checkout the current-cvs and all testpatterns run pass in DejaGNU. > > Some FAILs are target dependent. I've checked these FAILs and they are not > > gdb bug. > > I hope Score target can be added to GDB-6.6 if possible. > > Hi, Qinwei. gdb-patches is the right mailing list for this. However, > it may take us a while to review patches; there aren't very many > reviewers. If you don't get a response within a week, then please > post a 'ping' patch. > > Your work is more likely to be reviewed if you post it as a multi-file > patch which can be applied by running 'patch -p0 < foo.patch' in the > top-level source directory. Unified diffs (diff -u) seem to be the > preferred format. > > Your embed.mt file says: > > OOLIB_PATH=../../sim_lib/oolib_install > TDEPFILES= score-tdep.o > SIM_OBS= remote-sim.o > TM_CLIBS = -L $(OOLIB_PATH)/lib -lsc_gdb -lsc_tools -lsc_sim - > lsc_ice -lprobe -lscore -lsocshell -lsoc -lpackages -lstdc++ -lSDL -lSDL_image > SIM= ../sim/score/libsim.a > > It looks to me as if this means that the 'score' target depends on a > simulator located outside the GDB tree. Is this simulator Free > software? Please make sure your GDB satisfies the license conditions > explained in the COPYING file. If you can release the simulator as > Free software as well, that would be best. Otherwise, you may be able > to satisfy the license simply by building GDB without the simulator. > > It seems the simulator in your post is just a stub. We would rather > not have stub code in GDB. > > I don't see a patch to 'sim/configure.in' in your post. > 'sim/configure' is generated automatically from configure.in using > autoconf. Patches should generally not include changes to generated > files, like 'configure', because they can be large. > > I have some comments on score-tdep.c, but let's get the above issues > sorted out first. > > Finally, I don't know how Joel Brobecker, our release manager, feels > about including new ports this late in the process. On the one hand, > if the port is self-contained, it is unlikely to break other code. On > the other hand, we have already produced our first release candidate. > I'll leave the decision to him. > > Thanks for posting this port! Hi Jim, Thanks for your detailed explanation! I still have some questions. If we won't open simulator source, can we put simulator libs(11 libs) and simstub.c in the dir 'gdb-6.5/sim/score'? If we can, i will send you these libs. Otherwise, i post the patch in the following just containing 'score' gdb but without simulator. I diff gdb-6.5 gdb-6.5-score in the top-level and the result is the following. Thanks for checking my patch and i hope to hear your advice on score-tdep.c. Only in ../gdb-6.5-score/gdb/config: score diff -r -u ./gdb/configure.tgt ../gdb-6.5-score/gdb/configure.tgt --- ./gdb/configure.tgt 2006-11-22 17:31:03.000000000 +0800 +++ ../gdb-6.5-score/gdb/configure.tgt 2006-12-06 11:53:23.000000000 +0800 @@ -21,6 +21,7 @@ m88*) gdb_target_cpu=m88k ;; mips*) gdb_target_cpu=mips ;; powerpc*) gdb_target_cpu=powerpc ;; +score*) gdb_target_cpu=score ;; sparc*) gdb_target_cpu=sparc ;; thumb*) gdb_target_cpu=arm ;; s390*) gdb_target_cpu=s390 ;; @@ -174,6 +175,7 @@ rs6000-*-aix4*) gdb_target=aix4 ;; rs6000-*-*) gdb_target=rs6000 ;; +score-*-*) gdb_target=embed ;; s390*-*-*) gdb_target=s390 build_gdbserver=yes ;; Only in ../gdb-6.5-score/gdb: score-tdep.c Only in ../gdb-6.5-score/gdb: score-tdep.h Best regards, Qinwei Mail qinwei@sunnorth.com.cn Phone +86-010-62981668-2708 Fax +86-010-62985972