Hi Andrew,



>I need to think about both gdbarch.sh and tm-sysv4.h.  Denis, can you
>expand?


The tm-sysv4.h patch was simply needed to get the stuff to compile
multiarch,
I don't think most/all other stuff which uses tm-sysv4.h are compiled
multiarch which is
why I don't think you've seen this before.
 The SKIP_TRAMPOLINE_CODE macro is also defined in gdbarch.h.


The multiarch CALL_DUMMY_BREAKPOINT_OFFSET function that was emitted by
the old gdbarch.sh didn't check CALL_DUMMY_BREAKPOINT_OFFSET_P to see
that there was no multiarch version of this function available, therefore
my code failed the runtime check on startup without this fix.

I do a set_gdbarch_call_dummy_breakpoint_offset_p(gdbarch,0); to indidcate
that we don't have a CALL_DUMMY_BREAKPOINT_OFFSET function for s390 in
tm-s390.c

I believe/hope that was the intention of the CALL_DUMMY_BREAKPOINT_OFFSET_P
macro.

Hope this clears things up :-).


D.J. Barrow Gnu/Linux for S/390 kernel developer
eMail: djbarrow@de.ibm.com,barrow_dj@yahoo.com
Phone: +49-(0)7031-16-2583
IBM Germany Lab, Schönaicherstr. 220, 71032 Böblingen