From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27369 invoked by alias); 12 Aug 2013 12:02:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27327 invoked by uid 89); 12 Aug 2013 12:02:00 -0000 X-Spam-SWARE-Status: No, score=-6.0 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 Received: from e28smtp09.in.ibm.com (HELO e28smtp09.in.ibm.com) (122.248.162.9) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 12 Aug 2013 12:01:59 +0000 Received: from /spool/local by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Aug 2013 17:26:14 +0530 Received: from d28dlp03.in.ibm.com (9.184.220.128) by e28smtp09.in.ibm.com (192.168.1.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 12 Aug 2013 17:26:13 +0530 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by d28dlp03.in.ibm.com (Postfix) with ESMTP id CB45E1258043 for ; Mon, 12 Aug 2013 17:31:32 +0530 (IST) Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r7CC3A8a37224628 for ; Mon, 12 Aug 2013 17:33:10 +0530 Received: from d28av02.in.ibm.com (localhost [127.0.0.1]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r7CC1nIs026895 for ; Mon, 12 Aug 2013 17:31:50 +0530 Received: from d23ml188.in.ibm.com (d23ml188.in.ibm.com [9.182.8.144]) by d28av02.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r7CC1nNo026826; Mon, 12 Aug 2013 17:31:49 +0530 In-Reply-To: References: Subject: Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined. X-KeepSent: 4E4883FF:74E1DEB7-65257BC5:003D5DFF; type=4; name=$KeepSent To: David Edelsohn Cc: gdb-patches@sourceware.org, Mark Kettenis , Ulrich Weigand Message-ID: From: Raunaq 12 Date: Mon, 12 Aug 2013 12:02:00 -0000 MIME-Version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: quoted-printable X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13081211-2674-0000-0000-00000A33EB0A X-SW-Source: 2013-08/txt/msg00297.txt.bz2 David Edelsohn wrote on 08/09/2013 09:23:42 PM: > From: David Edelsohn > To: Raunaq 12/India/IBM@IBMIN, Mark Kettenis , Ulrich Weigand > > Cc: gdb-patches@sourceware.org > Date: 08/09/2013 09:22 PM > Subject: Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined. > > > When GDB is compiled in 64 BIT mode ptrace and ptracex calls are not defined on AIX. > > So, instead we check if ptrace64 is defined, if it is then we call that instead of ptrace/x. > > Have you tested the patch in both 32 bit mode and 64 bit mode for both host GDB and target > debugee? Yes, ran the tests in testsuite/gdb.base and any new failures did not arise when >I tried the earlier version of this patch from last year and experienced problems > debugging in 32 bit mode (I no longer could debug GCC). The earlier version of this patch was using ptrace64 only if BFD64 was defined, i.e. when GDB was built in 64 BIT mode. Did you build 32 bit gdb? If so, according to the previous version of this patch, no ptrace related calls were changed as ptrace64 was only called if BFD64 was defined. Could you please resend the error you got while debugging 32 bit GCC to my mail id? I can look into it to see where the problem is coming from. > ptrace, ptracex and ptrace64 are defined in syscalls.exp. > > ptrace64=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 syscall3264 > # 32 > ptrace=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 syscall32 > ptracex=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 syscall32 > As you wrote, ptrace and ptracex are 32 bit only API; ptrace64 is available as 32 bit and 64 bit > API. ptrace64 is suppose to support 32 bit debugee targets, but I experienced problems. > > ptrace64 will be discovered as supported by configure when building 32 bit GDB. > Is your intention to always use ptrace64 when it is available or only to use it for GDB hosted on > 64 bit mode? My initial intention was to use ptrace64 only if ptrace64 was available and GDB was built in 64 BIT. But after a few discussions over this, I decided to use ptrace64 when ever the API is defined. So, this present patch would use ptrace64 even for a 32 bit build as you rightly noticed. This did not change the test results for a 32 bit build of GDB. Thanks, Raunaq M. Bathija