From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11165 invoked by alias); 7 Aug 2013 13:36:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11140 invoked by uid 89); 7 Aug 2013 13:36:31 -0000 X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO e28smtp05.in.ibm.com) (122.248.162.5) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 07 Aug 2013 13:36:30 +0000 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 7 Aug 2013 19:00:12 +0530 Received: from d28dlp02.in.ibm.com (9.184.220.127) by e28smtp05.in.ibm.com (192.168.1.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 7 Aug 2013 19:00:10 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 22D51394004E for ; Wed, 7 Aug 2013 19:06:09 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r77DbUt938731814 for ; Wed, 7 Aug 2013 19:07:30 +0530 Received: from d28av04.in.ibm.com (localhost [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r77DaE7W014964 for ; Wed, 7 Aug 2013 19:06:14 +0530 Received: from d23ml188.in.ibm.com (d23ml188.in.ibm.com [9.182.8.144]) by d28av04.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r77DaEoZ014947; Wed, 7 Aug 2013 19:06:14 +0530 In-Reply-To: <201308011325.r71DPfva000959@glazunov.sibelius.xs4all.nl> References: <201308011325.r71DPfva000959@glazunov.sibelius.xs4all.nl> Subject: Re: [PATCH 4/5] powerpc64-aix ptrace64 when defined. X-KeepSent: 255B53E6:ACC02537-65257BC0:0049EB72; type=4; name=$KeepSent To: Mark Kettenis , Ulrich Weigand , gdb-patches@sourceware.org Cc: tromey@redhat.com Message-ID: From: Raunaq 12 Date: Wed, 07 Aug 2013 13:36:00 -0000 MIME-Version: 1.0 Content-type: multipart/mixed; Boundary="0__=EABBF153DFDA6DE28f9e8a93df938690918cEABBF153DFDA6DE2" Content-Disposition: inline X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13080713-8256-0000-0000-000008B1A9D4 X-Virus-Found: No X-SW-Source: 2013-08/txt/msg00196.txt.bz2 --0__=EABBF153DFDA6DE28f9e8a93df938690918cEABBF153DFDA6DE2 Content-type: text/plain; charset=US-ASCII Content-length: 1039 > > When GDB is compiled in 64 BIT mode ptrace and ptracex calls are not > > defined on AIX. > > So, instead we check if ptrace64 is defined, if it is then we call that > > instead of ptrace/x. > > > > Kindly review this. Thanks. > > I'm basically happy with the gdb_ptrace.h bit. You could apply some > of the advice about avoiding unecessary casts to rs600-nat.c Hi Mark, Removed the unnecessary casts from pid in rs6000-nat.c as well. If it is Okay to commit, Ulrich, kindly find the Changelog and attached patch below. This patch changes configure.ac so configure and config.in should be regenerated. --- Changelog :- * gdb_ptrace.h: Use ptrace64 instead of ptrace if HAVE_PTRACE64 is defined. * rs6000-nat.c: Check for __ld_info64_ if compiling 64 BIT gdb. (rs6000_ptrace32): Call ptrace64 instead of ptrace if present. (rs6000_ptrace64): Call ptace64 instead of ptracex if present. * configure.ac: Check for ptrace64. * configure, config.in: Regenerate. (See attached file: gdb-7.6-defptrace64.patch) Thanks, Raunaq M. Bathija --0__=EABBF153DFDA6DE28f9e8a93df938690918cEABBF153DFDA6DE2 Content-type: application/octet-stream; name="gdb-7.6-defptrace64.patch" Content-Disposition: attachment; filename="gdb-7.6-defptrace64.patch" Content-transfer-encoding: base64 Content-length: 3079 SW5kZXg6IC4vZ2RiL2dkYl9wdHJhY2UuaA0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KLS0tIC4vZ2RiLm9yaWcvZ2RiX3B0cmFjZS5oDQorKysgLi9nZGIv Z2RiX3B0cmFjZS5oDQpAQCAtMTM1LDcgKzEzNSwxNSBAQA0KICAgIHplcm8u ICAqLw0KIA0KICNpZmRlZiBQVFJBQ0VfVFlQRV9BUkc1DQotIyBkZWZpbmUg cHRyYWNlKHJlcXVlc3QsIHBpZCwgYWRkciwgZGF0YSkgcHRyYWNlIChyZXF1 ZXN0LCBwaWQsIGFkZHIsIGRhdGEsIDApDQorIyBpZmRlZiBIQVZFX1BUUkFD RTY0DQorIyAgZGVmaW5lIHB0cmFjZShyZXF1ZXN0LCBwaWQsIGFkZHIsIGRh dGEpIFwNCisgICAgICAgICAgcHRyYWNlNjQgKHJlcXVlc3QsIHBpZCwgYWRk ciwgZGF0YSwgMCkNCisjICB1bmRlZiBQVFJBQ0VfVFlQRV9BUkczDQorIyAg ZGVmaW5lIFBUUkFDRV9UWVBFX0FSRzMgbG9uZyBsb25nDQorIyBlbHNlDQor IyAgZGVmaW5lIHB0cmFjZShyZXF1ZXN0LCBwaWQsIGFkZHIsIGRhdGEpIFwN CisgICAgICAgICAgcHRyYWNlIChyZXF1ZXN0LCBwaWQsIGFkZHIsIGRhdGEs IDApDQorIyBlbmRpZg0KICNlbmRpZg0KIA0KICNlbmRpZiAvKiBnZGJfcHRy YWNlLmggKi8NCkluZGV4OiAuL2dkYi9yczYwMDAtbmF0LmMNCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0NCi0tLSAuL2dkYi5vcmlnL3JzNjAwMC1uYXQuYw0K KysrIC4vZ2RiL3JzNjAwMC1uYXQuYw0KQEAgLTY2LDcgKzY2LDcgQEANCiAv KiBJbiAzMi1iaXQgY29tcGlsYXRpb24gbW9kZSAod2hpY2ggaXMgdGhlIG9u bHkgbW9kZSBmcm9tIHdoaWNoIHB0cmFjZSgpDQogICAgd29ya3Mgb24gNC4z KSwgX19sZF9pbmZvMzIgaXMgI2RlZmluZWQgYXMgZXF1aXZhbGVudCB0byBs ZF9pbmZvLiAgKi8NCiANCi0jaWZkZWYgX19sZF9pbmZvMzINCisjaWYgZGVm aW5lZCAoX19sZF9pbmZvMzIpIHx8IGRlZmluZWQgKF9fbGRfaW5mbzY0KQ0K ICMgZGVmaW5lIEFSQ0gzMjY0DQogI2VuZGlmDQogDQpAQCAtMTMyLDcgKzEz MiwxMSBAQA0KIHN0YXRpYyBpbnQNCiByczYwMDBfcHRyYWNlMzIgKGludCBy ZXEsIGludCBpZCwgaW50ICphZGRyLCBpbnQgZGF0YSwgaW50ICpidWYpDQog ew0KKyAgI2lmZGVmIEhBVkVfUFRSQUNFNjQNCisgIGludCByZXQgPSBwdHJh Y2U2NCAocmVxLCBpZCwgKGxvbmcgbG9uZykgYWRkciwgZGF0YSwgYnVmKTsN CisgICNlbHNlDQogICBpbnQgcmV0ID0gcHRyYWNlIChyZXEsIGlkLCAoaW50 ICopYWRkciwgZGF0YSwgYnVmKTsNCisgICNlbmRpZg0KICNpZiAwDQogICBw cmludGYgKCJyczYwMDBfcHRyYWNlMzIgKCVkLCAlZCwgMHgleCwgJTA4eCwg MHgleCkgPSAweCV4XG4iLA0KIAkgIHJlcSwgaWQsICh1bnNpZ25lZCBpbnQp YWRkciwgZGF0YSwgKHVuc2lnbmVkIGludClidWYsIHJldCk7DQpAQCAtMTQ2 LDcgKzE1MCwxMSBAQA0KIHJzNjAwMF9wdHJhY2U2NCAoaW50IHJlcSwgaW50 IGlkLCBsb25nIGxvbmcgYWRkciwgaW50IGRhdGEsIHZvaWQgKmJ1ZikNCiB7 DQogI2lmZGVmIEFSQ0gzMjY0DQorICAjaWZkZWYgSEFWRV9QVFJBQ0U2NA0K KyAgaW50IHJldCA9IHB0cmFjZTY0IChyZXEsIGlkLCBhZGRyLCBkYXRhLCBi dWYpOw0KKyAgI2Vsc2UNCiAgIGludCByZXQgPSBwdHJhY2V4IChyZXEsIGlk LCBhZGRyLCBkYXRhLCBidWYpOw0KKyAgI2VuZGlmDQogI2Vsc2UNCiAgIGlu dCByZXQgPSAwOw0KICNlbmRpZg0KSW5kZXg6IC4vZ2RiL2NvbmZpZ3VyZS5h Yw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIC4vZ2RiLm9yaWcvY29u ZmlndXJlLmFjDQorKysgLi9nZGIvY29uZmlndXJlLmFjDQpAQCAtMTE4MCw3 ICsxMTgwLDcgQEANCiAJCXNpZ2FjdGlvbiBzaWdwcm9jbWFzayBzaWdzZXRt YXNrIHNvY2tldHBhaXIgc3lzY2FsbCBcDQogCQl0dHJhY2Ugd2JvcmRlciB3 cmVzaXplIHNldGxvY2FsZSBpY29udmxpc3QgbGliaWNvbnZsaXN0IGJ0b3dj IFwNCiAJCXNldHJsaW1pdCBnZXRybGltaXQgcG9zaXhfbWFkdmlzZSB3YWl0 cGlkIGxzdGF0IFwNCi0JCWZkd2FsayBwaXBlMl0pDQorCQlmZHdhbGsgcGlw ZTIgcHRyYWNlNjRdKQ0KIEFNX0xBTkdJTkZPX0NPREVTRVQNCiANCiAjIENo ZWNrIHRoZSByZXR1cm4gYW5kIGFyZ3VtZW50IHR5cGVzIG9mIHB0cmFjZS4g IE5vIGNhbm5lZCB0ZXN0IGZvcg0K --0__=EABBF153DFDA6DE28f9e8a93df938690918cEABBF153DFDA6DE2--