Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kai Tietz <Kai.Tietz@onevision.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
	        Mark Kettenis <mark.kettenis@xs4all.nl>,
	        Pedro Alves <pedro@codesourcery.com>
Subject: Re: Build failure for x86_64-pc-mingw32 target
Date: Wed, 06 May 2009 11:36:00 -0000	[thread overview]
Message-ID: <OF013BD42C.570D13F2-ONC12575AE.003F7ED5-C12575AE.003FAF2D@onevision.de> (raw)
In-Reply-To: <daef60380905060420n428e7e2dj2d089d63b476cc53@mail.gmail.com>

gdb-patches-owner@sourceware.org wrote on 06.05.2009 13:20:10:

> The patch is checked in.
> 
> 2009-05-06  Hui Zhu  <teawater@gmail.com>
> 
>    * i386-tdep.c (i386_process_record): Change bzero to memset.
> 
> Thanks,
> Hui
> 
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.271
> retrieving revision 1.272
> diff -u -r1.271 -r1.272
> --- src/gdb/i386-tdep.c   2009/05/01 08:09:16   1.271
> +++ src/gdb/i386-tdep.c   2009/05/06 11:16:40   1.272
> @@ -2993,7 +2993,7 @@
>    uint32_t opcode;
>    struct i386_record_s ir;
> 
> -  bzero (&ir, sizeof (struct i386_record_s));
> +  memset (&ir, 0, sizeof (struct i386_record_s));
>    ir.regcache = regcache;
>    ir.addr = addr;
>    ir.aflag = 1;
> 
> 
> On Wed, May 6, 2009 at 18:46, Hui Zhu <teawater@gmail.com> wrote:
> > OK.  I will post a patch to change bzero to memset.
> >
> > Thanks for your help guys.
> >
> > Hui
> >
> > On Wed, May 6, 2009 at 17:38, Pedro Alves <pedro@codesourcery.com> 
wrote:
> >> On Wednesday 06 May 2009 10:05:09, Hui Zhu wrote:
> >>> mingw32 don't have bzero?
> >>> Could you please help me try to build some code that have bzero in 
mingw?
> >>
> >> Please don't use bzero, use memset instead.  Patch doing that 
pre-approved.
> >>
> >> (Kai, please don't reply to unrelated threads to start a new topic. 
 Start
> >> a new thread instead.)
> >>
> >> --
> >> Pedro Alves
> >>
> >
> 

Hello,

I test build for x64 and it works now again.

Pedro, sorry. Wasn't by intention.

Hui, thanks for fixing it,

Cheers,
Kai

|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.


  reply	other threads:[~2009-05-06 11:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30  6:38 [RFA] Fix memory leak in gdbserver Doug Evans
2009-04-30  9:28 ` Pedro Alves
2009-05-06  8:50   ` Build failure for x86_64-pc-mingw32 target Kai Tietz
2009-05-06  9:05     ` Hui Zhu
2009-05-06  9:37       ` Pedro Alves
2009-05-06 10:46         ` Hui Zhu
2009-05-06 11:20           ` Hui Zhu
2009-05-06 11:36             ` Kai Tietz [this message]
2009-05-06 16:03         ` [ARI] Add "bzero" (was: "Re: Build failure for x86_64-pc-mingw32 target") Joel Brobecker
2009-05-06 16:53           ` Joel Brobecker
2009-05-06 18:11           ` Eli Zaretskii
2009-05-06 18:37             ` Joel Brobecker
2009-05-18 19:24           ` [ARI] Add "bzero" Tom Tromey
2009-05-20  5:19             ` Joel Brobecker
2009-05-21  0:27             ` Joel Brobecker
2009-05-27 18:15               ` Tom Tromey
2009-05-06 10:19       ` Build failure for x86_64-pc-mingw32 target Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF013BD42C.570D13F2-ONC12575AE.003F7ED5-C12575AE.003FAF2D@onevision.de \
    --to=kai.tietz@onevision.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=pedro@codesourcery.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox