From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92327 invoked by alias); 6 Jan 2020 10:14:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92319 invoked by uid 89); 6 Jan 2020 10:14:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.2 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:6883 X-HELO: NAM10-BN7-obe.outbound.protection.outlook.com Received: from mail-bn7nam10on2056.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) (40.107.92.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2020 10:14:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=efzUOtna01MkoAvcxAkVA/LcmXvU3ytCrCjgTefABJm1uESjFVq449pXpx5yYyLjoVMQQ0y+u1iog2tVSOdYdUeUUY0T9tUopavF7yXEXfUVF19WhFjDPg1D82MTJyT1R0luEbfGlkPccKGIOBRCLtil7GznvoGmk+lAR0/hIO31gdR/ZkmcEdshr7I2NLwv4jVU7VHqtEKKxOa2by9lkyBD4mW0+Cj8pjVvO+tNlQUUbu/KHZbWHZljJpNURGW/NIbwQ8xGI1n0Y1V31n23Tyx+bb6LeXXbsWaRnygzikgHSSkbR2dohJo7vl5S1kXvixhBVliR1WJPOfQISnQyYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4j2GZLiGXNNXIF/8V+YzSpfjleXMYGonYGVvQYBllR0=; b=KUKQygtZ1zKW8NOQSk9o8R5TKVrjBTCpO+TP7uTypyyDFjNJd5HUpMm2RabqG0kQjUakRHhwejtwLnHIbI4Mr7UhSfCfMern2pJyK4r23LydIiDevd3Zh+tl3rersElU3GL5oQ6xk1ruo7ZIakey/pP+enicFg8RjY6su+5+E3o546HyBqSh4qCXOzq2Brf/ZVdh7pgHTRb6ef6yBYSrwEOgh2ORHvZHmPFAoQUCeuGG4Fiv67PFvPE1XAmwxfDDhBWNQrcacCa5x/YbprFWIXgAXPnP3tWbpEByRvEns4H2kLSU0bhQgzHsn6rAauhDeN56qSf23i6/1hGDoCuxvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4j2GZLiGXNNXIF/8V+YzSpfjleXMYGonYGVvQYBllR0=; b=0TleWAVPaXAmghgCFjWUO9V3Np9T9lj+kaBg5j+iIPSLwM6D7HJE4wtPWa+C8LfjhmRrEtKpqHFieG/tL7G2R0VWlI5SMepRwfL8J2ijN009T1tecU1eQPqLDbqZcIyPW5UN8iCDxRD0nqwTURQecNidHXvYwG2t68kwf56xfy0= Received: from MN2PR12MB3744.namprd12.prod.outlook.com (10.255.237.80) by MN2PR12MB3645.namprd12.prod.outlook.com (20.178.243.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.12; Mon, 6 Jan 2020 10:14:33 +0000 Received: from MN2PR12MB3744.namprd12.prod.outlook.com ([fe80::c1cb:697d:c30d:718c]) by MN2PR12MB3744.namprd12.prod.outlook.com ([fe80::c1cb:697d:c30d:718c%5]) with mapi id 15.20.2602.015; Mon, 6 Jan 2020 10:14:33 +0000 From: "Achra, Nitika" To: Simon Marchi , "gdb-patches@sourceware.org" CC: "George, Jini Susan" , Ali Tamur Subject: RE: [PATCH] Support for DWARF5 location lists entries Date: Mon, 06 Jan 2020 10:14:00 -0000 Message-ID: References: <48103fb5-d3ee-0ae0-92a7-f1c02debd449@simark.ca> In-Reply-To: msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_enabled: true msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_setdate: 2020-01-06T10:14:30Z msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_method: Standard msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_name: Internal Use Only - Unrestricted msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_actionid: 88120aeb-50ae-43d2-8eb5-0000ade17564 msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_contentbits: 0 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Nitika.Achra@amd.com; x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:7691; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oTQya5DnJlWOgzzeS7oQTqbEaZWHextcEJKsoLgrJlHo+AcjmfnWY+Oekhkd4oR8b84Ny88heBKUt/CQVDs9+Q== X-SW-Source: 2020-01/txt/msg00102.txt.bz2 W0FNRCBPZmZpY2lhbCBVc2UgT25seSAtIEludGVybmFsIERpc3RyaWJ1dGlv biBPbmx5XQ0KDQpIaSBTaW1vbiwNCg0KU29ycnkuIEkgc2VudCB0aGUgd3Jv bmcgcGF0Y2ggYnkgbWlzdGFrZS4gVXBkYXRpbmcgdGhlIHBhdGNoLg0KDQoq SGFuZGxlIERXX0xMRV9iYXNlX2FkZHJlc3N4LCBEV19MTEVfc3RhcnR4X2xl bmd0aCBhbmQgRFdfTExFX3N0YXJ0X2xlbmd0aC4NCg0KVGVzdGVkIGJ5IHJ1 bm5pbmcgdGhlIHRlc3RzdWl0ZSBiZWZvcmUgYW5kIGFmdGVyIHRoZSBwYXRj aCBhbmQgdGhlcmUgaXMgbm8gaW5jcmVhc2UgaW4gdGhlIG51bWJlciBvZiB0 ZXN0IGNhc2VzIHRoYXQgZmFpbHMuDQpUZXN0ZWQgd2l0aCBib3RoIC1nZHdh cmYtNCBhbmQgLWdkd2FyZi01IGZsYWdzLiBBbHNvIHRlc3RlZCAtZ3NsaXQt ZHdhcmYgYWxvbmcgd2l0aCAtZ2R3YXJmLTQgYXMgd2VsbCBhcyAtZ2R3YXJm NSBmbGFncy4NCg0KDQpnZGIvQ2hhbmdlTG9nOg0KICAgICAgICAqZ2RiL2R3 YXJmMmxvYy5jIChkZWNvZGVfZGVidWdfbG9jbGlzdHNfYWRkcmVzc2VzKTog SGFuZGxlIERXX0xMRV9iYXNlX2FkZHJlc3N4LCBEV19MTEVfc3RhcnR4X2xl bmd0aCwgRFdfTExFX3N0YXJ0X2xlbmd0aC4NCg0KVGhpcyBpcyBhbiBlZmZv cnQgdG8gc3VwcG9ydCBEV0FSRjUgaW4gZ2RiLiBkaWZmIC0tZ2l0IGEvZ2Ri L2R3YXJmMmxvYy5jIGIvZ2RiL2R3YXJmMmxvYy5jDQppbmRleCA5OWNhYzAz YTU0Li5lMDk0MDY4OWVlIDEwMDY0NA0KLS0tIGEvZ2RiL2R3YXJmMmxvYy5j DQorKysgYi9nZGIvZHdhcmYybG9jLmMNCkBAIC0xNzMsNiArMTczLDQxIEBA IGRlY29kZV9kZWJ1Z19sb2NsaXN0c19hZGRyZXNzZXMgKHN0cnVjdCBkd2Fy ZjJfcGVyX2N1X2RhdGEgKnBlcl9jdSwNCg0KICAgc3dpdGNoICgqbG9jX3B0 cisrKQ0KICAgICB7DQorICAgIGNhc2UgRFdfTExFX2Jhc2VfYWRkcmVzc3g6 DQorICAgICAgKmxvdyA9IDA7DQorICAgICAgbG9jX3B0ciA9IGdkYl9yZWFk X3VsZWIxMjggKGxvY19wdHIsIGJ1Zl9lbmQsICZ1NjQpOw0KKyAgICAgIGlm IChsb2NfcHRyID09IE5VTEwpDQorICAgICAgICByZXR1cm4gREVCVUdfTE9D X0JVRkZFUl9PVkVSRkxPVzsNCisgICAgICAqaGlnaCA9IGR3YXJmMl9yZWFk X2FkZHJfaW5kZXggKHBlcl9jdSwgdTY0KTsNCisgICAgICAqbmV3X3B0ciA9 IGxvY19wdHI7DQorICAgICAgcmV0dXJuIERFQlVHX0xPQ19CQVNFX0FERFJF U1M7DQorICAgIGNhc2UgRFdfTExFX3N0YXJ0eF9sZW5ndGg6DQorICAgICAg bG9jX3B0ciA9IGdkYl9yZWFkX3VsZWIxMjggKGxvY19wdHIsIGJ1Zl9lbmQs ICZ1NjQpOw0KKyAgICAgIGlmIChsb2NfcHRyID09IE5VTEwpDQorICAgICAg ICByZXR1cm4gREVCVUdfTE9DX0JVRkZFUl9PVkVSRkxPVzsNCisgICAgICAq bG93ID0gZHdhcmYyX3JlYWRfYWRkcl9pbmRleCAocGVyX2N1LCB1NjQpOw0K KyAgICAgICpoaWdoID0gKmxvdzsNCisgICAgICBsb2NfcHRyID0gZ2RiX3Jl YWRfdWxlYjEyOCAobG9jX3B0ciwgYnVmX2VuZCwgJnU2NCk7DQorICAgICAg aWYgKGxvY19wdHIgPT0gTlVMTCkNCisgICAgICAgIHJldHVybiBERUJVR19M T0NfQlVGRkVSX09WRVJGTE9XOw0KKyAgICAgICpoaWdoICs9IHU2NDsNCisg ICAgICAqbmV3X3B0ciA9IGxvY19wdHI7DQorICAgICAgcmV0dXJuIERFQlVH X0xPQ19TVEFSVF9MRU5HVEg7DQorICAgIGNhc2UgRFdfTExFX3N0YXJ0X2xl bmd0aDoNCisgICAgICBpZiAoYnVmX2VuZCAtIGxvY19wdHIgPCBhZGRyX3Np emUpDQorICAgICAgICByZXR1cm4gREVCVUdfTE9DX0JVRkZFUl9PVkVSRkxP VzsNCisgICAgICBpZiAoc2lnbmVkX2FkZHJfcCkNCisgICAgICAgICpsb3cg PSBleHRyYWN0X3NpZ25lZF9pbnRlZ2VyIChsb2NfcHRyLCBhZGRyX3NpemUs IGJ5dGVfb3JkZXIpOw0KKyAgICAgIGVsc2UNCisgICAgICAgICpsb3cgPSBl eHRyYWN0X3Vuc2lnbmVkX2ludGVnZXIgKGxvY19wdHIsIGFkZHJfc2l6ZSwg Ynl0ZV9vcmRlcik7DQorICAgICAgbG9jX3B0ciArPSBhZGRyX3NpemU7DQor ICAgICAgKmhpZ2ggPSAqbG93Ow0KKyAgICAgIGxvY19wdHIgPSBnZGJfcmVh ZF91bGViMTI4IChsb2NfcHRyLCBidWZfZW5kLCAmdTY0KTsNCisgICAgICBp ZiAobG9jX3B0ciA9PSBOVUxMKQ0KKyAgICAgICAgcmV0dXJuIERFQlVHX0xP Q19CVUZGRVJfT1ZFUkZMT1c7DQorICAgICAgKmhpZ2ggKz0gdTY0Ow0KKyAg ICAgICpuZXdfcHRyID0gbG9jX3B0cjsNCisgICAgICByZXR1cm4gREVCVUdf TE9DX1NUQVJUX0xFTkdUSDsNCiAgICAgY2FzZSBEV19MTEVfZW5kX29mX2xp c3Q6DQogICAgICAgKm5ld19wdHIgPSBsb2NfcHRyOw0KICAgICAgIHJldHVy biBERUJVR19MT0NfRU5EX09GX0xJU1Q7DQpAQCAtMTk3LDYgKzIzMiw5IEBA IGRlY29kZV9kZWJ1Z19sb2NsaXN0c19hZGRyZXNzZXMgKHN0cnVjdCBkd2Fy ZjJfcGVyX2N1X2RhdGEgKnBlcl9jdSwNCiAgICAgICAqaGlnaCA9IHU2NDsN CiAgICAgICAqbmV3X3B0ciA9IGxvY19wdHI7DQogICAgICAgcmV0dXJuIERF QlVHX0xPQ19TVEFSVF9FTkQ7DQorICAgIGNhc2UgRFdfTExFX3N0YXJ0eF9l bmR4Og0KKyAgICBjYXNlIERXX0xMRV9zdGFydF9lbmQ6DQorICAgIGNhc2Ug RFdfTExFX2RlZmF1bHRfbG9jYXRpb246DQogICAgIGRlZmF1bHQ6DQogICAg ICAgcmV0dXJuIERFQlVHX0xPQ19JTlZBTElEX0VOVFJZOw0KICAgICB9DQoN Cg0KUmVnYXJkcywNCk5pdGlrYQ0KDQoNCg0KDQoNCg0KLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCkZyb206IEFjaHJhLCBOaXRpa2EgDQpTZW50OiBN b25kYXksIEphbnVhcnkgNiwgMjAyMCAxMjo1MiBQTQ0KVG86IFNpbW9uIE1h cmNoaSA8c2ltYXJrQHNpbWFyay5jYT47IGdkYi1wYXRjaGVzQHNvdXJjZXdh cmUub3JnDQpDYzogR2VvcmdlLCBKaW5pIFN1c2FuIDxKaW5pU3VzYW4uR2Vv cmdlQGFtZC5jb20+OyBBbGkgVGFtdXIgPHRhbXVyQGdvb2dsZS5jb20+DQpT dWJqZWN0OiBSRTogW1BBVENIXSBTdXBwb3J0IGZvciBEV0FSRjUgbG9jYXRp b24gbGlzdHMgZW50cmllcw0KDQpbQU1EIE9mZmljaWFsIFVzZSBPbmx5IC0g SW50ZXJuYWwgRGlzdHJpYnV0aW9uIE9ubHldDQoNCkhpIFNpbW9uLA0KDQpU aGFua3MgZm9yIHRoZSByZXZpZXcuIEkgaGF2ZSByZWZvcm1hdHRlZCBpdCBh cyBwZXIgdGhlIEdOVSBzdHlsZS4gUGxlYXNlIGhhdmUgYSBsb29rIGF0IGl0 Lg0KDQoNCg0KKkhhbmRsZSBEV19MTEVfYmFzZV9hZGRyZXNzeCwgRFdfTExF X3N0YXJ0eF9sZW5ndGggYW5kIERXX0xMRV9zdGFydF9sZW5ndGguDQoNClRl c3RlZCBieSBydW5uaW5nIHRoZSB0ZXN0c3VpdGUgYmVmb3JlIGFuZCBhZnRl ciB0aGUgcGF0Y2ggYW5kIHRoZXJlIGlzIG5vIGluY3JlYXNlIGluIHRoZSBu dW1iZXIgb2YgdGVzdCBjYXNlcyB0aGF0IGZhaWxzLg0KVGVzdGVkIHdpdGgg Ym90aCAtZ2R3YXJmLTQgYW5kIC1nZHdhcmYtNSBmbGFncy4gQWxzbyB0ZXN0 ZWQgLWdzbGl0LWR3YXJmIGFsb25nIHdpdGggLWdkd2FyZi00IGFzIHdlbGwg YXMgLWdkd2FyZjUgZmxhZ3MuDQoNCg0KZ2RiL0NoYW5nZUxvZzoNCiAgICAg ICAgKmdkYi9kd2FyZjJsb2MuYyAoZGVjb2RlX2RlYnVnX2xvY2xpc3RzX2Fk ZHJlc3Nlcyk6IEhhbmRsZSBEV19MTEVfYmFzZV9hZGRyZXNzeCwgRFdfTExF X3N0YXJ0eF9sZW5ndGgsIERXX0xMRV9zdGFydF9sZW5ndGguDQoNClRoaXMg aXMgYW4gZWZmb3J0IHRvIHN1cHBvcnQgRFdBUkY1IGluIGdkYi4NCg0KDQpk aWZmIC0tZ2l0IGEvZ2RiL2R3YXJmMmxvYy5jIGIvZ2RiL2R3YXJmMmxvYy5j IGluZGV4IDk5Y2FjMDNhNTQuLmRkOTllYTM1YzAgMTAwNjQ0DQotLS0gYS9n ZGIvZHdhcmYybG9jLmMNCisrKyBiL2dkYi9kd2FyZjJsb2MuYw0KQEAgLTE3 Myw2ICsxNzMsNDEgQEAgZGVjb2RlX2RlYnVnX2xvY2xpc3RzX2FkZHJlc3Nl cyAoc3RydWN0IGR3YXJmMl9wZXJfY3VfZGF0YSAqcGVyX2N1LA0KDQogICBz d2l0Y2ggKCpsb2NfcHRyKyspDQogICAgIHsNCisgICAgY2FzZSBEV19MTEVf YmFzZV9hZGRyZXNzeDoNCisgICAgICAqbG93ID0gMDsNCisgICAgICBsb2Nf cHRyID0gZ2RiX3JlYWRfdWxlYjEyOCAobG9jX3B0ciwgYnVmX2VuZCwgJnU2 NCk7DQorICAgICAgaWYgKGxvY19wdHIgPT0gTlVMTCkNCisgICAgICAgcmV0 dXJuIERFQlVHX0xPQ19CVUZGRVJfT1ZFUkZMT1c7DQorICAgICAgKmhpZ2gg PSBkd2FyZjJfcmVhZF9hZGRyX2luZGV4IChwZXJfY3UsIHU2NCk7DQorICAg ICAgKm5ld19wdHIgPSBsb2NfcHRyOw0KKyAgICAgIHJldHVybiBERUJVR19M T0NfQkFTRV9BRERSRVNTOw0KKyAgICBjYXNlIERXX0xMRV9zdGFydHhfbGVu Z3RoOg0KKyAgICAgIGxvY19wdHIgPSBnZGJfcmVhZF91bGViMTI4IChsb2Nf cHRyLCBidWZfZW5kLCAmdTY0KTsNCisgICAgICBpZiAobG9jX3B0ciA9PSBO VUxMKQ0KKyAgICAgICByZXR1cm4gREVCVUdfTE9DX0JVRkZFUl9PVkVSRkxP VzsNCisgICAgICAqbG93ID0gZHdhcmYyX3JlYWRfYWRkcl9pbmRleCAocGVy X2N1LCB1NjQpOw0KKyAgICAgICpoaWdoID0gKmxvdzsNCisgICAgICBsb2Nf cHRyID0gZ2RiX3JlYWRfdWxlYjEyOCAobG9jX3B0ciwgYnVmX2VuZCwgJnU2 NCk7DQorICAgICAgaWYgKGxvY19wdHIgPT0gTlVMTCkNCisgICAgICAgcmV0 dXJuIERFQlVHX0xPQ19CVUZGRVJfT1ZFUkZMT1c7DQorICAgICAgKmhpZ2gg Kz0gdTY0Ow0KKyAgICAgICpuZXdfcHRyID0gbG9jX3B0cjsNCisgICAgICBy ZXR1cm4gREVCVUdfTE9DX1NUQVJUX0xFTkdUSDsNCisgICAgY2FzZSBEV19M TEVfc3RhcnRfbGVuZ3RoOg0KKyAgICAgIGlmIChidWZfZW5kIC0gbG9jX3B0 ciA8IGFkZHJfc2l6ZSkNCisgICAgICAgcmV0dXJuIERFQlVHX0xPQ19CVUZG RVJfT1ZFUkZMT1c7DQorICAgICAgaWYgKHNpZ25lZF9hZGRyX3ApDQorICAg ICAgICpsb3cgPSBleHRyYWN0X3NpZ25lZF9pbnRlZ2VyIChsb2NfcHRyLCBh ZGRyX3NpemUsIGJ5dGVfb3JkZXIpOw0KKyAgICAgIGVsc2UNCisgICAgICAg KmxvdyA9IGV4dHJhY3RfdW5zaWduZWRfaW50ZWdlciAobG9jX3B0ciwgYWRk cl9zaXplLCBieXRlX29yZGVyKTsNCisgICAgICBsb2NfcHRyICs9IGFkZHJf c2l6ZTsNCisgICAgICAqaGlnaCA9ICpsb3c7DQorICAgICAgbG9jX3B0ciA9 IGdkYl9yZWFkX3VsZWIxMjggKGxvY19wdHIsIGJ1Zl9lbmQsICZ1NjQpOw0K KyAgICAgIGlmIChsb2NfcHRyID09IE5VTEwpDQorICAgICAgIHJldHVybiBE RUJVR19MT0NfQlVGRkVSX09WRVJGTE9XOw0KKyAgICAgICpoaWdoICs9IHU2 NDsNCisgICAgICAqbmV3X3B0ciA9IGxvY19wdHI7DQorICAgICAgcmV0dXJu IERFQlVHX0xPQ19TVEFSVF9MRU5HVEg7DQogICAgIGNhc2UgRFdfTExFX2Vu ZF9vZl9saXN0Og0KICAgICAgICpuZXdfcHRyID0gbG9jX3B0cjsNCiAgICAg ICByZXR1cm4gREVCVUdfTE9DX0VORF9PRl9MSVNUOw0KQEAgLTE5Nyw2ICsy MzIsOSBAQCBkZWNvZGVfZGVidWdfbG9jbGlzdHNfYWRkcmVzc2VzIChzdHJ1 Y3QgZHdhcmYyX3Blcl9jdV9kYXRhICpwZXJfY3UsDQogICAgICAgKmhpZ2gg PSB1NjQ7DQogICAgICAgKm5ld19wdHIgPSBsb2NfcHRyOw0KICAgICAgIHJl dHVybiBERUJVR19MT0NfU1RBUlRfRU5EOw0KKyAgICBjYXNlIERXX0xMRV9z dGFydHhfZW5keDoNCisgICAgY2FzZSBEV19MTEVfc3RhcnRfZW5kOg0KKyAg ICBjYXNlIERXX0xMRV9kZWZhdWx0X2xvY2F0aW9uOg0KICAgICBkZWZhdWx0 Og0KICAgICAgIHJldHVybiBERUJVR19MT0NfSU5WQUxJRF9FTlRSWTsNCiAg ICAgfQ0KDQoNClJlZ2FyZHMsDQpOaXRpa2ENCg0KLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCkZyb206IFNpbW9uIE1hcmNoaSA8c2ltYXJrQHNpbWFy ay5jYT4NClNlbnQ6IFdlZG5lc2RheSwgSmFudWFyeSAxLCAyMDIwIDEyOjAz IEFNDQpUbzogQWNocmEsIE5pdGlrYSA8Tml0aWthLkFjaHJhQGFtZC5jb20+ OyBnZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZw0KQ2M6IEdlb3JnZSwgSmlu aSBTdXNhbiA8SmluaVN1c2FuLkdlb3JnZUBhbWQuY29tPjsgQWxpIFRhbXVy IDx0YW11ckBnb29nbGUuY29tPg0KU3ViamVjdDogUmU6IFtQQVRDSF0gU3Vw cG9ydCBmb3IgRFdBUkY1IGxvY2F0aW9uIGxpc3RzIGVudHJpZXMNCg0KW0NB VVRJT046IEV4dGVybmFsIEVtYWlsXQ0KDQpPbiAyMDE5LTEyLTMxIDQ6NDEg YS5tLiwgQWNocmEsIE5pdGlrYSB3cm90ZToNCj4gW0FNRCBPZmZpY2lhbCBV c2UgT25seSAtIEludGVybmFsIERpc3RyaWJ1dGlvbiBPbmx5XQ0KPg0KPg0K Pg0KPiAqIEhhbmRsZSBEV19MTEVfYmFzZV9hZGRyZXNzeCwgRFdfTExFX3N0 YXJ0eF9sZW5ndGggYW5kIERXX0xMRV9zdGFydF9sZW5ndGguDQo+DQo+DQo+ DQo+IFRlc3RlZCBieSBydW5uaW5nIHRoZSB0ZXN0c3VpdGUgYmVmb3JlIGFu ZCBhZnRlciB0aGUgcGF0Y2ggYW5kIHRoZXJlIGlzIG5vIGluY3JlYXNlIGlu IHRoZSBudW1iZXIgb2YgdGVzdCBjYXNlcyB0aGF0IGZhaWxzLg0KPg0KPiBU ZXN0ZWQgd2l0aCBib3RoIC1nZHdhcmYtNCBhbmQgLWdkd2FyZi01IGZsYWdz Lg0KPg0KPg0KPg0KPg0KPiBnZGIvQ2hhbmdlTG9nOg0KPiAgICAgICAgICpn ZGIvZHdhcmYybG9jLmMgKGRlY29kZV9kZWJ1Z19sb2NsaXN0c19hZGRyZXNz ZXMpOiBIYW5kbGUgRFdfTExFX2Jhc2VfYWRkcmVzc3gsIERXX0xMRV9zdGFy dHhfbGVuZ3RoLCBEV19MTEVfc3RhcnRfbGVuZ3RoLg0KDQpIaSBOaXRpa2Es DQoNClRoYW5rcyBmb3IgdGhlIHBhdGNoLiAgSSBkb24ndCBoYXZlIHRpbWUg dG8gZG8gYW4gaW4tZGVwdGggcmV2aWV3IHJpZ2h0IG5vdywgYnV0IEkganVz dCB3YW50ZWQgdG8gcG9pbnQgb3V0IHRoZSBjb21tb24gZm9ybWF0dGluZyBx dWlya3Mgb2YgdGhlIEdOVSBzdHlsZSwgc28geW91IGNhbiBhcHBseSBpdCB0 byB0aGlzIHBhdGNoLg0KDQpJbiB0ZXJtcyBvZiBpbmRlbnRhdGlvbiwgd2Ug dXNlIHR3byBjb2x1bW5zIGZvciBlYWNoIGluZGVudC4gIEhvd2V2ZXIsIGxl YWRpbmcgZ3JvdXBzIG9mIDggc3BhY2VzIGdldCBjb252ZXJ0ZWQgdG8gYSB0 YWIuICBTbyBpbnN0ZWFkIG9mIDE0IHNwYWNlcywgeW91IHdvdWxkIGhhdmUg b25lIHRhYiBmb2xsb3dlZCBieSA2IHNwYWNlcyB0byByZWFjaCB0aGUgZGVz aXJlZCBjb2x1bW4uICBNb3N0IGVkaXRvcnMgaGF2ZSBhIHdheSB0byBiZSBz ZXQgdXAgbGlrZSB0aGlzLiAgVW5mb3J0dW5hdGVseSwgVlNDb2RlIGNhbid0 Lg0KDQpXZSB1c2UgYSBzcGFjZSBiZWZvcmUgb3BlbmluZyBwYXJlbnRoZXNp cyBpbiBmdW5jdGlvbiBkZWNsYXJhdGlvbi9kZWZpbml0aW9ucy9jYWxscy4N ClNvOg0KDQogIGxvY19wdHLCtz3Ct2dkYl9yZWFkX3VsZWIxMjgobG9jX3B0 cizCt2J1Zl9lbmQswrcmdTY0KTsNCg0Kd291bGQgYmVjb21lDQoNCiAgbG9j X3B0csK3PcK3Z2RiX3JlYWRfdWxlYjEyOCAobG9jX3B0cizCt2J1Zl9lbmQs wrcmdTY0KTsNCg0KVGhpczoNCg0KICAgICAgaWbCtyhsb2NfcHRywrc9PcK3 TlVMTCkNCiAgICAgICAgICAgICAgIHJldHVybsK3REVCVUdfTE9DX0JVRkZF Ul9PVkVSRkxPVzsNCg0Kc2hvdWxkIGJlY29tZToNCg0KICAgICAgaWbCtyhs b2NfcHRywrc9PcK3TlVMTCkNCiAgICAgICAgcmV0dXJuwrdERUJVR19MT0Nf QlVGRkVSX09WRVJGTE9XOw0KDQpTaW1vbg0K >From gdb-patches-return-162789-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jan 06 10:27:15 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 105388 invoked by alias); 6 Jan 2020 10:27:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105380 invoked by uid 89); 6 Jan 2020 10:27:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.221.67, H*RU:209.85.221.67, disassembling X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 06 Jan 2020 10:27:13 +0000 Received: by mail-wr1-f67.google.com with SMTP id z3so49050455wru.3 for ; Mon, 06 Jan 2020 02:27:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=HhoXjw2Oz8jHhcnif2/Az0dCt7B466AadgyF6YmpTYo=; b=p545BMw9c1AvOuQwnUlczKgCpreanvX8Ywr4EZSjkPPvToxx20IhTi9cjQbxs/uSBm wtVP0tEQp5wjOmUyKb/4WzUNRzcJ2XW3BdkRV0Rht8DrOGk7NYt6UWcucFdh9h34Rl4P IhVBDMeQZl5BKLc9clZPwLhUw7wJYuCi93PUew1jaL1g8rIpgVv4R+jv+nbqS9Qm82Fb 4obFLaJupqMBLqTLFphZvH3tLNAPC1PzZIZbqzZAogD86/mHh+6xczA1SR2FKTAgN17x mLQLCXCQS5X+nqhogUQnctHpHK3iKlGSvp1tdXlJIiQ7TbFXXwM9w63ndgdKdUkLWTPo qZaw== Return-Path: Received: from localhost.localdomain (ip-217-103-128-141.ip.prioritytelecom.net. [217.103.128.141]) by smtp.gmail.com with ESMTPSA id h17sm75171923wrs.18.2020.01.06.02.27.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2020 02:27:10 -0800 (PST) From: Shahab Vahedi To: gdb-patches@sourceware.org Cc: Shahab Vahedi , Claudiu Zissulescu , Francois Bedard Subject: [PATCH v2] GDB: Fix the overflow in addr_is_displayed() Date: Mon, 06 Jan 2020 10:27:00 -0000 Message-Id: <20200106102649.15710-1-shahab.vahedi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2020-01/txt/msg00103.txt.bz2 Content-length: 2307 From: Shahab Vahedi In a corner case scenario, where the height of the assembly TUI is bigger than the number of instructions in the whole program, GDB dumps core. The problem roots in this condition check: int i = 0; while (i < content. size() - threshold ...) { ... content[i] ... } "threshold" is 2 and there are times that "content. size()" is 0. This results into an overflow and the loop is entered whereas it should have been skipped. This has been discussed at length in bug 25345: https://sourceware.org/bugzilla/show_bug.cgi?id=25345 As a bonus, a few trailing spaces are also removed. gdb/ChangeLog: 2020-01-04 Shahab Vahedi * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Treat "content.size ()" as "int" to avoid overflow. * tui/tui-disasm.c: Remove trailing spaces. --- gdb/tui/tui-disasm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index c72b50730b0..68744cc61e3 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -43,7 +43,7 @@ #include "gdb_curses.h" -struct tui_asm_line +struct tui_asm_line { CORE_ADDR addr; std::string addr_string; @@ -150,7 +150,7 @@ tui_find_disassembly_address (struct gdbarch *gdbarch, CORE_ADDR pc, int from) CORE_ADDR last_addr; int pos; struct bound_minimal_symbol msymbol; - + /* Find backward an address which is a symbol and for which disassembling from that address will fill completely the window. */ @@ -176,7 +176,7 @@ tui_find_disassembly_address (struct gdbarch *gdbarch, CORE_ADDR pc, int from) do { CORE_ADDR next_addr; - + pos++; if (pos >= max_lines) pos = 0; @@ -349,10 +349,10 @@ bool tui_disasm_window::addr_is_displayed (CORE_ADDR addr) const { bool is_displayed = false; - int threshold = SCROLL_THRESHOLD; + int nr_of_lines = (int) content. size() - SCROLL_THRESHOLD; int i = 0; - while (i < content.size () - threshold && !is_displayed) + while (i < nr_of_lines && !is_displayed) { is_displayed = (content[i].line_or_addr.loa == LOA_ADDRESS -- 2.24.1