From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53356 invoked by alias); 13 Jan 2020 10:45:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53157 invoked by uid 89); 13 Jan 2020 10:45:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,FORGED_SPF_HELO,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: NAM12-BN8-obe.outbound.protection.outlook.com Received: from mail-bn8nam12on2057.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) (40.107.237.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 10:45:37 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gyohNS5xSkEH+xEwMSDSiklCvuMwSnybMHGtkWgB2F4ymftSRimHLKLP90PdZd3mXYeT/Dob/VAoU1mQogOImQ4iHix+xc1/EVn0ClqBwMhHHQVQxmhGog1ksps4ymRBfxwEIsTQOFjkJuPMHxHUlXlxbxWbBNXitfIGAhQk/QK1O4e17eNbEOBdX9hzoUGenAg2scDcPVWBJySq35nucLYzWQ4I6lcSE/jghxumMFoH79kgL64Gse06PSrfu7MrMRrkTwDhA6TndV5EewYT6b1lxnU5O7D9kqjQ0fmBv6+tJRNTB96o2xMqtfTPe7swLFyy0lNGULYaqao3NKtsqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNCsmGsuNmo0/4jjPeG3CB3RmAsiQnPMlIszHdYiN6E=; b=aiyrvNGzMW259dTm65TBCf67j1in+YXY140tgu76jW7fzwz5q/9msL5Pg9+UGJK7s6p9t/L1K72o5Ww4bHeoiFUzAcUjfmJuIp1UKBQe/Ccs3rNvBR+3ZjQop6ihDhtpGR2u1HZbbeEG6vldw5oQhlCmWjq+HQ+n4H7KaQJyT3g9k9P7BLBarsEkooMfC9fGmjItf+zMzq8PCJ9E+u0GsVcNDnSmExL3/S3GvSt/iubrueuOcyP8ScEMrf1ltf7Pr7dIcoRaFgWyJlVMAjJUNSaoDWskveUK8rwuC9Ecrmk/jUWrJyyXxrY3xDmltCnXN9wKLv1QEdrecOEjfSpnsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dNCsmGsuNmo0/4jjPeG3CB3RmAsiQnPMlIszHdYiN6E=; b=PtlnXWfAx9moFDWl2khezu9zZZ7ZAFOWhWsQek3CAvYb1lJ9xnbR95Nql7pvMkXLS2IyoWQ2/rDLm0CgE6Mk8SGlOdJBb4RI8chypYYZ1C8Xg4amH8XdlaLO5uFh/chrbd0FcZHiFKRgvE870aFW+9+BJPqnoV+yhYwnRprt9dw= Received: from MN2PR12MB3744.namprd12.prod.outlook.com (10.255.237.80) by MN2PR12MB3087.namprd12.prod.outlook.com (20.178.244.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.10; Mon, 13 Jan 2020 10:45:35 +0000 Received: from MN2PR12MB3744.namprd12.prod.outlook.com ([fe80::c1cb:697d:c30d:718c]) by MN2PR12MB3744.namprd12.prod.outlook.com ([fe80::c1cb:697d:c30d:718c%5]) with mapi id 15.20.2623.015; Mon, 13 Jan 2020 10:45:35 +0000 From: "Achra, Nitika" To: "gdb-patches@sourceware.org" , Simon Marchi CC: Ali Tamur , "George, Jini Susan" Subject: RE: [PATCH] Support for DWARF5 location lists entries Date: Mon, 13 Jan 2020 12:50:00 -0000 Message-ID: References: <48103fb5-d3ee-0ae0-92a7-f1c02debd449@simark.ca> <0d36089b-1890-c579-7715-641e94dd4bb6@simark.ca> In-Reply-To: <0d36089b-1890-c579-7715-641e94dd4bb6@simark.ca> msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_enabled: true msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_setdate: 2020-01-13T10:45:32Z msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_method: Standard msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_name: Internal Use Only - Unrestricted msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_actionid: b3c8e629-a121-4080-bb71-00006e8b87a3 msip_label_76546daa-41b6-470c-bb85-f6f40f044d7f_contentbits: 0 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Nitika.Achra@amd.com; x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:8882; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Pd2Jg6KWxxxoRv9xLDCNiw/AfVtSSVY29y+tqIRhfTuVcd1M0X1WijGyjUvlFZd0194H2Pa0GWyB7SB413Z1UQ== X-SW-Source: 2020-01/txt/msg00321.txt.bz2 W0FNRCBPZmZpY2lhbCBVc2UgT25seSAtIEludGVybmFsIERpc3RyaWJ1dGlv biBPbmx5XQ0KDQoNCg0KSGkgU2ltb24sDQoNClRoYW5rcyBmb3IgdGhlIGRl dGFpbGVkIHJldmlldy4gDQoNCioqKg0KPiArICAgICAgICByZXR1cm4gREVC VUdfTE9DX0JVRkZFUl9PVkVSRkxPVzsNCg0KPiBOb3Qgc3VyZSBpZiBpdCdz IHlvdXIgZW1haWwgY2xpZW50IHRoYXQgY2hhbmdlZCB0aGVtIHRvIHNwYWNl cywgYnV0IHRoZSBsaW5lcyBhdCB0aGlzIGluZGVudGF0aW9uIGxldmVsICh0 aGVyZSBhcmUgYSBmZXcgaW4gdGhlIHBhdGNoKSBzaG91bGQgYmUgaW5kZW50 ZWQgd2l0aCBhIHRhYi4NCg0KSSB3YXMgc2VuZGluZyB0aGUgbWFpbCBpbiBI VE1MIGZvcm1hdCB3aGljaCBpcyBjb252ZXJ0aW5nIHRhYnMgdG8gc3BhY2Vz IHdoaWxlIHNlbmRpbmcuIE5vdywgSSBhbSBzZW5kaW5nIGluIHBsYWluIHRl eHQgZm9ybWF0LiBJdCBzaG91bGQgZml4IHRoZSBpc3N1ZS4NCg0KKioqDQo+ ICsgICAgICAqaGlnaCArPSB1NjQ7DQo+ICsgICAgICAqbmV3X3B0ciA9IGxv Y19wdHI7DQo+ICsgICAgICByZXR1cm4gREVCVUdfTE9DX1NUQVJUX0xFTkdU SDsNCg0KPiBTb21ldGhpbmcgSSBub3RpY2VkIHdoaWxlIHJldmlld2luZywg d2hpY2ggY291bGQgYmUgYSBwb3NzaWJsZSBjbGVhbnVwIG1hZGUgaW4gYSBz ZXBhcmF0ZSBwYXRjaCBpZiB5b3UnZCBsaWtlLiAgSSBkb24ndCByZWFsbHkg c2VlIHdoeSBERUJVR19MT0NfU1RBUlRfTEVOR1RIIGV4aXN0cy4gIEFzIHdl IHJldHVybiA+ID4gdGhlIGxvdyBhbmQgaGlnaCBhZGRyZXNzZXMgdG8gdGhl IGNhbGxlciwgaXQncyBubyBkaWZmZXJlbnQgdGhhbiBERUJVR19MT0NfU1RB UlRfRU5ELiAgQW5kIGluZGVlZCwgdGhlIGNhbGxlcnMgdHJlYXQgYm90aCBE RUJVR19MT0NfU1RBUlRfRU5EIGFuZCBERUJVR19MT0NfU1RBUlRfTEVOR1RI ID4gPiB0aGUgc2FtZSB3YXkuICBTbyBJIHRoaW5rIF9MRU5HVEggY291bGQg YmUgcmVtb3ZlZC4NCg0KPiBBbmQgc2luY2UgYGVudW0gZGVidWdfbG9jX2tp bmRgIGlzIG9ubHkgdXNlZCBpbnRlcm5hbGx5IGluIEdEQiB0byBjb21tdW5p Y2F0ZSBiZXR3ZWVuIGZ1bmN0aW9ucyAoaXQncyBub3QgdXNlZCBmb3IgcGFy c2luZyBhbnl0aGluZyksIGl0IGRvZXNuJ3QgcmVhbGx5IG5lZWQgdG8gaGF2 ZSBleHBsaWNpdCB2YWx1ZXMgZm9yID4gZW51bWVyYXRvcnMuICBUaGUgZG9j dW1lbnRhdGlvbiBhYm91dCB0aGUgZW5jb2RpbmcgYWxzbyBzZWVtcyBpcnJl bGV2YW50IHRvIG1lLCBzaW5jZSwgYWdhaW4sIHRoZXkgYXJlIG5vdCBldmVu IHVzZWQgZm9yIHBhcnNpbmcgYW55dGhpbmcuDQoNCkkgd2lsbCBtYWRlIHRo aXMgY2xlYW51cCBpbiB0aGUgc2VwYXJhdGUgcGF0Y2guDQoNCg0KKioqDQo+ ICsgICAgY2FzZSBEV19MTEVfc3RhcnR4X2VuZHg6DQo+ICsgICAgY2FzZSBE V19MTEVfc3RhcnRfZW5kOg0KPiArICAgIGNhc2UgRFdfTExFX2RlZmF1bHRf bG9jYXRpb246DQoNCj4gRGlkIHlvdSBhZGQgdGhlbSBoZXJlIGJlY2F1c2Ug eW91IGRvbid0IGludGVuZCB0byBhZGQgc3VwcG9ydCBmb3IgdGhlbSwgYXQg bGVhc3QgZm9yIHRoZSBtb21lbnQ/ICBJZiBzbywgcGxlYXNlIGFkZCBhIGNv bW1lbnQsIGxpa2U6DQoNCj4gLyogTm90IHN1cHBvcnRlZCB5ZXQuICAqLw0K DQpEb25lLiBDbGFuZyBhbmQgZ2NjIGFyZSBub3QgZW1pdHRpbmcgdGhlIGFi b3ZlIHRocmVlIGVudHJpZXMgYXMgb2Ygbm93LiBTbywgSSBkaWRuJ3QgYWRk IHRoZSBzdXBwb3J0IGZvciB0aGVtLg0KDQotLS0NCipIYW5kbGUgRFdfTExF X2Jhc2VfYWRkcmVzc3gsIERXX0xMRV9zdGFydHhfbGVuZ3RoIGFuZCBEV19M TEVfc3RhcnRfbGVuZ3RoLg0KDQpUZXN0ZWQgYnkgcnVubmluZyB0aGUgdGVz dHN1aXRlIGJlZm9yZSBhbmQgYWZ0ZXIgdGhlIHBhdGNoIGFuZCB0aGVyZSBp cyBubyBpbmNyZWFzZSBpbiB0aGUgbnVtYmVyIG9mIHRlc3QgY2FzZXMgdGhh dCBmYWlscy4NClRlc3RlZCB3aXRoIGJvdGggLWdkd2FyZi00IGFuZCAtZ2R3 YXJmLTUgZmxhZ3MuIEFsc28gdGVzdGVkIC1nc2xpdC1kd2FyZiBhbG9uZyB3 aXRoIC1nZHdhcmYtNCBhcyB3ZWxsIGFzIC1nZHdhcmY1IGZsYWdzLg0KDQoN CmdkYi9DaGFuZ2VMb2c6DQogICAgICAgICpkd2FyZjJsb2MuYyAoZGVjb2Rl X2RlYnVnX2xvY2xpc3RzX2FkZHJlc3Nlcyk6IEhhbmRsZQ0KICAgICAgICAg IERXX0xMRV9iYXNlX2FkZHJlc3N4LCBEV19MTEVfc3RhcnR4X2xlbmd0aCwg RFdfTExFX3N0YXJ0X2xlbmd0aC4NCg0KVGhpcyBpcyBhbiBlZmZvcnQgdG8g c3VwcG9ydCBEV0FSRjUgaW4gZ2RiLg0KDQpkaWZmIC0tZ2l0IGEvZ2RiL2R3 YXJmMmxvYy5jIGIvZ2RiL2R3YXJmMmxvYy5jDQppbmRleCA5OWNhYzAzYTU0 Li5kZDk5ZWEzNWMwIDEwMDY0NA0KLS0tIGEvZ2RiL2R3YXJmMmxvYy5jDQor KysgYi9nZGIvZHdhcmYybG9jLmMNCkBAIC0xNzMsNiArMTczLDQxIEBAIGRl Y29kZV9kZWJ1Z19sb2NsaXN0c19hZGRyZXNzZXMgKHN0cnVjdCBkd2FyZjJf cGVyX2N1X2RhdGEgKnBlcl9jdSwNCiANCiAgIHN3aXRjaCAoKmxvY19wdHIr KykNCiAgICAgew0KKyAgICBjYXNlIERXX0xMRV9iYXNlX2FkZHJlc3N4Og0K KyAgICAgICpsb3cgPSAwOw0KKyAgICAgIGxvY19wdHIgPSBnZGJfcmVhZF91 bGViMTI4IChsb2NfcHRyLCBidWZfZW5kLCAmdTY0KTsNCisgICAgICBpZiAo bG9jX3B0ciA9PSBOVUxMKQ0KKwkgcmV0dXJuIERFQlVHX0xPQ19CVUZGRVJf T1ZFUkZMT1c7DQorICAgICAgKmhpZ2ggPSBkd2FyZjJfcmVhZF9hZGRyX2lu ZGV4IChwZXJfY3UsIHU2NCk7DQorICAgICAgKm5ld19wdHIgPSBsb2NfcHRy Ow0KKyAgICAgIHJldHVybiBERUJVR19MT0NfQkFTRV9BRERSRVNTOw0KKyAg ICBjYXNlIERXX0xMRV9zdGFydHhfbGVuZ3RoOg0KKyAgICAgIGxvY19wdHIg PSBnZGJfcmVhZF91bGViMTI4IChsb2NfcHRyLCBidWZfZW5kLCAmdTY0KTsN CisgICAgICBpZiAobG9jX3B0ciA9PSBOVUxMKQ0KKwkgcmV0dXJuIERFQlVH X0xPQ19CVUZGRVJfT1ZFUkZMT1c7DQorICAgICAgKmxvdyA9IGR3YXJmMl9y ZWFkX2FkZHJfaW5kZXggKHBlcl9jdSwgdTY0KTsNCisgICAgICAqaGlnaCA9 ICpsb3c7DQorICAgICAgbG9jX3B0ciA9IGdkYl9yZWFkX3VsZWIxMjggKGxv Y19wdHIsIGJ1Zl9lbmQsICZ1NjQpOw0KKyAgICAgIGlmIChsb2NfcHRyID09 IE5VTEwpDQorCSByZXR1cm4gREVCVUdfTE9DX0JVRkZFUl9PVkVSRkxPVzsN CisgICAgICAqaGlnaCArPSB1NjQ7DQorICAgICAgKm5ld19wdHIgPSBsb2Nf cHRyOw0KKyAgICAgIHJldHVybiBERUJVR19MT0NfU1RBUlRfTEVOR1RIOw0K KyAgICBjYXNlIERXX0xMRV9zdGFydF9sZW5ndGg6DQorICAgICAgaWYgKGJ1 Zl9lbmQgLSBsb2NfcHRyIDwgYWRkcl9zaXplKQ0KKwkgcmV0dXJuIERFQlVH X0xPQ19CVUZGRVJfT1ZFUkZMT1c7DQorICAgICAgaWYgKHNpZ25lZF9hZGRy X3ApDQorCSAqbG93ID0gZXh0cmFjdF9zaWduZWRfaW50ZWdlciAobG9jX3B0 ciwgYWRkcl9zaXplLCBieXRlX29yZGVyKTsNCisgICAgICBlbHNlDQorCSAq bG93ID0gZXh0cmFjdF91bnNpZ25lZF9pbnRlZ2VyIChsb2NfcHRyLCBhZGRy X3NpemUsIGJ5dGVfb3JkZXIpOw0KKyAgICAgIGxvY19wdHIgKz0gYWRkcl9z aXplOw0KKyAgICAgICpoaWdoID0gKmxvdzsNCisgICAgICBsb2NfcHRyID0g Z2RiX3JlYWRfdWxlYjEyOCAobG9jX3B0ciwgYnVmX2VuZCwgJnU2NCk7DQor ICAgICAgaWYgKGxvY19wdHIgPT0gTlVMTCkNCisJIHJldHVybiBERUJVR19M T0NfQlVGRkVSX09WRVJGTE9XOw0KKyAgICAgICpoaWdoICs9IHU2NDsNCisg ICAgICAqbmV3X3B0ciA9IGxvY19wdHI7DQorICAgICAgcmV0dXJuIERFQlVH X0xPQ19TVEFSVF9MRU5HVEg7DQogICAgIGNhc2UgRFdfTExFX2VuZF9vZl9s aXN0Og0KICAgICAgICpuZXdfcHRyID0gbG9jX3B0cjsNCiAgICAgICByZXR1 cm4gREVCVUdfTE9DX0VORF9PRl9MSVNUOw0KQEAgLTE5Nyw2ICsyMzIsOSBA QCBkZWNvZGVfZGVidWdfbG9jbGlzdHNfYWRkcmVzc2VzIChzdHJ1Y3QgZHdh cmYyX3Blcl9jdV9kYXRhICpwZXJfY3UsDQogICAgICAgKmhpZ2ggPSB1NjQ7 DQogICAgICAgKm5ld19wdHIgPSBsb2NfcHRyOw0KICAgICAgIHJldHVybiBE RUJVR19MT0NfU1RBUlRfRU5EOw0KKyAgICBjYXNlIERXX0xMRV9zdGFydHhf ZW5keDoNCisgICAgY2FzZSBEV19MTEVfc3RhcnRfZW5kOg0KKyAgICBjYXNl IERXX0xMRV9kZWZhdWx0X2xvY2F0aW9uOg0KICAgICBkZWZhdWx0Og0KICAg ICAgIHJldHVybiBERUJVR19MT0NfSU5WQUxJRF9FTlRSWTsNCiAgICAgfQ0K DQoNClJlZ2FyZHMsDQpOaXRpa2EgQWNocmENCg0KLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCkZyb206IFNpbW9uIE1hcmNoaSA8c2ltYXJrQHNpbWFy ay5jYT4gDQpTZW50OiBXZWRuZXNkYXksIEphbnVhcnkgOCwgMjAyMCA4OjU3 IEFNDQpUbzogQWNocmEsIE5pdGlrYSA8Tml0aWthLkFjaHJhQGFtZC5jb20+ OyBnZGItcGF0Y2hlc0Bzb3VyY2V3YXJlLm9yZw0KQ2M6IEdlb3JnZSwgSmlu aSBTdXNhbiA8SmluaVN1c2FuLkdlb3JnZUBhbWQuY29tPjsgQWxpIFRhbXVy IDx0YW11ckBnb29nbGUuY29tPg0KU3ViamVjdDogUmU6IFtQQVRDSF0gU3Vw cG9ydCBmb3IgRFdBUkY1IGxvY2F0aW9uIGxpc3RzIGVudHJpZXMNCg0KW0NB VVRJT046IEV4dGVybmFsIEVtYWlsXQ0KDQpPbiAyMDIwLTAxLTA2IDU6MTQg YS5tLiwgQWNocmEsIE5pdGlrYSB3cm90ZToNCj4gW0FNRCBPZmZpY2lhbCBV c2UgT25seSAtIEludGVybmFsIERpc3RyaWJ1dGlvbiBPbmx5XQ0KPg0KPiBI aSBTaW1vbiwNCj4NCj4gU29ycnkuIEkgc2VudCB0aGUgd3JvbmcgcGF0Y2gg YnkgbWlzdGFrZS4gVXBkYXRpbmcgdGhlIHBhdGNoLg0KPg0KPiAqSGFuZGxl IERXX0xMRV9iYXNlX2FkZHJlc3N4LCBEV19MTEVfc3RhcnR4X2xlbmd0aCBh bmQgRFdfTExFX3N0YXJ0X2xlbmd0aC4NCj4NCj4gVGVzdGVkIGJ5IHJ1bm5p bmcgdGhlIHRlc3RzdWl0ZSBiZWZvcmUgYW5kIGFmdGVyIHRoZSBwYXRjaCBh bmQgdGhlcmUgaXMgbm8gaW5jcmVhc2UgaW4gdGhlIG51bWJlciBvZiB0ZXN0 IGNhc2VzIHRoYXQgZmFpbHMuDQo+IFRlc3RlZCB3aXRoIGJvdGggLWdkd2Fy Zi00IGFuZCAtZ2R3YXJmLTUgZmxhZ3MuIEFsc28gdGVzdGVkIC1nc2xpdC1k d2FyZiBhbG9uZyB3aXRoIC1nZHdhcmYtNCBhcyB3ZWxsIGFzIC1nZHdhcmY1 IGZsYWdzLg0KDQpIaSBOaXRpa2EsDQoNClRoYW5rcywgdGhlIHBhdGNoIExH VE0sIHdpdGggYSBmZXcgZm9ybWF0dGluZyBjb21tZW50cyBhZGRyZXNzZWQu DQoNCj4gZ2RiL0NoYW5nZUxvZzoNCj4gICAgICAgICAqZ2RiL2R3YXJmMmxv Yy5jIChkZWNvZGVfZGVidWdfbG9jbGlzdHNfYWRkcmVzc2VzKTogSGFuZGxl IERXX0xMRV9iYXNlX2FkZHJlc3N4LCBEV19MTEVfc3RhcnR4X2xlbmd0aCwg RFdfTExFX3N0YXJ0X2xlbmd0aC4NCg0KVGhlIGZpbGUgaW4gdGhlIENoYW5n ZUxvZyBlbnRyeSBzaG91bGQgYmUgcmVsYXRpdmUgdG8gdGhlIENoYW5nZUxv ZyBmaWxlIGl0IHdpbGwgZW5kIHVwIGluLiAgU2luY2UgdGhpcyB3aWxsIGdv IGluIGdkYi9DaGFuZ2VMb2csIGl0IHNob3VsZCBiZSAiZHdhcmYybG9jLmMi LCBub3QgImdkYi9kd2FyZjJsb2MuYyIuICBBbHNvLCBpdCBzaG91bGQgYmUg d3JhcHBlZCB0byA4MCBjb2x1bW5zLiAgU28sIHNvbWV0aGluZyBsaWtlIHRo aXM6DQoNCiAgICAgICAgKiBkd2FyZjJsb2MuYyAoZGVjb2RlX2RlYnVnX2xv Y2xpc3RzX2FkZHJlc3Nlcyk6IEhhbmRsZQ0KICAgICAgICBEV19MTEVfYmFz ZV9hZGRyZXNzeCwgRFdfTExFX3N0YXJ0eF9sZW5ndGgsIERXX0xMRV9zdGFy dF9sZW5ndGguDQoNCj4gVGhpcyBpcyBhbiBlZmZvcnQgdG8gc3VwcG9ydCBE V0FSRjUgaW4gZ2RiLiBkaWZmIC0tZ2l0IA0KPiBhL2dkYi9kd2FyZjJsb2Mu YyBiL2dkYi9kd2FyZjJsb2MuYyBpbmRleCA5OWNhYzAzYTU0Li5lMDk0MDY4 OWVlIA0KPiAxMDA2NDQNCj4gLS0tIGEvZ2RiL2R3YXJmMmxvYy5jDQo+ICsr KyBiL2dkYi9kd2FyZjJsb2MuYw0KPiBAQCAtMTczLDYgKzE3Myw0MSBAQCBk ZWNvZGVfZGVidWdfbG9jbGlzdHNfYWRkcmVzc2VzIChzdHJ1Y3QgDQo+IGR3 YXJmMl9wZXJfY3VfZGF0YSAqcGVyX2N1LA0KPg0KPiAgICBzd2l0Y2ggKCps b2NfcHRyKyspDQo+ICAgICAgew0KPiArICAgIGNhc2UgRFdfTExFX2Jhc2Vf YWRkcmVzc3g6DQo+ICsgICAgICAqbG93ID0gMDsNCj4gKyAgICAgIGxvY19w dHIgPSBnZGJfcmVhZF91bGViMTI4IChsb2NfcHRyLCBidWZfZW5kLCAmdTY0 KTsNCj4gKyAgICAgIGlmIChsb2NfcHRyID09IE5VTEwpDQo+ICsgICAgICAg IHJldHVybiBERUJVR19MT0NfQlVGRkVSX09WRVJGTE9XOw0KDQpOb3Qgc3Vy ZSBpZiBpdCdzIHlvdXIgZW1haWwgY2xpZW50IHRoYXQgY2hhbmdlZCB0aGVt IHRvIHNwYWNlcywgYnV0IHRoZSBsaW5lcyBhdCB0aGlzIGluZGVudGF0aW9u IGxldmVsICh0aGVyZSBhcmUgYSBmZXcgaW4gdGhlIHBhdGNoKSBzaG91bGQg YmUgaW5kZW50ZWQgd2l0aCBhIHRhYi4NCg0KPiArICAgICAgKmhpZ2ggPSBk d2FyZjJfcmVhZF9hZGRyX2luZGV4IChwZXJfY3UsIHU2NCk7DQo+ICsgICAg ICAqbmV3X3B0ciA9IGxvY19wdHI7DQo+ICsgICAgICByZXR1cm4gREVCVUdf TE9DX0JBU0VfQUREUkVTUzsNCj4gKyAgICBjYXNlIERXX0xMRV9zdGFydHhf bGVuZ3RoOg0KPiArICAgICAgbG9jX3B0ciA9IGdkYl9yZWFkX3VsZWIxMjgg KGxvY19wdHIsIGJ1Zl9lbmQsICZ1NjQpOw0KPiArICAgICAgaWYgKGxvY19w dHIgPT0gTlVMTCkNCj4gKyAgICAgICAgcmV0dXJuIERFQlVHX0xPQ19CVUZG RVJfT1ZFUkZMT1c7DQo+ICsgICAgICAqbG93ID0gZHdhcmYyX3JlYWRfYWRk cl9pbmRleCAocGVyX2N1LCB1NjQpOw0KPiArICAgICAgKmhpZ2ggPSAqbG93 Ow0KPiArICAgICAgbG9jX3B0ciA9IGdkYl9yZWFkX3VsZWIxMjggKGxvY19w dHIsIGJ1Zl9lbmQsICZ1NjQpOw0KPiArICAgICAgaWYgKGxvY19wdHIgPT0g TlVMTCkNCj4gKyAgICAgICAgcmV0dXJuIERFQlVHX0xPQ19CVUZGRVJfT1ZF UkZMT1c7DQo+ICsgICAgICAqaGlnaCArPSB1NjQ7DQo+ICsgICAgICAqbmV3 X3B0ciA9IGxvY19wdHI7DQo+ICsgICAgICByZXR1cm4gREVCVUdfTE9DX1NU QVJUX0xFTkdUSDsNCg0KU29tZXRoaW5nIEkgbm90aWNlZCB3aGlsZSByZXZp ZXdpbmcsIHdoaWNoIGNvdWxkIGJlIGEgcG9zc2libGUgY2xlYW51cCBtYWRl IGluIGEgc2VwYXJhdGUgcGF0Y2ggaWYgeW91J2QgbGlrZS4gIEkgZG9uJ3Qg cmVhbGx5IHNlZSB3aHkgREVCVUdfTE9DX1NUQVJUX0xFTkdUSCBleGlzdHMu ICBBcyB3ZSByZXR1cm4gdGhlIGxvdyBhbmQgaGlnaCBhZGRyZXNzZXMgdG8g dGhlIGNhbGxlciwgaXQncyBubyBkaWZmZXJlbnQgdGhhbiBERUJVR19MT0Nf U1RBUlRfRU5ELiAgQW5kIGluZGVlZCwgdGhlIGNhbGxlcnMgdHJlYXQgYm90 aCBERUJVR19MT0NfU1RBUlRfRU5EIGFuZCBERUJVR19MT0NfU1RBUlRfTEVO R1RIIHRoZSBzYW1lIHdheS4gIFNvIEkgdGhpbmsgX0xFTkdUSCBjb3VsZCBi ZSByZW1vdmVkLg0KDQpBbmQgc2luY2UgYGVudW0gZGVidWdfbG9jX2tpbmRg IGlzIG9ubHkgdXNlZCBpbnRlcm5hbGx5IGluIEdEQiB0byBjb21tdW5pY2F0 ZSBiZXR3ZWVuIGZ1bmN0aW9ucyAoaXQncyBub3QgdXNlZCBmb3IgcGFyc2lu ZyBhbnl0aGluZyksIGl0IGRvZXNuJ3QgcmVhbGx5IG5lZWQgdG8gaGF2ZSBl eHBsaWNpdCB2YWx1ZXMgZm9yIGVudW1lcmF0b3JzLiAgVGhlIGRvY3VtZW50 YXRpb24gYWJvdXQgdGhlIGVuY29kaW5nIGFsc28gc2VlbXMgaXJyZWxldmFu dCB0byBtZSwgc2luY2UsIGFnYWluLCB0aGV5IGFyZSBub3QgZXZlbiB1c2Vk IGZvciBwYXJzaW5nIGFueXRoaW5nLg0KDQo+ICsgICAgY2FzZSBEV19MTEVf c3RhcnRfbGVuZ3RoOg0KPiArICAgICAgaWYgKGJ1Zl9lbmQgLSBsb2NfcHRy IDwgYWRkcl9zaXplKQ0KPiArICAgICAgICByZXR1cm4gREVCVUdfTE9DX0JV RkZFUl9PVkVSRkxPVzsNCj4gKyAgICAgIGlmIChzaWduZWRfYWRkcl9wKQ0K PiArICAgICAgICAqbG93ID0gZXh0cmFjdF9zaWduZWRfaW50ZWdlciAobG9j X3B0ciwgYWRkcl9zaXplLCBieXRlX29yZGVyKTsNCj4gKyAgICAgIGVsc2UN Cj4gKyAgICAgICAgKmxvdyA9IGV4dHJhY3RfdW5zaWduZWRfaW50ZWdlciAo bG9jX3B0ciwgYWRkcl9zaXplLCBieXRlX29yZGVyKTsNCj4gKyAgICAgIGxv Y19wdHIgKz0gYWRkcl9zaXplOw0KPiArICAgICAgKmhpZ2ggPSAqbG93Ow0K PiArICAgICAgbG9jX3B0ciA9IGdkYl9yZWFkX3VsZWIxMjggKGxvY19wdHIs IGJ1Zl9lbmQsICZ1NjQpOw0KPiArICAgICAgaWYgKGxvY19wdHIgPT0gTlVM TCkNCj4gKyAgICAgICAgcmV0dXJuIERFQlVHX0xPQ19CVUZGRVJfT1ZFUkZM T1c7DQo+ICsgICAgICAqaGlnaCArPSB1NjQ7DQo+ICsgICAgICAqbmV3X3B0 ciA9IGxvY19wdHI7DQo+ICsgICAgICByZXR1cm4gREVCVUdfTE9DX1NUQVJU X0xFTkdUSDsNCj4gICAgICBjYXNlIERXX0xMRV9lbmRfb2ZfbGlzdDoNCj4g ICAgICAgICpuZXdfcHRyID0gbG9jX3B0cjsNCj4gICAgICAgIHJldHVybiBE RUJVR19MT0NfRU5EX09GX0xJU1Q7DQo+IEBAIC0xOTcsNiArMjMyLDkgQEAg ZGVjb2RlX2RlYnVnX2xvY2xpc3RzX2FkZHJlc3NlcyAoc3RydWN0IGR3YXJm Ml9wZXJfY3VfZGF0YSAqcGVyX2N1LA0KPiAgICAgICAgKmhpZ2ggPSB1NjQ7 DQo+ICAgICAgICAqbmV3X3B0ciA9IGxvY19wdHI7DQo+ICAgICAgICByZXR1 cm4gREVCVUdfTE9DX1NUQVJUX0VORDsNCj4gKyAgICBjYXNlIERXX0xMRV9z dGFydHhfZW5keDoNCj4gKyAgICBjYXNlIERXX0xMRV9zdGFydF9lbmQ6DQo+ ICsgICAgY2FzZSBEV19MTEVfZGVmYXVsdF9sb2NhdGlvbjoNCg0KRGlkIHlv dSBhZGQgdGhlbSBoZXJlIGJlY2F1c2UgeW91IGRvbid0IGludGVuZCB0byBh ZGQgc3VwcG9ydCBmb3IgdGhlbSwgYXQgbGVhc3QgZm9yIHRoZSBtb21lbnQ/ ICBJZiBzbywgcGxlYXNlIGFkZCBhIGNvbW1lbnQsIGxpa2U6DQoNCi8qIE5v dCBzdXBwb3J0ZWQgeWV0LiAgKi8NCg0KVGhhbmtzLA0KDQpTaW1vbg== >From gdb-patches-return-163008-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jan 13 12:50:34 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 104096 invoked by alias); 13 Jan 2020 12:50:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 104053 invoked by uid 89); 13 Jan 2020 12:50:33 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=tankut, aktemur, Aktemur, Tankut X-HELO: mail-qk1-f195.google.com Received: from mail-qk1-f195.google.com (HELO mail-qk1-f195.google.com) (209.85.222.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 12:50:32 +0000 Received: by mail-qk1-f195.google.com with SMTP id j9so8329020qkk.1 for ; Mon, 13 Jan 2020 04:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=F7Jc5CAZFBs8e+5LLXxx6AAGXnsHoTg9+BRmKByqcsE=; b=UX73gicNwXOesT8/7T5Ii/ktRAVweDKLUewCuwRbi+xFRewie2oloicrYr7M6FK1Oc 9U/sjZZ/4wUMwxqHN2fZDNogAH7tbRwfDJHdg3ltu/IQ8j6U06fnXUY5/ce28pVdvs0U Im3Cfs6OIqFu0MFHHGy1ga+ENi9t9fcUJjdfd9Vbh4OiNvFpqJa8MOfyLZi4UOseOEwc TQEQo526A6YAVIXaC7d5iB+WVhuUwTOJAjuRLNRYfNTwP7LWieE4NQgO5D45wVVUZrG0 SxpFzwxNWSyAlSXoyh5byY3Zs75EHr+63Mc66qcvPyRCvQKS/ioXba/2lqYOutXuVlfH w+pA== Return-Path: Received: from [192.168.0.185] ([179.183.9.215]) by smtp.gmail.com with ESMTPSA id s1sm4881549qkm.84.2020.01.13.04.50.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2020 04:50:29 -0800 (PST) Subject: Re: [PATCH] [AArch64] Recognize more program breakpoint patterns To: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" References: <20191223173432.16955-1-luis.machado@linaro.org> From: Luis Machado Message-ID: Date: Mon, 13 Jan 2020 13:00:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00322.txt.bz2 Content-length: 762 On 1/9/20 12:59 PM, Aktemur, Tankut Baris wrote: > On Monday, December 23, 2019 6:35 PM, Luis Machado wrote: >> diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c >> index 1d5fb2001d..c69361d4ea 100644 >> --- a/gdb/aarch64-tdep.c >> +++ b/gdb/aarch64-tdep.c >> @@ -1201,6 +1201,28 @@ aarch64_execute_dwarf_cfa_vendor_op (struct gdbarch *gdbarch, gdb_byte op, >> return false; >> } >> >> +#define BRK_INSN_MASK 0xd4200000 > > I have a general question here. Given that GDB is using C++11, would it > make more sense to have this as > > static constexpr uint32_t BRK_INSN_MASK = 0xd4200000; > > for more type-safety for the uses of this #define? > I guess so. I have no problem with it, so i went ahead and fixed it and the other nits. Thanks!