Re: [PATCH v10 10/10] btrace: Extend ptwrite event decoding.

Eli Zaretskii via Gdb-patches
2023-07-18T13:01:18Z

> Date: Tue, 18 Jul 2023 13:56:37 +0200
> From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
>
> Call the ptwrite filter function whenever a ptwrite event is decoded.
> The returned string is written to the aux_data string table and a
> corresponding auxiliary instruction is appended to the function segment.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> ---
> gdb/NEWS | 7 +
> gdb/btrace.c | 58 +++
> gdb/config.in | 3 +
> gdb/configure | 11 +
> gdb/doc/python.texi | 149 ++++++
> gdb/testsuite/gdb.btrace/i386-ptwrite.S | 550 ++++++++++++++++++++++
> gdb/testsuite/gdb.btrace/ptwrite.c | 39 ++
> gdb/testsuite/gdb.btrace/ptwrite.exp | 202 ++++++++
> gdb/testsuite/gdb.btrace/x86_64-ptwrite.S | 544 +++++++++++++++++++++
> gdb/testsuite/lib/gdb.exp | 72 +++
> gdbsupport/common.m4 | 2 +
> gdbsupport/config.in | 3 +
> gdbsupport/configure | 11 +
> 13 files changed, 1651 insertions(+)
> create mode 100644 gdb/testsuite/gdb.btrace/i386-ptwrite.S
> create mode 100644 gdb/testsuite/gdb.btrace/ptwrite.c
> create mode 100644 gdb/testsuite/gdb.btrace/ptwrite.exp
> create mode 100644 gdb/testsuite/gdb.btrace/x86_64-ptwrite.S

The NEWS part is OK (the rest hasn't changed since v9, AFAIU).

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>