Re: [PATCH] gdb: Fix build error on macOS

[Enze Li via Gdb-patches <gdb-patches@sourceware.org>]

Thanks for the review.

I noticed that the upstream gnulib and the gnulib used in gdb have different directory structures, and it would be confused to forward this patch to them directly. I will soon remake a patch based on the upstream gnulib and send it to the bug-gnulib mailing list.

Thanks,
Enze

On 10/5/21 12:14 AM, Simon Marchi wrote:
> 
> 
> On 2021-10-04 06:03, Enze Li via Gdb-patches wrote:
>> PR build/28413 notes that the gdb master fails to build on macOS.
>>
>> Based on De Morgan's law, the expression
>> !(defined __GNUC__ && !defined __clang__ && __OPTIMIZE__)
>> is equal to (!defined __GNUC__ || defined __clang__ || !__OPTIMIZE).
>> The expression above looks weird, maybe there are some problems with
>> this way of judging. When any one of the conditions is established, the
>> subsequent judgment will be ignored.
>>
>> This patch works around the issue by rewriting the expression of
>> judgment after referring to the nearby notes.
>>
>> Tested by building on x86_64-Linux and macOS(Mojave & Catalina).
> 
> Thanks for addressing this.  Please send the patch to upstream gnulib,
> to the following mailing list:
> 
>   https://lists.gnu.org/mailman/listinfo/bug-gnulib
> 
> Then we can pull the updated feedback.
> 
> Otherwise, we can always have a local patch in
> binutils-gdb/gnulib/patches, but if the change is correct, I don't see
> why it wouldn't be accepted in upstream gnulib.
> 
> Thanks,
> 
> Simon
>