From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eY6VNomtYGr47yQAWB0awg (envelope-from ) for ; Wed, 22 Jul 2026 07:46:17 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=A7zlFJuK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DAC311E099; Wed, 22 Jul 2026 07:46:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5491E1E099 for ; Wed, 22 Jul 2026 07:46:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 960344BA2E0B for ; Wed, 22 Jul 2026 11:46:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 960344BA2E0B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=A7zlFJuK Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 4623E4BA543C for ; Wed, 22 Jul 2026 11:45:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4623E4BA543C Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4623E4BA543C Authentication-Results: sourceware.org; arc=fail smtp.remote-ip=148.163.156.1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784720746; cv=fail; b=kilwtzg6iNN+ODG+KudxHzPO+0Uq8QAb+UDcix4+o4Pz3vdfG4kMFa0eY/zuSozksm88uE6MiBlYKPoUzhyyPdJ3VA/1fzBjhaZjGO0GcDFUQA1u6Efnk+XYU4M9CdSL1VkjEALtjUjw8BzFDjPZOdY8DL7b8Ca/AC3zjDenrcQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1784720746; c=relaxed/simple; bh=rNY28P3xrkSE/N+ll2qDdLUJFLSsAmKrSzf0d8y4ReY=; h=DKIM-Signature:From:To:Date:Message-ID:MIME-Version:Subject; b=GK1wb1VbzvAXEkFZ7fbf3ogtcY31irqognGGwT+qBfRObnmkNUzV4XKUdAGztl0LcRj23wAOxILGfgFMg5I2w0va4C+nsD6W0g8K2rUMDp4o+cD+idHeee0r3mQkAgYIVj2pDZOkAagrAkNxg1c+BjAlgJAScdUjbaCv7C6Mu3c= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=A7zlFJuK DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4623E4BA543C Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M9C7F23672417; Wed, 22 Jul 2026 11:45:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=DFDqIL647RQLGrB1/f+knRm3RsH912 oZZk5pqRrIutc=; b=A7zlFJuK7INdRJzx9TPDI6NxVHdDOqZSUUgza1xebtxAh6 Cnjlr9clqZlwCiOBHjPrZ28nI0ex6DkcWoeRs5fUmFkXItUe8umpEBnETmZTi1dA FtcPyWO74hLl61CGgHNqd9MAV20VcaWnNXP5scPSFXEnk/Nl8SgwvlxcUrwE7Iv2 sSVMJDc51H9XIgIwvy9M1Wn6XEx2eZrjY6ioxvwbwl+SzsM1CUT1rOMp23lT/SuG DFIRV/3kUu0c1MblVVi/BmLeZtxnFd3HUynuAjL1gwyLrrYEJkWTGoD4TwMO/i0j XI5qD2/j6UNRh+T6Vjz0so9LNFh6bXUAv5GHDTqw== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013029.outbound.protection.outlook.com [40.93.196.29]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fg7911w9f-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 22 Jul 2026 11:45:42 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HXHcAmM5r23JvC1JXRspUTELkfnfE2WSWTSYMHrYHF9d73V+s3i5ks9rRQR0ZYe7FxftmxDpzhwbLJc1ahwCcpu6TOfaMvfh7sk9zdmwuJ98vkdGFRzjfl3vZjzzjiX+RyV4MtC0/eP+MV69eZL82KwIS421mhcqAKx3JJDUdNpVjniZ9GdqDn3uDxyiEXUzLiIOIbeNEx0F4P4QEwCbb7jbVo1KJOKkOW7/jSxs2ogZhKfQoK/S2W7zswXCKU/28ws/sjW+qDrC10+2rK5RNC2bMVjzEXzzLfPznHH1/2m1UdzQcAV94OK+BSFVhkXeJB9VQOvXSdKCGh6LsYLUQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DFDqIL647RQLGrB1/f+knRm3RsH912oZZk5pqRrIutc=; b=hTeuwQXJNTuQ5XUf0XXOpPfFXA3yZ38EdxuWQpz9K/Zd1RSKTii8sFfam7sN0sQyEj1vgvWDPgdRLTO1UbrGtZCCoVFWFXH9QsBSiiHJJa/WD5SWZtkl93TCItAXkk8URY9O4Yjho5yB15soRiyNLx7eoRC34HhNE2r8HXbU3wfely0kJV5DGHt4ZhGYYOBFCSD9rJ6btwMFMlvOQqqPY5xd8Z66NYY6O+mVvs+Sm7rLt2+RKJLXdsvOLCLuM2Ck3A6ByVsTJFVfgyLzRznLffX+g7Q6IZu4CWXKx9tFxIpGt/t/vxjBMziGeNMgo65/kztNplBw43eWrncevtiHgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ibm.com; dmarc=pass action=none header.from=ibm.com; dkim=pass header.d=ibm.com; arc=none Received: from LV8PR15MB6488.namprd15.prod.outlook.com (2603:10b6:408:1f4::13) by MW5PR15MB5147.namprd15.prod.outlook.com (2603:10b6:303:198::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Wed, 22 Jul 2026 11:45:37 +0000 Received: from LV8PR15MB6488.namprd15.prod.outlook.com ([fe80::cc4d:8604:c04f:2a40]) by LV8PR15MB6488.namprd15.prod.outlook.com ([fe80::cc4d:8604:c04f:2a40%4]) with mapi id 15.21.0223.017; Wed, 22 Jul 2026 11:45:36 +0000 From: Aditya Kamath To: Tom Tromey , Aditya Vidyadhar Kamath CC: Ulrich Weigand , "simon.marchi@polymtl.ca" , "tom@tromey.com" , "gdb-patches@sourceware.org" , SANGAMESH MALLAYYA , PRAJWAL B MEHENDARKAR Thread-Topic: [EXTERNAL] Re: [PATCH v2][RFC] Fix crash in AIX when current working directory is NULL Thread-Index: AQHdGTlRtsUBSiHn5Uu7Nd7DcqBwhbZ5bAul Date: Wed, 22 Jul 2026 11:45:36 +0000 Message-ID: References: <20260716112022.81520-2-akamath996@gmail.com> <878q74utan.fsf@tromey.com> In-Reply-To: <878q74utan.fsf@tromey.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-reactions: allow x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR15MB6488:EE_|MW5PR15MB5147:EE_ x-ms-office365-filtering-correlation-id: 82fcfc55-0007-4b58-3e26-08dee7e6bf0e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|23010399003|366016|376014|4143699003|8096899003|56012099006|18002099003|22082099003|5023799004|11063799006|10067099003|38070700021; x-microsoft-antispam-message-info: 4Rp3Q3pruvaaDmbV1x8phwACQeqOqbtyHBpnNnHVJJyfBtLS9S4lzZ1q5Imyd7VQ+/Wy6laqKhwZgMSA4Kno7iH2tMawEy71kA5CCC9fjmuPhQNqFP+PXStw08lxPPVLzg0DnDcISVGPddqLzK1ulYfq0kqVs56JdIcOq/PuZIKTQaFFqpwTCMPrJdOzwX4RFyTvbw3z9x/pism284EIk9eKLzFUoPasfveN7hunTBejSI142NqeRETtRUlC5Zbbl42mdvIvIe+5dkY078sqKsqSF39Eb3i8bQQSA51pUbAYU+11vBtsqe83sFxj7ZG5EgmByqW3Fa1BnhFaxqkHzdOrR2z7lo63o+Txgprw4PNz/OBDTYEQvMqnSUke5yQoNjJ3rHLcEJXzfMwvXNxIF0rGg9RKNCsAZqlFvUP0mwj/DAFBxL/uripYJSVwRA349/AD9Z05XUvwHUhpiG1KguCfefgBUUmxTDhgmsFjTiyZnva8RHEkNCnxiZybTyLnZC6mqWm/43NBBtodcgs5IkGe6aGkwyLDWj/s35ZSYoKRCzXD/SnBmKmcMlqFwAE35pNjDdZmxErF97rWk1bFRIKtnQSGBSlC2+qGIBp6VdOAPlX/XudG2pkZMec4h/WPKBUabXYVt/0t6656kpXYtSmTbOaWP3VPSX/wVKt4WNA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV8PR15MB6488.namprd15.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(4143699003)(8096899003)(56012099006)(18002099003)(22082099003)(5023799004)(11063799006)(10067099003)(38070700021); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?du2CuUsf9nHOjkV6GgUvYibY1XJtzl32xEbyvKdGW8/6fugAsL77tG4MfmnG?= =?us-ascii?Q?pZfFcujaxkhAOo5oXa0GsGVrnFloLfBJZgQea/TAAA+8eK+ZyqTRJh0eUCml?= =?us-ascii?Q?LObSqFrzHGDhVh957QL4PTF5ZmV1ihBP4nLsPb13p3ghI/DFfU/bcs1/0JqM?= =?us-ascii?Q?71sjjdvv/E/3RlAa1n1sReLw9PLwGJBl0pu9kKNWr+FXERkGbWwdImU0Y2vX?= =?us-ascii?Q?t9fIKeFgGgi3dAIXgNuULLqN4OenOT6idjaNY32NxPWdwjQGn1Sb3V5kR09S?= =?us-ascii?Q?Z+2D1w/RrfU9Tv2ZNmhZBWPfrkQMaio5MMbiOY4Kj51bUau6XnLYCzyFtHp3?= =?us-ascii?Q?q4x3IlMCgi5reg0CuRfnji19Zwk4hIrWiS9GdyPpshKRW9K9EklKxvhP9aWY?= =?us-ascii?Q?2BCJZ4wYkDk7bUoyu+BTvjIGVd6Uqxjy7jmJrXIRJWwIkTXEHlEzUcEfaSNf?= =?us-ascii?Q?xfozjMRYLeYTheDVr0SUQpgs1L+ESeAXjOZGzYViR/f4SkKs6KLwMhZBgiI7?= =?us-ascii?Q?nhWk9Rjvw1zwHN4oGDbyGBjT+VyAdJKrtjP5Nh3dOJN1UwMoUDQ6oOQ+XOXr?= =?us-ascii?Q?5LXq/Q5xt6K2YnWZrA+szfFRPohxhAb99PdC8wubUeGonQ4RbenOSUDERzlU?= =?us-ascii?Q?G0dTAOgEOpdg1BrkFqWKptPHv5E7hFsGkyWFfLDPTRdqwHAmga/LKjcJ4usk?= =?us-ascii?Q?BhVZfh3A8nbwIgicx1EeTfrNe2x0jBOQQ8bGxOUIQ0jsHmr0VwC/hyLlouBA?= =?us-ascii?Q?Z7M9cpK7xMdhn13F54sVW0uGd/yqSZ6ehWszowvbsZM8q3pWy8ojSc49YySD?= =?us-ascii?Q?hdmem/jC8yTGPCFAWYUUqbNlKSo5yipOUxeqOWYjkRMWVRfH062OT2HQ5NyN?= =?us-ascii?Q?jK6Gq49F9ce7MqpXMQ205IUnOPh+yCgqcpFmuW9D1L21MeeLV537eS7Ha2Mf?= =?us-ascii?Q?xgcGJVJOBJgw+OchlL3ayoQ9b67lXQqXp1saURVnUp1fcp+gLbYufK65I5/6?= =?us-ascii?Q?xBm0NGdnCbug1SjexOA09S3YkCWQgab9jFR2TNdc9F6vUZA0ytSR8ENy3ilf?= =?us-ascii?Q?ffjTtNkie/+QSLLOUlf3lpEXdb3EEMjjm3DU989rqat+fhmtZ/STXLPPDWAr?= =?us-ascii?Q?TqYaNWypjPD6wh08XfTkSLRxBtg6g5Gg7jl3u/FRTUXcNyR4LMWBoKav7uOa?= =?us-ascii?Q?dHj8Iw72yCtBNZvQtNDZreF6w6AFIJ56eD3xQ+aAHCxOXO97NRKi2ijP3tld?= =?us-ascii?Q?DE4MI9pjxfyXkRTWdksEYgwAI5Hl64c1Dl9SgEdE9Po5uSeBZzGVGncn+NpG?= =?us-ascii?Q?c6fGQuT3vafa67P3EfRortDBzWYZjj5UBs5nBqfbn5TXqxz3LOqlTHEYD4nU?= =?us-ascii?Q?t3h4fyW6aXtO+jTIHPBsTKlYlxcYlZYQEXnOOzDbuMhPLh9kNsXOj0OGFA5q?= =?us-ascii?Q?+HVJoW8WTxvrU40YQFwTJlbucKaRzE+P7ATp/hHWtFinr1qzOTIF1mxKSqV2?= =?us-ascii?Q?mwbNe1F9RlhQsMlp6InkSwww1g47TVJYB9G+IFa1R95U0molLJL88Bd2H/Fu?= =?us-ascii?Q?yqtUtvIyNx9PdOQzV/GrOCTwgqsFU69W3Z+mtXHq2scCoKxEmeIQ8eHsKqgn?= =?us-ascii?Q?N+vTnjhTBwHWwuWhtKvQyDDN9FwSgzywL2AV/9TB5JfwFF8a6j05NOAFvnyX?= =?us-ascii?Q?XezGQ+/xZvZIW12G67KueIrNli/yWVN9XJVpL8bXqE6i5OiiUbJq48Q8Vqd6?= =?us-ascii?Q?v3zVQfy8Mj29P6b+8CWfdavoPM9XPy0=3D?= Content-Type: multipart/alternative; boundary="_000_LV8PR15MB6488E3F5F81E181889342039D6C12LV8PR15MB6488namp_" MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: T81j/6SaHHWvcnkX47GS8cVuYJfSIQ4PWB9UhtMolPKepGnVpYJ4zgXX+V5kPaguox+rbtj+bGAZMDGXgzfgZhbsIedlZajNa2DAmNwJu0zVWOYGZpEoDlorgJFCo+YFjBafwr/W3AA17QMuYR/u/RybERRED/rS069+TCS+EUfwbj7Cisa6D/0Sn+HGLGY25FlgrnK0JBhjyMtNuPmdZSLtV39kYZE2ij5D2WO2if+oSxMG9ZlrztW+M4j95CmZHi/jRUi95xxzNc/NSie9JzuTlfLqYqXChnC/AOi16uHekOBFqc78GmzhMq04gVuqynDvsIujA6COJs9oGaf79w== X-OriginatorOrg: ibm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR15MB6488.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82fcfc55-0007-4b58-3e26-08dee7e6bf0e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2026 11:45:36.6829 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcf67057-50c9-4ad4-98f3-ffca64add9e9 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A0ZnzEolX2LDWjTTsb3spf3+60MdokTd+oymzliRS1ZPBxdYaCw80YYy8HGYtvDIVs5rlVQOvDJUOUi07NYhTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR15MB5147 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: ygHBF36jrhnexkMFjfGemlbtEnnVgzdN X-Authority-Analysis: v=2.4 cv=V6RNF+ni c=1 sm=1 tr=0 ts=6a60ad67 cx=c_pps a=y599upwrfiZ3HV94zaFOUg==:117 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=mDV3o1hIAAAA:8 a=hGbEqKusnnkfhXTlZi4A:9 a=CjuIK1q_8ugA:10 a=sOKKKeEq8sC691C0sj8A:9 a=Jb1o08u5JWjgoMkt:21 a=_W_S_7VecoQA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDExNCBTYWx0ZWRfX8DnSupStSzS2 RCheh9xB5j7iZKKqPkaCfoiWeUr1cqqB58QDokpg9oQa4H4vDo2ws8Wf/u2E5oHz1URNZ5wnv4q AalSKLFVc9jcTpDPEGxQyoRmtYumGto= X-Proofpoint-GUID: Gn2vnsafXW67U1IKbuu2eLxgTNyGln6k X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDExNCBTYWx0ZWRfX/QTa+8k2qabT SxeDtPMQaNQr9mGa39D5v7wCLgvn3/jZ/xfFxJl5NjR0dyI12naQgCwMi4S9V6Ecn9GTf+yradv MwJqOpeVP/CKkoxo2jnHA7OG5g/vMUUFq5S7fm6+VF5nhpm9ZhU+4SKkNxeo26+Wt4ETLn6YUDU ijT0jTG45INEa9fm2dAgLiv4QabrmU6tskqQ2J2owB51VCHsIfgn58PwVhDfd+Di8YRlTf037rm cDVbJpsA7bgMwCU7IwHOFRGbiTuxA1lfBrHAfdW4Ie4UBXOiVRoFinAxCHRjQFdxPuLcABLHWzu 9Z/iWqo6hGCDL76uskouXFvAGpkldpwTUwF5W92T+QbMlbEUSp7/7uKC5o6AlwIcmLt73ajyvpp pIdOsBcblN9U1m2mCeNRF4Sb086laRy3Gert3ZajFbt79ZocUhPjC44tWy81igGgRU9ItGoFPL9 jpQE/rKc0k7t5bpqm/w== Subject: RE: [PATCH v2][RFC] Fix crash in AIX when current working directory is NULL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_03,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 impostorscore=0 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220114 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --_000_LV8PR15MB6488E3F5F81E181889342039D6C12LV8PR15MB6488namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Tom and community members, Thank you for your feedback Tom. I have made corrections as per your inputs= and sent a v3 patch. >> desc =3D openp (search_path, flags, file_name, O_RDONLY | O_BINARY, >> - &absolute_name, per_bfd->captured_cwd.c_str ()); >> + &absolute_name, per_bfd->captured_cwd.has_value () ? >> + per_bfd->captured_cwd->c_str () : nullptr); >gdb style is to put operators at the start of a new line. >For "?:" in particular I would also move the condition to a new line. Done in v3. >> diff --git a/gdb/testsuite/gdb.base/getcwd-fail-helper.c b/gdb/testsuite= /gdb.base/getcwd-fail-helper.c >> new file mode 100644 >> index 00000000000..a5e8fe80cbf >> --- /dev/null >> +++ b/gdb/testsuite/gdb.base/getcwd-fail-helper.c >> @@ -0,0 +1,67 @@ >> +/* Helper to reproduce getcwd failure by deleting cwd via child process= . */ >> +#include >New files should have a copyright header. >This applies to the other files as well. Done in v3. Referred, bash-5.3# head -25 gdb.tui/tailcall-msym.exp # Copyright 2026 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 3 of the License, or # (at your option) any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program. If not, see . >> +catch {file delete -force $temp_dir} >Deleting this is probably undesirable. It's normally good if running a >test leaves the test environment around. Sure, done in v3 of the patch. Thanks and regards, Aditya. --_000_LV8PR15MB6488E3F5F81E181889342039D6C12LV8PR15MB6488namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Tom and community members,

Thank you for your feedback Tom. I have made corrections as per your inputs= and sent a v3 patch.

>>    desc =3D openp (search_path, flags, file_name, O= _RDONLY | O_BINARY,
>> -           = ;  &absolute_name, per_bfd->captured_cwd.c_str ());
>> +           = ;  &absolute_name, per_bfd->captured_cwd.has_value () ?
>> +           = ;  per_bfd->captured_cwd->c_str () : nullptr);

>gdb style is to put operators at the start of a new line.
>For "?:" in particular I would also move the condition to a n= ew line.

Done in v3.

>> diff --git a/gdb/testsuite/gdb.base/getcwd-fail-helper.c b/gdb/tes= tsuite/gdb.base/getcwd-fail-helper.c
>> new file mode 100644
>> index 00000000000..a5e8fe80cbf
>> --- /dev/null
>> +++ b/gdb/testsuite/gdb.base/getcwd-fail-helper.c
>> @@ -0,0 +1,67 @@
>> +/* Helper to reproduce getcwd failure by deleting cwd via child p= rocess.  */
>> +#include <stdio.h>

>New files should have a copyright header.

>This applies to the other files as well.

Done in v3.

Referred,
bash-5.3# head -25 gdb.tui/tailcall-msym.exp
# Copyright 2026 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/license= s/>.


>> +catch {file delete -force $temp_dir}

>Deleting this is probably undesirable.  It's normally good if runn= ing a
>test leaves the test environment around.

Sure, done in v3 of the patch.

Thanks and regards,
Aditya.
--_000_LV8PR15MB6488E3F5F81E181889342039D6C12LV8PR15MB6488namp_--