From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8btaA2fEwGksIDUAWB0awg (envelope-from ) for ; Mon, 23 Mar 2026 00:41:11 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=JfhsXm6k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 099A01E0BC; Mon, 23 Mar 2026 00:41:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9532C1E04F for ; Mon, 23 Mar 2026 00:41:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 38E2B4BAE7E7 for ; Mon, 23 Mar 2026 04:41:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 38E2B4BAE7E7 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=JfhsXm6k Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 5532E4BAE7CB for ; Mon, 23 Mar 2026 04:40:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5532E4BAE7CB Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5532E4BAE7CB Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=148.163.156.1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1774240840; cv=fail; b=DuAs2zZzY+piTG14aCpjL2JO54sSb2AdtSCjw3L/VETAZZkChk9JsWhR+JLQz6BCOSzbTdGroJGsxkwLqO3ES6RVdPLjbJOH08ULRMOZ5AvCH2g6Zh6hrOXyTeXy1u8A+a2nzGNYTvs3TpmfGzS0k30i6ySbCuGGZH0uHH5Os44= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1774240840; c=relaxed/simple; bh=tdXL6lyNqihpf7ut0+I31gxCwxXv7piRRemlSS6wZyk=; h=DKIM-Signature:From:To:Date:Message-ID:MIME-Version:Subject; b=KQZdIAGzP6R1A8B+wZb4XxCLueE4cSmHfNC4FB1l3p5eGsqmqqDUNh5Xe3BgbH8q7JvQPNMrJLyJ2Vc6BKlWn3aO8+Idq5zTDowsQ2XO96XZU2tIioHL9E8lpXdqQEQqx7UGmP4sfjfsk1TDDUe1Rxg8JIdPgkmzhVL9/Lbjuwo= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5532E4BAE7CB Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62MJRlpZ213179; Mon, 23 Mar 2026 04:40:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=vcSwSjY3G9c/2gqX9F7iVnEcuadurr g6NfxnE69AmwU=; b=JfhsXm6kuuT0MNOsod4LTq6Rh8qK07uj14CiyurumRCaFW uv8zT38MaQ0geHQDmBPwl0iNCsjz+G2uuNQlUMQ4EfSYPnDI5LL9In0LEwmz6k6c Negq5aaRpCSoa2EHrExEMOv0GtGRdAvWb4yO5WsthJpGe+ZdeQG09xNQ6y3sV8ED 0LQXdp2j1d+PZ8mJZc/s+jYsFp625hyM02yfNyvj/VSNwmUW7lBNMQsJ2iuW7X9r D9ANgzLbwEgGYM4Ttt7jLllprV+yAEVDMC2aCnqnehb/AEryeNBAVTOHdJuiEMQF /drR9DnvS23X8eE4EMt5Ixk2RVvCKBiOCVnEfopA== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11013065.outbound.protection.outlook.com [40.93.196.65]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4d1ktxncuy-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 23 Mar 2026 04:40:37 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=x1uKVP2KSuKFgTOCuNcqwCWsZj2ElJ25urCiNKE4SLCjBgyoHAvV93PMyvOfxsqtOZKz8ApJm0eXZefQehlZm+X+TwBofiTwT2V/ZoBYgeX4WwC/JhoGyRfqGw0nPPH5M061rwl45zXVRKGbCFV+Us78CsmSYqsX+pL83B70RcJrPaAaxshB4XTNsB9oz99zWmnP/G6iHdhJCZDI7P0rZQDsmIDJCmGVxEYEgJS6L+acJSyazCEjIUboCxoC6K9MMM6jPdgcux5PbVKYrX1YR4OliqWYadRDsbyuWMJ8cpZ6w/1/aeUIdhEhGWoaGsu/1MHYL8PBhvC2MTMJov3vwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vcSwSjY3G9c/2gqX9F7iVnEcuadurrg6NfxnE69AmwU=; b=Hdbk/DK7IhytHCR6bEErsEDu6OidxQC0OZkHiY9aKwUszIM1lXxjzfa5vTvc28yPbpPggoi6WaaJer7UcS0hkq3srOIMh5WUeMNo9oBygnIFZtrRULNzRu6ejfr7sAfUVc+GvegkH5t8Q7SFzE/VWmw59E3SwrfpIs4TIEDezww27bdvmIQPsnYgZAL/rhYQ6fSlalPeKHTIbPqSo8YAtWr96+1xJy+BJsosUCXbxDyNk6GrCvV5ejLKAuBKOmWqJjB65pUIGBhc0dvEtsSuA0LJblgPe06eOYZ13RNdxPqvJ37UpzSKFBrteyKGr8dEdkvs6yFAQlO2oHC63rFEXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ibm.com; dmarc=pass action=none header.from=ibm.com; dkim=pass header.d=ibm.com; arc=none Received: from LV8PR15MB6488.namprd15.prod.outlook.com (2603:10b6:408:1f4::13) by DM6PR15MB3910.namprd15.prod.outlook.com (2603:10b6:5:2b3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Mon, 23 Mar 2026 04:40:35 +0000 Received: from LV8PR15MB6488.namprd15.prod.outlook.com ([fe80::cc4d:8604:c04f:2a40]) by LV8PR15MB6488.namprd15.prod.outlook.com ([fe80::cc4d:8604:c04f:2a40%5]) with mapi id 15.20.9745.007; Mon, 23 Mar 2026 04:40:34 +0000 From: Aditya Kamath To: Tom Tromey , Aditya Vidyadhar Kamath CC: Ulrich Weigand , "simon.marchi@polymtl.ca" , "tom@tromey.com" , "gdb-patches@sourceware.org" , SANGAMESH MALLAYYA Thread-Topic: [EXTERNAL] Re: [PATCH v2] Add support for recording minimal symbols in AIX for non DWARF compiled library function record. Thread-Index: AQHcuI64FfwRx6VpoUihdcsNUWVh0LW7i8Oy Date: Mon, 23 Mar 2026 04:40:34 +0000 Message-ID: References: <20260320121637.91452-2-akamath996@gmail.com> <877br69zuc.fsf@tromey.com> In-Reply-To: <877br69zuc.fsf@tromey.com> Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-reactions: allow x-ms-publictraffictype: Email x-ms-traffictypediagnostic: LV8PR15MB6488:EE_|DM6PR15MB3910:EE_ x-ms-office365-filtering-correlation-id: 58d998b3-c258-4ca2-4ada-08de8896529c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|376014|366016|8096899003|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: mOfLorJXDUMNKJViIIsOCBM745zebWeeqIbx9h6a7GcVudGKaxQkTukPrYPLgAhjh8JtXPni3J3DBX+qO0W31d1pcnvMdNCJxlukKSengayrhP6xiurQ6ua4ndHeieh5JSVypINggUOwzqVkNZwvdk2sim7yUYAR/K4urSyANLGqo3qu0fbJm/yKHzOYja/rBLlpfEvu9KWcdnPvMDqd+K+6TJHQ/oivViXiFwMjIpTGCyShrwI4alF+CVZJUldvuazEaoxb99WNuoSS29k/mWEnCePekfayGsaoK3E86i9EzGhpk6zS0jUcM4Ldhq8potHQbcnjfyFz3uEAx5rIDv5QjDWrHfJ0QTPjPahPFK5TKoKMxGaAALrC0re8Hglb5Y7UwIgFxjuZ9AqMm73753+9rRT+GKEG/B9YSHkDPJgFGu5t2kfGfKOxMuCUOxou+iz3KS1/CHIc5LcQun0YphQ+W8tULuxaUROXIuw2I9sBLd/F6L1UPWCk35mliq7v9mSBu0oQTiUkj1FI8DsYZVxeCf0v5AJODOUC4bqXkw0GJVmNQMmA7pZy5OKK7niwCV8qWiJ1U+KUWf0rHQ+O1PxBp8ep2+L7RSkgl/TfNTWwI0tc5VNtrhY1k/7Pt0DIsFKtlwqLlTJftT6TuPrcRAc6+OX3M0hdiZ25m3M+rf7TwqY75V0HV67d77vdV1Q0bDFc0RTYeGvPh9Oc+qqgoOVs2sqD28YA1PrQK5G4O4ZpKZe5es0iCDH2Nbbfs/ogrSl5+fn4zXSM6fiF6XGpH9QK0WpPaiOMi4rnEA6vq0Q= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:LV8PR15MB6488.namprd15.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(8096899003)(38070700021)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?Windows-1252?Q?ey2yqe2Mx6hmZ05ghn1vjjhmB1N8zSGZe9AeCALfsjvUrLid0ThXR/KN?= =?Windows-1252?Q?mVjcd+eUrDWNaK15wso2ju/qcFpazNkCyVq12dB7qnFQng8z1eoaWU/w?= =?Windows-1252?Q?nlYbKbYIAEya6psx21DyxaFyUJvvvw5YFGZnC8LZpuz/Ya123tJ0ATqP?= =?Windows-1252?Q?6A1o7K9+PasXNA5UNRjm/e3aKT5dWOrUDr7/NsFBHIa2abG4oY4edal2?= =?Windows-1252?Q?PSSVIs4SrQFkFd/1lAM8nvhyFU0K0bBrZtxe1XVYYuJXyktxYOau1k0c?= =?Windows-1252?Q?+wiQTZQbEAYunoFU6iuuVXhWA3Q+ArKaZmiLwzObl3yIpIywANJyNeGj?= =?Windows-1252?Q?lqukO8SCB9uNrNi6IJxl3X9d3bWfAEAJ7J3XPf/khfkPmJoYUn7mJXFX?= =?Windows-1252?Q?/sSCvNK81YlYfNXq2i7O/6kEsdLNeSHUcWSaDYVeXRa0/ZAGTa91p3LS?= =?Windows-1252?Q?A2I0fS/hnaHEd0nT325kgLx899EUe+snKG2twPPmcGxtVCOHWSBwIuoc?= =?Windows-1252?Q?WjQGFa+VM7kURc1M7Qe89QPIqOSiNPIGlpyXnb2RgXXFnK8QjCVJ53wL?= =?Windows-1252?Q?qlqAhOt65s4i2ElKBY09+DN7YUvt5GRyJ7JF1eSTsYRPmD5O7n8rAV8r?= =?Windows-1252?Q?ViKEVPjSMfVd8hHU3mU/PKZ6GMbS4CdpL9EugxOuoliIvpfon+zR1SQ0?= =?Windows-1252?Q?R+8NPVHU22HCgdh6sQLM34NeoYnUyQZgBL96bt5kkGCmIl3SDoYbdP+y?= =?Windows-1252?Q?wSsElm7p8xLkh1tl6vC67+mKbWh6C+YMrpPdUHcQg4gwGmvyNR+F8N/m?= =?Windows-1252?Q?P6F7LiGbKit5SvHcULcDtTyPZxtuZLbT2kgpuACnSn641QWkMhzmn0JO?= =?Windows-1252?Q?fZXYRDxd+6u3eDjXckP2++6GurffKP5xgALOPqK3FV2p5PEYzjoTY4Om?= =?Windows-1252?Q?g/z4cElAxe9rIuZSYuwPKkze1Z9440tI9xmlL6N1g41H92EJPow0x3Qi?= =?Windows-1252?Q?smq2iEr0XSa2DYgbEEfEYSDmOuVFpctJDJt9KYbGml6jMKQwVB5NcGGI?= =?Windows-1252?Q?ss1B8KSypztn/zTiYZpK16u7I8P4Kj7xTDXoj3GOs0OPreVfEF9mlbg3?= =?Windows-1252?Q?jBFNbJTX4r1hj/OXnBagbqA+HloEp7ggsh0+My0QtOwEmWPOVjbw1QiH?= =?Windows-1252?Q?Mp+3Rf0qTG2YWrjMgh6v2CRbUDwSnkNqPqr9bivC79GuWK4WeG3rW+cP?= =?Windows-1252?Q?q0bNOP4mhVl1AC84zBr6zxmNQVEBDYQElfz4XGEeiIOj3DvbPvIoXOvV?= =?Windows-1252?Q?SaInZbbH6J/6cD/IRxf32BZNw0AcFVkVnbdKiF77tXVBFcS/+sr/pKF9?= =?Windows-1252?Q?aZ3SCiHQiTCkkH6NnWrxJKAs5/C52jHbUHcid5KuCRg2pJ19S+ovavY9?= =?Windows-1252?Q?gm6zolvjieZFsKe13S9ai7dje4eswsTE2GdhBu79QVwEkGO5oBeJx2KA?= =?Windows-1252?Q?+a+3aCgk5NsjSbLQTRjqsrA7GMdDXjvVMeiNDO77UzRWK4DDSCR5VBwQ?= =?Windows-1252?Q?w1WqyeXufWzc2cfchL1LeXx9g2IHMxkQzjdLLmvHYk2iMHtv4ocejDAX?= =?Windows-1252?Q?RE4KQH8pZRB6pD5fHzoc9iKWOURGzRHjluiAgolIqKeitGGtjTCatr2P?= =?Windows-1252?Q?zSEwb4hB1BswtvJQ4hhPjubaN6t4ADemlveVcc0mvEDsuJ9rnuHRagGw?= =?Windows-1252?Q?iMDLKhqv6LjRSIByPv6vicLvc/5spdfoxnLzAp8dNZDEuu0AA4lAbYV0?= =?Windows-1252?Q?vrGL4RBl/7GhRsCHTe0MOJ+G9pZp9ag7Cur9lkzM+NDiK16vmP7xH5tP?= =?Windows-1252?Q?s6ua7krmOH7aYPcXxmVi7jm9yeHfekSraBU=3D?= Content-Type: multipart/alternative; boundary="_000_LV8PR15MB6488DB91D898B67249F68BD1D64BALV8PR15MB6488namp_" MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: Alf/E0rhM87Ry4JXV4v7WxCbZ61gLzl6TjcvuGGOsVdc2le8qUdNvr9GcszdZl4D7ZpeaIJL3Jy2uNzTSXg0J3ZnV1ak+GVyOf1vLc3OSd4HiMuzZQJsa3lhG96E03N3L28s7TJKonLh+mtrOBPLeOTldGEpY1z6iyDOloKhdxAy+PfPbqIoHh8iV2/sAdjgPNQZllnNDWmo1Bwfnq6r/SW6AEPwZ3gOlUmMWpWh6XcyApM29O6TdqaiaFeHq4ZN1QO82YWV3Vn27TM997ZV5SGigwUGt4jjUz1mRkqEt1NRN0pWJbR+XOnuFCn1adl/j/2dMJ4YoYSs2qunOpLi7Q== X-OriginatorOrg: ibm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: LV8PR15MB6488.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58d998b3-c258-4ca2-4ada-08de8896529c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2026 04:40:34.5570 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcf67057-50c9-4ad4-98f3-ffca64add9e9 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bBsxC4nc96l7K6W+00aP3hiQx0q/LYnyb9ODS9PDvSJODLkFg+G/Wt9nZ7yV9i1Jf0Pipy3QhItx3erVMwHzAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB3910 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=IqITsb/g c=1 sm=1 tr=0 ts=69c0c445 cx=c_pps a=fgNoY2FrYBgJmLE9YDNrYg==:117 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=l23fEHn5NV9Z91sAzYIA:9 a=pILNOxqGKmIA:10 a=KkfQatZsXjhzf_sih3IA:9 a=nTS0qBvDHYB6tDp0:21 a=_W_S_7VecoQA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDAzMCBTYWx0ZWRfXxyjls/rhx1oa AiS0zF6qKwEbPXE9sjijowhYLz0jCXXu746C6xAQViWDZ+yKm9Wsk+BoWGVfnF1Pv+Sx8s2z6d9 Q8bN5EVIebJc9CR9Nw3i7vY1mrQ1QG/fZufkIW8CAk20u8+mDQuMHwBwedvQ2GmJq2j7ZpEV1Ld EBHkjUAejxl1pbjs84oLu3p/TMICixuGraInjHG5JaQt8YRZeRm230t82kxJDnzm0K259RfUL9o 54fHQwhv+izsO/PUbFZ7UuYT0G9UO48OMGG0ACjv3hsDw7+RqhFq4VOqwBLUFET5tl0PwlpdNt2 x5d6JEikDWDkNJgmzC95MdSMhFhMar0tWMFE5TaE9LxtwaIWzgXg+eIrdccFCNrishO0mCQ7ypE 0d7PKlnmPciqnO8mMOpBYCZDVlMcd5Ztr3dnlOGg9YsraJ4wSyCusbJk6JBOUHYo62FY4w9iuIS L0Xky+Tm0vU925Kc4AA== X-Proofpoint-GUID: 6wZWY5cg3KEzm49t6rgKVSDw9-mOACyC X-Proofpoint-ORIG-GUID: 0cRnhi6ihZDgxMWAhWIxIe0abksfxKF6 Subject: RE: [PATCH v2] Add support for recording minimal symbols in AIX for non DWARF compiled library function record. X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_01,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 spamscore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230030 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --_000_LV8PR15MB6488DB91D898B67249F68BD1D64BALV8PR15MB6488namp_ Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Hi Tom, Thank you for your feedback. I have sent a v3 of this patch with the sugges= tions. >> + bfd *abfd =3D objfile->obfd.get (); >> + long do_we_need_storage =3D bfd_get_symtab_upper_bound (abfd); >> + >> + if (do_we_need_storage <=3D 0) >> + return; >> + >> + gdb::unique_xmalloc_ptr sym_table >> + ((asymbol **) xmalloc (do_we_need_storage)); >> + /* Get the number of symbols we need. */ >> + int number_of_symbols =3D bfd_canonicalize_symtab (abfd, sym_table.ge= t()); >> + >> + /* Return on error. */ >> + if (number_of_symbols < 0) >> + return; >This code should be replaced with a call to >gdb_bfd_canonicalize_symtab. >That was added to avoid some pathological behavior, see the >?>comment in >gdb_bfd.h and/or the associated bug. >Since you don't want an error here you should pass 'false=92 for >should_throw. >I forgot about the existence of this earlier and only remembered it >when >I was looking at something else=85 Yeah, it is a nice idea and glad you suggested it. Thanks once again. Have a nice day ahead. Regards, Aditya. --_000_LV8PR15MB6488DB91D898B67249F68BD1D64BALV8PR15MB6488namp_ Content-Type: text/html; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable
Hi Tom,

Thank you for your feedback. I have sent a v3 of this patch with the sugges= tions.

>> +  bfd *abfd =3D objfile->obfd.get ();
>> +  long do_we_need_storage =3D bfd_get_symtab_upper_bound (ab= fd);
>> +
>> +  if (do_we_need_storage <=3D 0)
>> +    return;
>> +
>> +  gdb::unique_xmalloc_ptr<asymbol *> sym_table
>> +    ((asymbol **) xmalloc (do_we_need_storage)); >> +  /* Get the number of symbols we need.  */
>> +  int number_of_symbols =3D bfd_canonicalize_symtab (abfd, s= ym_table.get());
>> +
>> +  /* Return on error.  */
>> +  if (number_of_symbols < 0)
>> +      return;

>This code should be replaced with a call to >gdb_bfd_canonicalize_sy= mtab.
>That was added to avoid some pathological behavior, see the >?>co= mment in
>gdb_bfd.h and/or the associated bug.

>Since you don't want an error here you should pass 'false=92 for
>should_throw.

>I forgot about the existence of this earlier and only remembered it >= ;when
>I was looking at something else=85

Yeah, it is a nice idea and glad you suggested it. 

Thanks once again.

Have a nice day ahead.

Regards, 
Aditya.
--_000_LV8PR15MB6488DB91D898B67249F68BD1D64BALV8PR15MB6488namp_--