From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YYwfNW5/qmp1MRIAWB0awg (envelope-from ) for ; Wed, 16 Sep 2026 07:37:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=p5MHI6US; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D333B1E01F; Wed, 16 Sep 2026 07:37:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 314D11E01F for ; Wed, 16 Sep 2026 07:37:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 98B364BA7980 for ; Wed, 16 Sep 2026 11:37:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 98B364BA7980 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=p5MHI6US Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 581A04BA23FF for ; Wed, 16 Sep 2026 11:36:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 581A04BA23FF Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 581A04BA23FF Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=148.163.156.1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1789558608; cv=pass; b=uiPQ89qnK/GhEA8/VngB+2IfANZA14vqH8IxkqDHLCfYtsu27nfSE3bycfJB3JuisjRefzdtbo3bJ5n2i4ShiFPYlSJGYr7JLCUxxV8QUFGzQBV/q3bzBKHHuNwas80Y+TMq18Pc/AKov+/p8QR0FeE1C+tQOHm/w642Qq04BsM= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1789558608; c=relaxed/simple; bh=pMWhveY03jL4KYwyHhMw6BF+Oo/hCCWZwMcc/sctHaU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VIAi4U7qOlMdEvEK3VYJ4r46/fcgMYWbKURHMMMTU6DS3ywFutOUTC3NSv1ESAV6aAdQ6gnmG0Rt4oqRsWXzHmdgr0u9Ho2Lv+Npl6WbqZ7UthTCRyCEDsVDftn+X5wug4dQPxWx5eT1gHkvZetPee7bfQRCePDAfJ69/3WeO1U= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=p5MHI6US DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 581A04BA23FF Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68FLVgS0079125; Wed, 16 Sep 2026 11:36:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=jNSPiVWcoPfNIeJFnVi1QExozFJtyv ToRU87XqOemo8=; b=p5MHI6USSBHP7pYaUZkYyVIaEdhvgZ5ocGS9fIrDzq97B6 ClVnZWGnHwQBRNza97TD48Q8V/H+WRboAROO9JTm+/uKoHiPthkm2qRUrH9kExPd ls1+ZR77eiQ6PJDx/FWwKvHipOPseaE7N0mmFSoLgmqe+7fdu1gDbBijwTXEap+r XM6XHGokq4yyhwSScRBuNAIKQy/nNXSc/BN6KVIFtfh715IpVbHQSOink1uGCQdR m6Oz/3vOuKIjhK089C0b+kQGMiv1LNDIsFyI+GYIbNy4OCOJr6vkd3rUpDTe2Kcz GLovkzu8nwyYO5+MzgQe1prUVbqHKueq3Eu3SP+Q== Received: from bn1pr04cu002.outbound.protection.outlook.com (mail-eastus2azon11010067.outbound.protection.outlook.com [52.101.56.67]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4gmxdqc6r5-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 16 Sep 2026 11:36:45 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ua4M4d9YqZawXoRPh7NjGjlEl/xoQnPdsLMJr+9cKhriJTU6PxTWi6soWgkiK+bsu6WoOjHBlx9h2XRMwzzUE2cIG71v6iYsfXM8o5ZJVEPo82+0MI47NTUC1y8bb1CXV5yO0RmYGtcvO3ZBVgCpk2Rfa7ZGRMqyddA4IOudOyspJJb9ABYWA+IhRIJQxYYbkb6IXQFOcMzxREbqWLB52xOTiFScSddtNFgt5FrMCRxXjJczHGXlRgD33ZSVdObEMR0kXX5A1rZmWR+kjyO1Q+eXvFA5M7LE/oye+tyWa2cr5k1FDfVFirtJPswW04gr1Cg1eePcw4XZWO0b64ghmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jNSPiVWcoPfNIeJFnVi1QExozFJtyvToRU87XqOemo8=; b=MsPs6BzdbBJQT39NXtyv96fuQvU77vaBWApDECQAuit7oHbmg/If/nBT/BbKnxW82qxq2SPpzjnL26Gpn2xuXKTgjVBqjpsCaM4lQApMd5IzM0FrBeWSCmzRnCPE9NJz46W+2Aj3e1f5pRyOX51CDRkTCpe4BgCrS92MfT+dq++wwpQ41/ZSZoKope6GpYgwboJ5MlmULK0wxhkI/6F7VBhFP0Amk8SczX4gzZy0lMwGZp6jCpUf3qYbxx2H5MMBEC7XiN4ppxDi2PeYmWcYWdFAkMtQdzlvDDUm1P2arpvzbK+hRcZnuJ2KsszoH8JMPDqDZjZBlu6EUYpTJo4TjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ibm.com; dmarc=pass action=none header.from=ibm.com; dkim=pass header.d=ibm.com; arc=none Received: from SJ2PR15MB6466.namprd15.prod.outlook.com (2603:10b6:a03:56e::15) by DM3PPF70060AA38.namprd15.prod.outlook.com (2603:10b6:f:fc00::41e) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.406.12; Wed, 16 Sep 2026 11:36:42 +0000 Received: from SJ2PR15MB6466.namprd15.prod.outlook.com ([fe80::6fda:46c:feee:167c]) by SJ2PR15MB6466.namprd15.prod.outlook.com ([fe80::6fda:46c:feee:167c%6]) with mapi id 15.21.0406.007; Wed, 16 Sep 2026 11:36:41 +0000 From: Aditya Kamath To: Abhay Kandpal , Aditya Vidyadhar Kamath , Ulrich Weigand , "simon.marchi@polymtl.ca" , "tom@tromey.com" CC: "gdb-patches@sourceware.org" , SANGAMESH MALLAYYA Subject: Re: [PATCH v2] Speed up next/step while debugging multithreaded programs on AIX. Thread-Topic: [PATCH v2] Speed up next/step while debugging multithreaded programs on AIX. Thread-Index: AQHdQUpfuvCHlKCo10iJ3boz1VunirbPs4Xd Date: Wed, 16 Sep 2026 11:36:41 +0000 Message-ID: References: <20260910101643.85955-2-akamath996@gmail.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-IN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-reactions: allow x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ2PR15MB6466:EE_|DM3PPF70060AA38:EE_ x-ms-office365-filtering-correlation-id: 073a835a-1483-462f-934b-08df13e6c76b x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|1800799024|23010399003|366016|10067099003|56012099006|4143699003|11063799006|22082099003|18002099003|8096899003|38070700021; x-microsoft-antispam-message-info: RVmKA4dBJQx4gYAmrLQCfExDwHkNy/7suR5Ks8ulU76uDnZPy2AsDa0LXxjeBeVmfQFCYLEOhYACUAQ64HAXDqD34gVuK/173W4knKZsonjXncxq3/w44aLgnQQq1w46XeUBTZbyDZV9x+8ouQGBKwGup7adQBm9TtNRlhY/J343Rr4NpH+nFioN6pKwVlsIvSopqG1CsyiigifAaHU5GaQ8/Tu/hjMzL2KHudl9vCjZRTEwGiaZnGYm/Mg1XhUrc+semBnLsJDtjwxT4W5G9QVTVSp1CGbuQUGCZkJu2Cq0BiFvZhgJ6isclXofACq2uQ4MfHYLyWSV0WC4rmFpNyYm7r4eL90kssoSbCtcSX0JtxzggdwwbEQVrDGGPn5gPa5OmgYZzFY1p0x+V3pqPrvmp+XyO+22QRE58itj3Ctmqa3WW2z8FhYph9Zsrn6fwtF/a5IZsaKsWMr91q8rqSrkxtMao17b1wAANo1gtWEjehVZIbRFlWh2OLIleuqFqA0MRD71wUsmHwHQIad+27RgTd2CndjxhTGmHuceRk6kodnqXYKPxXbTgOxqKO2RoiPLEjUBOIrVPrXuLeBWY4CCSOxfuiY7Jge9t7cX70reVobHgIMIkUmAWGqyXzxg4wX/CYmhjXgKjhCnjUVwwo32rx3+ilosLWSKqXFn7bNCkxNn1y+VG3Z2tXWCtQrncFfO97nuTxq91V+5IZl3ty0Sm9yXuMm3p9PEMOq1N08= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR15MB6466.namprd15.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(23010399003)(366016)(10067099003)(56012099006)(4143699003)(11063799006)(22082099003)(18002099003)(8096899003)(38070700021); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PZwKtwA1xMdGQRcqEv4wdAaqcA5Okub5IcofVxZd8Y0y84L4juhou1wbnvm/?= =?us-ascii?Q?BCnDr51uGRfykNtEDbQmG+Mni3GTJFoWHgPqqHvrKnSKXM2/hjouAUEZtKXa?= =?us-ascii?Q?zEWXyQ3OgVcPhyhDNo9uuwxY5VjczZePXR3gc+ILhky+gnE1DpT04R994z80?= =?us-ascii?Q?SM+iUTxj1MCzMS/lT14tQrL8DnhWyePlg+iwA694cA0WKYl71jmhCsrPtrzt?= =?us-ascii?Q?7G4NC7A5co9QzGfy10GpOUltXEOvR927/KS49/RE5NpIJkXUHdryNBM7/+Cd?= =?us-ascii?Q?K9LRZXTIi91Kw1snP87m4dkteTN0WneTRl+DSY/0FO9l1B01AuAAUZD7cz2V?= =?us-ascii?Q?KAn7hbUfA5m3+rhbBtbvj+661srBuajG2IfqbzFJKBI4vcND3MYkzt6lK9o1?= =?us-ascii?Q?+6ftAwGiCnbL6yxz1bArdfWgJalG63hGMJdH4RQ9bauSjDKyKfhZ6+TmHW8J?= =?us-ascii?Q?Tq9ZhoTMHYP7iccIuUeDSuUsupM32ObU0BXXBeu5cosFCHSbPdhTJ2R6M/FZ?= =?us-ascii?Q?SYoDSJALWys7pYO0dCiaggGhvTcLhsbhgBfvlwz33cZoInMB9wuyAJfmdkR8?= =?us-ascii?Q?rGX9Dryf0c2YZht9dtDgkSTDt6MSKKYLPfoVwIBfJGH3OMUsNDYU/PIkU65M?= =?us-ascii?Q?128395h7aJoNyblN5rYUSz8Nti3eYXq/7qDZBihu8PbvrDknTZIzT0C+ytj6?= =?us-ascii?Q?hfNucYVeILL6PMvYUWmvLvtNP+lwskQZXqvkK+1ozGpsGm8CqOVyUZXJJiff?= =?us-ascii?Q?E159jkcKAgroqyi94a1fpt7zZEBIus1w5eNHPI1KcU1oCSd4NIabdROqjjO7?= =?us-ascii?Q?9TAcXbPce8bZuX30p5LJZVZ702wYIoaK5uF/RNx+BkN+6FquDQeZIlsPw0wZ?= =?us-ascii?Q?mjIxSmS/i+rSn4XD9UKtUF6Q6z/TIdt/XwjpIlj8OAj4N9sA0L1+YTcHRlJ9?= =?us-ascii?Q?m059Old4K3JHbff/I7PKoP2KO/QZJHkwEolHbam/IdjGCMF9kuPJnE1JQ6lo?= =?us-ascii?Q?IbLwiuSMh0edI2UjLwsQQZd8TNAp/dwClV0LKCqiUcn6WbTjzR9LfN/LtMpi?= =?us-ascii?Q?jRYSElRAWpRVvSTrDmeVm1Of3aVGUF9uO0I4hXuxJ8iiSYYH1Eo92F+UoSPE?= =?us-ascii?Q?Tp50Et6j3SII/5SLzJd/61Y2GUbuTxplRdlOlB4Ozbl2gZ5F6qz9q2CnoNhp?= =?us-ascii?Q?t7vaqZ1zU4uYvAadmD2EWOxPtYCYciAXWQUbrBgEw8IbISRN8NYTUA22jJ+x?= =?us-ascii?Q?R01pV+doBc5Yd++KM6bSB9GuN0f1AkyvtsFbZtEb1ADp6QSZiNvLlRd4xEdl?= =?us-ascii?Q?CEqz6qpGVbvg9g8+N+xanvfcu6zhcL+BC3rtamrkpZ1dAjl8Dzdh2CFlxEE5?= =?us-ascii?Q?o675TFoUECi35CSU2GjdNYNamCPxJxrbniVCOEmOny/cmB/WiWzOTa2yH86V?= =?us-ascii?Q?nAG3m+lDULL/5WLHAkKcAg1Phm7x4DWO8bVahtnRdwpZYOg7c1ANRH4x93cv?= =?us-ascii?Q?KAaslc7DcewUXXCmLfx9jzYcxF27mZdFnGgCCilsyy31Tdj0XrUfMWh2ip1y?= =?us-ascii?Q?XwJ1zn5uypOfIEcvuhSNHWtpKG+oUajh3cqgG6f9WBKpXtA6QRYpjnddruf6?= =?us-ascii?Q?uBuklvGlZIXuOIJFqiw9oPmo6OjcS7dv6mZAxzlYKNlal01PngnFzIBCTFz3?= =?us-ascii?Q?M7iws4Ymt0olMgoc8bjfjI1nfp25A2j47/4D9R7P+x98GgXAZ508cO+vnz6p?= =?us-ascii?Q?4BJBCb/dosQq6HQuuQO4PnbFctkanFE=3D?= Content-Type: multipart/alternative; boundary="_000_LV8PR15MB6488B6528394B15CB08B1BF4D6BA2LV8PR15MB6488namp_" MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: g2nTVqMv6IunBP8OQiYmFTYWxw374uVWB3OuzLWFXFaX1sAu/wzV/osexXOMD8x6ED+GuHa+jFEtgV4kT8BJXJl0az1RAaanXi/f5MA8M0/3WQ/tuIg530JvuhJk22+f2TaEwqdEye6Zw7w/7IpFEKlzL0LCacwiMjJpWUNK/2EONAPaKeuhzQXFakUMqTqFyx3VwwHipq+mxE1cbGEXT0/mwb3gH207rQlzxx+ffGW+RjUJhKlb4fb48a7JqS5YS81foe4n4odv1YP63WYe7Ld4j4mkqDiBTAweV3tm7HpWXcRKjV3kPcn39/5qHHYSf7ovRvX92/1aycoKrX7Tcg== X-OriginatorOrg: ibm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ2PR15MB6466.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 073a835a-1483-462f-934b-08df13e6c76b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2026 11:36:41.8445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fcf67057-50c9-4ad4-98f3-ffca64add9e9 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tvbKKau/FmK1kqrQXQmZk7KUw31AyFWORf+aPWwr+90NtUC1KUkrxa6c2/aSSA1Z7qWniTNHSXEAYeQC7eupGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PPF70060AA38 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTE2MDE1MyBTYWx0ZWRfXw6ueXc7tTJbz Yj928l/cgy4zdbqcNC+tbU+F+b5VD4mDuveB4OQo2I+weDLs3XBaX1DpuBZB8gSxpPBkJEPEd5g 1pA7tvHMRcjTLXvNN064xAKMkm85wiQiopB8HXHkx9aIXqAYlTg6mQSGllvGm4ddnmloFVHctLS YXFeWiPHUcbb3gKF6m5mOB0NOsAmZ12KltLjKY+XbfpjbWH1zDN+fMl7Y9PJYG3kXcJTXXK/v1Z Lkh2vCbRKhbRcqlrDWgtEqrNrO9aUohcxnrNpw/cfVHI3YfKXdLSJ1p57a6EkthZnBqrnx0wmUu zd2k6sA3VzH9/IdqPmJZNtrhqOvf11KbcjF5ExEwJTEEGEXeRVfTxr4z6qpqg+1PTK+pc3nYS4n xwvNzxQ2nqyjrvZCgRlwduhMN3kffwjj/qXs2UqmIlrix2252N8bRdaac3UrYngugl5ez2EKGSo tVO80nmBxCgXlUXAGtw== X-Proofpoint-GUID: kCAlRf5Ay_WYExzokhcd4q_7pEeRvA0E X-Authority-Analysis: v=2.4 cv=DobDa2/+ c=1 sm=1 tr=0 ts=6aaa7f4d cx=c_pps a=rvqTtZJOg9Ha/t6LIbsz2g==:117 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=VdqzKS8jKosA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=Plu9PlKzrm7RCuOtPgAA:9 a=CjuIK1q_8ugA:10 a=gXZfQB4y3DYvjPVb:21 a=_W_S_7VecoQA:10 X-Proofpoint-ORIG-GUID: CKLQZX4V17_-jvkDcd5y3hqHF-c4My6V X-Proofpoint-Spam-Info: AW1haW4tMjYwOTE2MDE1MyBTYWx0ZWRfXxDYHujGffHOl Z0XD72+ljbQi3msBTGRk5Cqrb3J2y5HkkuT5ciBV3JT2Cbaf0zLV8rXJGy64eHe1pqD9cC97ySL ze0PU23hOtFo9U2v4KPGIuWYrmkcBiQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-15_05,2026-09-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 clxscore=1015 adultscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609160153 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org --_000_LV8PR15MB6488B6528394B15CB08B1BF4D6BA2LV8PR15MB6488namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Abhay and community members, Thank you for the feedback so far. Please see my comments. >inferior_thread () returns the currently selected thread, >which is not >necessarily the thread named by the ptid argument. Since >thread_has_single_step_breakpoints_set () is a per-thread >query, asking >it about the wrong thread would give the wrong answer for >last_resume_step. >The else branch a few lines below already resolves the >thread from the >argument: > thread =3D current_inferior ()->find_thread (ptid); >Would that be more appropriate here? I am also unsure what >the flag >should be when ptid.tid () =3D=3D 0 and the resume covers more >than one >thread. > >Separately, would it be worth adding testsuite coverage for >this? The >benchmark program creates all 20 threads before do_steps (), >so the >thread population never changes after the first stop and it >cannot >exercise the case the v1 logic got wrong. >Something that creates threads between two breakpoint stops >and checks >"info threads" at the second one would cover it, and a >"next" over a >call that spawns a thread would cover Simon's point. I >don't have an >AIX machine to run it on, so I can't offer a patch for it >myself. Have done the same in v3 version of this patch and also corrected the threa= d_has_single_step_breakpoints_set () to use ptid. Thanks for the suggestion= s. Let me know your thoughts and if I missed anything. Have a nice day. Thanks and regards, Aditya. --_000_LV8PR15MB6488B6528394B15CB08B1BF4D6BA2LV8PR15MB6488namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Hi Abhay and community members,

Thank you for the feedback so far. 

Please see my comments. 
>in=
ferior_thread () returns the currently selected thread, >which is not=0A=
>necessarily the thread named by the ptid argument.  Since=0A=
>thread_has_single_step_breakpoints_set () is a per-thread >query, as=
king=0A=
>it about the wrong thread would give the wrong answer for=0A=
>last_resume_step.=0A=
>The else branch a few lines below already resolves the >thread from =
the=0A=
>argument:=0A=
>  thread =3D current_inferior ()->find_thread (ptid);=0A=
>Would that be more appropriate here?  I am also unsure what >the fla=
g=0A=
>should be when ptid.tid () =3D=3D 0 and the resume covers more >than=
 one=0A=
>thread.=0A=
=0A=
>
&=
gt;Separately, would it be worth adding testsuite coverage for >this?  T=
he=0A=
>benchmark program creates all 20 threads before do_steps (), >so the=
=0A=
>thread population never changes after the first stop and it >cannot=
=0A=
>exercise the case the v1 logic got wrong.=0A=
=0A=
>Something that creates threads between two breakpoint stops >and che=
cks=0A=
>"info threads" at the second one would cover it, and a >&q=
uot;next" over a=0A=
>call that spawns a thread would cover Simon's point.  I >don't have =
an=0A=
>AIX machine to run it on, so I can't offer a patch for it >myself.=
=0A=


Have done the same in v3 version of this patch and als=
o corrected the thread_has_single_step_breakpoints_set () to use ptid. Thanks for the suggestions. Let me=
 know your thoughts and if I missed anything.

Have a nice day.

Thanks and re=
gards,
Aditya.
--_000_LV8PR15MB6488B6528394B15CB08B1BF4D6BA2LV8PR15MB6488namp_--