Thanks, Eli, for your feedback! I have addressed your comment accordingly. V4: https://inbox.sourceware.org/gdb-patches/20260714092128.12941-1-mohamed.bouhaouel@intel.com/ --Mohamed ________________________________ From: Eli Zaretskii Sent: Monday, July 6, 2026 2:41 PM To: Bouhaouel, Mohamed Cc: gdb-patches@sourceware.org ; Rohr, Stephan ; Metzger, Markus T ; pedro@palves.net ; aburgess@redhat.com Subject: Re: [PATCH v3 11/11] gdb, gdbserver: add AlwaysNonStop remote protocol extension > From: Mohamed Bouhaouel > Cc: stephan.rohr@intel.com, markus.t.metzger@intel.com, pedro@palves.net, > aburgess@redhat.com > Date: Mon, 6 Jul 2026 14:11:24 +0200 > > From: "Bouhaouel, Mohamed" > > Add a new RSP extension allowing remote stub to declare that a target > must always operate in non-stop mode. > > When a stub advertises "AlwaysNonStop+" in its qSupported response: > > * The stub automatically initializes to non-stop mode > * GDB will operate the stub in non-stop mode (with default settings) > * The stub will reject QNonStop:0 requests > * GDB errors if 'maint set target-non-stop off' is explicitly set > --- > gdb/NEWS | 8 ++++++++ > gdb/doc/gdb.texinfo | 30 +++++++++++++++++++++++++++++- > gdb/remote.c | 27 +++++++++++++++++++++++++++ > gdbserver/server.cc | 30 +++++++++++++++++++++++++++++- > gdbserver/target.cc | 6 ++++++ > gdbserver/target.h | 6 ++++++ > 6 files changed, 105 insertions(+), 2 deletions(-) Thanks. The documentation parts are okay, with the following comment: > +@item @samp{E @var{nn}} > +The request failed. This may occur if the stub requires non-stop mode > +and advertised @samp{AlwaysNonStop+} support, and GDB attempted to ^^^ Should be @value{GDBN} Reviewed-By: Eli Zaretskii Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 89 991 430, www.intel.de Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell Chairperson of the Supervisory Board: Nicole Lau Registered Seat: Munich Commercial Register: Amtsgericht Muenchen HRB 186928