From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 02S/D2yUx2aY0BAAWB0awg (envelope-from ) for ; Thu, 22 Aug 2024 15:41:32 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=protonmail.com header.i=@protonmail.com header.a=rsa-sha256 header.s=protonmail3 header.b=R9S0XbkR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 26F5C1E0D0; Thu, 22 Aug 2024 15:41:32 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7D72C1E08C for ; Thu, 22 Aug 2024 15:41:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A08223860C33 for ; Thu, 22 Aug 2024 19:41:28 +0000 (GMT) Received: from mail-43166.protonmail.ch (mail-43166.protonmail.ch [185.70.43.166]) by sourceware.org (Postfix) with ESMTPS id C529A3860756 for ; Thu, 22 Aug 2024 19:41:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C529A3860756 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=protonmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C529A3860756 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.70.43.166 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724355669; cv=none; b=tW0QdK4gyyLJQtpN+vd9KpOYYfSgazQEQvm6wuGTH2phRZjRlabPboCv58LYllD3VmZTXaECdeu2B7o5r0CCvMKONCxBayfZv2EXyxmAIa/HuG7fLHS/QeJuY64nZRt/QFFsYqun4ljzK9MK6QvLQz6oV5uM/wft82x5dpjJsc4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724355669; c=relaxed/simple; bh=JqBSPBjWHiPj340ysPjkOoZbJEv9Dvj63ahHDmmtdDk=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=Mxua4FakAU8DkTx9MPVAPV+5IZ4lvvjVVQCxo5Nwf/qyJ7XRo23BvreiSmZg/CQdh86HiRI9bn627WtRw9iTEC0JyvDbvZWmr4WS63GJxt7JGD8lKsIGMRHvneXRRLVCNHPwlLoJ4MgMLj6MBKL7sa4gYbgxk5nuiaj/oqlLxDs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1724355665; x=1724614865; bh=JqBSPBjWHiPj340ysPjkOoZbJEv9Dvj63ahHDmmtdDk=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=R9S0XbkRsbCASbRxYwMAgtDUaCsw3jbrSnGZs4QRjWlLzHhSgxburPZF2Ncjjvoaz TwjmGxg9iBIhdJT4IFin4Ew0iVecfS6v7J9z/HJ9Go7o7j4vizOF0E6KMEsFG5xpbY Co0FC8GZ4VnGFAeW3mLTfktFcJKELlzsRcZJkXZatmXSbxUzom8K4Goy0wlJ81Z1fL NZrqlEgvoTSKZAC/u2ob2Yky3ehOJUEsBPvrpd4DDTYzgfIJOIytsbQ6QbquYyqmcQ 7U5FAhdEWaqjF2Me/lVmVFRkh2f/Ck5zpW+qu9d8qtQv2aPVc1yxePvTRtM7IBYZ7E mJFL/IX+xMsHA== Date: Thu, 22 Aug 2024 19:41:01 +0000 To: gdb-patches@sourceware.org From: nt8r@protonmail.com Subject: Re: [PATCH 2/2] gdb: Tab complete internalvars in expressions Message-ID: In-Reply-To: <20240822154730.1595141-3-nt8r@protonmail.com> References: <20240822154730.1595141-1-nt8r@protonmail.com> <20240822154730.1595141-3-nt8r@protonmail.com> Feedback-ID: 21706885:user:proton X-Pm-Message-ID: fb47d259f08eeff787ff1029cce73bfdf19401aa MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org It seems I misunderstood the semantics of the 'word' and 'text' parameters = here. I'll correct in v2; as written this doesn't work for completions not = at the start of the text to complete (e.g. 'print 4+$fo' or 'print $fo= +4'). On Thursday, August 22nd, 2024 at 3:47 PM, Antonio Rische wrote: > For example, 'print $f' after running 'set $foo=3D0' now tab >=20 > completes. >=20 > 'print $_siginf' also now tab completes. >=20 > --- > gdb/completer.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/gdb/completer.c b/gdb/completer.c > index 1008ec23b..6476ddf79 100644 > --- a/gdb/completer.c > +++ b/gdb/completer.c > @@ -1099,6 +1099,16 @@ complete_expression (completion_tracker &tracker, > && expr_completer->complete (exp.get (), tracker)) >=20 > return; >=20 > + if (text[0] =3D=3D '$') > + { > + tracker.advance_custom_word_point_by (1); > + /* We don't support completion of history indices. */ > + if (!isdigit (text[1])) > + complete_internalvar (tracker, &text[1]); > + tracker.advance_custom_word_point_by (-1); > + return; > + } > + > complete_files_symbols (tracker, text, word); > } >=20 > -- > 2.46.0