From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80057 invoked by alias); 10 Aug 2017 09:25:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68806 invoked by uid 89); 10 Aug 2017 09:24:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=can X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50045.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Aug 2017 09:24:28 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0104.eurprd08.prod.outlook.com (10.160.211.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1320.16; Thu, 10 Aug 2017 09:24:07 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::b8e2:8809:e2b2:ae37]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::b8e2:8809:e2b2:ae37%14]) with mapi id 15.01.1320.019; Thu, 10 Aug 2017 09:24:07 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Replace regbuf with regcache in record-full.c Date: Thu, 10 Aug 2017 09:25:00 -0000 Message-ID: References: <86fuesjtss.fsf@gmail.com> <84525A76-483C-4200-B7B6-C1F6AD5CC12F@arm.com> <86efubi24c.fsf@gmail.com> In-Reply-To: <86efubi24c.fsf@gmail.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0104;6:4mmcnV6Xq9iyFK60RjYv0266MSdmgoHy2OiqAvEI8F0J3MO9Lu9GYH6x/v8vuRejPgLkpqxTSdrKyTg0+Rce7q3JNgHP3voAEDBv2tId0g88s/8Fa6WzxiqpuKxyLk9VEtszW+GdZFhjZHhw3xRONNv4l3b7mJ+1kayeizEralAPm4pq1eqTD4Uj6KovALsHFqt+7vrGOK0vI0ymSJw6bNHzXSaSWz1/6nxtJUf4muB3sxFWqNXvJBMmanQbAwWh6nT4vWjJ/qRnZu138jhJe0+vAz8HSgCmn30RXixmLSRKzm6MSQzlisrEGatqeJY6uC11KC0VxA6AFBmm86pMxg==;5:UmROsHK89UvNaRXB1bHaMkFifQ6ydymJ8+/AGWKAhyS+xk1Vh4sbkN2g1gyg72QHYo9oRIAlB2vG48cI/a2BogKasgxCyMHxkK38m2M09OrHrTOsoCZpGEhgdBXeWvkWtKjUFxL0SduaCmNhE9bI+A==;24:ytJDiA620wsKlBQjz/NYU3m7p7TKRizxeJQNT75Qe9qSZkpAaM1eN95oPzj/OK0znL2tAJc1EkhsVN2MhubjD67B/t26t8pb+4NJxgvCHJM=;7:VdM1JF+h16fuyhxqA//FiDDWNDeBksgvjtlYxls7IJqsBx+4LcCMSFgcImlUL1TQ/cNa7zyj7rrfvNLDk3JaAd0p9Il3jKf/wZ7geHcLkxp3P3eNd9TZsIauh2mVhr11dvrzq7TcT9VubklresOPX49E5FsQ0L63t77Fh5sU0ju7GgKeICJXUbKt6/GOUsFjHEyG5aEHbC5WQsjG+6Ae6zxQD+0hwTjnwgyIxTVIu04= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: e06033b5-dea1-466c-ff26-08d4dfd18ce4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:AM3PR08MB0104; x-ms-traffictypediagnostic: AM3PR08MB0104: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(788757137089); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR08MB0104;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR08MB0104; x-forefront-prvs: 03950F25EC x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39860400002)(39850400002)(39450400003)(39400400002)(39410400002)(199003)(189002)(8676002)(81156014)(189998001)(39060400002)(8936002)(110136004)(38730400002)(93886004)(4326008)(102836003)(3846002)(6116002)(6246003)(83716003)(1411001)(6512007)(97736004)(81166006)(66066001)(105586002)(5660300001)(106356001)(53936002)(36756003)(6486002)(99286003)(2900100001)(72206003)(478600001)(76176999)(6436002)(54356999)(50986999)(54906002)(305945005)(7736002)(3660700001)(68736007)(33656002)(229853002)(82746002)(2906002)(6506006)(25786009)(2950100002)(3280700002)(6916009)(101416001)(86362001)(14454004)(5890100001)(5250100002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0104;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <1D3A359FCCED8F479968D6015D042553@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2017 09:24:06.9652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0104 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00209.txt.bz2 DQo+PiANCj4+PiANCj4+PiBBcyBJIHVuZGVyc3RhbmQgaXQsIHRoZSBjb29r ZWQgcmVnaXN0ZXJzIGV4aXN0IGJlY2F1c2Ugb24gc29tZSBhcmNoaXRlY3R1 cmVzDQo+Pj4gZXh0cmEgc3RhdGUgbmVlZHMgc2F2aW5nIGluIHRoZSBjb29r ZWQgcmVnaXN0ZXJzIChjb2RlIGNvbW1lbnQ6ICJzb21lDQo+Pj4gYXJjaGl0 ZWN0dXJlcw0KPj4+IG5lZWQgdG8gc2F2ZS9yZXN0b3JlIGBjb29rZWQgcmVn aXN0ZXJzIHRoYXQgbGl2ZSBpbiBtZW1vcnku4oCdKS4NCj4+PiANCj4+PiBU aGVyZWZvcmUgdGhlIGNvb2tlZCByZWdpc3RlciBzdGF0ZSBuZWVkcyB0byBi ZSBhIHByb3BlcnR5IG9mIGRldGFjaGVkDQo+Pj4gYW5kIG5vdCBvZg0KPj4+ IHJlYWRvbmx5Lg0KPj4+IA0KPj4gDQo+PiBtX3JlZ2lzdGVycyBhbmQgbV9y ZWdpc3Rlcl9zdGF0dXMgYXJlIGZpZWxkcyBvZiBkZXRhY2hlZCByZWdjYWNo ZSwgd2UNCj4+IGNhbiBkZWZpbml0ZWx5IHNhdmUgY29va2VkIHJlZ2lzdGVy IHN0YXRlIGluIGRldGFjaGVkIHJlZ2NhY2hlLg0KPj4gDQo+Pj4gDQo+Pj4g QSBkaWZmZXJlbnQgaXNzdWUgaXMgdGhhdCB3ZSB0cmVhdCBzYXZlL3Jlc3Rv cmUgZGlmZmVyZW50bHkuDQo+Pj4gSW4geW91ciBjb2RlIG9uZSBvZiB0aGUg cmVjYWNoZXMgaGFzIHRvIGJlIGJvdGggcmVhZC1vbmx5IChjaGVja2luZw0K Pj4+IHZpYSBnZGJfYXNzZXJ0KSBhbmQgZGV0YWNoZWQuDQo+Pj4gSW4gbXkg Y29kZSB0aGUgY2hlY2sgaXMgdGhhdCB0aGUgcmVnY2FjaGUgaXMgZGV0YWNo ZWQgb3INCj4+PiBub3QuIFJlYWQtb25seSBpcyBub3QgcmVsZXZhbnQuDQo+ PiANCj4+IEl0IGlzIHJlYWQtb25seSBpbiBteSBjb2RlLCBidXQgaXQgZG9l c24ndCBoYXZlIHRvIGJlLiAgSSBkb24ndCBzZWUgYW55DQo+PiBzaG93LXN0 b3BwZXJzIGluIHRoZSBkZXNpZ24gb2Ygc3BsaXR0aW5nIHJlZ2NhY2hlLiAg VGhlIGF0dHJpYnV0ZXMNCj4+ICJkZXRhY2hlZCIgYW5kICJyZWFkLW9ubHki IGFyZSBvcnRob2dvbmFsIGluIGRlc2lnbi4gIERvIHlvdSBoYXZlIHNvbWUN Cj4+IGNvbW1lbnRzIG9uIHRoZSBvdmVyYWxsIGRlc2lnbiByYXRoZXIgdGhh biB0aGUgY29kZSBkZXRhaWxzPyAgSSdsbA0KPj4gcmV3cml0ZSBteSBwYXRj aGVzLCBhbmQgcG9zdCB0aGVtLiAgSXQgaXMgdW5mb3J0dW5hdGUgdGhhdCBp dCBpcyBoYXJkIHRvDQo+PiByZXZpZXcgdGhlIG92ZXJhbGwgZGVzaWduIHdp dGhvdXQgdGhlIGNvZGUuDQo+IA0KDQoNCknigJl2ZSB0YWtlbiBhIGxvb2sg YXQgaW1wbGVtZW50aW5nIHRoZSBzcGxpdCByZWdjYWNoZSBhbmQgaGF2ZSBy dW4gaW50byBhbg0KaW50ZXJlc3RpbmcgaXNzdWUuDQoNCmZyYW1lLmMsIGlu ZmNtZC5jLCBpbmZydW4uYywgaml0LmMsIGxpbnV4LWZvcmsuYywgbWkvbWkt bWFpbi5jDQpUaGVzZSBmaWxlcyBhbGwgZHVwbGljYXRlIHRoZSByZWdpc3Rl ciBjYWNoZS4NCkluIHRoZSBuZXcgcGF0Y2gsIHRoaXMgd2lsbCBhIGNyZWF0 ZSBkZXRhY2hlZF9yZWdjYWNoZS4NCg0KVGhlc2UgZmlsZXMgdGhlbiBhY2Nl c3MgdGhpcyBjb3BpZWQgKGRldGFjaGVkKSByZWdjYWNoZSB1c2luZzoNCnJl Z2NhY2hlX2Nvb2tlZF9yZWFkDQpnZGJhcmNoX3BzZXVkb19yZWdpc3Rlcl9y ZWFkX3ZhbHVlDQpnZGJhcmNoX3JldHVybl92YWx1ZQ0KcmVnY2FjaGVfcmVh ZF9wYw0KDQpJdOKAmXMgZWFzeSBlbm91Z2ggdG8gcmVwbGFjZSB0aGUgY29v a2VkX3JlYWQgd2l0aCBhIHJhd19jb2xsZWN0Lg0KDQpIb3dldmVyLCB0aGUg b3RoZXIgdGhyZWUgYXJlIGEgbG90IHRyaWNraWVyLg0KVGhleSBhbGwgY2Fs bCBvdXQgdG8gdGFyZ2V0IGZ1bmN0aW9ucywgKOKApi53aGljaCBjYWxsIG91 dCB0byBvdGhlciBmdW5jdGlvbnPigKYpDQp3aGljaCBhbGwgbWFrZSBtdWx0 aXBsZSBjYWxscyB0byBjb29rZWRfcmVhZCBhbmQgcmF3X3JlYWQuDQoNClRo ZSB0YXJnZXQgZnVuY3Rpb25zIGNhbuKAmXQgYmUgdXBkYXRlZCB0byB1c2Ug cmF3X2NvbGxlY3QsIGJlY2F1c2UgaW4gb3RoZXIgY2FzZQ0KdGhleSB3aWxs IGJlIHVzZWQgd2l0aCB0aGUgYXR0YWNoZWQgcmVnY2FjaGUsIHdoaWNoIHdp bGwgYmUgZXhwZWN0aW5nIHJlYWRzIHRvIGJlDQpwdWxsZWQgZnJvbSB0aGUg dGFyZ2V0Lg0KDQpDcmVhdGluZyBkdXBsaWNhdGUgZnVuY3Rpb25zIChlLmcu IGdkYmFyY2hfZGV0YWNoZWRfcmV0dXJuX3ZhbHVlKSB3b3VsZCBiZSBzaWxs eS4NCg0KVGhlIG9ubHkgc29sdXRpb24gSSBjYW4gc2VlIGlzIHRvIGNyZWF0 ZSB2aXJ0dWFsIGNvb2tlZF9yZWFkIGFuZCByYXdfcmVhZCBpbg0KZGV0YWNo ZWRfcmVnY2FjaGUuIFRoZXNlIGZ1bmN0aW9ucyAganVzdCByZWFkIGZyb20g dGhlIGNhY2hlIGluc3RlYWQgb2YNCnVwZGF0aW5nIGZyb20gdGhlIHRhcmdl dC4NCkluIHRoaXMgbmV3IHdvcmxkLCBjYWxsaW5nIGNvb2tlZF9yZWFkIG9y IHJhd19yZWFkIG9uIGVpdGhlciBhIGRldGFjaGVkX3JlZ2FjaGUNCm9yIGF0 dGFjaGVkIHJlZ2NhY2hlIHdvdWxkIGRvIHRoZSBjb3JyZWN0IHRoaW5nLg0K DQooVGhlIGZ1bmN0aW9uIHByb3RvdHlwZXMgaW4gYWxsIHRoZSB0YXJnZXQg ZmlsZXMgc3RpbGwgbmVlZCB1cGRhdGluZywgYnV0IHRoYXQgaXMgYSBmYWly bHkNCnNpbXBsZSBjb3B5L3Bhc3RlLikNCg0KRG9lcyB0aGlzIGFwcHJvYWNo IHNlZW0gc2Vuc2libGU/DQpJZiB0aGVyZSBhcmUgbm8gb2JqZWN0aW9ucywg SeKAmWxsIGNhcnJ5IG9uIHdvcmtpbmcgdGhlIHBhdGNoIHVzaW5nIHRoaXMg YXBwcm9hY2guDQoNCkkgY2FuIHBvc3QgYSB3b3JrIGluIHByb2dyZXNzIHBh dGNoIGlmIHJlcXVpcmVkIChidXQgdGhhdCBtaWdodCBiZSBiZXR0ZXIgdG8g d2FpdCB1bnRpbA0KSSBoYXZlIHNvbWV0aGluZyBmdWxseSB3b3JraW5nIGFu ZCBzcGxpdCBpbnRvIHNtYWxsZXIgY2hhbmdlcykuDQoNCkFsYW4uDQoNCg== >From gdb-patches-return-140895-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Aug 10 11:08:42 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 87794 invoked by alias); 10 Aug 2017 11:08:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 87467 invoked by uid 89); 10 Aug 2017 11:08:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Aug 2017 11:08:40 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1042C404323; Thu, 10 Aug 2017 11:08:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1042C404323 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1BBAB831A8; Thu, 10 Aug 2017 11:08:36 +0000 (UTC) Subject: Re: [AArch64][6/6] Core file support for "pauth" feature To: Jiong Wang , GDB , Binutils References: From: Pedro Alves Message-ID: Date: Thu, 10 Aug 2017 11:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00211.txt.bz2 Content-length: 1481 On 08/09/2017 01:23 PM, Jiong Wang wrote: > /* Implementation of `gdbarch_stap_is_single_operand', as defined in > diff --git a/gdb/aarch64-linux-tdep.h b/gdb/aarch64-linux-tdep.h > index d0f9b12..580a8b8 100644 > --- a/gdb/aarch64-linux-tdep.h > +++ b/gdb/aarch64-linux-tdep.h > @@ -29,6 +29,14 @@ > are 4 bytes wide each, and the whole structure is padded to 128 bit > alignment. */ > #define AARCH64_LINUX_SIZEOF_FPREGSET (33 * V_REGISTER_SIZE) > +#define AARCH64_LINUX_SIZEOF_PAUTH (2 * X_REGISTER_SIZE) > > extern const struct regset aarch64_linux_gregset; > extern const struct regset aarch64_linux_fpregset; > +extern const struct regset aarch64_linux_pauthregset; > + > +#ifndef HWCAP_APIA > +/* AArch64 GNU/Linux HWCAP values. These should be synced with kernel > + definitions. */ > +#define HWCAP_APIA (1 << 16) > +#endif Re. the #ifndef, consider that tdep.h files are included in cross debugger builds. E.g., an x86-hosted gdb cross debugging aarch64. Some archs have "namespaced" names like the s390 mips, sparc, etc. (e.g., HWCAP_S390_VX) which avoids the case of the names being defined on host/target with a different meanings/values, but not all do. But even with such names, we always have to provide fallback definitions for cross debuggers. And with that all in mind, and since you're defining fallbacks anyway, how about unconditionally defining/using our own conflict-resistant versions, like AARCH64_HWCAP_APIA? Thanks, Pedro Alves