From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130095 invoked by alias); 21 Jun 2018 19:52:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130081 invoked by uid 89); 21 Jun 2018 19:52:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0056.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.56) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 19:52:24 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2614.eurprd08.prod.outlook.com (10.172.252.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Thu, 21 Jun 2018 19:52:21 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::a152:f8f6:6608:7624]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::a152:f8f6:6608:7624%5]) with mapi id 15.20.0863.016; Thu, 21 Jun 2018 19:52:21 +0000 From: Alan Hayward To: Simon Marchi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 1/3] Use unsigned ints in regcache_map_entry Date: Thu, 21 Jun 2018 19:52:00 -0000 Message-ID: References: <20180621093802.79342-1-alan.hayward@arm.com> <20180621093802.79342-2-alan.hayward@arm.com> <4e636367-f19b-3aa8-6491-42d4ea5b024b@ericsson.com> <3c8db027-f24e-91cb-b7cc-25fb8cae0067@ericsson.com> <3e13b55d-5283-eb61-c018-880ff0e92ab1@ericsson.com> <068f1831-32ff-e5ab-e43d-32e1e634d98d@ericsson.com> In-Reply-To: <068f1831-32ff-e5ab-e43d-32e1e634d98d@ericsson.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1a671547-4952-4dfb-52d6-08d5d7b0806a x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: DB6PR0802MB2614: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(37575265505322); x-ms-exchange-senderadcheck: 1 x-forefront-prvs: 07106EF9B9 received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a671547-4952-4dfb-52d6-08d5d7b0806a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2018 19:52:20.9898 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2614 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00530.txt.bz2 DQoNCj4gT24gMjEgSnVuIDIwMTgsIGF0IDE4OjMyLCBTaW1vbiBNYXJjaGkg PHNpbW9uLm1hcmNoaUBlcmljc3Nvbi5jb20+IHdyb3RlOg0KPiANCj4gT24g MjAxOC0wNi0yMSAxMTozNCBBTSwgU2ltb24gTWFyY2hpIHdyb3RlOg0KPj4g T24gMjAxOC0wNi0yMSAxMToxOSBBTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0K Pj4+IEkgb3JpZ2luYWxseSB3cm90ZSB0aGlzIGZvciBqdXN0IHRoZSBfcGFy dCBmdW5jdGlvbnMgYW5kIHRoZW4gSSByZWplY3RlZA0KPj4+IGl0LiBUaGUg cHJvYmxlbSBhcyBJIHNlZSBpdCB3aXRoIHRoaXMgaXMgdGhhdCwgbW9zdGx5 IGFsbCB0aGUgY29kZSBjYWxsaW5nDQo+Pj4gdGhlc2UgZnVuY3Rpb25zIHRv ZGF5IGFyZSB1c2luZyBpbnRzLg0KPj4+IA0KPj4+IFNvLCB0byBrZWVwIGl0 IHNhZmUgd2Ugc2hvdWxkIHJlYWxseSB1cGRhdGUgYWxsIHRoZSBjYWxsZXJz IHRvby4gRm9yIGV4YW1wbGUsDQo+Pj4gb25lIHBpY2tlZCBhdCByYW5kb206 DQo+Pj4gDQo+Pj4gLS0tIGEvZ2RiL20zMmMtdGRlcC5jDQo+Pj4gKysrIGIv Z2RiL20zMmMtdGRlcC5jDQo+Pj4gQEAgLTQ0Myw5ICs0NDMsOSBAQCBtMzJj X2ZpbmRfcGFydCAoc3RydWN0IG0zMmNfcmVnICpyZWcsIGludCAqb2Zmc2V0 X3AsIGludCAqbGVuX3ApDQo+Pj4gICAgYml0cywgcmVhZCB0aGUgdmFsdWUg b2YgdGhlIFJFRy0+bid0aCBlbGVtZW50LiAgKi8NCj4+PiBzdGF0aWMgZW51 bSByZWdpc3Rlcl9zdGF0dXMNCj4+PiBtMzJjX3BhcnRfcmVhZCAoc3RydWN0 IG0zMmNfcmVnICpyZWcsIHJlYWRhYmxlX3JlZ2NhY2hlICpjYWNoZSwgZ2Ri X2J5dGUgKmJ1ZikNCj4+PiB7DQo+Pj4gLSAgaW50IG9mZnNldCwgbGVuOw0K Pj4+ICsgIHVuc2lnbmVkIGludCBvZmZzZXQsIGxlbjsNCj4+PiANCj4+PiAg IG1lbXNldCAoYnVmLCAwLCBUWVBFX0xFTkdUSCAocmVnLT50eXBlKSk7DQo+ Pj4gICBtMzJjX2ZpbmRfcGFydCAocmVnLCAmb2Zmc2V0LCAmbGVuKTsNCj4+ PiAgIHJldHVybiBjYWNoZS0+Y29va2VkX3JlYWRfcGFydCAocmVnLT5yeC0+ bnVtLCBvZmZzZXQsIGxlbiwgYnVmKTsNCj4+PiANCj4+PiBBbmQgd2l0aG91 dCBjaGVja2luZywgSeKAmW0gbm90IHN1cmUgbTMyY19maW5kX3BhcnQgY2Fu IGd1YXJhbnRlZSB1bnNpZ25lZC4NCj4+PiANCj4+PiBXaXRob3V0IHRob3Nl IGNoYW5nZXMgYWxsIHdlIGFyZSBkb2luZyBpcyBsb3Npbmcgc29tZSBhc3Nl cnQgcHJvdGVjdGlvbi4NCj4+IA0KPj4gRmFpciBlbm91Z2gsIEknbSBmaW5l IHdpdGgga2VlcGluZyB0aGUgaW50cyBhbmQgdGhlID49IDAgYXNzZXJ0cy4g IEl0IHdhcyBqdXN0DQo+PiBhIHRpbnkgaXRjaCA6KS4NCj4+IA0KPj4gU2lt b24NCj4+IA0KPiANCj4gSSB0aG91Z2h0IGFib3V0IGl0IGEgYml0IG1vcmUs IGFuZCB3ZSBpbmRlZWQgcHJvYmFibHkgbmVlZCBhcyBtYW55IGFzc2VydGlv bnMNCj4gd2l0aCB1bnNpZ25lZCB0eXBlcyBhcyB3ZSBkbyB3aXRoIHNpZ25l ZCB0eXBlcywgSSB3YXMgd3JvbmcgdGhpbmtpbmcgaXQgd291bGQNCj4gc2lt cGxpZnkgdGhpbmdzLg0KPiANCj4gTGV0J3Mgc2F5IGEgY2FsbGVyIG1pc2Nh bGN1bGF0ZSAib2Zmc2V0IiBhbmQgaXQgZW5kcyB1cCBiZWluZyAtMiAoMHhm ZmZmZmZmZSBhcyBhbg0KPiB1bnNpZ25lZCBpbnQpIGFuZCBsZW5ndGggaXMg NC4NCj4gVGhlIGFzc2VydGlvbg0KPiANCj4gIGdkYl9hc3NlcnQgKG9mZnNl dCArIGxlbiA8PSByZWdfc2l6ZSkNCj4gDQo+IHdpbGwgbm90IGNhdGNoIGl0 LCBzaW5jZSAob2Zmc2V0ICsgbGVuKSB3aWxsIHN0aWxsIGJlIDIgKGFmdGVy IHRoZSBvdmVyZmxvdykuICBTbw0KPiB3ZSB3b3VsZCBuZWVkIHRvIGNoZWNr IHRoYXQgb2Zmc2V0IGFuZCBsZW4gYXJlIHdpdGhpbiByZWdfc2l6ZSBpbmRp dmlkdWFsbHksIGFzIHdlbGwNCj4gYXMgdGhlaXIgc3VtOg0KPiANCj4gIGdk Yl9hc3NlcnQgKG9mZnNldCA8PSByZWdfc2l6ZSk7DQo+ICBnZGJfYXNzZXJ0 IChsZW4gPD0gcmVnX3NpemUpOw0KPiAgZ2RiX2Fzc2VydCAob2Zmc2V0ICsg bGVuIDw9IHJlZ19zaXplKTsNCj4gDQo+IEFuZCB0aGF0IGlzIGVxdWl2YWxl bnQgdG8gd2hhdCB3ZSB3b3VsZCBuZWVkIHdpdGggc2lnbmVkIHR5cGVzOg0K PiANCj4gIGdkYl9hc3NlcnQgKG9mZnNldCA+PSAwKTsNCj4gIGdkYl9hc3Nl cnQgKGxlbiA+PSAwKTsNCj4gIGdkYl9hc3NlcnQgKG9mZnNldCArIGxlbiA8 PSByZWdfc2l6ZSk7DQo+IA0KPiBTbyBpbiB0aGUgZW5kLCBJIHRoaW5rIHlv dSBjYW4gZm9yZ2V0IGNoYW5naW5nIHRoaW5ncyB0byB1bnNpZ25lZCwgc2lu Y2UgaXQNCj4gZG9lc24ndCByZWFsbHkgYWRkIHZhbHVlLi4uIHNvcnJ5IGZv ciB0aGUgbm9pc2UuDQo+IA0KDQpBZ3JlZSB3aXRoIHRoaXMuIEnigJlsbCBk cm9wIHRoaXMgcGF0Y2ggZnJvbSB0aGUgc2VyaWVzLg0KDQoNCkFsYW4uDQoN Cg== >From gdb-patches-return-148388-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Jun 21 19:56:01 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 14200 invoked by alias); 21 Jun 2018 19:56:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 14161 invoked by uid 89); 21 Jun 2018 19:56:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:5d5b6d4, H*f:sk:5d5b6d4 X-Spam-User: qpsmtpd, 2 recipients X-HELO: 9pmail.ess.barracuda.com Received: from 9pmail.ess.barracuda.com (HELO 9pmail.ess.barracuda.com) (64.235.154.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 19:55:59 +0000 Received: from mipsdag02.mipstec.com (mail2.mips.com [12.201.5.32]) by mx1401.ess.rzc.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=NO); Thu, 21 Jun 2018 19:55:41 +0000 Received: from [10.20.78.194] (10.20.78.194) by mipsdag02.mipstec.com (10.20.40.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Thu, 21 Jun 2018 12:55:38 -0700 Date: Thu, 21 Jun 2018 19:56:00 -0000 From: "Maciej W. Rozycki" To: Simon Marchi CC: Simon Marchi , , , Joel Brobecker , Fredrik Noring Subject: Re: [PATCH v4] GDB PR tdep/8282: MIPS: Wire in `set disassembler-options' In-Reply-To: <5d5b6d47508d5f54ff2eb6e514a7da2c@polymtl.ca> Message-ID: References: <3bd95a5f-e43e-2efe-e261-c2cf30d06d14@ericsson.com> <5d5b6d47508d5f54ff2eb6e514a7da2c@polymtl.ca> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-ClientProxiedBy: mipsdag02.mipstec.com (10.20.40.47) To mipsdag02.mipstec.com (10.20.40.47) X-BESS-ID: 1529610940-321457-7401-21700-1 X-BESS-VER: 2018.7-r1806151722 X-BESS-Apparent-Source-IP: 12.201.5.32 X-BESS-Envelope-From: Maciej.Rozycki@mips.com X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS59374 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-Orig-Rcpt: simon.marchi@polymtl.ca,simon.marchi@ericsson.com,gdb-patches@sourceware.org,binutils@sourceware.org,brobecker@adacore.com,noring@nocrew.org X-BESS-BRTS-Status:1 X-SW-Source: 2018-06/txt/msg00531.txt.bz2 Content-length: 1958 On Thu, 21 Jun 2018, Simon Marchi wrote: > > Thanks for the pointer. Although it makes sense to me at first glance > > that's quite a recent change to a long-established practice. Perhaps it > > could have been avoided by coding the regression analysis tools referred > > more carefully, but I won't be questioning the decision at this point. > > That's because of how DejaGNU formats test messages, for example when there is > a timeout (as shown in the example on the wiki). We don't have control over > that, and we don't want "foo" and "foo (timeout)" to be considered as two > different tests. I think you chose the wrong example, after all what's the problem for tools to notice that "foo (bar)" and "foo (bar) (timeout)" are the same test? If the number of parenthesis pairs is different between two messages, then strip the extra ones along with the text between from the message that has more of them and only then compare the resulting strings. What the problem would be are different failures in different runs, e.g. if we have "foo (bar) (timeout)" in one and "foo (bar) (internal error)" in the other one, then indeed we have an issue. We could strip parenthesis pairs one by one from both messages at a time, but then we'd incorrectly consider "foo (bar)" and "foo (baz)" the same test. Does it matter in reality? I suppose so, given the outcome of the discussion referred from the wiki, although I don't see the scenario I have outlined here actually mentioned there (parts of the discussion seem to be missing though from the archive). > That does not really apply to your case though. I think here you can just > remove the parenthesis, and maybe add a comma. > > mips_disassemble_test bar "move\tv0,a4" "disassemble ABI, n64" > > As long as it's clear. OK, works for me. I'll make that adjustment as I commit the change once the binutils parts have been approved. Thank you for your review. Maciej