From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4758 invoked by alias); 10 May 2012 14:11:23 -0000 Received: (qmail 4743 invoked by uid 22791); 10 May 2012 14:11:21 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 10 May 2012 14:11:08 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id AB61A290058; Thu, 10 May 2012 16:11:13 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5O1Ciuo9u5n7; Thu, 10 May 2012 16:11:13 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 49F00290007; Thu, 10 May 2012 16:11:13 +0200 (CEST) Subject: Re: [RFA] Emit a warning for ineffective set VAR = EXP command Mime-Version: 1.0 (Apple Message framework v1257) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: <20120509141704.GG15555@adacore.com> Date: Thu, 10 May 2012 14:11:00 -0000 Cc: "Maciej W. Rozycki" , "gdb-patches@sourceware.org ml" Content-Transfer-Encoding: 7bit Message-Id: References: <8781499A-A489-42D0-80B1-75136331DBDB@adacore.com> <20120507193824.GW15555@adacore.com> <419AD66E-6D21-40D6-97FE-1FF387117B7D@adacore.com> <20120509141704.GG15555@adacore.com> To: Joel Brobecker X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00339.txt.bz2 On May 9, 2012, at 4:17 PM, Joel Brobecker wrote: >> I don't know who should approve this adjustment, but here is the >> version that deals with pre/post inc/dec. Note that it still warns >> for expressions such as i++ * 2. > > I think a warning is fine in this case. "set i++ * 2" almost certainly > means something is fishy, because the multiplication is useless. > >> 2012-05-09 Tristan Gingold >> >> * printcmd.c (set_command): Add pre/post inc/dec. > > This looks good to me. Now committed. Tristan.