From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64433 invoked by alias); 5 Apr 2017 13:57:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64339 invoked by uid 89); 5 Apr 2017 13:57:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0064.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.64) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 13:57:25 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0103.eurprd08.prod.outlook.com (10.160.211.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Wed, 5 Apr 2017 13:57:24 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::5931:f431:f97d:943d%16]) with mapi id 15.01.1005.018; Wed, 5 Apr 2017 13:57:24 +0000 From: Alan Hayward To: Andreas Schwab CC: Yao Qi , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 7/11] Add BFIN_MAX_REGISTER_SIZE Date: Wed, 05 Apr 2017 13:57:00 -0000 Message-ID: References: <86tw63p2rx.fsf@gmail.com> In-Reply-To: authentication-results: suse.de; dkim=none (message not signed) header.d=none;suse.de; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1;AM3PR08MB0103;7:EZiIb8TLhTgroAMTl/SOytICX7GI/ZeVfPhmSkPS+8z9fhYOQH767bH9jStAOroqdLsj9JCLPoN1YmT4I/WzcZAn642BnsHj0QqltkURZN3YZ+eNvrR/LVNkfFCt7xynNFxUhjiDBKnZpltOWjSJaCobUPi0CKnMK2Eg5sUM0DlvZaJnYf+YEGpeMZfZ60SVTwpOxir4ck1eJ7GWJIfpGNKPHYkaOZEhXtl6vCI1C2xVGxgE1TCyccWjkEuAuDWFWHWV9tURA7wooCiRkIjEDKknyChYHYKdWq7TKQ1VYIIO+UhSs85nSujXUdUJpVhRsC5OWShMmhj4T/23nFdMpQ== x-ms-office365-filtering-correlation-id: 143d54f6-efeb-47be-2c20-08d47c2bafc6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:AM3PR08MB0103; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(17755550239193); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(6072148);SRVR:AM3PR08MB0103;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0103; x-forefront-prvs: 0268246AE7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39450400003)(39860400002)(39840400002)(39850400002)(39400400002)(39410400002)(24454002)(53546009)(82746002)(2950100002)(6916009)(6512007)(36756003)(38730400002)(50986999)(53936002)(189998001)(25786009)(76176999)(110136004)(54356999)(6246003)(6116002)(3846002)(6506006)(33656002)(102836003)(4326008)(8676002)(81166006)(229853002)(6436002)(83716003)(54906002)(99286003)(6486002)(39060400002)(305945005)(7736002)(93886004)(3660700001)(8936002)(5660300001)(3280700002)(66066001)(5250100002)(2900100001)(86362001)(2906002)(575784001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0103;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2017 13:57:23.5676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0103 X-SW-Source: 2017-04/txt/msg00106.txt.bz2 DQo+IE9uIDUgQXByIDIwMTcsIGF0IDE0OjUwLCBBbmRyZWFzIFNjaHdhYiA8 c2Nod2FiQHN1c2UuZGU+IHdyb3RlOg0KPiANCj4gT24gQXByIDA1IDIwMTcs IEFsYW4gSGF5d2FyZCA8QWxhbi5IYXl3YXJkQGFybS5jb20+IHdyb3RlOg0K PiANCj4+PiBPbiA1IEFwciAyMDE3LCBhdCAxMToyOCwgWWFvIFFpIDxxaXlh b2x0Y0BnbWFpbC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IEFsYW4gSGF5d2Fy ZCA8QWxhbi5IYXl3YXJkQGFybS5jb20+IHdyaXRlczoNCj4+PiANCj4+Pj4g ZGlmZiAtLWdpdCBhL2dkYi9iZmluLXRkZXAuYyBiL2dkYi9iZmluLXRkZXAu Yw0KPj4+PiBpbmRleCAzZGYxYmEzODdhMzIzZGM2ODI3YjExODk0MzJmODg3 N2QxODMzMTg0Li45YjQ1NjMzY2FiMTViOGUwYWRiMGQ1MWEyZmE2NTBkYzJi YzYzMzliIDEwMDY0NA0KPj4+PiAtLS0gYS9nZGIvYmZpbi10ZGVwLmMNCj4+ Pj4gKysrIGIvZ2RiL2JmaW4tdGRlcC5jDQo+Pj4+IEBAIC02ODksNyArNjg5 LDcgQEAgc3RhdGljIGVudW0gcmVnaXN0ZXJfc3RhdHVzDQo+Pj4+IGJmaW5f cHNldWRvX3JlZ2lzdGVyX3JlYWQgKHN0cnVjdCBnZGJhcmNoICpnZGJhcmNo LCBzdHJ1Y3QgcmVnY2FjaGUgKnJlZ2NhY2hlLA0KPj4+PiAJCQkgICBpbnQg cmVnbnVtLCBnZGJfYnl0ZSAqYnVmZmVyKQ0KPj4+PiB7DQo+Pj4+IC0gIGdk Yl9ieXRlICpidWYgPSAoZ2RiX2J5dGUgKikgYWxsb2NhIChNQVhfUkVHSVNU RVJfU0laRSk7DQo+Pj4+ICsgIGdkYl9ieXRlICpidWYgPSAoZ2RiX2J5dGUg KikgYWxsb2NhIChCRklOX01BWF9SRUdJU1RFUl9TSVpFKTsNCj4+PiANCj4+ PiBXaHkgZG9uJ3QgeW91IGRvICJnZGJfYnl0ZSBidWZbNF07Ij8gIEl0IGlz IG9ubHkgZm9yIENDIHJlZ2lzdGVyIHdoaWNoDQo+Pj4gaXMgMzItYml0Lg0K Pj4+IA0KPj4gDQo+PiBJcyBpdCBub3QgY2xlYXJlciBjb2RlIHRvIGFkZCBh bmQgdXNlIGEgbWFjcm8gcmF0aGVyIHRoYW4gYSBtYWdpYyBudW1iZXIgPw0K Pj4gDQo+PiBJdOKAmXMgYWxzbyBub3Qgb2J2aW91cyBhbnl3aGVyZSB0aGF0 IHRoZSBhc3RhdCByZWdpc3RlciBpcyAzMmJpdHMuIEkgaGFkIHRvIGdvDQo+ PiBkaWdnaW5nIGluc2lkZSByZWdmb3JtYXRzL3JlZy1iZmluLmRhdCBiZWZv cmUgSSBmb3VuZCBpdCBvdXQuDQo+PiANCj4+IEdpdmVuIHRoYXQgQkZJTl9N QVhfUkVHSVNURVJfU0laRSBpcyBhbHNvIDQsIGl0IGNvbXBpbGVzIHRvIHRo ZSBzYW1lIHNpemUgYW55d2F5Lg0KPiANCj4gU2luY2UgQkZJTl9NQVhfUkVH SVNURVJfU0laRSBpcyBhIGNvbnN0YW50IHlvdSBkb24ndCBuZWVkIGFsbG9j YSBlaXRoZXINCj4gd2F5Lg0KPiANCg0KU29ycnksIHllcywgSSBtZWFudCB0 byBzYXk6DQoNCldoeSBub3QgdXNlOg0KZ2RiX2J5dGUgYnVmW0JGSU5fTUFY X1JFR0lTVEVSX1NJWkVdOw0KDQpSYXRoZXIgdGhhbg0KZ2RiX2J5dGUgYnVm WzRdOw0KDQpHaXZlbiB0aGF0IGEgbWFjcm8gaXMgY2xlYXJlciB0aGFuIGEg bWFnaWMgbnVtYmVyLg0KDQpBbGFuLg0KDQo= >From gdb-patches-return-138023-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Apr 05 14:10:17 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 56306 invoked by alias); 5 Apr 2017 14:10:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 55495 invoked by uid 89); 5 Apr 2017 14:10:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:820 X-HELO: mail-wr0-f181.google.com Received: from mail-wr0-f181.google.com (HELO mail-wr0-f181.google.com) (209.85.128.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 14:10:15 +0000 Received: by mail-wr0-f181.google.com with SMTP id t20so16706572wra.1 for ; Wed, 05 Apr 2017 07:10:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jPQ+hhrowqyCxtadb6Bkpf4D8nSz+KsYWL9Gdyr3lFI=; b=pnwqQck2rWTE1BomWbTCDp+g5WCHgmn4nGB2yK+PtdIRpaH3g1EBM1LIOJdFyIgLJY ow35ZF3nxsQeVM9C4AgEj0J5nq8e4cJ2Ytmg+Kf8ahDYo6xe8ooZN6h7wzq0s+MUrrip bhPerky1EhhfnNHwEJoQGwpzcu2bTfBQqM7TaNf75P7c6Wb+RQnLW+l511fSZct0rASC pZhMgO/Rfm3MynBaSAIhycAlhVAH52bxfeAqvCsfsxGuaerIlHemOt8CvVIziaVtcxR/ AxR/4PNYpfZiTF3LeRt1m3OO9j90hEebPir7yeurZ2yC3U7LOh/1RgvZbdMVzud1DnuQ NFgg== X-Gm-Message-State: AFeK/H2/ihDuxzBfExuW/nyi+VG/RgIkPOpccvTY6ZDYl0XhBXw9iAcwMM8p86+MRzeVPA== X-Received: by 10.223.176.11 with SMTP id f11mr7203492wra.158.1491401414893; Wed, 05 Apr 2017 07:10:14 -0700 (PDT) Received: from E107787-LIN ([194.214.185.158]) by smtp.gmail.com with ESMTPSA id t79sm22546934wmd.29.2017.04.05.07.10.13 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 05 Apr 2017 07:10:14 -0700 (PDT) From: Yao Qi To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH 7/11] Add BFIN_MAX_REGISTER_SIZE References: <86tw63p2rx.fsf@gmail.com> Date: Wed, 05 Apr 2017 14:10:00 -0000 In-Reply-To: (Alan Hayward's message of "Wed, 5 Apr 2017 13:43:50 +0000") Message-ID: <86d1croshn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00107.txt.bz2 Content-length: 801 Alan Hayward writes: > Is it not clearer code to add and use a macro rather than a magic number ? > Macro is better, but "buf[4]" is not that magic, because it is only used within bfin_pseudo_register_read, or we can define ASTAT_REGISTER_SIZE. > It=E2=80=99s also not obvious anywhere that the astat register is 32bits.= I had to go > digging inside regformats/reg-bfin.dat before I found it out. It is easier to figure out the size of a specific register than the max size of a set of registers. > > Given that BFIN_MAX_REGISTER_SIZE is also 4, it compiles to the same > size anyway. "gdb_byte buf[BFIN_MAX_REGISTER_SIZE]" is fine to me. Could you define BFIN_MAX_REGISTER_SIZE in bfin-tdep.c instead of .h? It is not used elsewhere. --=20 Yao (=E9=BD=90=E5=B0=A7)