From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4568 invoked by alias); 17 Sep 2012 20:28:08 -0000 Received: (qmail 4549 invoked by uid 22791); 17 Sep 2012 20:28:05 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from server-nat-6.cs.umd.edu (HELO bacon.cs.umd.edu) (128.8.127.149) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Sep 2012 20:27:51 +0000 Received: from [10.109.174.174] (129-2-129-155.wireless.umd.edu [129.2.129.155]) (Authenticated sender: khooyp) by bacon.cs.umd.edu (Postfix) with ESMTPSA id BBB42B40875; Mon, 17 Sep 2012 16:27:49 -0400 (EDT) Subject: Re: [PATCH] Warn about data-directory when failing to import Python "gdb" module Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Khoo Yit Phang In-Reply-To: <20120917202241.GB4423@host2.jankratochvil.net> Date: Mon, 17 Sep 2012 20:28:00 -0000 Cc: Khoo Yit Phang , GDB Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <20120917202241.GB4423@host2.jankratochvil.net> To: Jan Kratochvil X-CSD-MailScanner-ID: BBB42B40875.A0DE0 X-CSD-MailScanner: Found to be clean X-CSD-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-50, required 5, autolearn=not spam, ALL_TRUSTED -50.00) X-CSD-MailScanner-From: khooyp@cs.umd.edu X-CSD-MailScanner-Watermark: 1348518469.90849@CteSr/BeRwOkQssrnoHaNw Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00326.txt.bz2 Hi, On Sep 17, 2012, at 4:22 PM, Jan Kratochvil wrote: > On Mon, 17 Sep 2012 21:36:37 +0200, Khoo Yit Phang wrote: >> + warning (_("Please make sure that data-directory is set correctly= .")); >=20 > Couldn't you make it more explicit, such as mentioning the -data-directory > command-line parameter and that it should contain file python/gdb/__init_= _.py > or that it is gdb/data-directory in the source tree or some such wording? How about: If you are running GDB from the build directory, please run gdb with the -d= ata-directory flag set as appropriate, e.g., "builddir/gdb -data-directory = builddir/data-directory". Yit September 17, 2012