From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21832 invoked by alias); 9 Nov 2012 19:31:01 -0000 Received: (qmail 21820 invoked by uid 22791); 9 Nov 2012 19:31:00 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Nov 2012 19:30:55 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1TWuI2-0005q2-VB from Ali_Anwar@mentor.com ; Fri, 09 Nov 2012 11:30:54 -0800 Received: from SVR-IES-FEM-04.mgc.mentorg.com ([137.202.0.110]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 9 Nov 2012 11:30:54 -0800 Received: from EU-MBX-02.mgc.mentorg.com ([169.254.3.224]) by SVR-IES-FEM-04.mgc.mentorg.com ([137.202.0.110]) with mapi id 14.01.0289.001; Fri, 9 Nov 2012 19:30:53 +0000 From: "Anwar, Ali" To: "dje@google.com" CC: "Qi, Yao" , "gdb-patches@sourceware.org" Subject: RE: Patch to propagate GDB's knowledge of the executing state to frontend Date: Fri, 09 Nov 2012 19:31:00 -0000 Message-ID: References: <50891E05.7050509@codesourcery.com> <508F719C.2080409@codesourcery.com> <20627.61842.606081.697743@ruffy2.mtv.corp.google.com>,<50941519.6010005@codesourcery.com> In-Reply-To: <50941519.6010005@codesourcery.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00264.txt.bz2 Ping... OK to commit? Regards, -Ali ________________________________________ From: gdb-patches-owner@sourceware.org [gdb-patches-owner@sourceware.org] o= n behalf of Anwar, Ali Sent: Friday, November 02, 2012 11:46 PM To: dje@google.com Cc: Qi, Yao; gdb-patches@sourceware.org Subject: Re: Patch to propagate GDB's knowledge of the executing state to f= rontend On 11/02/2012 09:15 PM, dje@google.com wrote: > Yao Qi writes: > > On 10/25/2012 07:09 PM, ali_anwar wrote: > > > [...] > > > @@ -1,3 +1,13 @@ > > > +2012-10-25 Ali Anwar > > > + > > > + * infrun.c (handle_inferior_event_stub, regcache_dup_stub): > > > + New functions. > > > + (normal_stop): Change to propagate GDB's knowledge of the > > > + executing state to frontend when not able to fetch register= s. > > > + (wait_for_inferior): Chnage to propagate GDB's knowledge of > > ^^^^^^ typo > > > > > > > + the executing state if not able to fetch backtrace once the > > > + step has already occured. > > ^^^^^^^ typo. > > > > In each changelog entry, we'll put 'what do we change' instead of 'w= hy > > do we change in this way'. So this entry can be simplified. > > Hi. > > I agree with your first sentence, and would add that if such an > explanation is needed, it belongs in the code not the changelog. > [We don't have enough comments in the code explaining *why* things > are the way they are.] > > But I'd say that's not the case here, at least for the changelog entries. > Instead, I would remove the leading "Change to", and just say "Propagate = ...". > > Also, I would add a comment to the code explaining *why* the calls are wr= apped > in catch_error (and I would have the comment live at the call to catch_er= ror, > not in the definition of the two new stubs). > > One could also say the two new functions also require comments, > but they're pretty simple and hook_stop_stub doesn't have a comment, > so I'd be ok with leaving them out. Thanks for the review. Please find attached the modified patch. -Ali