From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32614 invoked by alias); 17 Jun 2019 15:45:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32489 invoked by uid 89); 17 Jun 2019 15:45:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.9 required=5.0 tests=AWL,BAYES_20,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=sk:Wsugges, sk:wsugges, H*i:sk:2019053, sk:maybeu X-HELO: EUR04-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr70088.outbound.protection.outlook.com (HELO EUR04-HE1-obe.outbound.protection.outlook.com) (40.107.7.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jun 2019 15:45:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qOhZIOzNkWIu4KS+tCmZ7kZOTvdl/unIB9kk7sYFTw0=; b=74Hq96svQL2j7kQLOl/5TGh0kP5qO3ILH0/EiNVWguUBG8gOhC8QNeuYCT/RprGhkPSiYFdJvD0RKsz1a7i3sU4L8PIZPF8l1dYfOn9XhAWQlXJe8+Pu/fPyuMZEoTQ5+XlrxjQomgOFLshAkWt2pbUXOGSJINdJhFTIkMU8/nU= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2423.eurprd08.prod.outlook.com (10.172.247.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.11; Mon, 17 Jun 2019 15:44:58 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::7c2c:8bc6:920:f845]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::7c2c:8bc6:920:f845%6]) with mapi id 15.20.1987.014; Mon, 17 Jun 2019 15:44:58 +0000 From: Alan Hayward To: Tom Tromey CC: "gdb-patches\\@sourceware.org" , nd Subject: Re: [RFC 2/2] Move gdb's xmalloc and friends to new file Date: Mon, 17 Jun 2019 15:45:00 -0000 Message-ID: References: <20190530213046.20542-1-tom@tromey.com> <20190530213046.20542-3-tom@tromey.com> In-Reply-To: <20190530213046.20542-3-tom@tromey.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-exchange-purlcount: 1 x-ms-oob-tlc-oobclassifiers: OLM:4941; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Alan.Hayward@arm.com X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00309.txt.bz2 VG9tLA0KDQpMb29rcyBsaWtlIHRoaXMgYnJlYWtzIHRoZSBidWlsZGluZyBv ZiBhbGxvYy1pcGEubyB3aGVuIHVzaW5nIE1ha2UgMy44MQ0KSeKAmXZlIHRy aWVkIHRoaXMgb24gYSBmZXcgZGlmZmVyZW50IG1hY2hpbmVzLg0KDQpnKysg LXggYysrICAtZyAtTzIgICAgLUkuIC1JLi4vLi4vLi4vc3JjL2JpbnV0aWxz LWdkYi9nZGIvZ2Ric2VydmVyIC1JLi4vLi4vLi4vc3JjL2JpbnV0aWxzLWdk Yi9nZGIvZ2Ric2VydmVyLy4uL3JlZ2Zvcm1hdHMgLUkuLi8uLi8uLi9zcmMv YmludXRpbHMtZ2RiL2dkYi9nZGJzZXJ2ZXIvLi4gLUkuLi8uLi8uLi9zcmMv YmludXRpbHMtZ2RiL2dkYi9nZGJzZXJ2ZXIvLi4vLi4vaW5jbHVkZSAtSS4u Ly4uLy4uL3NyYy9iaW51dGlscy1nZGIvZ2RiL2dkYnNlcnZlci8uLi8uLi9n bnVsaWIvaW1wb3J0IC1JYnVpbGQtZ251bGliLWdkYnNlcnZlci9pbXBvcnQg IC1XYWxsIC1XcG9pbnRlci1hcml0aCAtV25vLXVudXNlZCAtV3VudXNlZC12 YWx1ZSAtV3VudXNlZC12YXJpYWJsZSAtV3VudXNlZC1mdW5jdGlvbiAtV25v LXN3aXRjaCAtV25vLWNoYXItc3Vic2NyaXB0cyAtV2VtcHR5LWJvZHkgLVd1 bnVzZWQtYnV0LXNldC1wYXJhbWV0ZXIgLVd1bnVzZWQtYnV0LXNldC12YXJp YWJsZSAtV25vLXNpZ24tY29tcGFyZSAtV25vLWVycm9yPW1heWJlLXVuaW5p dGlhbGl6ZWQgLVdzdWdnZXN0LW92ZXJyaWRlIC1XaW1wbGljaXQtZmFsbHRo cm91Z2g9MyAtV2R1cGxpY2F0ZWQtY29uZCAtV3NoYWRvdz1sb2NhbCAtV2Zv cm1hdCAtV2Zvcm1hdC1ub25saXRlcmFsIC1XZXJyb3IgLURHREJTRVJWRVIg IC1EQ09ORklHX1VTVF9HREJfSU5URUdSQVRJT04gLURycGxfc3RyZXJyb3I9 c3RyZXJyb3IgLWZQSUMgLURJTl9QUk9DRVNTX0FHRU5UIC1mdmlzaWJpbGl0 eT1oaWRkZW4gLWMgLW8gYWxsb2MtaXBhLm8gLU1UIGFsbG9jLWlwYS5vIC1N TUQgLU1QIC1NRiAuLy5kZXBzL2FsbG9jLWlwYS5UcG8gYGVjaG8gIiAtV2Fs bCAtV3BvaW50ZXItYXJpdGggLVduby11bnVzZWQgLVd1bnVzZWQtdmFsdWUg LVd1bnVzZWQtdmFyaWFibGUgLVd1bnVzZWQtZnVuY3Rpb24gLVduby1zd2l0 Y2ggLVduby1jaGFyLXN1YnNjcmlwdHMgLVdlbXB0eS1ib2R5IC1XdW51c2Vk LWJ1dC1zZXQtcGFyYW1ldGVyIC1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUg LVduby1zaWduLWNvbXBhcmUgLVduby1lcnJvcj1tYXliZS11bmluaXRpYWxp emVkIC1Xc3VnZ2VzdC1vdmVycmlkZSAtV2ltcGxpY2l0LWZhbGx0aHJvdWdo PTMgLVdkdXBsaWNhdGVkLWNvbmQgLVdzaGFkb3c9bG9jYWwgLVdmb3JtYXQg LVdmb3JtYXQtbm9ubGl0ZXJhbCAiIHwgc2VkICJzLyAtV2Zvcm1hdC1ub25s aXRlcmFsIC8gLVduby1mb3JtYXQtbm9ubGl0ZXJhbCAvZyJgDQpnKys6IHdh cm5pbmc6IOKAmC14IGMrK+KAmSBhZnRlciBsYXN0IGlucHV0IGZpbGUgaGFz IG5vIGVmZmVjdA0KZysrOiBmYXRhbCBlcnJvcjogbm8gaW5wdXQgZmlsZXMN CmNvbXBpbGF0aW9uIHRlcm1pbmF0ZWQuDQptYWtlLTMuODFbNF06ICoqKiBb YWxsb2MtaXBhLm9dIEVycm9yIDENCm1ha2UtMy44MVs0XTogKioqIFdhaXRp bmcgZm9yIHVuZmluaXNoZWQgam9icy4uLi4NCg0KDQpTb21ldGhpbmcgaGFz IHN0cmlwcGVkIHRoZSAiLi4vLi4vLi4vc3JjL2JpbnV0aWxzLWdkYi9nZGIv Z2Ric2VydmVyLy4uL2FsbG9jLmPigJ0gZnJvbSB0aGUgYnVpbGQgbGluZS4N Cg0KQml6YXJyZWx5LCBpZiB5b3UgdGhlbiBydW4gbWFrZSBhIHNlY29uZCB0 aW1lLCBldmVyeXRoaW5nIHdvcmtzOg0KDQpnKysgLXggYysrICAtZyAtTzIg ICAgLUkuIC1JLi4vLi4vLi4vc3JjL2JpbnV0aWxzLWdkYi9nZGIvZ2Ric2Vy dmVyIC1JLi4vLi4vLi4vc3JjL2JpbnV0aWxzLWdkYi9nZGIvZ2Ric2VydmVy Ly4uL3JlZ2Zvcm1hdHMgLUkuLi8uLi8uLi9zcmMvYmludXRpbHMtZ2RiL2dk Yi9nZGJzZXJ2ZXIvLi4gLUkuLi8uLi8uLi9zcmMvYmludXRpbHMtZ2RiL2dk Yi9nZGJzZXJ2ZXIvLi4vLi4vaW5jbHVkZSAtSS4uLy4uLy4uL3NyYy9iaW51 dGlscy1nZGIvZ2RiL2dkYnNlcnZlci8uLi8uLi9nbnVsaWIvaW1wb3J0IC1J YnVpbGQtZ251bGliLWdkYnNlcnZlci9pbXBvcnQgIC1XYWxsIC1XcG9pbnRl ci1hcml0aCAtV25vLXVudXNlZCAtV3VudXNlZC12YWx1ZSAtV3VudXNlZC12 YXJpYWJsZSAtV3VudXNlZC1mdW5jdGlvbiAtV25vLXN3aXRjaCAtV25vLWNo YXItc3Vic2NyaXB0cyAtV2VtcHR5LWJvZHkgLVd1bnVzZWQtYnV0LXNldC1w YXJhbWV0ZXIgLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZSAtV25vLXNpZ24t Y29tcGFyZSAtV25vLWVycm9yPW1heWJlLXVuaW5pdGlhbGl6ZWQgLVdzdWdn ZXN0LW92ZXJyaWRlIC1XaW1wbGljaXQtZmFsbHRocm91Z2g9MyAtV2R1cGxp Y2F0ZWQtY29uZCAtV3NoYWRvdz1sb2NhbCAtV2Zvcm1hdCAtV2Zvcm1hdC1u b25saXRlcmFsIC1XZXJyb3IgLURHREJTRVJWRVIgIC1EQ09ORklHX1VTVF9H REJfSU5URUdSQVRJT04gLURycGxfc3RyZXJyb3I9c3RyZXJyb3IgLWZQSUMg LURJTl9QUk9DRVNTX0FHRU5UIC1mdmlzaWJpbGl0eT1oaWRkZW4gLWMgLW8g YWxsb2MtaXBhLm8gLU1UIGFsbG9jLWlwYS5vIC1NTUQgLU1QIC1NRiAuLy5k ZXBzL2FsbG9jLWlwYS5UcG8gYGVjaG8gIiAtV2FsbCAtV3BvaW50ZXItYXJp dGggLVduby11bnVzZWQgLVd1bnVzZWQtdmFsdWUgLVd1bnVzZWQtdmFyaWFi bGUgLVd1bnVzZWQtZnVuY3Rpb24gLVduby1zd2l0Y2ggLVduby1jaGFyLXN1 YnNjcmlwdHMgLVdlbXB0eS1ib2R5IC1XdW51c2VkLWJ1dC1zZXQtcGFyYW1l dGVyIC1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGUgLVduby1zaWduLWNvbXBh cmUgLVduby1lcnJvcj1tYXliZS11bmluaXRpYWxpemVkIC1Xc3VnZ2VzdC1v dmVycmlkZSAtV2ltcGxpY2l0LWZhbGx0aHJvdWdoPTMgLVdkdXBsaWNhdGVk LWNvbmQgLVdzaGFkb3c9bG9jYWwgLVdmb3JtYXQgLVdmb3JtYXQtbm9ubGl0 ZXJhbCAiIHwgc2VkICJzLyAtV2Zvcm1hdC1ub25saXRlcmFsIC8gLVduby1m b3JtYXQtbm9ubGl0ZXJhbCAvZyJgIC4uLy4uLy4uL3NyYy9iaW51dGlscy1n ZGIvZ2RiL2dkYnNlcnZlci8uLi9hbGxvYy5jDQoNCg0KUmV2ZXJ0aW5nIHlv dXIgY2hhbmdlIGZpeGVzIHRoZSBpc3N1ZS4NCg0KSeKAmXZlIG5vIGlkZWEg d2hhdOKAmXMgY2F1c2luZyBpdCwgYW5kIGFtIGFzc3VtaW5nIGl04oCZcyBh IHdlaXJkIG1ha2UgYnVnLg0KSSByZW1lbWJlciBoYXZpbmcgYSAzLjgxIGlz c3VlIGFyb3VuZCB0aGUgc2FtZSBhcmVhOg0KYTU0M2M1Y2E3YzEyODU1NDg3 MjZlNmQ5MmNhNjA0NGRjMTk2MzM0MC4NCg0KDQooUGVyc29uYWxseSwgSeKA mXZlIG5vIGF0dGFjaG1lbnQgdG8gMy44MSwgYW5kIHVzdWFsbHkgdXNlIDQu eC4pDQoNCg0KDQpBbGFuLg0KDQoNCg0KDQo+IE9uIDMwIE1heSAyMDE5LCBh dCAyMjozMCwgVG9tIFRyb21leSA8dG9tQHRyb21leS5jb20+IHdyb3RlOg0K PiANCj4gV2hlbiAiY29tbW9uIiBiZWNvbWVzIGEgbGlicmFyeSwgbGlua2lu ZyB3aWxsIGNhdXNlIGEgc3ltYm9sIGNsYXNoLA0KPiBiZWNhdXNlICJ4bWFs bG9jIiBhbmQgc29tZSByZWxhdGVkIHN5bWJvbHMgYXJlIGRlZmluZWQgaW4g dGhhdA0KPiBsaWJyYXJ5LCBsaWJpYmVydHksIGFuZCByZWFkbGluZS4NCj4g DQo+IFRvIHdvcmsgYXJvdW5kIHRoaXMgcHJvYmxlbSwgdGhpcyBwYXRjaCBt b3ZlcyB0aGUgY2xhc2hpbmcgc3ltYm9scyB0bw0KPiBhIG5ldyBmaWxlLCB3 aGljaCBpcyB0aGVuIGNvbXBpbGVkIHNlcGFyYXRlbHkgZm9yIGJvdGggZ2Ri IGFuZA0KPiBnZGJzZXJ2ZXIuDQo+IA0KPiBnZGIvQ2hhbmdlTG9nDQo+IDIw MTktMDUtMzAgIFRvbSBUcm9tZXkgIDx0b21AdHJvbWV5LmNvbT4NCj4gDQo+ IAkqIGNvbW1vbi9jb21tb24tdXRpbHMuYyAoeG1hbGxvYywgeHJlYWxsb2Ms IHhjYWxsb2MpDQo+IAkoeG1hbGxvY19mYWlsZWQpOiBNb3ZlIHRvIGFsbG9j LmMuDQo+IAkqIGFsbG9jLmM6IE5ldyBmaWxlLg0KPiAJKiBNYWtlZmlsZS5p biAoQ09NTU9OX1NGSUxFUyk6IEFkZCBhbGxvYy5jLg0KPiANCj4gZ2RiL2dk YnNlcnZlci9DaGFuZ2VMb2cNCj4gMjAxOS0wNS0zMCAgVG9tIFRyb21leSAg PHRvbUB0cm9tZXkuY29tPg0KPiANCj4gCSogTWFrZWZpbGUuaW4gKFNGSUxF Uyk6IEFkZCBhbGxvYy5jLg0KPiAJKE9CUyk6IEFkZCBhbGxvYy5vLg0KPiAJ KElQQV9PQkpTKTogQWRkIGFsbG9jLWlwYS5vLg0KPiAJKGFsbG9jLWlwYS5v KTogTmV3IHRhcmdldC4NCj4gCSglLm86IC4uLyUuYyk6IE5ldyBwYXR0ZXJu IHJ1bGUuDQo+IC0tLQ0KPiBnZGIvQ2hhbmdlTG9nICAgICAgICAgICAgIHwg IDcgKysrDQo+IGdkYi9NYWtlZmlsZS5pbiAgICAgICAgICAgfCAgMSArDQo+ IGdkYi9hbGxvYy5jICAgICAgICAgICAgICAgfCA5NSArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gZ2RiL2NvbW1vbi9jb21t b24tdXRpbHMuYyB8IDcyIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t DQo+IGdkYi9nZGJzZXJ2ZXIvQ2hhbmdlTG9nICAgfCAgOCArKysrDQo+IGdk Yi9nZGJzZXJ2ZXIvTWFrZWZpbGUuaW4gfCAxMSArKysrKw0KPiA2IGZpbGVz IGNoYW5nZWQsIDEyMiBpbnNlcnRpb25zKCspLCA3MiBkZWxldGlvbnMoLSkN Cj4gY3JlYXRlIG1vZGUgMTAwNjQ0IGdkYi9hbGxvYy5jDQo+IA0KPiBkaWZm IC0tZ2l0IGEvZ2RiL01ha2VmaWxlLmluIGIvZ2RiL01ha2VmaWxlLmluDQo+ IGluZGV4IDBmNDk1NzgzNjAwLi4xNWVjN2E2MWIxYyAxMDA2NDQNCj4gLS0t IGEvZ2RiL01ha2VmaWxlLmluDQo+ICsrKyBiL2dkYi9NYWtlZmlsZS5pbg0K PiBAQCAtOTI0LDYgKzkyNCw3IEBAIENPTU1PTl9TRklMRVMgPSBcDQo+IAlh ZGEtdmFyb2JqLmMgXA0KPiAJYWRkcm1hcC5jIFwNCj4gCWFnZW50LmMgXA0K PiArCWFsbG9jLmMgXA0KPiAJYW5ub3RhdGUuYyBcDQo+IAlhcmNoLXV0aWxz LmMgXA0KPiAJYXV0by1sb2FkLmMgXA0KPiBkaWZmIC0tZ2l0IGEvZ2RiL2Fs bG9jLmMgYi9nZGIvYWxsb2MuYw0KPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0K PiBpbmRleCAwMDAwMDAwMDAwMC4uZTZjOWMyMTU0MzUNCj4gLS0tIC9kZXYv bnVsbA0KPiArKysgYi9nZGIvYWxsb2MuYw0KPiBAQCAtMCwwICsxLDk1IEBA DQo+ICsvKiBTaGFyZWQgYWxsb2NhdGlvbiBmdW5jdGlvbnMgZm9yIEdEQiwg dGhlIEdOVSBkZWJ1Z2dlci4NCj4gKw0KPiArICAgQ29weXJpZ2h0IChDKSAy MDE5IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLg0KPiArDQo+ICsg ICBUaGlzIGZpbGUgaXMgcGFydCBvZiBHREIuDQo+ICsNCj4gKyAgIFRoaXMg cHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0 ZSBpdCBhbmQvb3IgbW9kaWZ5DQo+ICsgICBpdCB1bmRlciB0aGUgdGVybXMg b2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hl ZCBieQ0KPiArICAgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbjsgZWl0 aGVyIHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3INCj4gKyAgIChhdCB5 b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uDQo+ICsNCj4gKyAgIFRo aXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0 IHdpbGwgYmUgdXNlZnVsLA0KPiArICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJB TlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YNCj4g KyAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VM QVIgUFVSUE9TRS4gIFNlZSB0aGUNCj4gKyAgIEdOVSBHZW5lcmFsIFB1Ymxp YyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+ICsNCj4gKyAgIFlvdSBz aG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFs IFB1YmxpYyBMaWNlbnNlDQo+ICsgICBhbG9uZyB3aXRoIHRoaXMgcHJvZ3Jh bS4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5zZXMv Pi4gICovDQo+ICsNCj4gKyNpbmNsdWRlICJjb21tb24vY29tbW9uLWRlZnMu aCINCj4gKyNpbmNsdWRlICJsaWJpYmVydHkuaCINCj4gKyNpbmNsdWRlIDxj c3RkbGliPg0KPiArI2luY2x1ZGUgImNvbW1vbi9lcnJvcnMuaCINCj4gKw0K PiArLyogVGhlIHhtYWxsb2MoKSAobGliaWJlcnR5LmgpIGZhbWlseSBvZiBt ZW1vcnkgbWFuYWdlbWVudCByb3V0aW5lcy4NCj4gKw0KPiArICAgVGhlc2Ug YXJlIGxpa2UgdGhlIElTTy1DIG1hbGxvYygpIGZhbWlseSBleGNlcHQgdGhh dCB0aGV5IGltcGxlbWVudA0KPiArICAgY29uc2lzdGVudCBzZW1hbnRpY3Mg YW5kIGd1YXJkIGFnYWluc3QgdHlwaWNhbCBtZW1vcnkgbWFuYWdlbWVudA0K PiArICAgcHJvYmxlbXMuICAqLw0KPiArDQo+ICsvKiBOT1RFOiBUaGVzZSBh cmUgZGVjbGFyZWQgdXNpbmcgUFRSIHRvIGVuc3VyZSBjb25zaXN0ZW5jeSB3 aXRoDQo+ICsgICAibGliaWJlcnR5LmgiLiAgeGZyZWUoKSBpcyBHREIgbG9j YWwuICAqLw0KPiArDQo+ICtQVFIgICAgICAgICAgICAgICAgICAgICAgICAg ICAgLyogQVJJOiBQVFIgKi8NCj4gK3htYWxsb2MgKHNpemVfdCBzaXplKQ0K PiArew0KPiArICB2b2lkICp2YWw7DQo+ICsNCj4gKyAgLyogU2VlIGxpYmli ZXJ0eS94bWFsbG9jLmMuICBUaGlzIGZ1bmN0aW9uIG5lZWQncyB0byBtYXRj aCB0aGF0J3MNCj4gKyAgICAgc2VtYW50aWNzLiAgSXQgbmV2ZXIgcmV0dXJu cyBOVUxMLiAgKi8NCj4gKyAgaWYgKHNpemUgPT0gMCkNCj4gKyAgICBzaXpl ID0gMTsNCj4gKw0KPiArICB2YWwgPSBtYWxsb2MgKHNpemUpOyAgICAgICAg IC8qIEFSSTogbWFsbG9jICovDQo+ICsgIGlmICh2YWwgPT0gTlVMTCkNCj4g KyAgICBtYWxsb2NfZmFpbHVyZSAoc2l6ZSk7DQo+ICsNCj4gKyAgcmV0dXJu IHZhbDsNCj4gK30NCj4gKw0KPiArUFRSICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgLyogQVJJOiBQVFIgKi8NCj4gK3hyZWFsbG9jIChQVFIgcHRy LCBzaXplX3Qgc2l6ZSkgICAgICAgICAgLyogQVJJOiBQVFIgKi8NCj4gK3sN Cj4gKyAgdm9pZCAqdmFsOw0KPiArDQo+ICsgIC8qIFNlZSBsaWJpYmVydHkv eG1hbGxvYy5jLiAgVGhpcyBmdW5jdGlvbiBuZWVkJ3MgdG8gbWF0Y2ggdGhh dCdzDQo+ICsgICAgIHNlbWFudGljcy4gIEl0IG5ldmVyIHJldHVybnMgTlVM TC4gICovDQo+ICsgIGlmIChzaXplID09IDApDQo+ICsgICAgc2l6ZSA9IDE7 DQo+ICsNCj4gKyAgaWYgKHB0ciAhPSBOVUxMKQ0KPiArICAgIHZhbCA9IHJl YWxsb2MgKHB0ciwgc2l6ZSk7CS8qIEFSSTogcmVhbGxvYyAqLw0KPiArICBl bHNlDQo+ICsgICAgdmFsID0gbWFsbG9jIChzaXplKTsJICAgICAgICAvKiBB Ukk6IG1hbGxvYyAqLw0KPiArICBpZiAodmFsID09IE5VTEwpDQo+ICsgICAg bWFsbG9jX2ZhaWx1cmUgKHNpemUpOw0KPiArDQo+ICsgIHJldHVybiB2YWw7 DQo+ICt9DQo+ICsNCj4gK1BUUiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAvKiBBUkk6IFBUUiAqLw0KPiAreGNhbGxvYyAoc2l6ZV90IG51bWJlciwg c2l6ZV90IHNpemUpDQo+ICt7DQo+ICsgIHZvaWQgKm1lbTsNCj4gKw0KPiAr ICAvKiBTZWUgbGliaWJlcnR5L3htYWxsb2MuYy4gIFRoaXMgZnVuY3Rpb24g bmVlZCdzIHRvIG1hdGNoIHRoYXQncw0KPiArICAgICBzZW1hbnRpY3MuICBJ dCBuZXZlciByZXR1cm5zIE5VTEwuICAqLw0KPiArICBpZiAobnVtYmVyID09 IDAgfHwgc2l6ZSA9PSAwKQ0KPiArICAgIHsNCj4gKyAgICAgIG51bWJlciA9 IDE7DQo+ICsgICAgICBzaXplID0gMTsNCj4gKyAgICB9DQo+ICsNCj4gKyAg bWVtID0gY2FsbG9jIChudW1iZXIsIHNpemUpOyAgICAgIC8qIEFSSTogeGNh bGxvYyAqLw0KPiArICBpZiAobWVtID09IE5VTEwpDQo+ICsgICAgbWFsbG9j X2ZhaWx1cmUgKG51bWJlciAqIHNpemUpOw0KPiArDQo+ICsgIHJldHVybiBt ZW07DQo+ICt9DQo+ICsNCj4gK3ZvaWQNCj4gK3htYWxsb2NfZmFpbGVkIChz aXplX3Qgc2l6ZSkNCj4gK3sNCj4gKyAgbWFsbG9jX2ZhaWx1cmUgKHNpemUp Ow0KPiArfQ0KPiBkaWZmIC0tZ2l0IGEvZ2RiL2NvbW1vbi9jb21tb24tdXRp bHMuYyBiL2dkYi9jb21tb24vY29tbW9uLXV0aWxzLmMNCj4gaW5kZXggNzRj YTkzODEwYzcuLmRkODM5YTBkNGQxIDEwMDY0NA0KPiAtLS0gYS9nZGIvY29t bW9uL2NvbW1vbi11dGlscy5jDQo+ICsrKyBiL2dkYi9jb21tb24vY29tbW9u LXV0aWxzLmMNCj4gQEAgLTIyLDg0ICsyMiwxMiBAQA0KPiAjaW5jbHVkZSAi aG9zdC1kZWZzLmgiDQo+ICNpbmNsdWRlIDxjdHlwZS5oPg0KPiANCj4gLS8q IFRoZSB4bWFsbG9jKCkgKGxpYmliZXJ0eS5oKSBmYW1pbHkgb2YgbWVtb3J5 IG1hbmFnZW1lbnQgcm91dGluZXMuDQo+IC0NCj4gLSAgIFRoZXNlIGFyZSBs aWtlIHRoZSBJU08tQyBtYWxsb2MoKSBmYW1pbHkgZXhjZXB0IHRoYXQgdGhl eSBpbXBsZW1lbnQNCj4gLSAgIGNvbnNpc3RlbnQgc2VtYW50aWNzIGFuZCBn dWFyZCBhZ2FpbnN0IHR5cGljYWwgbWVtb3J5IG1hbmFnZW1lbnQNCj4gLSAg IHByb2JsZW1zLiAgKi8NCj4gLQ0KPiAtLyogTk9URTogVGhlc2UgYXJlIGRl Y2xhcmVkIHVzaW5nIFBUUiB0byBlbnN1cmUgY29uc2lzdGVuY3kgd2l0aA0K PiAtICAgImxpYmliZXJ0eS5oIi4gIHhmcmVlKCkgaXMgR0RCIGxvY2FsLiAg Ki8NCj4gLQ0KPiAtUFRSICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8q IEFSSTogUFRSICovDQo+IC14bWFsbG9jIChzaXplX3Qgc2l6ZSkNCj4gLXsN Cj4gLSAgdm9pZCAqdmFsOw0KPiAtDQo+IC0gIC8qIFNlZSBsaWJpYmVydHkv eG1hbGxvYy5jLiAgVGhpcyBmdW5jdGlvbiBuZWVkJ3MgdG8gbWF0Y2ggdGhh dCdzDQo+IC0gICAgIHNlbWFudGljcy4gIEl0IG5ldmVyIHJldHVybnMgTlVM TC4gICovDQo+IC0gIGlmIChzaXplID09IDApDQo+IC0gICAgc2l6ZSA9IDE7 DQo+IC0NCj4gLSAgdmFsID0gbWFsbG9jIChzaXplKTsgICAgICAgICAvKiBB Ukk6IG1hbGxvYyAqLw0KPiAtICBpZiAodmFsID09IE5VTEwpDQo+IC0gICAg bWFsbG9jX2ZhaWx1cmUgKHNpemUpOw0KPiAtDQo+IC0gIHJldHVybiB2YWw7 DQo+IC19DQo+IC0NCj4gLVBUUiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC8qIEFSSTogUFRSICovDQo+IC14cmVhbGxvYyAoUFRSIHB0ciwgc2l6 ZV90IHNpemUpICAgICAgICAgIC8qIEFSSTogUFRSICovDQo+IC17DQo+IC0g IHZvaWQgKnZhbDsNCj4gLQ0KPiAtICAvKiBTZWUgbGliaWJlcnR5L3htYWxs b2MuYy4gIFRoaXMgZnVuY3Rpb24gbmVlZCdzIHRvIG1hdGNoIHRoYXQncw0K PiAtICAgICBzZW1hbnRpY3MuICBJdCBuZXZlciByZXR1cm5zIE5VTEwuICAq Lw0KPiAtICBpZiAoc2l6ZSA9PSAwKQ0KPiAtICAgIHNpemUgPSAxOw0KPiAt DQo+IC0gIGlmIChwdHIgIT0gTlVMTCkNCj4gLSAgICB2YWwgPSByZWFsbG9j IChwdHIsIHNpemUpOwkvKiBBUkk6IHJlYWxsb2MgKi8NCj4gLSAgZWxzZQ0K PiAtICAgIHZhbCA9IG1hbGxvYyAoc2l6ZSk7CSAgICAgICAgLyogQVJJOiBt YWxsb2MgKi8NCj4gLSAgaWYgKHZhbCA9PSBOVUxMKQ0KPiAtICAgIG1hbGxv Y19mYWlsdXJlIChzaXplKTsNCj4gLQ0KPiAtICByZXR1cm4gdmFsOw0KPiAt fQ0KPiAtDQo+IC1QVFIgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyog QVJJOiBQVFIgKi8gICAgICAgICAgIA0KPiAteGNhbGxvYyAoc2l6ZV90IG51 bWJlciwgc2l6ZV90IHNpemUpDQo+IC17DQo+IC0gIHZvaWQgKm1lbTsNCj4g LQ0KPiAtICAvKiBTZWUgbGliaWJlcnR5L3htYWxsb2MuYy4gIFRoaXMgZnVu Y3Rpb24gbmVlZCdzIHRvIG1hdGNoIHRoYXQncw0KPiAtICAgICBzZW1hbnRp Y3MuICBJdCBuZXZlciByZXR1cm5zIE5VTEwuICAqLw0KPiAtICBpZiAobnVt YmVyID09IDAgfHwgc2l6ZSA9PSAwKQ0KPiAtICAgIHsNCj4gLSAgICAgIG51 bWJlciA9IDE7DQo+IC0gICAgICBzaXplID0gMTsNCj4gLSAgICB9DQo+IC0N Cj4gLSAgbWVtID0gY2FsbG9jIChudW1iZXIsIHNpemUpOyAgICAgIC8qIEFS STogeGNhbGxvYyAqLw0KPiAtICBpZiAobWVtID09IE5VTEwpDQo+IC0gICAg bWFsbG9jX2ZhaWx1cmUgKG51bWJlciAqIHNpemUpOw0KPiAtDQo+IC0gIHJl dHVybiBtZW07DQo+IC19DQo+IC0NCj4gdm9pZCAqDQo+IHh6YWxsb2MgKHNp emVfdCBzaXplKQ0KPiB7DQo+ICAgcmV0dXJuIHhjYWxsb2MgKDEsIHNpemUp Ow0KPiB9DQo+IA0KPiAtdm9pZA0KPiAteG1hbGxvY19mYWlsZWQgKHNpemVf dCBzaXplKQ0KPiAtew0KPiAtICBtYWxsb2NfZmFpbHVyZSAoc2l6ZSk7DQo+ IC19DQo+IC0NCj4gLyogTGlrZSBhc3ByaW50Zi92YXNwcmludGYgYnV0IGdl dCBhbiBpbnRlcm5hbF9lcnJvciBpZiB0aGUgY2FsbA0KPiAgICBmYWlscy4g Ki8NCj4gDQo+IGRpZmYgLS1naXQgYS9nZGIvZ2Ric2VydmVyL01ha2VmaWxl LmluIGIvZ2RiL2dkYnNlcnZlci9NYWtlZmlsZS5pbg0KPiBpbmRleCBmNWZj NTUwMzRlZS4uYTA3OTNlNjU3YzUgMTAwNjQ0DQo+IC0tLSBhL2dkYi9nZGJz ZXJ2ZXIvTWFrZWZpbGUuaW4NCj4gKysrIGIvZ2RiL2dkYnNlcnZlci9NYWtl ZmlsZS5pbg0KPiBAQCAtMTk3LDYgKzE5Nyw3IEBAIFNGSUxFUyA9IFwNCj4g CSQoc3JjZGlyKS9hcmNoL2FybS1nZXQtbmV4dC1wY3MuYyBcDQo+IAkkKHNy Y2RpcikvYXJjaC9hcm0tbGludXguYyBcDQo+IAkkKHNyY2RpcikvYXJjaC9w cGMtbGludXgtY29tbW9uLmMgXA0KPiArCSQoc3JjZGlyKS8uLi9hbGxvYy5j IFwNCj4gCSQoc3JjZGlyKS9jb21tb24vYnRyYWNlLWNvbW1vbi5jIFwNCj4g CSQoc3JjZGlyKS9jb21tb24vYnVmZmVyLmMgXA0KPiAJJChzcmNkaXIpL2Nv bW1vbi9jbGVhbnVwcy5jIFwNCj4gQEAgLTIzOCw2ICsyMzksNyBAQCBTT1VS Q0VTID0gJChTRklMRVMpDQo+IFRBR0ZJTEVTID0gJChTT1VSQ0VTKSAke0hG SUxFU30gJHtBTExQQVJBTX0gJHtQT1NTTElCU30NCj4gDQo+IE9CUyA9IFwN Cj4gKwlhbGxvYy5vIFwNCj4gCWF4Lm8gXA0KPiAJY29tbW9uL2FnZW50Lm8g XA0KPiAJY29tbW9uL2J0cmFjZS1jb21tb24ubyBcDQo+IEBAIC00MTMsNiAr NDE1LDcgQEAgZ2RicmVwbGF5JChFWEVFWFQpOiAkKHNvcnQgJChHREJSRVBM QVlfT0JTKSkgJChMSUJHTlUpICQoTElCSUJFUlRZKQ0KPiAJCSQoTElCSUJF UlRZKQ0KPiANCj4gSVBBX09CSlMgPSBcDQo+ICsJYWxsb2MtaXBhLm8gXA0K PiAJYXgtaXBhLm8gXA0KPiAJY29tbW9uL2NvbW1vbi11dGlscy1pcGEubyBc DQo+IAljb21tb24vZXJyb3JzLWlwYS5vIFwNCj4gQEAgLTU2OCw2ICs1NzEs MTAgQEAgYXgubzogYXguYw0KPiAJJChDT01QSUxFKSAkKFdBUk5fQ0ZMQUdT X05PX0ZPUk1BVCkgJDwNCj4gCSQoUE9TVENPTVBJTEUpDQo+IA0KPiArYWxs b2MtaXBhLm86IC4uL2FsbG9jLmMNCj4gKwkkKElQQUdFTlRfQ09NUElMRSkg JChXQVJOX0NGTEFHU19OT19GT1JNQVQpICQ8DQo+ICsJJChQT1NUQ09NUElM RSkNCj4gKw0KPiAjIFJ1bGVzIGZvciBvYmplY3RzIHRoYXQgZ28gaW4gdGhl IGluLXByb2Nlc3MgYWdlbnQuDQo+IA0KPiBhcmNoLyUtaXBhLm86IC4uL2Fy Y2gvJS5jDQo+IEBAIC02MjMsNiArNjMwLDEwIEBAIGNvbW1vbi8lLm86IC4u L2NvbW1vbi8lLmMNCj4gCSQoQ09NUElMRSkgJDwNCj4gCSQoUE9TVENPTVBJ TEUpDQo+IA0KPiArJS5vOiAuLi8lLmMNCj4gKwkkKENPTVBJTEUpICQ8DQo+ ICsJJChQT1NUQ09NUElMRSkNCj4gKw0KPiAjIFJ1bGVzIGZvciByZWdpc3Rl ciBmb3JtYXQgZGVzY3JpcHRpb25zLiAgU3VmZml4IGRlc3RpbmF0aW9uIGZp bGVzIHdpdGgNCj4gIyAtZ2VuZXJhdGVkIHRvIGlkZW50aWZ5IGFuZCBjbGVh biB0aGVtIGVhc2lseS4NCj4gDQo+IC0tIA0KPiAyLjE3LjINCj4gDQoNCg== >From gdb-patches-return-156836-listarch-gdb-patches=sources.redhat.com@sourceware.org Mon Jun 17 16:21:07 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 45932 invoked by alias); 17 Jun 2019 16:21:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 45922 invoked by uid 89); 17 Jun 2019 16:21:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=translate X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jun 2019 16:21:04 +0000 Received: by mail-wm1-f65.google.com with SMTP id u8so38596wmm.1 for ; Mon, 17 Jun 2019 09:21:03 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id e11sm11982483wrc.9.2019.06.17.09.21.00 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 09:21:01 -0700 (PDT) Subject: Re: [PATCH] Introduce the "with" command To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20190614193759.21029-1-palves@redhat.com> <1560723550.1815.1.camel@skynet.be> From: Pedro Alves Message-ID: <3cf7202f-017c-b7a3-5380-92c357172917@redhat.com> Date: Mon, 17 Jun 2019 16:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1560723550.1815.1.camel@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-06/txt/msg00310.txt.bz2 Content-length: 2769 On 6/16/19 11:19 PM, Philippe Waroquiers wrote: > I quickly read the patch, and played a little bit with it > > 2 minor comments below. > > Only one (minor) strange behaviour: 'out of range' encountered in > the below 'nested' case: > (gdb) w print repeats unlimited -- w print repeats 1 -- p "1223334444" > $18 = "1", '2' , '3' , '4' > integer 4294967295 out of range Oh, thanks for catching that. The reason is that a user can type 0 to mean "unlimited", but, "unlimited" is stored internally as -1, which is 4294967295 in unsigned int. The patch is currently passing the internal "-1" directly to the set command. We need to translate the -1 back to "unlimited" or 0. We already have code to do that in do_show_command, so I'll reuse it. As for testing, I'm going to tweak the recently added "maint test-settings set/show" commands, rename them to "maint set/show test-settings", and then I'll add a "maint with" command, which is just like "with", but works with "maint set" settings. This will allow testing all kind of different combinations similarly to your example above, like: (gdb) maint with test-settings uinteger unlimited -- maint with test-settings uinteger 1 (gdb) maint with test-settings uinteger 1 -- maint with test-settings uinteger unlimited and it'll be easy to do the same thing for all types of settings (var_uinteger, var_zuinteger, var_string, etc.). > > with set thank-you on -- echo It looks really nice :) Cool. :-) > > Philippe > > > On Fri, 2019-06-14 at 20:37 +0100, Pedro Alves wrote: >> * printcmd.c: Include "top.h", "cli/cli-decode.h", and >> "cli/cli-setshow.h". >> (with_command, with_command_completer): New. >> (_initialize_printcmd): Install the "with" command and its "w" >> alias. > It is slightly unexpected to have the with_command in the printcmd.c > file, but I found no real good alternate place, as cli-setshow.c > does not define any command, it just provides support to the "set" > and "show" commands. Yeah. I put it here, because it's where the set_command is defined, I guess because "set" has a double purpose of being a prefix command, and implementing "set VAR = EXP". See just above with_command. show_command is in cli-cmds.c, I suppose we could put "with" there. > > >> diff --git a/gdb/printcmd.c b/gdb/printcmd.c > .... > with_command_completer is not mentioned in valprint.h, > and can be static I think. >> +/* See valprint.h. */ >> + >> +void >> +with_command_completer (struct cmd_list_element *ignore, >> + completion_tracker &tracker, >> + const char *text, const char * /*word*/) Thanks, will fix, though I'll need to export a version of this for "maint with" in the new version. Thanks, Pedro Alves