From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68707 invoked by alias); 24 May 2017 10:20:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68607 invoked by uid 89); 24 May 2017 10:20:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Meanwhile, Hx-languages-length:2103 X-HELO: EUR03-DB5-obe.outbound.protection.outlook.com Received: from mail-eopbgr40074.outbound.protection.outlook.com (HELO EUR03-DB5-obe.outbound.protection.outlook.com) (40.107.4.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 May 2017 10:20:26 +0000 Received: from DB3PR08MB0106.eurprd08.prod.outlook.com (10.161.56.20) by DB3PR08MB0107.eurprd08.prod.outlook.com (10.161.56.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14; Wed, 24 May 2017 10:20:27 +0000 Received: from DB3PR08MB0106.eurprd08.prod.outlook.com ([fe80::890e:6062:a061:5234]) by DB3PR08MB0106.eurprd08.prod.outlook.com ([fe80::890e:6062:a061:5234%14]) with mapi id 15.01.1101.019; Wed, 24 May 2017 10:20:27 +0000 From: Alan Hayward To: Pedro Alves CC: Yao Qi , "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 3/11] Add MIPS_MAX_REGISTER_SIZE (2/4) Date: Wed, 24 May 2017 10:20:00 -0000 Message-ID: References: <3C00280E-37C9-4C0A-9DA6-F3B9DB1A6E8F@arm.com> <86y3v7uf9j.fsf@gmail.com> <806B436F-EFA1-4200-AC54-9036D166C9B9@arm.com> <867f1m8nhm.fsf@gmail.com> <8637bx9jsw.fsf@gmail.com> <78A7E8EA-7203-44DF-B7FD-63E75A5ECEF5@arm.com> <540372d8-efc3-f842-5cac-cd813bacc3f5@redhat.com> <4F90CD36-759D-4BDA-BFEC-8DD86F44A0B7@arm.com> <40597975-9458-e9af-8915-9d303bb1ed98@redhat.com> In-Reply-To: <40597975-9458-e9af-8915-9d303bb1ed98@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB3PR08MB0107;7:I6PSEh2of73GGeFEy7fr98hDZ8yy8psWoq+SxmyLzqGTdmg0dxS4rXwnJYKgKmVIAFbwuMzXI2Ldij5QdosWNiGQYPNWuPJoLm4UhzFxICBIYsPAwH5H3bmtLuOwzpZ5Vu4A9PFn4t8uTT/jkq4DF/Wqv8e3I3lQsOP8+EOasLRvDIAEPlMdZAtAGBg2+KhXimBkbGrKf6dyJYvHJciV4TsdpXSKmE+nfaPAansCBlUkbMVoM2hU+GQ3PKxj9g4JLCCt+Ix3ud+eSinu4xkTo3T2MFb79IHHgBsOJukREraHP2AG3rE2y5f13NcBVFcGTdbVnszn3M/N6/XfC6Zsbw== x-ms-traffictypediagnostic: DB3PR08MB0107: x-ms-office365-filtering-correlation-id: 6c9672cf-2467-4636-36de-08d4a28e7f51 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:DB3PR08MB0107; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123560025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148);SRVR:DB3PR08MB0107;BCL:0;PCL:0;RULEID:;SRVR:DB3PR08MB0107; x-forefront-prvs: 031763BCAF x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39860400002)(39840400002)(39450400003)(24454002)(377454003)(2950100002)(2900100001)(6916009)(189998001)(478600001)(36756003)(5660300001)(53546009)(25786009)(305945005)(7736002)(86362001)(82746002)(72206003)(83716003)(4326008)(6486002)(6512007)(5250100002)(53936002)(39060400002)(2906002)(33656002)(6506006)(81166006)(93886004)(3660700001)(54356999)(8936002)(8676002)(6116002)(66066001)(6246003)(229853002)(54906002)(3846002)(99286003)(38730400002)(3280700002)(76176999)(50986999)(110136004)(6436002)(102836003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR08MB0107;H:DB3PR08MB0106.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2017 10:20:26.7059 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB0107 X-SW-Source: 2017-05/txt/msg00521.txt.bz2 DQo+IE9uIDI0IE1heSAyMDE3LCBhdCAxMDoyMCwgUGVkcm8gQWx2ZXMgPHBh bHZlc0ByZWRoYXQuY29tPiB3cm90ZToNCj4gDQo+IE9uIDA1LzI0LzIwMTcg MTA6MDcgQU0sIEFsYW4gSGF5d2FyZCB3cm90ZToNCj4gDQo+Pj4gSG1tLCBJ IHRoaW5rIHlvdSBtYXkgaGF2ZSBtaXN1bmRlcnN0b29kLiAgVGhlIG1haW4g cG9pbnQgd2FzIHRvDQo+Pj4gYXZvaWQgaGF2aW5nIHRvIGhhdmUgVC9MT05H RVNUIHRlbXBvcmFyeSBhdCBhbGwgaGVyZToNCj4gDQo+IC4uLg0KPiANCj4+ PiANCj4+PiBhbmQgbWF5YmUgdGhlIG5lZWQgZm9yIGFsbCB0aGUgdGVtcGxh dGluZy4NCj4+PiANCj4+IA0KPj4gV291bGQgc3RpbGwgbmVlZCB0byBoYXZl IGVhdGVyIHNpZ25lZC91bnNpZ25lZCB2ZXJzaW9ucyBvZiB0aGUgZnVuY3Rp b25zLA0KPj4gb3IgbWF5YmUgaGF2ZSDigJxib29sIHNpZ25lZOKAnSBwYXJh bWV0ZXIuDQo+IA0KPiBQYXJhbWV0ZXIgc291bmRzIGZpbmUgdG8gbWUuDQo+ IA0KPj4gQXJlIHlvdSBzdWdnZXN0aW5nIHNvbWV0aGluZyBsaWtlIHRoaXM6 DQo+PiAoV2FybmluZyAtIHRoaXMgc25pcHBldCBtYXkgbm90IGV2ZW4gY29t cGlsZSwgYW5kIEnigJltIG5vdCBzdXJlIG9uIHRoZSBlbmRpYW4NCj4+IGxv Z2ljKQ0KPiANCj4gWWVzLCBleGFjdGx5LiAgV0RZVD8NCg0KSeKAmW0gaGFw cHkgaW4gcHJpbmNpcGxlIHdpdGggaXQgKGFmdGVyIGZpeCB1cHMpDQoNCj4g DQo+PiBNZWFud2hpbGUgcmF3X2NvbGxlY3RfaW50ZWdlciBkb2VzbuKAmXQg bmVlZCBhIHNpZ25lZCBwYXJhbWV0ZXI6DQo+IA0KPiBXb3VsZG4ndCB3ZSBu ZWVkIHRvIHN1cHBvcnQgQUREUl9MRU4gbGFyZ2VyIHRoYW4gdGhlIHJlZ2lz dGVyIHNpemU/DQoNClRoaXMgbWlnaHQgYmUgbWUgbWlzdW5kZXJzdGFuZGlu ZyBnZGIsDQpCdXQgSSBhc3N1bWVkIHRoYXQgYWRkciB3b3VsZCBhbHdheXMg YmUgc2hvcnRlciB0aGFuIHRoZSByZWdpc3RlciBzaXplLg0KSWYgYWRkciBp cyBiaWdnZXIgdGhhbiB0aGUgcmVnaXN0ZXIgc2l6ZSB0aGVuIHRoZSBtb3N0 IHNpZ25pZmljYW50IGJpdHMgd2lsbA0KYmUgY2hvcHBlZCBvZmYgKGluY2x1 ZGluZyB0aGUgc2lnbiksIHdoaWNoIEkgdGhpbmsgd291bGQgYmUgYSBiYWQg aWRlYT8NCg0KDQo+IA0KPiBPbiAyNCBNYXkgMjAxNywgYXQgMTA6MjksIFBl ZHJvIEFsdmVzIDxwYWx2ZXNAcmVkaGF0LmNvbT4gd3JvdGU6DQo+IA0KPiBP biAwNS8yNC8yMDE3IDEwOjA3IEFNLCBBbGFuIEhheXdhcmQgd3JvdGU6DQo+ PiAvKiBDb3B5IENPUFlfTEVOIGJ5dGVzIGZyb20gU09VUkNFIHRvIERFU1Qs IHRoZW4gc2lnbiBleHRlbmQgb3IgemVybyBleHRlbmQNCj4+ICAgdG8gRklM TF9MRU4gYnl0ZXMuICAqLw0KPj4gdm9pZCBjb3B5X2FuZF9maWxsX3RvX3Np emUgKGNvbnN0IGdkYl9ieXRlICpkZXN0LCBjb25zdCBnZGJfYnl0ZSAqc291 cmNlLA0KPj4gCQkJICAgIGludCBjb3B5X2xlbiwgaW50IGZpbGxfbGVuLCBi b29sIGlzX3NpZ25lZCwNCj4+IAkJCSAgICBlbnVtIGJmZF9lbmRpYW4gYnl0 ZV9vcmRlcikNCj4+IHsNCj4+ICBzaWduZWQgaW50IGxlbl9kaWZmID0gZmls bF9sZW4gLSBjb3B5X2xlbjsNCj4+ICBnZGJfYXNzZXJ0IChsZW5fZGlmZiA+ PSAwKTsNCj4+IA0KPj4gIGlmIChieXRlX29yZGVyID09IEJGRF9FTkRJQU5f QklHKQ0KPj4gICAgbWVtY3B5IChkZXN0K2xlbl9kaWZmLCBzb3VyY2UsIGNv cHlfbGVuKTsNCj4+ICBlbHNlDQo+PiAgICBtZW1jcHkgKGRlc3QsIHNvdXJj ZSwgY29weV9sZW4pOw0KPiANCj4gTm90ZSBoZXJlIEkgd2FzIHRoaW5raW5n IHlvdSdkIG5lZWQgdG8gaGFuZGxlIHRydW5jYXRpb24gYXMgd2VsbC4NCj4g SS5lLiwgb25seSBjb3B5IGZpbGxfbGVuIGJ5dGVzIHdoZW4gZmlsbF9sZW4g aXMgbmFycm93ZXIgdGhhbg0KPiBjb3B5X2xlbi4gIFNvIEknZCBwcm9iYWJs eSByZW5hbWUgY29weV9sZW4vZmlsbF9sZW4gdG8gZGVzdF9sZW4vc291cmNl X2xlbg0KPiB0byBtYXRjaCAnZGVzdCcgYW5kICdzb3VyY2UnLCBhbmQgbmFt ZSB0aGUgZnVuY3Rpb24gc29tZXRoaW5nDQo+IGVsc2UgdGhhdCBkb2Vzbid0 IGhhdmUgImZpbGwiIGluIGl0Lg0KDQpBZ3JlZWQgKHJlZ2FyZGxlc3Mgb2Yg dGhlIG91dGNvbWUgZm9yIHRoZSBwcmV2aW91cyBxdWVzdGlvbikuDQoNCg0K QWxhbi4NCg0KDQo= >From gdb-patches-return-139262-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed May 24 11:07:39 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 112349 invoked by alias); 24 May 2017 11:07:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 112329 invoked by uid 89); 24 May 2017 11:07:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy=transfers, unheard X-HELO: mail-wm0-f53.google.com Received: from mail-wm0-f53.google.com (HELO mail-wm0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 24 May 2017 11:07:37 +0000 Received: by mail-wm0-f53.google.com with SMTP id d127so63991224wmf.0 for ; Wed, 24 May 2017 04:07:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=7BzJY3PyPeS5u2UqU0fhE09ZP/93lkEpf2uzikX/S34=; b=i3eJJaGlkjOf8RDeJ6kWQSn4954mk2jwhuD2gGiHCZv1d7u4br6L7BMTc/gba3bKsz PeS5p5IrFBvd0TkKVb9B9LQWMy9mpR/ddxMKfUo5kFu5U5YCMb6VXZujMxY0HBlH4C0H 2VvAmo4ZSPLilZ5fUGuUPfUxGQogGu/X1wJB9J8eE9xN0IKk5yzRH1sWc3Z2Q4ta+s7P Adpa9UNTvGO1KKh5d5EG76dhaL5WEsJMtJlYrQJGflJoSQBlN80N+vjkHOs8peJV384s mzNdSPXvWFY6NqTvyXkpkJAT/NrFAj8gxtaKSDLiEbyjA+tD2P39vnZPzi4pdDqTwZbg VoSg== X-Gm-Message-State: AODbwcC3KnOzSx6ope0ePk/EMnvSqgTlorEaoIDmWGXA/pef4MP1JQJE 1Fwk50wMV/UTJRtT X-Received: by 10.28.24.207 with SMTP id 198mr5391823wmy.86.1495624057987; Wed, 24 May 2017 04:07:37 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id y60sm5322483wrb.39.2017.05.24.04.07.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 May 2017 04:07:37 -0700 (PDT) Subject: Re: [PATCH 3/11] Add MIPS_MAX_REGISTER_SIZE (2/4) To: Alan Hayward References: <3C00280E-37C9-4C0A-9DA6-F3B9DB1A6E8F@arm.com> <86y3v7uf9j.fsf@gmail.com> <806B436F-EFA1-4200-AC54-9036D166C9B9@arm.com> <867f1m8nhm.fsf@gmail.com> <8637bx9jsw.fsf@gmail.com> <78A7E8EA-7203-44DF-B7FD-63E75A5ECEF5@arm.com> <540372d8-efc3-f842-5cac-cd813bacc3f5@redhat.com> <4F90CD36-759D-4BDA-BFEC-8DD86F44A0B7@arm.com> <40597975-9458-e9af-8915-9d303bb1ed98@redhat.com> Cc: Yao Qi , "gdb-patches@sourceware.org" , nd From: Pedro Alves Message-ID: Date: Wed, 24 May 2017 11:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-05/txt/msg00522.txt.bz2 Content-length: 1573 On 05/24/2017 11:20 AM, Alan Hayward wrote: >>> Meanwhile raw_collect_integer doesn’t need a signed parameter: >> >> Wouldn't we need to support ADDR_LEN larger than the register size? > > This might be me misunderstanding gdb, > But I assumed that addr would always be shorter than the register size. > If addr is bigger than the register size then the most significant bits will > be chopped off (including the sign), which I think would be a bad idea? Yeah, the case of a 32-bit register being given a 64-bit slot in a ptrace register buffer is actually not unheard of. For example the segment registers on x86-64 (cs, ss, ds, etc.) are 32-bit in gdb's register cache, but Linux ptrace transfers them as 64-bit [see /usr/include/sys/reg.h]. I'm not exactly sure whether in such cases we end up needing to sign/zero extend when copying back, or whether the kernel ignores the upper bits. I think that on x86 we just copy the lower 4 bytes and leave the upper ones as they were, so probably the latter. The MIPS architecture is special around addresses being signed though, and given the existing code, I'd play it safe and keep the collect/store functions mirrors - if one truncates, the other fills/extends, and vice versa. There's also /* Is the target using 64-bit raw integer registers but only storing a left-aligned 32-bit value in each? */ int mips64_transfers_32bit_regs_p; which most probably doesn't apply in this case (FreeBSD, while I think that was originally added for remote), but it compounds in the weirdness. Thanks, Pedro Alves