From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8711 invoked by alias); 5 Apr 2017 18:10:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8684 invoked by uid 89); 5 Apr 2017 18:10:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*RU:15.01.1005.020, H*r:15.01.1005.020, Hx-spam-relays-external:15.01.1005.020 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0046.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 18:10:12 +0000 Received: from DB3PR08MB0106.eurprd08.prod.outlook.com (10.161.56.20) by DB3PR08MB0105.eurprd08.prod.outlook.com (10.161.56.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Wed, 5 Apr 2017 18:10:09 +0000 Received: from DB3PR08MB0106.eurprd08.prod.outlook.com ([fe80::ecab:57c3:6de6:7bde]) by DB3PR08MB0106.eurprd08.prod.outlook.com ([fe80::ecab:57c3:6de6:7bde%16]) with mapi id 15.01.1005.020; Wed, 5 Apr 2017 18:10:10 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from regcache.c Date: Wed, 05 Apr 2017 18:10:00 -0000 Message-ID: References: <562B2F6F-F3C6-4A76-9489-57539F396C94@arm.com> <868tnvukjh.fsf@gmail.com> <7359B5C0-BF61-42E2-9886-B322C1825865@arm.com> <0DADF920-69B9-4F96-A153-6965E56B5DA8@arm.com> <868tneq1xj.fsf@gmail.com> In-Reply-To: <868tneq1xj.fsf@gmail.com> authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-microsoft-exchange-diagnostics: 1;DB3PR08MB0105;7:LAOIEolCwM8hMq1eP8KvG9+/y5Ic+cIWbrw/XMmZW1JKf0//nd7pyN0CUp9rbDQLTmr563ZJg+FLqzEhZlL18rPqqc/+pySKgfWj9PKNVuL2bSRxvhg+vqpPrN8GlMfhx/kWJCDquJI0M+VEdWSLnlFGnJ5jUHjOTYkT58IgGvu0rtB+Jeuf1/R+JZ/lTNFQNJTy4XzL4Gunrp6/xFpOjWe47mx1QzDVCeTOm4QNaHeyYuPo12T3WGTQX7AS1IP9TweCLV9neZVAo3HSr7uMXqreu/Jd9M04Bk9vjDW1j+opn4PJsNte9PKUKsf0q1wEoCvdnuVclJpnrTHY3YfYrg== x-ms-office365-filtering-correlation-id: 751e746a-0473-4ec6-54a5-08d47c4eff83 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081);SRVR:DB3PR08MB0105; nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(6072148);SRVR:DB3PR08MB0105;BCL:0;PCL:0;RULEID:;SRVR:DB3PR08MB0105; x-forefront-prvs: 0268246AE7 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39850400002)(39860400002)(39840400002)(39450400003)(39400400002)(24454002)(54906002)(6506006)(1411001)(86362001)(39060400002)(50986999)(6246003)(54356999)(53936002)(76176999)(99286003)(6436002)(6486002)(189998001)(4326008)(5250100002)(2900100001)(229853002)(110136004)(38730400002)(6512007)(82746002)(66066001)(6916009)(36756003)(2950100002)(8676002)(81166006)(3660700001)(83716003)(3280700002)(25786009)(8936002)(53546009)(305945005)(7736002)(2906002)(3846002)(93886004)(6116002)(102836003)(5660300001)(33656002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB3PR08MB0105;H:DB3PR08MB0106.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <1C5750CB29601A41A665A92C7B492586@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2017 18:10:09.8970 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR08MB0105 X-SW-Source: 2017-04/txt/msg00123.txt.bz2 DQo+IE9uIDUgQXByIDIwMTcsIGF0IDE3OjAwLCBZYW8gUWkgPHFpeWFvbHRj QGdtYWlsLmNvbT4gd3JvdGU6DQoNCjxzbmlwIE1zcDQzMCBhbmQgbmRzMzIg Y2hhbmdlcz4NCk1vdmVkIHRoZXNlIG91dCB0byBhIGRpZmZlcmVudCBwYXRj aA0KDQo+PiBAQCAtMzc5LDcgKzM4OCw3IEBAIHJlZ2NhY2hlX3Jlc3RvcmUg KHN0cnVjdCByZWdjYWNoZSAqZHN0LA0KPj4gCQkgIHZvaWQgKmNvb2tlZF9y ZWFkX2NvbnRleHQpDQo+PiB7DQo+PiAgIHN0cnVjdCBnZGJhcmNoICpnZGJh cmNoID0gZHN0LT5kZXNjci0+Z2RiYXJjaDsNCj4+IC0gIGdkYl9ieXRlIGJ1 ZltNQVhfUkVHSVNURVJfU0laRV07DQo+PiArICBzdGQ6OnZlY3RvcjxnZGJf Ynl0ZT4gYnVmIChtYXhfcmVnaXN0ZXJfc2l6ZSAoZ2RiYXJjaCkpOw0KPj4g ICBpbnQgcmVnbnVtOw0KPj4gDQo+PiAgIC8qIFRoZSBkc3QgaGFkIGJldHRl ciBub3QgYmUgcmVhZC1vbmx5LiAgSWYgaXQgaXMsIHRoZSBgcmVzdG9yZScN Cj4+IEBAIC0zOTUsOSArNDA0LDkgQEAgcmVnY2FjaGVfcmVzdG9yZSAoc3Ry dWN0IHJlZ2NhY2hlICpkc3QsDQo+PiAJew0KPj4gCSAgZW51bSByZWdpc3Rl cl9zdGF0dXMgc3RhdHVzOw0KPiANCj4gQ2FuIHdlIG1vdmUgImJ1ZiIgaGVy ZT8gYW5kIGluaXRpYWxpemUgaXQgd2l0aCB0aGUgcmVnaXN0ZXJfc2l6ZSwN Cj4gDQo+ICAgICAgICAgICBzdGQ6OnZlY3RvcjxnZGJfYnl0ZT4gYnVmIChy ZWdpc3Rlcl9zaXplIChnZGJhcmNoLCByZWdudW0pKTsNCj4gDQo+IHRoZW4s IHdlIGRvbid0IG5lZWQgbWF4X3JlZ2lzdGVyX3NpemUgKCkuDQo+IA0KDQpQ cm9ibGVtIHdpdGggdGhpcyBpcyB0aGF0IHdlIGFyZSB0aGVuIGNyZWF0aW5n IGEgYnJhbmQgbmV3IGJ1ZmZlciBmb3IgZWFjaA0KaXRlcmF0aW9uIG9mIHRo ZSBsb29wLCB3aGljaCBpcyBhIGxpdHRsZSBoZWF2eXdlaWdodC4NCldlIGNv dWxkIGNyZWF0ZSBhbiBlbXB0eSBidWYgb3V0c2lkZSB0aGUgbG9vcCBhbmQg cmUtc2l6ZSBpdCBlYWNoIGl0ZXJhdGlvbiwNCmJ1dCB0aGF0J3Mgc3RpbGwg Z29pbmcgdG8gY29zdC4NCg0KV2UnbGwgc3RpbGwgbmVlZCB0byBrZWVwIG1h eF9yZWdpc3Rlcl9zaXplICgpIGlmIHdlIHdhbnQgdG8gYWRkIGNoZWNrcw0K dGhhdCB0aGUgRk9PX01BWF9SRUdJU1RFUiBzaXplIGRlZmluZXMgYXJlIGJp ZyBlbm91Z2guDQooc2VlIHRoZSBCRklOX01BWF9SRUdJU1RFUl9TSVpFIGVt YWlsIHRocmVhZCkNCg0KDQoNCj4+IEBAIC0xNDgwLDE3ICsxNDg4LDE5IEBA IHJlZ2NhY2hlX2R1bXAgKHN0cnVjdCByZWdjYWNoZSAqcmVnY2FjaGUsIHN0 cnVjdCB1aV9maWxlICpmaWxlLA0KPj4gCSAgICBmcHJpbnRmX3VuZmlsdGVy ZWQgKGZpbGUsICJDb29rZWQgdmFsdWUiKTsNCj4+IAkgIGVsc2UNCj4+IAkg ICAgew0KPj4gLQkgICAgICBlbnVtIHJlZ2lzdGVyX3N0YXR1cyBzdGF0dXM7 DQo+PiArCSAgICAgIHN0cnVjdCB2YWx1ZSAqdmFsdWUgPSByZWdjYWNoZV9j b29rZWRfcmVhZF92YWx1ZSAocmVnY2FjaGUsDQo+PiArCQkJCQkJCQlyZWdu dW0pOw0KPj4gDQo+PiAtCSAgICAgIHN0YXR1cyA9IHJlZ2NhY2hlX2Nvb2tl ZF9yZWFkIChyZWdjYWNoZSwgcmVnbnVtLCBidWYpOw0KPj4gLQkgICAgICBp ZiAoc3RhdHVzID09IFJFR19VTktOT1dOKQ0KPj4gLQkJZnByaW50Zl91bmZp bHRlcmVkIChmaWxlLCAiPGludmFsaWQ+Iik7DQo+PiAtCSAgICAgIGVsc2Ug aWYgKHN0YXR1cyA9PSBSRUdfVU5BVkFJTEFCTEUpDQo+PiArCSAgICAgIGlm ICh2YWx1ZV9vcHRpbWl6ZWRfb3V0ICh2YWx1ZSkNCj4+ICsJCSAgfHwgIXZh bHVlX2VudGlyZWx5X2F2YWlsYWJsZSAodmFsdWUpKQ0KPj4gCQlmcHJpbnRm X3VuZmlsdGVyZWQgKGZpbGUsICI8dW5hdmFpbGFibGU+Iik7DQo+IA0KPiBJ dCBpcyBzdGlsbCBub3QgcmlnaHQgdG8gbWUuICBXaXRoIHlvdXIgY2hhbmdl cyB0byBtc3A0MzAgYW5kIG5kczMyLCB3ZQ0KPiB3b24ndCBnZXQgUkVHX1VO S05PV04gZm9yIHBzZXVkbyByZWdpc3RlcnMsIGJ1dCB3ZSBtYXkgc3RpbGwg Z2V0DQo+IFJFR19VTktOT1dOIGZyb20gcmF3IHJlZ2lzdGVycyAoZnJvbSBy ZWdjYWNoZS0+cmVnaXN0ZXJfc3RhdHVzW10pLiAgSG93DQo+IGlzIHRoaXM/ DQo+IA0KPiAgZ2RiX2J5dGUgKmJ1ZiA9IE5VTEw7DQo+ICBlbnVtIHJlZ2lz dGVyX3N0YXR1cyBzdGF0dXM7DQo+ICBzdHJ1Y3QgdmFsdWUgKiB2YWx1ZSA9 IE5VTEw7DQo+IA0KPiAgaWYgKHJlZ251bSA8IHJlZ2NhY2hlLT5kZXNjci0+ bnJfcmF3X3JlZ2lzdGVycykNCj4gICAgew0KPiAgICAgIHJlZ2NhY2hlX3Jh d191cGRhdGUgKHJlZ2NhY2hlLCByZWdudW0pOw0KPiANCj4gICAgICBzdGF0 dXMgPSByZWdjYWNoZS0+cmVnaXN0ZXJfc3RhdHVzW3JlZ251bV07DQo+ICAg ICAgYnVmID0gcmVnaXN0ZXJfYnVmZmVyIChyZWdjYWNoZSwgcmVnbnVtKTsN Cj4gICAgfQ0KPiAgZWxzZQ0KPiAgIHsNCj4gICAgICB2YWx1ZSA9IHJlZ2Nh Y2hlX2Nvb2tlZF9yZWFkX3ZhbHVlIChyZWdjYWNoZSwgcmVnbnVtKTsNCj4g DQo+ICAgICAgaWYgKHZhbHVlX2VudGlyZWx5X2F2YWlsYWJsZSAodmFsdWUp KQ0KPiAgICAgICAgew0KPiAgICAgICAgICBzdGF0dXMgPSBSRUdfVkFMSUQ7 DQo+ICAgICAgICAgIGJ1ZiA9IHZhbHVlX2NvbnRlbnRzX2FsbCAodmFsdWUp Ow0KPiAgICAgICAgfQ0KPiAgICAgIGVsc2UNCj4gICAgICAgIHN0YXR1cyA9 IFJFR19SRUdfVU5BVkFJTEFCTEU7DQo+ICAgfQ0KPiANCj4gICBpZiAoc3Rh dHVzID09IFJFR19VTktOT1dOKQ0KPiAgICAgIGZwcmludGZfdW5maWx0ZXJl ZCAoZmlsZSwgIjxpbnZhbGlkPiIpOw0KPiAgIGVsc2UgaWYgKHN0YXR1cyA9 PSBSRUdfVU5BVkFJTEFCTEUpDQo+ICAgICAgZnByaW50Zl91bmZpbHRlcmVk IChmaWxlLCAiPHVuYXZhaWxhYmxlPiIpOw0KPiAgIGVsc2UNCj4gICAgICAg cHJpbnRfaGV4X2NoYXJzIChmaWxlLCBidWYsDQo+IAkJCSByZWdjYWNoZS0+ ZGVzY3ItPnNpemVvZl9yZWdpc3RlcltyZWdudW1dLA0KPiAJCQkgZ2RiYXJj aF9ieXRlX29yZGVyIChnZGJhcmNoKSk7DQo+IA0KPiAgIGlmICh2YWx1ZSAh PSBOVUxMKQ0KPiAgICB7DQo+ICAgICAgcmVsZWFzZV92YWx1ZSAodmFsdWUp Ow0KPiAgICAgIHZhbHVlX2ZyZWUgKHZhbHVlKTsNCj4gICAgfQ0KPiANCg0K WWVzLCBJ4oCZbGwgYWRkIHRob3NlIGNoYW5nZXMuDQoNCg== >From gdb-patches-return-138040-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Apr 05 18:23:23 2017 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 70682 invoked by alias); 5 Apr 2017 18:23:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 70652 invoked by uid 89); 5 Apr 2017 18:23:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Apr 2017 18:22:59 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E7851C04BD48 for ; Wed, 5 Apr 2017 18:22:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E7851C04BD48 Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E7851C04BD48 Received: from cascais.lan (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4BFFF18997 for ; Wed, 5 Apr 2017 18:22:57 +0000 (UTC) From: Pedro Alves To: gdb-patches@sourceware.org Subject: [pushed] -Wwrite-strings: Fix Solaris "set procfs-file" Date: Wed, 05 Apr 2017 18:23:00 -0000 Message-Id: <1491416576-9775-1-git-send-email-palves@redhat.com> X-SW-Source: 2017-04/txt/msg00124.txt.bz2 Content-length: 2610 Compiling GDB with -Wwrite-strings flags this code in gdb/proc-api.c: static char *procfs_filename = "procfs_trace"; as needing a cast. However, this variable is a command variable, and as such it's incorrect to initialize it to a literal, since when you use the corresponding set command, gdb frees the old string... I didn't manage to fully build Solaris gdb (fails for other reasons), but I confirmed that the system GDB on Solaris 11 crashes when running this command: (gdb) set procfs-file foo Segmentation Fault (core dumped) So I don't think this commit can make it worse than the status quo. gdb/ChangeLog: 2017-04-05 Pedro Alves * proc-api.c (procfs_filename): Don't initialize procfs_filename. (prepare_to_trace): Assume procfs_filename is non-NULL. (_initialize_proc_api): Give procfs_filename a default value here. --- gdb/ChangeLog | 7 +++++++ gdb/proc-api.c | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d391859..f4e9562 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2017-04-05 Pedro Alves + * proc-api.c (procfs_filename): Don't initialize + procfs_filename. + (prepare_to_trace): Assume procfs_filename is non-NULL. + (_initialize_proc_api): Give procfs_filename a default value here. + +2017-04-05 Pedro Alves + * break-catch-throw.c (handle_gnu_v3_exceptions): Constify 'cond_string' parameter. (extract_exception_regexp): Constify 'string' parameter. diff --git a/gdb/proc-api.c b/gdb/proc-api.c index 72746ce..dbadd55 100644 --- a/gdb/proc-api.c +++ b/gdb/proc-api.c @@ -60,15 +60,14 @@ struct trans { static int procfs_trace = 0; static FILE *procfs_file = NULL; -static char *procfs_filename = "procfs_trace"; +static char *procfs_filename; static void prepare_to_trace (void) { if (procfs_trace) /* if procfs tracing turned on */ if (procfs_file == NULL) /* if output file not yet open */ - if (procfs_filename != NULL) /* if output filename known */ - procfs_file = fopen (procfs_filename, "a"); /* open output file */ + procfs_file = fopen (procfs_filename, "a"); /* open output file */ } static void @@ -785,6 +784,7 @@ Show tracing for /proc api calls."), NULL, NULL, /* FIXME: i18n: */ &setlist, &showlist); + procfs_filename = xstrdup ("procfs_trace"); add_setshow_filename_cmd ("procfs-file", no_class, &procfs_filename, _("\ Set filename for /proc tracefile."), _("\ Show filename for /proc tracefile."), NULL, -- 2.5.5