From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23965 invoked by alias); 10 Sep 2012 15:04:04 -0000 Received: (qmail 23948 invoked by uid 22791); 10 Sep 2012 15:04:03 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Sep 2012 15:03:49 +0000 Received: from eusaamw0711.eamcs.ericsson.se ([147.117.20.178]) by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id q8AF7OIP009338; Mon, 10 Sep 2012 10:07:37 -0500 Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.2.164]) by eusaamw0711.eamcs.ericsson.se ([147.117.20.178]) with mapi; Mon, 10 Sep 2012 11:03:39 -0400 From: Marc Khouzam To: "'Mircea Gherzan'" , "'Pedro Alves'" CC: "'gdb-patches@sourceware.org'" , "'mgherzan@gmail.com'" Date: Mon, 10 Sep 2012 15:04:00 -0000 Subject: RE: [PATCH] Add the -catch-load and -catch-unload MI commands. Message-ID: References: <1346320317-1599-1-git-send-email-mircea.gherzan@intel.com> <503FA714.4020206@intel.com> <504DF49D.7070700@redhat.com> <504DFDB8.7090005@intel.com> In-Reply-To: <504DFDB8.7090005@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00112.txt.bz2 > -----Original Message----- > From: Mircea Gherzan [mailto:mircea.gherzan@intel.com]=20 > Sent: Monday, September 10, 2012 10:48 AM > To: Pedro Alves > Cc: Marc Khouzam; 'gdb-patches@sourceware.org'; 'mgherzan@gmail.com' > Subject: Re: [PATCH] Add the -catch-load and -catch-unload MI=20 > commands. >=20 > Hi, >=20 > Thank you for your feedback. >=20 > On 10.09.2012 16:09, Pedro Alves wrote: > > [...] > > I don't this would be a good idea compared to separate=20 > commands. Each > > of those catch variants takes different parameters/options. I'm not > > seeing what putting them all under the same roof would buy. >=20 > I am still in favour of having them as separate commands, but, if the=20 > powers that be decide otherwise, I am willing to rework the patch. >=20 > > In the CLI, although "catch exec", "catch fork", "catch=20 > syscall", etc. > > have the same prefix, they're really implemented as=20 > separate commands > > as well. > > >=20 > Please let me know if there are any issues that prevent this=20 > patch from getting merged. An enhancement that would be nice (but may not be blocking) is to support a '-d' flag like -break-insert does. This would create the catchpoint in a disabled state. Currently, a frontend that wants to create a disabled catchpoint must do: catch load -break-disabled 1 (assuming the catchpoint number is 1) in non-stop mode, this can cause a race condition where the=20 catchpoint could hit before it is disabled. It would be better=20 to do a single command: -catch-load -d Note that I've never actually seen this happen, but I believe the risk is there. BTW, we have the same potential problem with watchpoints=20 which use -break-watch. Thanks for these proposed new MI commands, they will be useful for Eclipse. Marc >=20 > Thanks, > Mircea >=20 > --=20 >=20 > Intel GmbH > Dornacher Strasse 1 > 85622 Feldkirchen/Muenchen, Deutschland > Sitz der Gesellschaft: Feldkirchen bei Muenchen > Geschaeftsfuehrer: Peter Gleissner, Christian Lamprechter,=20 > Hannes Schwaderer, Douglas Lusk > Registergericht: Muenchen HRB 47456 > Ust.-IdNr./VAT Registration No.: DE129385895 > Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052 >=20 >=20