From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25546 invoked by alias); 2 Dec 2011 19:16:25 -0000 Received: (qmail 25528 invoked by uid 22791); 2 Dec 2011 19:16:23 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 02 Dec 2011 19:16:10 +0000 Received: from eusaamw0711.eamcs.ericsson.se ([147.117.20.178]) by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id pB2JG0aO029637; Fri, 2 Dec 2011 13:16:06 -0600 Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.43]) by eusaamw0711.eamcs.ericsson.se ([147.117.20.178]) with mapi; Fri, 2 Dec 2011 14:15:57 -0500 From: Marc Khouzam To: "'Pedro Alves'" , "'gdb-patches@sourceware.org'" Date: Fri, 02 Dec 2011 19:16:00 -0000 Subject: RE: [RFC/WIP PATCH 03/14] Flip to set target-async on by default Message-ID: References: <20111128153742.17761.21459.stgit@localhost6.localdomain6> <20111128153910.17761.37341.stgit@localhost6.localdomain6> In-Reply-To: <20111128153910.17761.37341.stgit@localhost6.localdomain6> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00050.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org=20 > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Monday, November 28, 2011 10:39 AM > To: gdb-patches@sourceware.org > Subject: [RFC/WIP PATCH 03/14] Flip to set target-async on by default >=20 > This flips "set target-async" to default to on. I see no failures > left with this on x86_64-linux, and there used to be none either > against gdbserver, but I haven't tried recently. One thing left to > decide is what to do with MI. If the frontend never flips async > explicitly, should we bother to emulate sync MI output, or can we > expect that all frontends can and should cope with async on by default > by now? I've just caught up with the 1400 GDB emails I had neglected in the last couple of months so I surely missed some interesting points that may be=20 of interested to Eclipse. But I did catch this one :-) Eclipse is not ready for a default target-async on. But that change wouldn't be very hard to adapt to, so I'll do it anyway for safety. (As a side note, I would like Eclipse to always use target-async on,=20 even for all-stop, but that would be a large change that I don't have the bandwith to work on. Besides, we still support GDB back to 6.6, so we couldn't get rid of the dealing with the sync behavior anyway.) Marc > --- > gdb/target.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/gdb/target.c b/gdb/target.c > index 3bc4be2..c2aaa7e 100644 > --- a/gdb/target.c > +++ b/gdb/target.c > @@ -4259,11 +4259,11 @@ maintenance_print_target_stack (char=20 > *cmd, int from_tty) > } >=20=20 > /* Controls if async mode is permitted. */ > -int target_async_permitted =3D 0; > +int target_async_permitted =3D 1; >=20=20 > /* The set command writes to this variable. If the inferior is > executing, linux_nat_async_permitted is *not* updated. */ > -static int target_async_permitted_1 =3D 0; > +static int target_async_permitted_1 =3D 1; >=20=20 > static void > set_maintenance_target_async_permitted (char *args, int from_tty, >=20 >=20