From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76681-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11122 invoked by alias); 25 Nov 2010 21:22:19 -0000
Received: (qmail 11109 invoked by uid 22791); 25 Nov 2010 21:22:18 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from imr3.ericy.com (HELO imr3.ericy.com) (198.24.6.13)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Nov 2010 21:22:13 +0000
Received: from eusaamw0712.eamcs.ericsson.se ([147.117.20.181])	by imr3.ericy.com (8.13.8/8.13.8) with ESMTP id oAPLMBN2006041	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL)	for <gdb-patches@sourceware.org>; Thu, 25 Nov 2010 15:22:11 -0600
Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.63]) by eusaamw0712.eamcs.ericsson.se ([147.117.20.181]) with mapi; Thu, 25 Nov 2010 16:22:11 -0500
From: Marc Khouzam <marc.khouzam@ericsson.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Date: Thu, 25 Nov 2010 21:22:00 -0000
Subject: Segfault on empty 'strace'
Message-ID: <F7CE05678329534C957159168FA70DEC572E79BC9E@EUSAACMS0703.eamcs.ericsson.se>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00438.txt.bz2

Hi,

segfault on an empty 'strace' command.
The patch below checks for NULL before calling strncmp().

> ./gdb -ex strace
GNU gdb (GDB) 7.2.50.20101125-cvs
Segmentation fault

No regressions.

Ok?
What about 7_2?

Thanks

Marc

2010-11-25  Marc Khouzam  <marc.khouzam@ericsson.com>

	* breakpoint.c (is_marker_spec): Check for NULL.

### Eclipse Workspace Patch 1.0
#P src
Index: gdb/breakpoint.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.516
diff -u -r1.516 breakpoint.c
--- gdb/breakpoint.c    11 Nov 2010 14:11:51 -0000      1.516
+++ gdb/breakpoint.c    25 Nov 2010 21:09:56 -0000
@@ -222,7 +222,7 @@
 /* Assuming we're creating a static tracepoint, does S look like a
    static tracepoint marker spec ("-m MARKER_ID")?  */
 #define is_marker_spec(s)                                              \
-  (strncmp (s, "-m", 2) =3D=3D 0 && ((s)[2] =3D=3D ' ' || (s)[2] =3D=3D '\=
t'))
+  (s !=3D NULL && strncmp (s, "-m", 2) =3D=3D 0 && ((s)[2] =3D=3D ' ' || (=
s)[2] =3D=3D '\t'))
=20
 /* A reference-counted struct command_line.  This lets multiple
    breakpoints share a single command list.  */