From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76680-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3591 invoked by alias); 25 Nov 2010 20:56:00 -0000
Received: (qmail 3583 invoked by uid 22791); 25 Nov 2010 20:55:59 -0000
X-SWARE-Spam-Status: No, hits=-1.5 required=5.0	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.8)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Nov 2010 20:55:54 +0000
Received: from eusaamw0706.eamcs.ericsson.se ([147.117.20.31])	by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id oAPLMdDg030689	for <gdb-patches@sourceware.org>; Thu, 25 Nov 2010 15:22:42 -0600
Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.63]) by eusaamw0706.eamcs.ericsson.se ([147.117.20.31]) with mapi; Thu, 25 Nov 2010 15:55:51 -0500
From: Marc Khouzam <marc.khouzam@ericsson.com>
To: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Date: Thu, 25 Nov 2010 20:56:00 -0000
Subject: [MI] Duplicate --thread-group flag not detected
Message-ID: <F7CE05678329534C957159168FA70DEC572E7598F3@EUSAACMS0703.eamcs.ericsson.se>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-11/txt/msg00437.txt.bz2

Hi,

There is a missing 'else' in mi_parse() which prevents the
detection of a duplicate --thread-group flag.

> ./gdb
GNU gdb (GDB) 7.2.50.20101125-cvs
(gdb) interpreter-exec mi "-break-insert --thread-group i1 --thread-group i=
1 main"
^error,msg=3D"mi_cmd_break_insert: Unknown option ``-thread-group''"

instead of giving an error about "Duplicate --thread-group flag".

No regressions.

Ok?
What about the 7_2 branch?

2010-11-25  Marc Khouzam  <marc.khouzam@ericsson.com>

	* mi/mi-parse.c (mi_parse): Missing else.

### Eclipse Workspace Patch 1.0
#P src
Index: gdb/mi/mi-parse.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/src/src/gdb/mi/mi-parse.c,v
retrieving revision 1.21
diff -u -r1.21 mi-parse.c
--- gdb/mi/mi-parse.c   17 May 2010 20:49:39 -0000      1.21
+++ gdb/mi/mi-parse.c   25 Nov 2010 20:43:31 -0000
@@ -319,7 +319,7 @@
          chp +=3D 1;
          parse->thread_group =3D strtol (chp, &chp, 10);
        }
-      if (strncmp (chp, "--thread ", ts) =3D=3D 0)
+      else if (strncmp (chp, "--thread ", ts) =3D=3D 0)
        {
          if (parse->thread !=3D -1)
            error (_("Duplicate '--thread' option"));