From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5659 invoked by alias); 14 Sep 2009 13:52:03 -0000 Received: (qmail 5649 invoked by uid 22791); 14 Sep 2009 13:52:02 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from imr1.ericy.com (HELO imr1.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Sep 2009 13:51:58 +0000 Received: from eusrcmw751.eamcs.ericsson.se (eusrcmw751.exu.ericsson.se [138.85.77.51]) by imr1.ericy.com (8.13.1/8.13.1) with ESMTP id n8EDprmd009403; Mon, 14 Sep 2009 08:51:56 -0500 Received: from eusrcmw750.eamcs.ericsson.se ([138.85.77.50]) by eusrcmw751.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.3959); Mon, 14 Sep 2009 08:51:10 -0500 Received: from eusaamw0706.eamcs.ericsson.se ([147.117.20.31]) by eusrcmw750.eamcs.ericsson.se with Microsoft SMTPSVC(6.0.3790.3959); Mon, 14 Sep 2009 08:51:09 -0500 Received: from EUSAACMS0703.eamcs.ericsson.se ([169.254.1.20]) by eusaamw0706.eamcs.ericsson.se ([147.117.20.31]) with mapi; Mon, 14 Sep 2009 09:51:07 -0400 From: Marc Khouzam To: "'Hui Zhu'" CC: "'Michael Snyder'" , "'gdb-patches ml'" Date: Mon, 14 Sep 2009 13:52:00 -0000 Subject: RE: PRecord sets memory even when it says it did not Message-ID: References: In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00396.txt.bz2 =20 > -----Original Message----- > From: Hui Zhu [mailto:teawater@gmail.com]=20 > Sent: Monday, September 14, 2009 12:40 AM > To: Marc Khouzam > Cc: gdb@sourceware.org; Michael Snyder; gdb-patches ml > Subject: Re: PRecord sets memory even when it says it did not >=20 ... >=20 > Hi Marc, >=20 > Thanks for your help. >=20 > I just tried change it with "p a=3D99". I think it must have something > different with "set var a =3D 8". I also tried it with p a=3D8 and in my case, the same things happens: the memory is changed. > This issue is because some value cache about the memory. So I add a > "free_all_values ();" before error. > It looks OK now. Please help me try it. I tried with the patch and it did not fix the problem. Let me know if I can do anything to help debug. I'm seing this on both SLED and Ubuntu. Thanks, Marc >=20 > 2009-09-14 Hui Zhu >=20 > * record.c (record_xfer_partial): Call free_all_values when > cancel the operation. >=20 > --- > record.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > --- a/record.c > +++ b/record.c > @@ -1023,7 +1023,10 @@ record_xfer_partial (struct target_ops * > "will make the execution log unusable=20 > from this " > "point onward. Write memory at address %s?"), > paddress (target_gdbarch, offset))) > - error (_("Process record canceled the operation.")); > + { > + free_all_values (); > + error (_("Process record canceled the operation.")); > + } >=20 > /* Destroy the record from here forward. */ > record_list_release_next (); >=20