Re: [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory

Joel Brobecker
2012-10-04T00:09:07Z

> > Does anyone have any objection to this approach in principle?
>
> I'm not entirely comfortable with this yet, but I might be persuaded.

I have to admit that I have been having second thoughts as well,
trying to figure out all the implications of this change.

> Alternative: Is there a robust enough test to determine gdb is being
> run from its build directory?

I don't see a robust way to determine that we are bing run from
the build directory. I kind of see this approach as riskier than
the first one.

I've been mulling over the following two options:

1. Go with the idea of installing the data-directory inside the build
directory". But this assumes that the data-directory is relocatable,
and that it is a subdirectory of the prefix. If that's not the case,
then I think "make all" could end up installing the data-directory
at the configured location, outside the build directory. It seems
like an innocent thing, but in the end, I think it's bad - almost
sneaky. I'd probably be the first one to curse if that happened
to me.

2. Accept the new situation, and configure with a --prefix somewhere
in the build directory. I can do an install the first time, and
then as needed based on what changes have been made since the
last install...

It's a pain in the neck, but I think I have slowly been coming to
the conclusion that it is probably best for me, and the others who
were relying on this undocumented feature, to learn to live with
the new requirement. At least we tried...

--
Joel