From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16620 invoked by alias); 21 Jun 2018 19:56:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16603 invoked by uid 89); 21 Jun 2018 19:56:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=settled X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0066.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 19:56:24 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2614.eurprd08.prod.outlook.com (10.172.252.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19; Thu, 21 Jun 2018 19:56:21 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::a152:f8f6:6608:7624]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::a152:f8f6:6608:7624%5]) with mapi id 15.20.0863.016; Thu, 21 Jun 2018 19:56:21 +0000 From: Alan Hayward To: Simon Marchi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 3/3] Use partial register read/writes in transfer_regset Date: Thu, 21 Jun 2018 19:56:00 -0000 Message-ID: References: <20180621093802.79342-1-alan.hayward@arm.com> <20180621093802.79342-4-alan.hayward@arm.com> <85583a14-9c9f-605c-8216-57b6cda22d41@ericsson.com> In-Reply-To: <85583a14-9c9f-605c-8216-57b6cda22d41@ericsson.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1870be89-cbbb-46b4-2306-08d5d7b10fe5 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: DB6PR0802MB2614: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(37575265505322); x-ms-exchange-senderadcheck: 1 x-forefront-prvs: 07106EF9B9 received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1870be89-cbbb-46b4-2306-08d5d7b10fe5 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2018 19:56:21.7870 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2614 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00532.txt.bz2 DQo+IE9uIDIxIEp1biAyMDE4LCBhdCAxNToxNCwgU2ltb24gTWFyY2hpIDxz aW1vbi5tYXJjaGlAZXJpY3Nzb24uY29tPiB3cm90ZToNCj4gDQo+IEhpIEFs YW4sDQo+IA0KPiBPbiAyMDE4LTA2LTIxIDA1OjM4IEFNLCBBbGFuIEhheXdh cmQgd3JvdGU6DQo+PiBAQCAtMTAxMywxMiArMTA3NywxOCBAQCByZWdjYWNo ZTo6dHJhbnNmZXJfcmVnc2V0IChjb25zdCBzdHJ1Y3QgcmVnc2V0ICpyZWdz ZXQsDQo+PiAJICAgIGlmIChvZmZzICsgc2xvdF9zaXplID4gc2l6ZSkNCj4+ IAkgICAgICBicmVhazsNCj4+IA0KPj4gKwkgICAgLyogVXNlIHBhcnQgdmVy c2lvbnMgdG8gcHJldmVudCBwb3NzaWJsZSBvdmVyZmxvdy4gICovDQo+PiAJ ICAgIGlmIChvdXRfYnVmKQ0KPiANCj4gQ2FuIHlvdSB1cGRhdGUgdGhlIHBv aW50ZXIgY29tcGFyaXNvbnMgaW4gdGhlIGNvZGUgeW91IHRvdWNoIHRvIHVz ZSAhPSBOVUxMIG9yICE9IG51bGxwdHI/DQo+IA0KDQpXaWxsIGRvLg0KDQo+ PiBkaWZmIC0tZ2l0IGEvZ2RiL3JlZ2NhY2hlLmggYi9nZGIvcmVnY2FjaGUu aA0KPj4gaW5kZXggYzE3Y2UwOWRlZS4uYTY5YjY3ZDUxMyAxMDA2NDQNCj4+ IC0tLSBhL2dkYi9yZWdjYWNoZS5oDQo+PiArKysgYi9nZGIvcmVnY2FjaGUu aA0KPj4gQEAgLTE2Miw2ICsxNjIsMTEgQEAgcHVibGljOg0KPj4gICB2b2lk IHJhd19jb2xsZWN0X2ludGVnZXIgKGludCByZWdudW0sIGdkYl9ieXRlICph ZGRyLCBpbnQgYWRkcl9sZW4sDQo+PiAJCQkgICAgYm9vbCBpc19zaWduZWQp IGNvbnN0Ow0KPj4gDQo+PiArICAvKiBDb2xsZWN0IHJlZ2lzdGVyIFJFR05V TSBmcm9tIFJFR0NBQ0hFLCBzdGFydGluZyBhdCBvZmZzZXQgaW4gUkVHQ0FD SEUsDQo+PiArICAgICByZWFkaW5nIG9ubHkgTEVOLiAgSWYgdGhpcyBydW5z IG9mZiB0aGUgZW5kIG9mIHRoZSByZWdpc3RlciwgdGhlbiBmaWxsIHRoZQ0K Pj4gKyAgICAgYWRkaXRpb25hbCBzcGFjZSB3aXRoIHplcm9zLiAgKi8NCj4g DQo+IFRvIGhhdmUgYSBjb25zaXN0ZW50IGludGVyZmFjZSwgIEkgd291bGQg YmUgdGVtcHRlZCB0byB1c2UgdGhlIHNhbWUgYmVoYXZpb3IgYXMNCj4gcmVh ZF9wYXJ0IGFuZCB3cml0ZV9wYXJ0IGZvciByZWFkcyBhbmQgd3JpdGVzIHRo YXQgcnVuIG9mZiB0aGUgZW5kIG9mIHRoZSByZWdpc3Rlcg0KPiAobm90IGFs bG93IGl0KS4gIEl0IHdvdWxkIGJlIHRoZSByZXNwb25zaWJpbGl0eSBvZiB0 aGUgY2FsbGVyIHRvIGVuc3VyZSB0aGF0IHRoZXkNCj4gZG9uJ3Qgb3ZlcmZs b3cuICBJIHRoaW5rIGl0IHdvdWxkIGp1c3QgYmUgYSBtYXR0ZXIgb2YNCj4g DQo+ICBzdGQ6Om1pbiAocmVnX3NpemUsIHNsb3Rfc2l6ZSkNCj4gDQo+ID8N Cg0KSSB3ZW50IGJhY2sgYW5kIHRvbyBiZXR3ZWVuIGRvaW5nIGl0IHRoaXMg d2F5IGFuZCB0aGUgd2F5IEkgcG9zdGVkLg0KSSBzZXR0bGVkIG9uIHRoaXMg d2F5IGJlY2F1c2UgaXQgbWFkZSB0cmFuc2Zlcl9yZWdzZXQgbmVhdGVyLiBJ IGFncmVlIGl0IG1ha2VzDQpzZW5zZSB0byBrZWVwIHRoZSBpbnRlcmZhY2Ug dGhlIHNhbWUuIEluIGFkZGl0aW9uIEnigJlkIHRoZW4gaGF2ZSB0byBwdWxs IHRoZQ0KbWVtc2V0IG9mIDBzIGludG8gdHJhbnNmZXJfcmVnc2V0LiBJIHRo aW5rIGl04oCZbGwgbG9vayBiZXR0ZXIgaWYgSSBwdWxsIHRoZSB0d28NCmFs bW9zdCBpZGVudGljYWwgYmxvYnMgb2YgY29kZSBpbnRvIGEgaGVscGVyIGZ1 bmN0aW9uLg0KDQpJ4oCZbGwgc3dpdGNoIGl0IGFyb3VuZCBhbmQgcmVwb3N0 IGFzIHNpbmdsZSBWMyB0b21vcnJvdywgd2l0aCBhbGwgdGhlIHVuc2lnbmVk IHN0dWZmDQpkcm9wcGVkLg0KDQoNCkFsYW4uDQoNCg== >From gdb-patches-return-148390-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Jun 21 20:06:40 2018 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 103829 invoked by alias); 21 Jun 2018 20:06:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 103804 invoked by uid 89); 21 Jun 2018 20:06:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=terribly X-Spam-User: qpsmtpd, 2 recipients X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 20:06:38 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5LK6VvJ026344 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jun 2018 16:06:36 -0400 Received: by simark.ca (Postfix, from userid 112) id 9DC301EF28; Thu, 21 Jun 2018 16:06:31 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CBB311E059; Thu, 21 Jun 2018 16:06:24 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 Jun 2018 20:06:00 -0000 From: Simon Marchi To: "Maciej W. Rozycki" Cc: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org, Joel Brobecker , Fredrik Noring Subject: Re: [PATCH v4] GDB PR tdep/8282: MIPS: Wire in `set disassembler-options' In-Reply-To: References: <3bd95a5f-e43e-2efe-e261-c2cf30d06d14@ericsson.com> <5d5b6d47508d5f54ff2eb6e514a7da2c@polymtl.ca> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 Jun 2018 20:06:31 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00533.txt.bz2 Content-length: 1937 On 2018-06-21 15:55, Maciej W. Rozycki wrote: > I think you chose the wrong example, after all what's the problem for > tools to notice that "foo (bar)" and "foo (bar) (timeout)" are the same > test? If the number of parenthesis pairs is different between two > messages, then strip the extra ones along with the text between from > the > message that has more of them and only then compare the resulting > strings. We can do that if we know that they are supposed to be the different test. But how do we know whether they are different tests or the same test with a special outcome in the second case? > What the problem would be are different failures in different runs, > e.g. > if we have "foo (bar) (timeout)" in one and "foo (bar) (internal > error)" > in the other one, then indeed we have an issue. We could strip > parenthesis pairs one by one from both messages at a time, but then > we'd > incorrectly consider "foo (bar)" and "foo (baz)" the same test. > > Does it matter in reality? I suppose so, given the outcome of the > discussion referred from the wiki, although I don't see the scenario I > have outlined here actually mentioned there (parts of the discussion > seem > to be missing though from the archive). The only purpose I am aware of is the script on the buildbot that analyzes results. It would show a timeout as new FAIL: foo (timeout) instead of now: PASS -> FAIL: foo So it's not terribly important, but it helps making the analysis output a bit better. >> That does not really apply to your case though. I think here you can >> just >> remove the parenthesis, and maybe add a comma. >> >> mips_disassemble_test bar "move\tv0,a4" "disassemble ABI, n64" >> >> As long as it's clear. > > OK, works for me. I'll make that adjustment as I commit the change > once > the binutils parts have been approved. > > Thank you for your review. > > Maciej Thanks, Simon