From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16200 invoked by alias); 26 May 2011 07:48:33 -0000 Received: (qmail 16191 invoked by uid 22791); 26 May 2011 07:48:32 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 May 2011 07:48:17 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 2628FCB02AC; Thu, 26 May 2011 09:48:16 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tgA8PCS1GPYA; Thu, 26 May 2011 09:48:13 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 2AC49CB021E; Thu, 26 May 2011 09:48:12 +0200 (CEST) Subject: Re: [PATCH 2/4] dwarf2read.c: handle alternate dwarf2 debug sections name. Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: Date: Thu, 26 May 2011 07:48:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <1306146544-3925-1-git-send-email-gingold@adacore.com> <1306146544-3925-3-git-send-email-gingold@adacore.com> To: Tom Tromey X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00596.txt.bz2 On May 23, 2011, at 5:40 PM, Tom Tromey wrote: > Tristan> Simply because the XCOFF maintainer was against this approach: > Tristan> http://sourceware.org/ml/binutils/2011-04/msg00364.html >=20 > I see. Onward, then. >=20 > Also I see my other note was completely in error. Sigh. Sorry about > that. I'll reply to that to eliminate confusion. >=20 > I have a few nits with this patch, nothing serious. >=20 >=20 > Tristan> + bfd_map_over_sections (objfile->obfd, dwarf2_locate_secti= ons, > Tristan> + (void *)names); >=20 > Space after ")". >=20 > Tristan> + names =3D (const struct dwarf2_debug_sections *)vnames; >=20 > You shouldn't need the cast, but if for some reason you do, there should > be a space after the ")". >=20 > Tristan> +struct dwarf2_section_names { > Tristan> + const char *normal; > Tristan> + const char *compressed; > Tristan> +}; > Tristan> + > Tristan> +struct dwarf2_debug_sections { >=20 > These should both have introductory comments explaining the purpose of > the structs. >=20 > Ok with those changes. Thanks, committed with these changes. Tristan.