Re: [PATCH] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64

Mark Kettenis
2011-12-20T19:31:25Z

> From: Valery Khromov <valery.khromov@gmail.com>
> Date: Tue, 20 Dec 2011 20:47:53 +0300
>
> On 20.12.2011, at 19:05, Pedro Alves wrote:
>
> > On Tuesday 20 December 2011 15:03:09, Mark Kettenis wrote:
> >>> From: Valery Khromov <valery.khromov@gmail.com>
> >>> Date: Tue, 6 Dec 2011 04:54:24 +0400
> >>>
> >>> This patch provides hardware breakpoint/watchpoint support for
> >>> FreeBSD/AMD64. Most of the code is borrowed from the i386 implementation.
> >>
> >> I fear that since the recent changes that Pedro made, the code needs
> >> to be resycnhed with the i386 version :(. Can you do that?
> >
> > Yeah, sorry about that. I was actually planning on taking the
> > hit myself and updating Valery's patch. Let me know if you'd
> > like me to do it.
>
> See the following e-mails for fixes.
>
> I prefer not to change my original patch because FreeBSD still uses
> gdb 7.3.1 in ports and this fixes incompatible with it.

Sorry, you'll have to send a single diff against the current GDB CVS
sources for this, with a single Changelog entry. Diffs on top of
diffs are hard to review, and there is no point in having
intermediate/broken steps in our CVS repository.