Re: [PATCH v2] Fix PR gdb/12953: No hardware watchpoints on FreeBSD amd64

Pedro Alves
2012-02-09T16:10:43Z

On 12/20/2011 08:10 PM, Valery Khromov wrote:
> This patch provides hardware breakpoint/watchpoint support for
> FreeBSD/AMD64. Most of the code is borrowed from the i386 implementation.

Thanks. It looks good to me. I've applied the patch now.

> Also removed not necessary DBREG_DRX macro definition.

> 2011-12-20 Valery Khromov <valery.khromov@gmail.com>
>
> * i386bsd-nat.c: [HAVE_PT_GETDBREGS] (DBREG_DRX): Delete.

But without this bit though. Mark only mentioned that the macro always
exists on amd64, not i386:

> That bit can go. FreeBSD/amd64 has always had the DBREG_DRX macro, at
> least ever since support for debug registers was added.

The code does mention that some versions may need it:

/* Not all versions of FreeBSD/i386 that support the debug registers
have this macro. */
#ifndef DBREG_DRX
#define DBREG_DRX(d, x) ((&d->dr0)[x])
#endif

So if this can also be removed, let's do that separately.

--
Pedro Alves