From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1713 invoked by alias); 2 May 2005 14:22:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1020 invoked from network); 2 May 2005 14:21:49 -0000 Received: from unknown (HELO wampa.office.slickedit.com) (24.106.178.205) by sourceware.org with SMTP; 2 May 2005 14:21:49 -0000 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [RFC] fullname attribute for GDB/MI stack frames Date: Mon, 02 May 2005 14:22:00 -0000 Message-ID: From: "Dennis Brueni" To: Cc: "Bob Rossi" , "Eli Zaretskii" , "Daniel Jacobowitz" X-SW-Source: 2005-05/txt/msg00045.txt.bz2 > -----Original Message----- >=20 > > > Like Dennis noted, it could be possible that the fullname=20 > might not=20 > > > start with a "/". I originally posted the patch with the fullname=20 > > > starting with a "/", and since then, there hasn't been any=20 > > > complaints. If there is a better regex that ensures that the=20 > > > fullname is absolute I'd be happy to change the=20 > mi-file.exp test to=20 > > > it. > >=20 > > The proper regexp should be something like > >=20 > > \([A-z]:\)?[/\\].*basics.c > >=20 > > This assumes that \(...\) is the proper syntax for grouping=20 > (I don't=20 > > know much about the regexp syntax expected by Expect). > >=20 > > (The uppercase A but lowercase z in the above are=20 > intentional: that's=20 > > because letters between Z and a can also be drive letters, amazingly > > enough.) >=20 > OK, I don't know why no one has ever posted to this list with=20 > testsuite failures on the mi-file.exp testcase. Maybe no one=20 > runs the mi testsuite=20 > on windows? I tried. Many failures, unrelated to fullname, led me to believe that configuration was not considered as supported by the mi testsuite. Also, in my tests at least, the fullname paths from stack frames all come back as /cygdrive//..., so the simplistic regex would suffice. > Either way, I'm going to submit a patch later today which=20 > will add a variable to mi-support.exp similar to=20 > mi_gdb_prompt. The variable will describe the syntax of a=20 > fullname field. It will abstract the details=20 > and complications from new users trying to write testcase's. >=20 > I'll try to find time to make this quick change tonight. If=20 > people don't like this idea, let me know. This is a good idea, but as the complexity of the regex increases it becomes more compelling to do an exact check. Calculate what the absolute path to the source file should be and compare that with the fullname attribute. However, I'm not volunteering to do that. ;) It's easy to overblow the testing for what amounts to a five line code change. --Dennis