From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3159 invoked by alias); 14 Oct 2013 09:37:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3145 invoked by uid 89); 14 Oct 2013 09:37:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_40 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Oct 2013 09:37:05 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VVeaC-0002tY-5k from Hafiz_Abid@mentor.com ; Mon, 14 Oct 2013 02:37:00 -0700 Received: from SVR-IES-FEM-05.mgc.mentorg.com ([137.202.0.112]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 14 Oct 2013 02:37:00 -0700 Received: from EU-MBX-03.mgc.mentorg.com ([169.254.2.112]) by SVR-IES-FEM-05.mgc.mentorg.com ([137.202.0.112]) with mapi id 14.02.0247.003; Mon, 14 Oct 2013 10:36:57 +0100 From: "Abid, Hafiz" To: Doug Evans CC: "Pedro Alves (palves@redhat.com)" , "gdb-patches@sourceware.org" , "Mirza, Taimoor" Subject: RE: [patch] Disassembly improvements Date: Mon, 14 Oct 2013 09:37:00 -0000 Message-ID: References: In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2013-10/txt/msg00427.txt.bz2 > Question: How much more of the general problem can we fix without having > a fix baked into the disassembler? Perhaps we can improve GDB memory caching to handle this case instead of ba= king a solution into disassembler. I am not very familiar with dcache.c but I wi= ll=20 investigate if we can extend that approach. Any guidance is welcome offcour= se. > -----Original Message----- > From: Doug Evans [mailto:dje@google.com] > Sent: 11 October 2013 22:34 > To: Abid, Hafiz > Cc: Pedro Alves (palves@redhat.com); gdb- > patches@sourceware.org; Mirza, Taimoor > Subject: Re: [patch] Disassembly improvements >=20 > On Thu, Oct 10, 2013 at 6:14 AM, Abid, Hafiz > wrote: > > Hi Pedro, > > I am attaching the patch that was mentioned in the following thread. I > resurrected it from our internal repo, did a bit of manual testing and ru= n the > regression suite without any problem. It basically reads memory from the > target in a buffer in gdb_disassembly and tries to use this buffer in > dis_asm_read_memory instead of reading from the target. This saves us on > repeated memory read calls. The problem was noted when eclipse was trying > to fill its disassembly view. > > https://sourceware.org/ml/gdb-patches/2013-10/msg00221.html > > > > Regards, > > Abid > > > > 2013-10-10 Taimoor Mirza > > > > * disasm.c (DIS_BUF_SIZE): New define. > > (dis_asm_read_memory): Read from the disassembly buffer instead > > of target memory directly. > > (gdb_disassembly): Fill the disassembly buffer with a chunk of > > the memory to disassemble. >=20 > This is a specific fix to a general problem. > Question: How much more of the general problem can we fix without having > a fix baked into the disassembler?