From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15114 invoked by alias); 10 Oct 2013 13:57:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15101 invoked by uid 89); 10 Oct 2013 13:57:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 13:57:53 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VUGkP-0002GG-H9 from Hafiz_Abid@mentor.com ; Thu, 10 Oct 2013 06:57:49 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 10 Oct 2013 06:57:50 -0700 Received: from EU-MBX-03.mgc.mentorg.com ([169.254.2.112]) by SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) with mapi id 14.02.0247.003; Thu, 10 Oct 2013 14:57:48 +0100 From: "Abid, Hafiz" To: Pedro Alves CC: "gdb-patches@sourceware.org" , "Mirza, Taimoor" Subject: RE: [patch] Disassembly improvements Date: Thu, 10 Oct 2013 13:57:00 -0000 Message-ID: References: <5256ACED.7040402@redhat.com> In-Reply-To: <5256ACED.7040402@redhat.com> Content-Type: multipart/mixed; boundary="_002_EB3B29AD43CA924DA27099BC85192376E0705237EUMBX03mgcmento_" MIME-Version: 1.0 X-SW-Source: 2013-10/txt/msg00344.txt.bz2 --_002_EB3B29AD43CA924DA27099BC85192376E0705237EUMBX03mgcmento_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 786 Thanks for review. Here is updated patch. > > + /* Assume the disassembler always read memory forwards. If we > "always reads" Fixed. > > + useless to keep retrying reading that buffer line. Simply > > + fallback to reading directly from target memory. */ >=20 > Should be "retrying to read", I think. Fixed. > > + /* Try fetching a new buffer line from the target. */ >=20 > Hmm, this seems to miss making sure LEN doesn't read beyond the original > requested memory range. It'd be good to add that. Changed to following line which should take care of this. unsigned int length =3D min (len, info->buffer_length); >=20 > That "unsigned int len" variable shadows the function's "len" > parameter. It'd be good to rename it. Fixed. >=20 >=20 > -- > Pedro Alves --_002_EB3B29AD43CA924DA27099BC85192376E0705237EUMBX03mgcmento_ Content-Type: application/octet-stream; name="disasm.patch" Content-Description: disasm.patch Content-Disposition: attachment; filename="disasm.patch"; size=2960; creation-date="Thu, 10 Oct 2013 13:54:00 GMT"; modification-date="Thu, 10 Oct 2013 13:47:00 GMT" Content-Transfer-Encoding: base64 Content-length: 4014 ZGlmZiAtLWdpdCBhL2dkYi9kaXNhc20uYyBiL2dkYi9kaXNhc20uYwppbmRl eCBlNjQzYzJkLi43ZTNkOTA4IDEwMDY0NAotLS0gYS9nZGIvZGlzYXNtLmMK KysrIGIvZ2RiL2Rpc2FzbS5jCkBAIC00MiwxMSArNDIsNjIgQEAgc3RydWN0 IGRpc19saW5lX2VudHJ5CiAgIENPUkVfQUREUiBlbmRfcGM7CiB9OwogCisv KiBTaXplIG9mIHRoZSBkaXNhc3NlbWJseSBtZW1vcnkgYnVmZmVyLiAgKi8K KyNkZWZpbmUgRElTX0JVRl9TSVpFIDEwMjQKKwogLyogTGlrZSB0YXJnZXRf cmVhZF9tZW1vcnksIGJ1dCBzbGlnaHRseSBkaWZmZXJlbnQgcGFyYW1ldGVy cy4gICovCiBzdGF0aWMgaW50CiBkaXNfYXNtX3JlYWRfbWVtb3J5IChiZmRf dm1hIG1lbWFkZHIsIGdkYl9ieXRlICpteWFkZHIsIHVuc2lnbmVkIGludCBs ZW4sCiAJCSAgICAgc3RydWN0IGRpc2Fzc2VtYmxlX2luZm8gKmluZm8pCiB7 CisgIC8qIEFzc3VtZSB0aGUgZGlzYXNzZW1ibGVyIGFsd2F5cyByZWFkcyBt ZW1vcnkgZm9yd2FyZHMuICBJZiB3ZQorICAgICBmYWlsZWQgdG8gcmVhZCBh IGJ1ZmZlciBsaW5lIGluIGEgcHJldmlvdXMgY2FsbCwgYXNzdW1lIHdlJ3Jl CisgICAgIHJlYWRpbmcgY2xvc2UgdG8gdGhlIGVuZCBvZiBhIG1hcHBlZCBw YWdlIG9yIHNlY3Rpb24sIGFuZCBzbyBpdCdzCisgICAgIHVzZWxlc3MgdG8g a2VlcCByZXRyeWluZyB0byByZWFkIHRoYXQgYnVmZmVyIGxpbmUuICBTaW1w bHkKKyAgICAgZmFsbGJhY2sgdG8gcmVhZGluZyBkaXJlY3RseSBmcm9tIHRh cmdldCBtZW1vcnkuICAqLworICBpZiAoaW5mby0+YnVmZmVyX2xlbmd0aCA+ IDApCisgICAgeworICAgICAgd2hpbGUgKGxlbikKKwl7CisJICBpZiAobWVt YWRkciA+PSBpbmZvLT5idWZmZXJfdm1hCisJICAgICAgJiYgbWVtYWRkciA8 IGluZm8tPmJ1ZmZlcl92bWEgKyBpbmZvLT5idWZmZXJfbGVuZ3RoKQorCSAg ICB7CisJICAgICAgdW5zaWduZWQgaW50IG9mZnNldCA9IChtZW1hZGRyIC0g aW5mby0+YnVmZmVyX3ZtYSk7CisJICAgICAgdW5zaWduZWQgaW50IGwgPSBt aW4gKGxlbiwgaW5mby0+YnVmZmVyX2xlbmd0aCAtIG9mZnNldCk7CisKKwkg ICAgICBtZW1jcHkgKG15YWRkciwgaW5mby0+YnVmZmVyICsgb2Zmc2V0LCBs KTsKKworCSAgICAgIG1lbWFkZHIgKz0gbDsKKwkgICAgICBteWFkZHIgKz0g bDsKKwkgICAgICBsZW4gLT0gbDsKKworCSAgICAgIGlmIChsZW4gPT0gMCkK KwkJcmV0dXJuIDA7CisJICAgIH0KKwkgIGVsc2UKKwkgICAgeworCSAgICAg IGludCBydmFsOworCSAgICAgIHVuc2lnbmVkIGludCBsZW5ndGggPSBtaW4g KGxlbiwgaW5mby0+YnVmZmVyX2xlbmd0aCk7CisKKwkgICAgICAvKiBUcnkg ZmV0Y2hpbmcgYSBuZXcgYnVmZmVyIGxpbmUgZnJvbSB0aGUgdGFyZ2V0LiAg Ki8KKworCSAgICAgIC8qIElmIHdlIGZhaWwgcmVhZGluZyBtZW1vcnkgaGFs ZndheSwgd2UnbGwgaGF2ZSBjbG9iYmVyZWQKKwkJIHRoZSBidWZmZXIsIHNv IGRvbid0IHRydXN0IGl0IGFueW1vcmUsIGV2ZW4gb24gZmFpbC4gICovCisJ ICAgICAgaW5mby0+YnVmZmVyX2xlbmd0aCA9IDA7CisJICAgICAgcnZhbCA9 IHRhcmdldF9yZWFkX21lbW9yeSAobWVtYWRkciwgaW5mby0+YnVmZmVyLCBs ZW5ndGgpOworCSAgICAgIGlmIChydmFsID09IDApCisJCXsKKwkJICBpbmZv LT5idWZmZXJfdm1hID0gbWVtYWRkcjsKKwkJICBpbmZvLT5idWZmZXJfbGVu Z3RoID0gbGVuZ3RoOworCQl9CisJICAgICAgZWxzZQorCQl7CisJCSAgLyog UmVhZCBmcm9tIHRhcmdldCBtZW1vcnkgZGlyZWN0bHkgZnJvbSBub3cgb24u ICAqLworCQkgIGJyZWFrOworCQl9CisJICAgIH0KKwl9CisgICAgfQogICBy ZXR1cm4gdGFyZ2V0X3JlYWRfbWVtb3J5IChtZW1hZGRyLCBteWFkZHIsIGxl bik7CiB9CiAKQEAgLTQxNSw2ICs0NjYsMTAgQEAgZ2RiX2Rpc2Fzc2VtYmx5 IChzdHJ1Y3QgZ2RiYXJjaCAqZ2RiYXJjaCwgc3RydWN0IHVpX291dCAqdWlv dXQsCiAgIHN0cnVjdCBzeW10YWIgKnN5bXRhYiA9IE5VTEw7CiAgIHN0cnVj dCBsaW5ldGFibGVfZW50cnkgKmxlID0gTlVMTDsKICAgaW50IG5saW5lcyA9 IC0xOworICBpbnQgYnVmZl9zaXplID0gRElTX0JVRl9TSVpFOworICBpbnQg cmVxX3NpemUgPSBoaWdoIC0gbG93OworICBpbnQgZXJyID0gMDsKKyAgZ2Ri X2J5dGUgKnBidWZmZXIgPSBOVUxMOwogCiAgIC8qIEFzc3VtZSBzeW10YWIg aXMgdmFsaWQgZm9yIHdob2xlIFBDIHJhbmdlLiAgKi8KICAgc3ltdGFiID0g ZmluZF9wY19zeW10YWIgKGxvdyk7CkBAIC00MjUsNiArNDgwLDIzIEBAIGdk Yl9kaXNhc3NlbWJseSAoc3RydWN0IGdkYmFyY2ggKmdkYmFyY2gsIHN0cnVj dCB1aV9vdXQgKnVpb3V0LAogICAgICAgbGUgPSBzeW10YWItPmxpbmV0YWJs ZS0+aXRlbTsKICAgICAgIG5saW5lcyA9IHN5bXRhYi0+bGluZXRhYmxlLT5u aXRlbXM7CiAgICAgfQorICBpZiAocmVxX3NpemUgPCBidWZmX3NpemUpCisg ICAgYnVmZl9zaXplID0gcmVxX3NpemU7CisKKyAgaWYgKHJlcV9zaXplID4g MCkKKyAgICB7CisgICAgICAvKiBBbGxvY2F0ZSBidWZmZXIgYW5kIHJlYWQg bWVtb3J5IHJlZ2lvbiBpbiBidWZmZXIuICAqLworICAgICAgcGJ1ZmZlciA9 IHhtYWxsb2MgKGJ1ZmZfc2l6ZSk7CisgICAgICBtYWtlX2NsZWFudXAgKHhm cmVlLCBwYnVmZmVyKTsKKyAgICAgIGVyciA9IHRhcmdldF9yZWFkX21lbW9y eSAobG93LCBwYnVmZmVyLCBidWZmX3NpemUpOworICAgICAgaWYgKGVyciA9 PSAwKQorCXsKKwkgIGRpLmJ1ZmZlciA9IHBidWZmZXI7CisJICBkaS5idWZm ZXJfbGVuZ3RoID0gYnVmZl9zaXplOworCSAgZGkuYnVmZmVyX3ZtYSA9IGxv dzsKKwl9CisgICAgfQorCiAKICAgaWYgKCEoZmxhZ3MgJiBESVNBU1NFTUJM WV9TT1VSQ0UpIHx8IG5saW5lcyA8PSAwCiAgICAgICB8fCBzeW10YWIgPT0g TlVMTCB8fCBzeW10YWItPmxpbmV0YWJsZSA9PSBOVUxMKQo= --_002_EB3B29AD43CA924DA27099BC85192376E0705237EUMBX03mgcmento_--