From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24890 invoked by alias); 10 Oct 2013 13:14:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24876 invoked by uid 89); 10 Oct 2013 13:14:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 13:14:56 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1VUG4q-0004mO-OZ from Hafiz_Abid@mentor.com ; Thu, 10 Oct 2013 06:14:52 -0700 Received: from SVR-IES-FEM-05.mgc.mentorg.com ([137.202.0.112]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 10 Oct 2013 06:14:52 -0700 Received: from EU-MBX-03.mgc.mentorg.com ([169.254.2.112]) by SVR-IES-FEM-05.mgc.mentorg.com ([137.202.0.112]) with mapi id 14.02.0247.003; Thu, 10 Oct 2013 14:14:50 +0100 From: "Abid, Hafiz" To: "Pedro Alves (palves@redhat.com)" CC: "gdb-patches@sourceware.org" , "Mirza, Taimoor" Subject: [patch] Disassembly improvements Date: Thu, 10 Oct 2013 13:14:00 -0000 Message-ID: Content-Type: multipart/mixed; boundary="_002_EB3B29AD43CA924DA27099BC85192376E0705106EUMBX03mgcmento_" MIME-Version: 1.0 X-SW-Source: 2013-10/txt/msg00342.txt.bz2 --_002_EB3B29AD43CA924DA27099BC85192376E0705106EUMBX03mgcmento_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Content-length: 850 Hi Pedro, I am attaching the patch that was mentioned in the following thread. I resu= rrected it from our internal repo, did a bit of manual testing and run the = regression suite without any problem. It basically reads memory from the ta= rget in a buffer in gdb_disassembly and tries to use this buffer in dis_asm= _read_memory instead of reading from the target. This saves us on repeated = memory read calls. The problem was noted when eclipse was trying to fill it= s disassembly view. https://sourceware.org/ml/gdb-patches/2013-10/msg00221.html Regards, Abid 2013-10-10 Taimoor Mirza * disasm.c (DIS_BUF_SIZE): New define. (dis_asm_read_memory): Read from the disassembly buffer instead of target memory directly. (gdb_disassembly): Fill the disassembly buffer with a chunk of the memory to disassemble. --_002_EB3B29AD43CA924DA27099BC85192376E0705106EUMBX03mgcmento_ Content-Type: application/octet-stream; name="disasm.patch" Content-Description: disasm.patch Content-Disposition: attachment; filename="disasm.patch"; size=2939; creation-date="Thu, 10 Oct 2013 13:04:58 GMT"; modification-date="Thu, 10 Oct 2013 13:02:04 GMT" Content-Transfer-Encoding: base64 Content-length: 3986 ZGlmZiAtLWdpdCBhL2dkYi9kaXNhc20uYyBiL2dkYi9kaXNhc20uYwppbmRl eCBlNjQzYzJkLi5kYWVkYzk4IDEwMDY0NAotLS0gYS9nZGIvZGlzYXNtLmMK KysrIGIvZ2RiL2Rpc2FzbS5jCkBAIC00MiwxMSArNDIsNjIgQEAgc3RydWN0 IGRpc19saW5lX2VudHJ5CiAgIENPUkVfQUREUiBlbmRfcGM7CiB9OwogCisv KiBTaXplIG9mIHRoZSBkaXNhc3NlbWJseSBtZW1vcnkgYnVmZmVyLiAgKi8K KyNkZWZpbmUgRElTX0JVRl9TSVpFIDEwMjQKKwogLyogTGlrZSB0YXJnZXRf cmVhZF9tZW1vcnksIGJ1dCBzbGlnaHRseSBkaWZmZXJlbnQgcGFyYW1ldGVy cy4gICovCiBzdGF0aWMgaW50CiBkaXNfYXNtX3JlYWRfbWVtb3J5IChiZmRf dm1hIG1lbWFkZHIsIGdkYl9ieXRlICpteWFkZHIsIHVuc2lnbmVkIGludCBs ZW4sCiAJCSAgICAgc3RydWN0IGRpc2Fzc2VtYmxlX2luZm8gKmluZm8pCiB7 CisgIC8qIEFzc3VtZSB0aGUgZGlzYXNzZW1ibGVyIGFsd2F5cyByZWFkIG1l bW9yeSBmb3J3YXJkcy4gIElmIHdlCisgICAgIGZhaWxlZCB0byByZWFkIGEg YnVmZmVyIGxpbmUgaW4gYSBwcmV2aW91cyBjYWxsLCBhc3N1bWUgd2UncmUK KyAgICAgcmVhZGluZyBjbG9zZSB0byB0aGUgZW5kIG9mIGEgbWFwcGVkIHBh Z2Ugb3Igc2VjdGlvbiwgYW5kIHNvIGl0J3MKKyAgICAgdXNlbGVzcyB0byBr ZWVwIHJldHJ5aW5nIHJlYWRpbmcgdGhhdCBidWZmZXIgbGluZS4gIFNpbXBs eQorICAgICBmYWxsYmFjayB0byByZWFkaW5nIGRpcmVjdGx5IGZyb20gdGFy Z2V0IG1lbW9yeS4gICovCisgIGlmIChpbmZvLT5idWZmZXJfbGVuZ3RoID4g MCkKKyAgICB7CisgICAgICB3aGlsZSAobGVuKQorCXsKKwkgIGlmIChtZW1h ZGRyID49IGluZm8tPmJ1ZmZlcl92bWEKKwkgICAgICAmJiBtZW1hZGRyIDwg aW5mby0+YnVmZmVyX3ZtYSArIGluZm8tPmJ1ZmZlcl9sZW5ndGgpCisJICAg IHsKKwkgICAgICB1bnNpZ25lZCBpbnQgb2Zmc2V0ID0gKG1lbWFkZHIgLSBp bmZvLT5idWZmZXJfdm1hKTsKKwkgICAgICB1bnNpZ25lZCBpbnQgbCA9IG1p biAobGVuLCBpbmZvLT5idWZmZXJfbGVuZ3RoIC0gb2Zmc2V0KTsKKworCSAg ICAgIG1lbWNweSAobXlhZGRyLCBpbmZvLT5idWZmZXIgKyBvZmZzZXQsIGwp OworCisJICAgICAgbWVtYWRkciArPSBsOworCSAgICAgIG15YWRkciArPSBs OworCSAgICAgIGxlbiAtPSBsOworCisJICAgICAgaWYgKGxlbiA9PSAwKQor CQlyZXR1cm4gMDsKKwkgICAgfQorCSAgZWxzZQorCSAgICB7CisJICAgICAg aW50IHJ2YWw7CisJICAgICAgdW5zaWduZWQgaW50IGxlbiA9IGluZm8tPmJ1 ZmZlcl9sZW5ndGg7CisKKwkgICAgICAvKiBUcnkgZmV0Y2hpbmcgYSBuZXcg YnVmZmVyIGxpbmUgZnJvbSB0aGUgdGFyZ2V0LiAgKi8KKworCSAgICAgIC8q IElmIHdlIGZhaWwgcmVhZGluZyBtZW1vcnkgaGFsZndheSwgd2UnbGwgaGF2 ZSBjbG9iYmVyZWQKKwkJIHRoZSBidWZmZXIsIHNvIGRvbid0IHRydXN0IGl0 IGFueW1vcmUsIGV2ZW4gb24gZmFpbC4gICovCisJICAgICAgaW5mby0+YnVm ZmVyX2xlbmd0aCA9IDA7CisJICAgICAgcnZhbCA9IHRhcmdldF9yZWFkX21l bW9yeSAobWVtYWRkciwgaW5mby0+YnVmZmVyLCBsZW4pOworCSAgICAgIGlm IChydmFsID09IDApCisJCXsKKwkJICBpbmZvLT5idWZmZXJfdm1hID0gbWVt YWRkcjsKKwkJICBpbmZvLT5idWZmZXJfbGVuZ3RoID0gbGVuOworCQl9CisJ ICAgICAgZWxzZQorCQl7CisJCSAgLyogUmVhZCBmcm9tIHRhcmdldCBtZW1v cnkgZGlyZWN0bHkgZnJvbSBub3cgb24uICAqLworCQkgIGJyZWFrOworCQl9 CisJICAgIH0KKwl9CisgICAgfQogICByZXR1cm4gdGFyZ2V0X3JlYWRfbWVt b3J5IChtZW1hZGRyLCBteWFkZHIsIGxlbik7CiB9CiAKQEAgLTQxNSw2ICs0 NjYsMTAgQEAgZ2RiX2Rpc2Fzc2VtYmx5IChzdHJ1Y3QgZ2RiYXJjaCAqZ2Ri YXJjaCwgc3RydWN0IHVpX291dCAqdWlvdXQsCiAgIHN0cnVjdCBzeW10YWIg KnN5bXRhYiA9IE5VTEw7CiAgIHN0cnVjdCBsaW5ldGFibGVfZW50cnkgKmxl ID0gTlVMTDsKICAgaW50IG5saW5lcyA9IC0xOworICBpbnQgYnVmZl9zaXpl ID0gRElTX0JVRl9TSVpFOworICBpbnQgcmVxX3NpemUgPSBoaWdoIC0gbG93 OworICBpbnQgZXJyID0gMDsKKyAgZ2RiX2J5dGUgKnBidWZmZXIgPSBOVUxM OwogCiAgIC8qIEFzc3VtZSBzeW10YWIgaXMgdmFsaWQgZm9yIHdob2xlIFBD IHJhbmdlLiAgKi8KICAgc3ltdGFiID0gZmluZF9wY19zeW10YWIgKGxvdyk7 CkBAIC00MjUsNiArNDgwLDIzIEBAIGdkYl9kaXNhc3NlbWJseSAoc3RydWN0 IGdkYmFyY2ggKmdkYmFyY2gsIHN0cnVjdCB1aV9vdXQgKnVpb3V0LAogICAg ICAgbGUgPSBzeW10YWItPmxpbmV0YWJsZS0+aXRlbTsKICAgICAgIG5saW5l cyA9IHN5bXRhYi0+bGluZXRhYmxlLT5uaXRlbXM7CiAgICAgfQorICBpZiAo cmVxX3NpemUgPCBidWZmX3NpemUpCisgICAgYnVmZl9zaXplID0gcmVxX3Np emU7CisKKyAgaWYgKHJlcV9zaXplID4gMCkKKyAgICB7CisgICAgICAvKiBB bGxvY2F0ZSBidWZmZXIgYW5kIHJlYWQgbWVtb3J5IHJlZ2lvbiBpbiBidWZm ZXIuICAqLworICAgICAgcGJ1ZmZlciA9IHhtYWxsb2MgKGJ1ZmZfc2l6ZSk7 CisgICAgICBtYWtlX2NsZWFudXAgKHhmcmVlLCBwYnVmZmVyKTsKKyAgICAg IGVyciA9IHRhcmdldF9yZWFkX21lbW9yeSAobG93LCBwYnVmZmVyLCBidWZm X3NpemUpOworICAgICAgaWYgKGVyciA9PSAwKQorCXsKKwkgIGRpLmJ1ZmZl ciA9IHBidWZmZXI7CisJICBkaS5idWZmZXJfbGVuZ3RoID0gYnVmZl9zaXpl OworCSAgZGkuYnVmZmVyX3ZtYSA9IGxvdzsKKwl9CisgICAgfQorCiAKICAg aWYgKCEoZmxhZ3MgJiBESVNBU1NFTUJMWV9TT1VSQ0UpIHx8IG5saW5lcyA8 PSAwCiAgICAgICB8fCBzeW10YWIgPT0gTlVMTCB8fCBzeW10YWItPmxpbmV0 YWJsZSA9PSBOVUxMKQo= --_002_EB3B29AD43CA924DA27099BC85192376E0705106EUMBX03mgcmento_--