From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14018 invoked by alias); 8 Oct 2013 12:47:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14004 invoked by uid 89); 8 Oct 2013 12:47:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Oct 2013 12:47:20 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VTWh0-0003rc-9R from Hafiz_Abid@mentor.com ; Tue, 08 Oct 2013 05:47:14 -0700 Received: from SVR-IES-FEM-03.mgc.mentorg.com ([137.202.0.108]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 8 Oct 2013 05:47:14 -0700 Received: from EU-MBX-03.mgc.mentorg.com ([169.254.2.112]) by SVR-IES-FEM-03.mgc.mentorg.com ([137.202.0.108]) with mapi id 14.02.0247.003; Tue, 8 Oct 2013 13:47:13 +0100 From: "Abid, Hafiz" To: Pedro Alves , Stan Shebs , "Mirza, Taimoor" CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 0/7 V2] Trust readonly sections if target has memory protection Date: Tue, 08 Oct 2013 12:47:00 -0000 Message-ID: References: <1378432920-7731-1-git-send-email-yao@codesourcery.com> <1378641807-24256-1-git-send-email-yao@codesourcery.com> <201309091916.r89JGbpf009986@glazunov.sibelius.xs4all.nl> <522E9A8A.7040509@codesourcery.com> <52317B66.3020602@codesourcery.com> <201309120949.r8C9nFsJ016506@glazunov.sibelius.xs4all.nl> <5232C9EC.2040707@codesourcery.com> <5249B9F9.4030901@redhat.com> <5249BE1C.5050907@redhat.com> <525335C0.8030004@earthlink.net> <5253F822.2090707@redhat.com> In-Reply-To: <5253F822.2090707@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2013-10/txt/msg00220.txt.bz2 PiBJIGRpc3RpbmN0bHkgcmVtZW1iZXIgcmV2aWV3aW5nIHRoaXMgZm9yIHRo ZSBkaXNhc3NlbWJsZSBjb21tYW5kLCBleGFjdGx5DQo+IGFzIEkgd2FzIHN1 Z2dlc3RpbmcuICBJIG5vdyByZWNhbGwgYmV0dGVyIGJlY2F1c2UgSSBhbHNv IGhhY2tlZCBvbiB0aGUgcGF0Y2gNCj4gd2hpbGUgaXRlcmF0aW5nIG9uIG11 bHRpcGxlIGl0ZXJhdGlvbnMgb2YgcGF0Y2ggcmV2aWV3cy4gIFRoZSBjaGFu Z2Ugd2FzDQo+IGNvbnRhaW5lZCB0byAganVzdCBnZGIvZGlzYXNtLmMgKG9y IHRoZSBncm9zcyBvZiBpdCBhdCBsZWFzdCksIElJUkMuDQo+IEJsZWgsIGlm IHdlIGNhbid0IGZpbmQgaXQsIHdlIGNhbiBhbHdheXMgcmV3cml0ZSBpdC4g IDotUC4NCg0KVGFpbW9vciB3cm90ZSBhIHBhdGNoIGFib3V0IGRpc2Fzc2Vt Ymx5IGltcHJvdmVtZW50IGluIEFwcmlsIDIwMTEuIFBlZHJvIHJldmlldyB0 aGlzIHBhdGNoIGJ1dCBJIHRoaW5rIGl0IHN0YXllZCBpbiBvdXIgaW50ZXJu YWwgcmVwbyBhbmQgbmV2ZXIgd2VudCB1cHN0cmVhbS4gSWYgdGhlcmUgaXMg aW50ZXJlc3QsIEkgY2FuIHRyeSB0byByZXN1cnJlY3QgaXQuDQoNClJlZ2Fy ZHMsDQpBYmlkDQo= >From gdb-patches-return-106108-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Oct 08 13:34:46 2013 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 21344 invoked by alias); 8 Oct 2013 13:34:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21330 invoked by uid 89); 8 Oct 2013 13:34:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Oct 2013 13:34:44 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r98DYd6O001908 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Oct 2013 09:34:39 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r98DYb8P030341; Tue, 8 Oct 2013 09:34:38 -0400 Message-ID: <525409ED.7020200@redhat.com> Date: Tue, 08 Oct 2013 13:34:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Abid, Hafiz" CC: Stan Shebs , "Mirza, Taimoor" , "gdb-patches@sourceware.org" Subject: Re: [PATCH 0/7 V2] Trust readonly sections if target has memory protection References: <1378432920-7731-1-git-send-email-yao@codesourcery.com> <1378641807-24256-1-git-send-email-yao@codesourcery.com> <201309091916.r89JGbpf009986@glazunov.sibelius.xs4all.nl> <522E9A8A.7040509@codesourcery.com> <52317B66.3020602@codesourcery.com> <201309120949.r8C9nFsJ016506@glazunov.sibelius.xs4all.nl> <5232C9EC.2040707@codesourcery.com> <5249B9F9.4030901@redhat.com> <5249BE1C.5050907@redhat.com> <525335C0.8030004@earthlink.net> <5253F822.2090707@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2013-10/txt/msg00221.txt.bz2 Content-length: 707 On 10/08/2013 01:47 PM, Abid, Hafiz wrote: >> I distinctly remember reviewing this for the disassemble command, exactly >> as I was suggesting. I now recall better because I also hacked on the patch >> while iterating on multiple iterations of patch reviews. The change was >> contained to just gdb/disasm.c (or the gross of it at least), IIRC. >> Bleh, if we can't find it, we can always rewrite it. :-P. > > Taimoor wrote a patch about disassembly improvement in April 2011. Pedro review this patch but I think it stayed in our internal repo and never went upstream. If there is interest, I can try to resurrect it. Ah! Thanks for digging that up. Yeah, that'd be great. Thanks, -- Pedro Alves