From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17518 invoked by alias); 24 Jul 2012 16:17:41 -0000 Received: (qmail 17501 invoked by uid 22791); 24 Jul 2012 16:17:37 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jul 2012 16:17:23 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SthnX-00009q-3o from Hafiz_Abid@mentor.com ; Tue, 24 Jul 2012 09:17:23 -0700 Received: from SVR-IES-FEM-05.mgc.mentorg.com ([137.202.0.112]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 24 Jul 2012 09:17:24 -0700 Received: from EU-MBX-03.mgc.mentorg.com ([169.254.2.57]) by SVR-IES-FEM-05.mgc.mentorg.com ([137.202.0.112]) with mapi id 14.01.0289.001; Tue, 24 Jul 2012 17:17:21 +0100 From: "Abid, Hafiz" To: Marc Khouzam CC: "gdb-patches@sourceware.org" , Eli Zaretskii Subject: RE: [patch] MI telnet service Date: Tue, 24 Jul 2012 16:17:00 -0000 Message-ID: References: <837gu9az0t.fsf@gnu.org>, In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00494.txt.bz2 > -----Original Message----- > From: Marc Khouzam [mailto:marc.khouzam@ericsson.com] > Sent: Saturday, July 14, 2012 8:37 PM > To: Abid, Hafiz; Eli Zaretskii > Cc: gdb-patches@sourceware.org > Subject: RE: [patch] MI telnet service >=20 > > > -----Original Message----- > > > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > > > owner@sourceware.org] On Behalf Of Eli Zaretskii > > > Sent: Thursday, July 12, 2012 2:29 PM > > > To: Abid, Hafiz > > > Cc: gdb-patches@sourceware.org > > > Subject: Re: [patch] MI telnet service > > > > > > > From: "Abid, Hafiz" > > > > Date: Thu, 12 Jul 2012 11:20:36 +0000 > > > > > > > > This patch provides implementation of telnet service. This is > based > > > on initial work by Grigory > Tolstolytkin.(http://sourceware.org/ml/gdb- > > > patches/2011-11/msg00466.html) > > > > > > Thanks. A few comments about the documentation part: > > > > > > > +Start a telnet service on the given port. After the service is > > > started, > > > ^^ > > > Two spaces between sentences, please (here and elsewhere, including > in > > > comments to C code). > > > > > > > +user can connect to the gdb via telnet and execute CLI commands > in > > > ^^^ > > > "@value{GDBN}" instead of a literal "gdb". > > > > > > > +new one. For telnet service to work, @value{GDBN} > > > > +should be configured with --enable-gdbmitel=3Dyes. > > > > > > Use @option for options, like this: @samp{--enable-gdbmitel=3Dyes}. > > > > > > Btw, why does it make sense to require a configure-time option for > > > this feature? why not include it by default? > > > > It just felt a bit safer to keep it optional. If community thinks > that > > it is useful feature then I see no problem in making it available by > default. >=20 > I think it makes sense to have a way to turn off this feature. Some > people may > think it is a security issue to have this port open and wish to keep > the feature > completely disabled. However, if Eclipse is to make use of this > feature, it > has to be enabled in GDB, and it would complicate things greatly if we > had to > ask the user to re-compile GDB to enable this setting. It would be > much nicer > if it worked directly in the GDB distributed with their linux box. > Therefore, I hope we can have this setting enabled by default. >=20 > I tried out the patch with and without Eclipse and it looks quite good! > Here are some issues I found: >=20 > - If I set a tty (-inferior-tty-set), GDB exits (or crashes?) when > sending an > empty command (just pressing enter) over telnet. Eclipse uses a tty > for the > inferiors. Can you kindly list the steps to reproduce this crash. I tried but it worke= d ok for me. >=20 > - For every command sent over telnet, there is a printout in the orinal > GDB > saying "Switching to interpreter "console"." Not a big deal, but maybe > something to remove. >=20 > - starting the telnet service, connecting to it, and then stopping the > service (-stop-telnet-service), does no seem to clean up the port > propertly > and I see: > ^error,msg=3D"Error: port 9996 can't be bind" >=20 > - If I start GDB in CLI mode, and try to use the telnet service, GDB > segfaults > after the first command is sent over telnet. I know this service is > not > currently meant to be used with the CLI mode, but it should not crash > :) > I personally think this would be cool to have even for CLI mode, but if > it > won't be for now, maybe the telnet service should be disabled in that > case. >=20 > I realize this is a first and important step, but it will be even nicer > when the telnet service supports tab-completion and command-history. >=20 > This is very exciting! Thanks! >=20 > Marc Thanks for taking time to test. Regards, Abid