From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24303 invoked by alias); 12 Jul 2012 14:45:24 -0000 Received: (qmail 24289 invoked by uid 22791); 12 Jul 2012 14:45:23 -0000 X-SWARE-Spam-Status: No, hits=-4.0 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Jul 2012 14:45:01 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1SpKdY-00020z-Bo from Hafiz_Abid@mentor.com ; Thu, 12 Jul 2012 07:45:00 -0700 Received: from SVR-IES-FEM-03.mgc.mentorg.com ([137.202.0.108]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 12 Jul 2012 07:45:00 -0700 Received: from EU-MBX-03.mgc.mentorg.com ([169.254.2.57]) by SVR-IES-FEM-03.mgc.mentorg.com ([169.254.100.23]) with mapi id 14.01.0289.001; Thu, 12 Jul 2012 15:43:11 +0100 From: "Abid, Hafiz" To: Eli Zaretskii CC: "gdb-patches@sourceware.org" Subject: RE: [patch] MI telnet service Date: Thu, 12 Jul 2012 14:45:00 -0000 Message-ID: References: <837gu9az0t.fsf@gnu.org> In-Reply-To: <837gu9az0t.fsf@gnu.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00163.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org [mailto:gdb-patches- > owner@sourceware.org] On Behalf Of Eli Zaretskii > Sent: Thursday, July 12, 2012 2:29 PM > To: Abid, Hafiz > Cc: gdb-patches@sourceware.org > Subject: Re: [patch] MI telnet service >=20 > > From: "Abid, Hafiz" > > Date: Thu, 12 Jul 2012 11:20:36 +0000 > > > > This patch provides implementation of telnet service. This is based > on initial work by Grigory Tolstolytkin.(http://sourceware.org/ml/gdb- > patches/2011-11/msg00466.html) >=20 > Thanks. A few comments about the documentation part: >=20 > > +Start a telnet service on the given port. After the service is > started, > ^^ > Two spaces between sentences, please (here and elsewhere, including in > comments to C code). >=20 > > +user can connect to the gdb via telnet and execute CLI commands in > ^^^ > "@value{GDBN}" instead of a literal "gdb". >=20 > > +new one. For telnet service to work, @value{GDBN} > > +should be configured with --enable-gdbmitel=3Dyes. >=20 > Use @option for options, like this: @samp{--enable-gdbmitel=3Dyes}. >=20 > Btw, why does it make sense to require a configure-time option for > this feature? why not include it by default? It just felt a bit safer to keep it optional. If community thinks that it i= s useful feature then I see no problem in making it available by default.=20 =20 Thanks, Abid