From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14109 invoked by alias); 21 Jun 2012 08:52:59 -0000 Received: (qmail 14091 invoked by uid 22791); 21 Jun 2012 08:52:57 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,TW_CP X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jun 2012 08:52:43 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1Shd86-0005Y6-2l from Hafiz_Abid@mentor.com ; Thu, 21 Jun 2012 01:52:42 -0700 Received: from SVR-IES-FEM-04.mgc.mentorg.com ([137.202.0.110]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 21 Jun 2012 01:52:01 -0700 Received: from EU-MBX-03.mgc.mentorg.com ([169.254.2.57]) by SVR-IES-FEM-04.mgc.mentorg.com ([137.202.0.110]) with mapi id 14.01.0289.001; Thu, 21 Jun 2012 09:52:34 +0100 From: "Abid, Hafiz" To: "Qi, Yao" , "gdb-patches@sourceware.org" CC: Joel Brobecker Subject: RE: [PATCH/python] notify memory changed. Date: Thu, 21 Jun 2012 08:52:00 -0000 Message-ID: References: <1340075728-24870-1-git-send-email-yao@codesourcery.com> <12411572.tk6EVZMAgM@qiyao.dyndns.org> <20120620145222.GC2799@adacore.com> <1375760.Ghu1pfDITS@qiyao.dyndns.org> In-Reply-To: <1375760.Ghu1pfDITS@qiyao.dyndns.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00653.txt.bz2 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBnZGItcGF0 Y2hlcy1vd25lckBzb3VyY2V3YXJlLm9yZyBbbWFpbHRvOmdkYi1wYXRjaGVz LQ0KPiBvd25lckBzb3VyY2V3YXJlLm9yZ10gT24gQmVoYWxmIE9mIFFpLCBZ YW8NCj4gU2VudDogVGh1cnNkYXksIEp1bmUgMjEsIDIwMTIgMjo1NCBBTQ0K PiBUbzogZ2RiLXBhdGNoZXNAc291cmNld2FyZS5vcmcNCj4gQ2M6IEpvZWwg QnJvYmVja2VyDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0gvcHl0aG9uXSBub3Rp ZnkgbWVtb3J5IGNoYW5nZWQuDQo+IA0KPiBPbiBXZWRuZXNkYXkgMjAgSnVu ZSAyMDEyIDA3OjUyOjIyIEpvZWwgQnJvYmVja2VyIHdyb3RlOg0KPiA+IFBl cmhhcHMsIGZvciBsYXRlciwgd2UgbWlnaHQgd2FudCB0byBoYXZlIGEgbG9v ayBhdCBoYXZpbmcgdHdvDQo+IHJvdXRpbmVzLA0KPiA+IG9uZSAic2lsZW50 IiwgYW5kIG9uZSB0aGF0IG5vdGlmaWVzIHRoZSBvYnNlcnZlcnMsIGEgbGl0 dGxlIGJpdCBsaWtlDQo+ID4gdGhlIHJvdXRpbmUgd2UgaGF2ZSBmb3IgYWRk aW5nIG5ldyB0aHJlYWRzLCBmb3IgaW5zdGFuY2UuDQo+IA0KPiBBZ3JlZWQu ICBIZXJlIGlzIGEgbmV3IG9uZS4NCj4gDQo+IC0tDQo+IFlhbyAo6b2Q5bCn KQ0KPiANCj4gDQo+IDIwMTItMDYtMjEgIFlhbyBRaSAgPHlhb0Bjb2Rlc291 cmNlcnkuY29tPg0KPiANCj4gCSogY29yZWZpbGUuYyAod3JpdGVfbWVtb3J5 X3dpdGhfbm90aWZpY2F0aW9uKTogTmV3Lg0KPiAJSW5jbHVkZSAib2JzZXJ2 ZXIuaCIuDQo+IAkqIGdkYmNvcmUuaDogRGVjbGFyZSB3cml0ZV9tZW1vcnlf d2l0aF9ub3RpZmljYXRpb24uDQo+IAkqIGFkYS1sYW5nLmMgKGFkYV92YWx1 ZV9hc3NpZ24pOiBSZXBsYWNlICd3cml0ZV9tZW1vcnknIGFuZA0KPiAJJ29i c2VydmVyX25vdGlmeV9tZW1vcnlfY2hhbmdlZCcgd2l0aA0KPiAnd3JpdGVf bWVtb3J5X3dpdGhfbm90aWZpY2F0aW9uJy4NCj4gCSogdmFsb3BzLmMgKHZh bHVlX2Fzc2lnbik6IExpa2V3aXNlLg0KPiAJKiBweXRob24vcHktaW5mZXJp b3IuYyAoaW5mcHlfd3JpdGVfbWVtb3J5KTogQ2FsbA0KPiAJJ3dyaXRlX21l bW9yeV93aXRoX25vdGlmaWNhdGlvbicuDQo+IA0KPiAtLS0NCj4gIGdkYi9h ZGEtbGFuZy5jICAgICAgICAgICB8ICAgIDMgKy0tDQo+ICBnZGIvY29yZWZp bGUuYyAgICAgICAgICAgfCAgIDExICsrKysrKysrKysrDQo+ICBnZGIvZ2Ri Y29yZS5oICAgICAgICAgICAgfCAgICA2ICsrKysrKw0KPiAgZ2RiL3B5dGhv bi9weS1pbmZlcmlvci5jIHwgICAgMiArLQ0KPiAgZ2RiL3ZhbG9wcy5jICAg ICAgICAgICAgIHwgICAgNCArLS0tDQo+ICA1IGZpbGVzIGNoYW5nZWQsIDIw IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0t Z2l0IGEvZ2RiL2FkYS1sYW5nLmMgYi9nZGIvYWRhLWxhbmcuYw0KPiBpbmRl eCA2ZjY1NDcyLi43YWZjZWY4IDEwMDY0NA0KPiAtLS0gYS9nZGIvYWRhLWxh bmcuYw0KPiArKysgYi9nZGIvYWRhLWxhbmcuYw0KPiBAQCAtMjUzNCw4ICsy NTM0LDcgQEAgYWRhX3ZhbHVlX2Fzc2lnbiAoc3RydWN0IHZhbHVlICp0b3Zh bCwgc3RydWN0DQo+IHZhbHVlDQo+ICpmcm9tdmFsKQ0KPiAgICAgICAgZWxz ZQ0KPiAgICAgICAgICBtb3ZlX2JpdHMgKGJ1ZmZlciwgdmFsdWVfYml0cG9z ICh0b3ZhbCksDQo+ICAJCSAgIHZhbHVlX2NvbnRlbnRzIChmcm9tdmFsKSwg MCwgYml0cywgMCk7DQo+IC0gICAgICB3cml0ZV9tZW1vcnkgKHRvX2FkZHIs IGJ1ZmZlciwgbGVuKTsNCj4gLSAgICAgIG9ic2VydmVyX25vdGlmeV9tZW1v cnlfY2hhbmdlZCAodG9fYWRkciwgbGVuLCBidWZmZXIpOw0KPiArICAgICAg d3JpdGVfbWVtb3J5X3dpdGhfbm90aWZpY2F0aW9uICh0b19hZGRyLCBidWZm ZXIsIGxlbik7DQo+IA0KPiAgICAgICAgdmFsID0gdmFsdWVfY29weSAodG92 YWwpOw0KPiAgICAgICAgbWVtY3B5ICh2YWx1ZV9jb250ZW50c19yYXcgKHZh bCksIHZhbHVlX2NvbnRlbnRzIChmcm9tdmFsKSwNCj4gZGlmZiAtLWdpdCBh L2dkYi9jb3JlZmlsZS5jIGIvZ2RiL2NvcmVmaWxlLmMNCj4gaW5kZXggNjEx Y2Q2Mi4uYWM4ZWZmNSAxMDA2NDQNCj4gLS0tIGEvZ2RiL2NvcmVmaWxlLmMN Cj4gKysrIGIvZ2RiL2NvcmVmaWxlLmMNCj4gQEAgLTM0LDYgKzM0LDcgQEAN Cj4gICNpbmNsdWRlICJnZGJfc3RhdC5oIg0KPiAgI2luY2x1ZGUgImNvbXBs ZXRlci5oIg0KPiAgI2luY2x1ZGUgImV4Y2VwdGlvbnMuaCINCj4gKyNpbmNs dWRlICJvYnNlcnZlci5oIg0KPiANCj4gIC8qIExvY2FsIGZ1bmN0aW9uIGRl Y2xhcmF0aW9ucy4gICovDQo+IA0KPiBAQCAtMzYxLDYgKzM2MiwxNiBAQCB3 cml0ZV9tZW1vcnkgKENPUkVfQUREUiBtZW1hZGRyLA0KPiAgICAgIG1lbW9y eV9lcnJvciAoc3RhdHVzLCBtZW1hZGRyKTsNCj4gIH0NCj4gDQo+ICsvKiBT YW1lIGFzIHdyaXRlX21lbW9yeSwgYnV0IG5vdGlmeSAnbWVtb3J5X2NoYW5n ZWQnIG9ic2VydmVycy4gICovDQo+ICsNCj4gK3ZvaWQNCj4gK3dyaXRlX21l bW9yeV93aXRoX25vdGlmaWNhdGlvbiAoQ09SRV9BRERSIG1lbWFkZHIsIGNv bnN0IGJmZF9ieXRlDQo+ICpteWFkZHIsDQo+ICsJCQkJc3NpemVfdCBsZW4p DQo+ICt7DQo+ICsgIHdyaXRlX21lbW9yeSAobWVtYWRkciwgbXlhZGRyLCBs ZW4pOw0KPiArICBvYnNlcnZlcl9ub3RpZnlfbWVtb3J5X2NoYW5nZWQgKG1l bWFkZHIsIGxlbiwgbXlhZGRyKTsNCj4gK30NCj4gKw0KRG8geW91IHRoaW5r IGl0IHdpbGwgYmUgdXNlZnVsIHRvIGhhdmUgcGFyYW1ldGVycyBvZiBvYnNl cnZlcl9ub3RpZnlfbWVtb3J5X2NoYW5nZWQgaW4gc2FtZSBvcmRlciBhcyB3 cml0ZV9tZW1vcnkuIFdoZW4gSSBsb29rZWQgYXQgdGhpcyBjb2RlLCBJIGhh ZCB0byBsb29rIGF0IHRoZSBmdW5jdGlvbiB0byBtYWtlIHN1cmUgaXQgd2Fz IG5vdCBhIHR5cG8uDQoNCj4gIC8qIFN0b3JlIFZBTFVFIGF0IEFERFIgaW4g dGhlIGluZmVyaW9yIGFzIGEgTEVOLWJ5dGUgdW5zaWduZWQNCj4gICAgIGlu dGVnZXIuICAqLw0KPiAgdm9pZA0KPiBkaWZmIC0tZ2l0IGEvZ2RiL2dkYmNv cmUuaCBiL2dkYi9nZGJjb3JlLmgNCj4gaW5kZXggMTA4MWYzZi4uZDZjOWRl MiAxMDA2NDQNCj4gLS0tIGEvZ2RiL2dkYmNvcmUuaA0KPiArKysgYi9nZGIv Z2RiY29yZS5oDQo+IEBAIC04Niw2ICs4NiwxMiBAQCBDT1JFX0FERFIgcmVh ZF9tZW1vcnlfdHlwZWRfYWRkcmVzcyAoQ09SRV9BRERSIGFkZHIsDQo+IHN0 cnVjdA0KPiB0eXBlICp0eXBlKTsNCj4gIGV4dGVybiB2b2lkIHdyaXRlX21l bW9yeSAoQ09SRV9BRERSIG1lbWFkZHIsIGNvbnN0IGdkYl9ieXRlICpteWFk ZHIsDQo+ICAJCQkgIHNzaXplX3QgbGVuKTsNCj4gDQo+ICsvKiBTYW1lIGFz IHdyaXRlX21lbW9yeSwgYnV0IG5vdGlmeSAnbWVtb3J5X2NoYW5nZWQnIG9i c2VydmVycy4gICovDQo+ICsNCj4gK2V4dGVybiB2b2lkIHdyaXRlX21lbW9y eV93aXRoX25vdGlmaWNhdGlvbiAoQ09SRV9BRERSIG1lbWFkZHIsDQo+ICsJ CQkJCSAgICBjb25zdCBiZmRfYnl0ZSAqbXlhZGRyLA0KPiArCQkJCQkgICAg c3NpemVfdCBsZW4pOw0KPiArDQo+ICAvKiBTdG9yZSBWQUxVRSBhdCBBRERS IGluIHRoZSBpbmZlcmlvciBhcyBhIExFTi1ieXRlIHVuc2lnbmVkIGludGVn ZXIuDQo+ICovDQo+ICBleHRlcm4gdm9pZCB3cml0ZV9tZW1vcnlfdW5zaWdu ZWRfaW50ZWdlciAoQ09SRV9BRERSIGFkZHIsIGludCBsZW4sDQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZW51bSBi ZmRfZW5kaWFuIGJ5dGVfb3JkZXIsDQo+IGRpZmYgLS1naXQgYS9nZGIvcHl0 aG9uL3B5LWluZmVyaW9yLmMgYi9nZGIvcHl0aG9uL3B5LWluZmVyaW9yLmMN Cj4gaW5kZXggMGVhNGY1NS4uYWE0MTA3MyAxMDA2NDQNCj4gLS0tIGEvZ2Ri L3B5dGhvbi9weS1pbmZlcmlvci5jDQo+ICsrKyBiL2dkYi9weXRob24vcHkt aW5mZXJpb3IuYw0KPiBAQCAtNDkzLDcgKzQ5Myw3IEBAIGluZnB5X3dyaXRl X21lbW9yeSAoUHlPYmplY3QgKnNlbGYsIFB5T2JqZWN0ICphcmdzLA0KPiBQ eU9iamVjdCAqa3cpDQo+ICAJICBlcnJvciA9IDE7DQo+ICAJICBicmVhazsN Cj4gIAl9DQo+IC0gICAgICB3cml0ZV9tZW1vcnkgKGFkZHIsIGJ1ZmZlciwg bGVuZ3RoKTsNCj4gKyAgICAgIHdyaXRlX21lbW9yeV93aXRoX25vdGlmaWNh dGlvbiAoYWRkciwgYnVmZmVyLCBsZW5ndGgpOw0KPiAgICAgIH0NCj4gICAg R0RCX1BZX0hBTkRMRV9FWENFUFRJT04gKGV4Y2VwdCk7DQo+IA0KPiBkaWZm IC0tZ2l0IGEvZ2RiL3ZhbG9wcy5jIGIvZ2RiL3ZhbG9wcy5jDQo+IGluZGV4 IDUwMDIyNzIuLjk3ZDg4OWIgMTAwNjQ0DQo+IC0tLSBhL2dkYi92YWxvcHMu Yw0KPiArKysgYi9nZGIvdmFsb3BzLmMNCj4gQEAgLTEyOTksOSArMTI5OSw3 IEBAIHZhbHVlX2Fzc2lnbiAoc3RydWN0IHZhbHVlICp0b3ZhbCwgc3RydWN0 IHZhbHVlDQo+ICpmcm9tdmFsKQ0KPiAgCSAgICBkZXN0X2J1ZmZlciA9IHZh bHVlX2NvbnRlbnRzIChmcm9tdmFsKTsNCj4gIAkgIH0NCj4gDQo+IC0Jd3Jp dGVfbWVtb3J5IChjaGFuZ2VkX2FkZHIsIGRlc3RfYnVmZmVyLCBjaGFuZ2Vk X2xlbik7DQo+IC0Jb2JzZXJ2ZXJfbm90aWZ5X21lbW9yeV9jaGFuZ2VkIChj aGFuZ2VkX2FkZHIsIGNoYW5nZWRfbGVuLA0KPiAtCQkJCQlkZXN0X2J1ZmZl cik7DQo+ICsJd3JpdGVfbWVtb3J5X3dpdGhfbm90aWZpY2F0aW9uIChjaGFu Z2VkX2FkZHIsIGRlc3RfYnVmZmVyLA0KPiBjaGFuZ2VkX2xlbik7DQo+ICAg ICAgICB9DQo+ICAgICAgICBicmVhazsNCj4gDQo+IC0tDQo+IDEuNy43LjYN Cj4gDQoNCg== >From gdb-patches-return-92321-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Jun 21 09:04:34 2012 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 21306 invoked by alias); 21 Jun 2012 09:04:33 -0000 Received: (qmail 21293 invoked by uid 22791); 21 Jun 2012 09:04:32 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jun 2012 09:04:19 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1ShdJL-00079y-4V from Yao_Qi@mentor.com ; Thu, 21 Jun 2012 02:04:19 -0700 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 21 Jun 2012 02:03:38 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Thu, 21 Jun 2012 02:04:18 -0700 From: Yao Qi To: CC: "Abid, Hafiz" , Joel Brobecker Subject: Re: [PATCH/python] notify memory changed. Date: Thu, 21 Jun 2012 09:04:00 -0000 Message-ID: <2883062.LPF6KAsNoT@qiyao.dyndns.org> User-Agent: KMail/4.8.3 (Linux/3.3.7-1.fc16.i686; KDE/4.8.3; i686; ; ) In-Reply-To: References: <1340075728-24870-1-git-send-email-yao@codesourcery.com> <1375760.Ghu1pfDITS@qiyao.dyndns.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org X-SW-Source: 2012-06/txt/msg00654.txt.bz2 Content-length: 803 On Thursday 21 June 2012 16:52:33 Abid, Hafiz wrote: > > +/* Same as write_memory, but notify 'memory_changed' observers. */ > > + > > +void > > +write_memory_with_notification (CORE_ADDR memaddr, const bfd_byte > > *myaddr, > > + ssize_t len) > > +{ > > + write_memory (memaddr, myaddr, len); > > + observer_notify_memory_changed (memaddr, len, myaddr); > > +} > > + >=20 > Do you think it will be useful to have parameters of > observer_notify_memory_changed in same order as write_memory. When I look= ed > at this code, I had to look at the function to make sure it was not a typ= o. Hafiz, I am not sure. Both 'write_memory' and 'observer_notify_memory_changed'=20 exists here for some years, and I guess people get use to them. --=20 Yao Qi (=E9=BD=90=E5=B0=A7)