From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13678 invoked by alias); 20 Feb 2019 11:52:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13657 invoked by uid 89); 20 Feb 2019 11:52:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=junior X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30065.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Feb 2019 11:52:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eUgH27kusrt59CSKWood6s+dho4BEqbqIIY+ZKpQwE4=; b=RKXubDqvVsA5gK8SmjhW4jhjMPcy4vrdM0BgiGrzMENoFJTrcST1kSKuRUYs5yaap/2kX7+epGxzsVtNFauspFuqssBs3JjM+yBgbfl98wm+VJSWGboUDg4K4k6R6EZLaiCQgjBmxTHKfCSZB8i693XK2Af/WP6GOYcxB9hanA0= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2552.eurprd08.prod.outlook.com (10.172.252.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1622.19; Wed, 20 Feb 2019 11:52:46 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7%3]) with mapi id 15.20.1622.020; Wed, 20 Feb 2019 11:52:45 +0000 From: Alan Hayward To: Sergio Durigan Junior CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2] Testsuite: Ensure stack protection is off for GCC Date: Wed, 20 Feb 2019 11:52:00 -0000 Message-ID: References: <20190118172550.65430-1-alan.hayward@arm.com> <87a7ir7inq.fsf@redhat.com> In-Reply-To: <87a7ir7inq.fsf@redhat.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-exchange-purlcount: 4 received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: <4D86F7754D6D7E448FDA24EA691A7E87@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00328.txt.bz2 DQoNCj4gT24gMTkgRmViIDIwMTksIGF0IDE4OjExLCBTZXJnaW8gRHVyaWdh biBKdW5pb3IgPHNlcmdpb2RqQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4g T24gRnJpZGF5LCBKYW51YXJ5IDE4IDIwMTksIEFsYW4gSGF5d2FyZCB3cm90 ZToNCj4gDQo+PiBVc2luZyAtZnN0YWNrLXByb3RlY3Rvci1zdHJvbmcgd2ls bCBjYXVzZSBHREIgdG8gYnJlYWsgb24gdGhlIHdyb25nIGxpbmUNCj4+IHdo ZW4gcGxhY2luZyBhIGJyZWFrcG9pbnQgb24gYSBmdW5jdGlvbi4gIFRoaXMg aXMgZHVlIHRvIGluYWRlcXVhdGUgZHdhcmYNCj4+IGxpbmUgbnVtYmVyaW5n LCBhbmQgaXMgYmVpbmcgdHJhY2tlZCBieSB0aGUgR0NDIGJ1Zw0KPj4gaHR0 cHM6Ly9nY2MuZ251Lm9yZy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/aWQ9ODg0 MzINCj4+IA0KPj4gR0NDIChhbmQgQ2xhbmcpIHByb3ZpZGVkIGJ5IERlYmlh bi9VYnVudHUgZGVmYXVsdCB0byBzdGFjayBwcm90ZWN0b3INCj4+IGJlaW5n IGVuYWJsZWQuDQo+PiANCj4+IEVuc3VyZSB0aGF0IHdoZW4gcnVubmluZyB0 aGUgR0RCIHRlc3RzdWl0ZSwgc3RhY2sgcHJvdGVjdG9yIGlzIGFsd2F5cw0K Pj4gdHVybmVkIG9mZiBmb3IgR0NDIDQuMS4wICh3aGVuIHN0YWNrIHByb3Rl Y3RvciB3YXMgYWRkZWQpIGFuZCBhYm92ZS4NCj4+IA0KPj4gRW5zdXJlIHRo YXQgdGhpcyBkb2VzIG5vdCBjYXVzZSBpbmZpbml0ZSByZWN1cnNpb24gZHVl IHRvDQo+PiB0ZXN0X2NvbXBpbGVyX2luZm8gaGF2aW5nIHRvIGNvbXBpbGUg YSBmaWxlIGl0c2VsZi4NCj4+IA0KPj4gQWRkIGEgdGVzdCB0byBleHBsaWNp dGx5IHRlc3QgYnJlYWtwb2ludHMgd2l0aCB2YXJpb3VzIGxldmVscyBvZiBz dGFjaw0KPj4gcHJvdGVjdGlvbiBvbiBib3RoIEdDQyBhbmQgQ2xhbmcsIHdp dGggeGZhaWwgZm9yIHRoZSBrbm93biBlcnJvcnMuDQo+PiANCj4+IFJlc3Rv cmUgY2hhbmdlIGluIG92bGRicmVhay5leHAgd2hpY2ggd29ya2VkIGFyb3Vu ZCB0aGUgaXNzdWUuDQo+IA0KPiBIaSBBbGFuLA0KPiANCj4gVGhpcyBjb21t aXQgaGFzIGNhdXNlZCBhIHByb2JsZW0gd2hlbiB3ZSBydW4gdGhlIHRlc3Rz dWl0ZSBpbiBwYXJhbGxlbA0KPiBtb2RlLiAgRm9yIHNvbWUgcmVhc29uLCB0 aGUgIj09PSBnZGIgU3VtbWFyeSA9PT0iIGxpbmUgaXMgbm90IGJlaW5nDQo+ IGdlbmVyYXRlZCBmb3IgYSBmZXcgdGVzdGNhc2VzLiAgVGhpcyBpcyBjYXVz aW5nIHRoZSBjb25zb2xpZGF0aW9uIHNjcmlwdA0KPiB0aGF0IHJ1bnMgYXQg dGhlIGVuZCBvZiB0aGUgdGVzdHN1aXRlIHRvIGZhaWwsIHdoaWNoIHRoZW4g Y2F1c2VzIGdkYi5sb2cNCj4gdG8gYmUgZW1wdHkuDQo+IA0KPiBUaGUgQnVp bGRCb3QgaXMgZW5jb3VudGVyaW5nIHRoaXMgZXJyb3IgKGJlY2F1c2Ugd2Ug YWx3YXlzIHJ1biB0aGUgdGVzdHMNCj4gaW4gcGFyYWxsZWwgdGhlcmUpOyB5 b3UgY2FuIHNlZSBhbiBleGFtcGxlIG9mIGl0IGhlcmU6DQo+IA0KPiAgaHR0 cHM6Ly9nZGItYnVpbGQuc2VyZ2lvZGoubmV0L2J1aWxkZXJzL0ZlZG9yYS14 ODZfNjQtbTY0L2J1aWxkcy8xMTk2Ny9zdGVwcy90ZXN0JTIwZ2RiL2xvZ3Mv c3RkaW8NCj4gDQo+IEdvIHRvIHRoZSBlbmQgb2YgdGhlIHBhZ2UgYW5kIGxv b2sgZm9yDQo+IA0KPiAgb3V0cHV0cy9nZGIuYmFzZS9mdWxscGF0aC1leHBh bmQvZ2RiLmxvZzogbm8gcmVjb2duaXNlZCBzdW1tYXJ5IGxpbmUNCj4gDQo+ IEkgY2FuIHJlcHJvZHVjZSB0aGlzIGxvY2FsbHkgYnkgZG9pbmc6DQo+IA0K PiAgbWFrZSAtayBjaGVjayBURVNUUz1nZGIuYmFzZS8qLmV4cCBGT1JDRV9Q QVJBTExFTD0xIC1qNA0KPiANCj4gSW5pdGlhbGx5IEkgZG9uJ3Qga25vdyB3 aGF0IGNvdWxkIGNhdXNlIHRoaXMgcHJvYmxlbSwgYmVjYXVzZSB5b3VyDQo+ IGNoYW5nZXMgc2VlbSB2ZXJ5IGhhcm1sZXNzLiAgRWl0aGVyIHdheSwgSSdk IGFwcHJlY2lhdGUgaWYgeW91IGNvdWxkDQo+IHRha2UgYSBsb29rIGF0IHRo aXMgYXMgd2VsbC4NCj4gDQoNClRoYXTigJlzIHZlcnkgd2VpcmQhIEnigJl2 ZSBleHBlcmllbmNlZCB0aGUgaXNzdWUgbXlzZWxmLCBidXQgYXNzdW1lZCBp dCBoYWQgYmVlbg0KYW4gaW50ZW50aW9uYWwgY2hhbmdlIGVsc2V3aGVyZS4g SeKAmWxsIGxvb2sgaW50byBpdC4NCg0KDQpBbGFuLg0KDQoNCg0KDQo+IFRo YW5rcywNCj4gDQo+PiBnZGIvdGVzdHN1aXRlL0NoYW5nZUxvZzoNCj4+IA0K Pj4gMjAxOS0wMS0xOCAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJkQGFy bS5jb20+DQo+PiANCj4+IAkqIGdkYi5iYXNlL3N0YWNrLXByb3RlY3Rvci5j OiBOZXcgdGVzdC4NCj4+IAkqIGdkYi5iYXNlL3N0YWNrLXByb3RlY3Rvci5l eHA6IE5ldyBmaWxlLg0KPj4gICAgICAgICogZ2RiLmNwL292bGRicmVhay5l eHA6IE9ubHkgYWxsb3cgYSBzaW5nbGUgYnJlYWsgbGluZS4NCj4+ICAgICAg ICAqIGxpYi9nZGIuZXhwIChnZXRfY29tcGlsZXJfaW5mbyk6IFVzZSBnZXR0 aW5nX2NvbXBpbGVyX2luZm8gb3B0aW9uLg0KPj4gICAgICAgIChnZGJfY29t cGlsZSk6IFJlbW92ZSBzdGFjayBwcm90ZWN0b3IgZm9yIEdDQyBhbmQgcHJl dmVudCByZWN1cnNpb24uDQo+PiAtLS0NCj4+IGdkYi90ZXN0c3VpdGUvZ2Ri LmJhc2Uvc3RhY2stcHJvdGVjdG9yLmMgICB8IDI3ICsrKysrKysrKw0KPj4g Z2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9zdGFjay1wcm90ZWN0b3IuZXhwIHwg NjggKysrKysrKysrKysrKysrKysrKysrKw0KPj4gZ2RiL3Rlc3RzdWl0ZS9n ZGIuY3Avb3ZsZGJyZWFrLmV4cCAgICAgICAgIHwgIDIgKy0NCj4+IGdkYi90 ZXN0c3VpdGUvbGliL2dkYi5leHAgICAgICAgICAgICAgICAgICB8IDIwICsr KysrKy0NCj4+IDQgZmlsZXMgY2hhbmdlZCwgMTE0IGluc2VydGlvbnMoKyks IDMgZGVsZXRpb25zKC0pDQo+PiBjcmVhdGUgbW9kZSAxMDA2NDQgZ2RiL3Rl c3RzdWl0ZS9nZGIuYmFzZS9zdGFjay1wcm90ZWN0b3IuYw0KPj4gY3JlYXRl IG1vZGUgMTAwNjQ0IGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2Uvc3RhY2stcHJv dGVjdG9yLmV4cA0KPj4gDQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0 ZS9nZGIuYmFzZS9zdGFjay1wcm90ZWN0b3IuYyBiL2dkYi90ZXN0c3VpdGUv Z2RiLmJhc2Uvc3RhY2stcHJvdGVjdG9yLmMNCj4+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0DQo+PiBpbmRleCAwMDAwMDAwMDAwLi41ZTA0ODg1OWE3DQo+PiAt LS0gL2Rldi9udWxsDQo+PiArKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNl L3N0YWNrLXByb3RlY3Rvci5jDQo+PiBAQCAtMCwwICsxLDI3IEBADQo+PiAr LyogVGhpcyB0ZXN0IHByb2dyYW0gaXMgcGFydCBvZiBHREIsIHRoZSBHTlUg ZGVidWdnZXIuDQo+PiArDQo+PiArICAgQ29weXJpZ2h0IDIwMTkgRnJlZSBT b2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuDQo+PiArDQo+PiArICAgVGhpcyBw cm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRl IGl0IGFuZC9vciBtb2RpZnkNCj4+ICsgICBpdCB1bmRlciB0aGUgdGVybXMg b2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hl ZCBieQ0KPj4gKyAgIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVp dGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yDQo+PiArICAgKGF0 IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4NCj4+ICsNCj4+ICsg ICBUaGlzIHByb2dyYW0gaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhh dCBpdCB3aWxsIGJlIHVzZWZ1bCwNCj4+ICsgICBidXQgV0lUSE9VVCBBTlkg V0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBv Zg0KPj4gKyAgIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBB UlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUNCj4+ICsgICBHTlUgR2VuZXJh bCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLg0KPj4gKw0KPj4g KyAgIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdO VSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlDQo+PiArICAgYWxvbmcgd2l0aCB0 aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3Jn L2xpY2Vuc2VzLz4uICAqLw0KPj4gKw0KPj4gK2ludCBmb28gKGludCBhKQ0K Pj4gK3sNCj4+ICsgIHJldHVybiBhICsgNzsgLyogYnJlYWsgaGVyZS4gICov DQo+PiArfQ0KPj4gKw0KPj4gK2ludA0KPj4gK21haW4gKCkNCj4+ICt7DQo+ PiArICByZXR1cm4gZm9vICg1KTsNCj4+ICt9DQo+PiBkaWZmIC0tZ2l0IGEv Z2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9zdGFjay1wcm90ZWN0b3IuZXhwIGIv Z2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9zdGFjay1wcm90ZWN0b3IuZXhwDQo+ PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPj4gaW5kZXggMDAwMDAwMDAwMC4u YWQ4YzE1ZGU5Zg0KPj4gLS0tIC9kZXYvbnVsbA0KPj4gKysrIGIvZ2RiL3Rl c3RzdWl0ZS9nZGIuYmFzZS9zdGFjay1wcm90ZWN0b3IuZXhwDQo+PiBAQCAt MCwwICsxLDY4IEBADQo+PiArIyBDb3B5cmlnaHQgKEMpIDIwMTkgRnJlZSBT b2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuDQo+PiArDQo+PiArIyBUaGlzIHBy b2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUg aXQgYW5kL29yIG1vZGlmeQ0KPj4gKyMgaXQgdW5kZXIgdGhlIHRlcm1zIG9m IHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQg YnkNCj4+ICsjIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhl ciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yDQo+PiArIyAoYXQgeW91 ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLg0KPj4gKyMNCj4+ICsjIFRo aXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0 IHdpbGwgYmUgdXNlZnVsLA0KPj4gKyMgYnV0IFdJVEhPVVQgQU5ZIFdBUlJB TlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YNCj4+ ICsjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VM QVIgUFVSUE9TRS4gIFNlZSB0aGUNCj4+ICsjIEdOVSBHZW5lcmFsIFB1Ymxp YyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuDQo+PiArIw0KPj4gKyMgWW91 IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVy YWwgUHVibGljIExpY2Vuc2UNCj4+ICsjIGFsb25nIHdpdGggdGhpcyBwcm9n cmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNlbnNl cy8+Lg0KPj4gKw0KPj4gKyMgVGVzdCBicmVha3BvaW50cyB3b3JrIGNvcnJl Y3RseSB3aGVuIHN0YWNrIHByb3RlY3RvciBpcyB1c2VkLg0KPj4gKw0KPj4g KyMgTm90ZSBvbiBEZWJpYW4vVWJ1bnR1LCBzdGFjayBwcm90ZWN0b3IgaXMg b24gYnkgZGVmYXVsdCwgYW5kIGlzDQo+PiArIyBjdXJyZW50bHkgZm9yY2Ug ZGlzYWJsZWQgaW4gZ2RiX2NvbXBpbGUgZHVlIHRvIHRoZSBYRkFJTCBiZWxv dy4NCj4+ICsNCj4+ICsjIEVuc3VyZSB0aGUgY29tcGlsZXIgaXMgZ2NjL2Ns YW5nIGFuZCBpcyBuZXcgZW5vdWdoIHRvIHN1cHBvcnQgc3RhY2sNCj4+ICsj IHByb3RlY3Rpb24uDQo+PiAraWYgeyAhKFt0ZXN0X2NvbXBpbGVyX2luZm8g ImdjYy0qIl0gfHwgW3Rlc3RfY29tcGlsZXJfaW5mbyAiY2xhbmctKiJdKQ0K Pj4gKyAgICAgfHwgW3Rlc3RfY29tcGlsZXJfaW5mbyB7Z2NjLVswLTNdLSp9 XQ0KPj4gKyAgICAgfHwgW3Rlc3RfY29tcGlsZXJfaW5mbyB7Z2NjLTQtMC0q fV0NCj4+ICsgICAgIHx8IFt0ZXN0X2NvbXBpbGVyX2luZm8ge2NsYW5nLVsw LTRdPSp9XSB9IHsNCj4+ICsgICAgcmV0dXJuIDANCj4+ICt9DQo+PiArDQo+ PiArc3RhbmRhcmRfdGVzdGZpbGUNCj4+ICsNCj4+ICtzZXQgcHJvdGVjdG9y X29wdGlvbnMgeyAiLWZuby1zdGFjay1wcm90ZWN0b3IiICItZnN0YWNrLXBy b3RlY3RvciIgXA0KPj4gKwkJCSItZnN0YWNrLXByb3RlY3Rvci1hbGwiICIt ZnN0YWNrLXByb3RlY3Rvci1zdHJvbmciIH0NCj4+ICsNCj4+ICtwcm9jIHNp bXBsZV9mdW5jX2JyZWFrX3Rlc3QgeyBwcm90ZWN0aW9uIH0gew0KPj4gKyAg ICBnbG9iYWwgdGVzdGZpbGUNCj4+ICsgICAgZ2xvYmFsIHNyY2ZpbGUNCj4+ ICsgICAgZ2xvYmFsIGJpbmZpbGUNCj4+ICsNCj4+ICsgICAgc2V0IG9wdGlv bnMgZGVidWcNCj4+ICsgICAgbGFwcGVuZCBvcHRpb25zIGFkZGl0aW9uYWxf ZmxhZ3M9JHByb3RlY3Rpb24NCj4+ICsNCj4+ICsgICAgaWYge1twcmVwYXJl X2Zvcl90ZXN0aW5nICJmYWlsZWQgdG8gcHJlcGFyZSIgJHRlc3RmaWxlICRz cmNmaWxlICRvcHRpb25zXX0gew0KPj4gKwlyZXR1cm4gLTENCj4+ICsgICAg fQ0KPj4gKw0KPj4gKyAgICBjbGVhbl9yZXN0YXJ0ICR7YmluZmlsZX0NCj4+ ICsNCj4+ICsgICAgaWYgeyAhW3J1bnRvX21haW5dIH0gdGhlbiB7DQo+PiAr CWZhaWwgImNhbid0IHJ1biB0byBtYWluIg0KPj4gKwlyZXR1cm4gLTENCj4+ ICsgICAgfQ0KPj4gKw0KPj4gKyAgICAjIEJyZWFrIG9uIGZ1bmN0aW9uIGZv byBhbmQgZW5zdXJlIGl0IHN0b3BzIG9uIHRoZSBmaXJzdCBsaW5lIG9mIGNv ZGUuDQo+PiArICAgIGdkYl9icmVha3BvaW50ICJmb28iDQo+PiArDQo+PiAr ICAgIGlmIHsgJHByb3RlY3Rpb24gPT0gIi1mc3RhY2stcHJvdGVjdG9yLWFs bCINCj4+ICsgICAgICAgICAmJiBbdGVzdF9jb21waWxlcl9pbmZvICJnY2Mt KiJdIH0gew0KPj4gKwlzZXR1cF94ZmFpbCAiZ2NjLzg4NDMyIiAiKi0qLWxp bnV4KiINCj4+ICsgICAgfQ0KPj4gKyAgICBnZGJfY29udGludWVfdG9fYnJl YWtwb2ludCAiZm9vIiAiLipicmVhayBoZXJlLioiDQo+PiArDQo+PiArICAg IHJldHVybiAxDQo+PiArfQ0KPj4gKw0KPj4gK2ZvcmVhY2hfd2l0aF9wcmVm aXggcHJvdGVjdGlvbiAkcHJvdGVjdG9yX29wdGlvbnMgew0KPj4gKyAgICBz aW1wbGVfZnVuY19icmVha190ZXN0ICRwcm90ZWN0aW9uDQo+PiArfQ0KPj4g ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmNwL292bGRicmVhay5l eHAgYi9nZGIvdGVzdHN1aXRlL2dkYi5jcC9vdmxkYnJlYWsuZXhwDQo+PiBp bmRleCA0OTRmMmExMmU5Li4zZmZkMDQyMDlhIDEwMDY0NA0KPj4gLS0tIGEv Z2RiL3Rlc3RzdWl0ZS9nZGIuY3Avb3ZsZGJyZWFrLmV4cA0KPj4gKysrIGIv Z2RiL3Rlc3RzdWl0ZS9nZGIuY3Avb3ZsZGJyZWFrLmV4cA0KPj4gQEAgLTIw OSw3ICsyMDksNyBAQCBmb3Ige3NldCBpZHggMH0geyRpZHggPCBbbGxlbmd0 aCAkb3ZlcmxvYWRzXX0ge2luY3IgaWR4fSB7DQo+PiANCj4+ICMgVmVyaWZ5 IHRoZSBicmVha3BvaW50cy4NCj4+IHNldCBicHRhYmxlICJOdW1cW1x0IFxd K1R5cGVcW1x0IFxdK0Rpc3AgRW5iIEFkZHJlc3NcW1x0IFxdK1doYXQuKlxb XHJcbl0rIg0KPj4gLWFwcGVuZCBicHRhYmxlICJcWzAtOVxdK1xbXHQgXF0r YnJlYWtwb2ludFxbXHQgXF0ra2VlcFxbXHQgXF15XFtcdCBcXSskaGV4XFtc dCBcXStpbiBtYWluKFxcKCh8dm9pZClcXCkpPyBhdC4qJHNyY2ZpbGU6NFxb ODlcXVxbXHJcblxdKyINCj4+ICthcHBlbmQgYnB0YWJsZSAiXFswLTlcXStc W1x0IFxdK2JyZWFrcG9pbnRcW1x0IFxdK2tlZXBcW1x0IFxdeVxbXHQgXF0r JGhleFxbXHQgXF0raW4gbWFpbihcXCgofHZvaWQpXFwpKT8gYXQuKiRzcmNm aWxlOjQ5XFtcclxuXF0rIg0KPj4gYXBwZW5kIGJwdGFibGUgIlxbXHQgXF0r YnJlYWtwb2ludCBhbHJlYWR5IGhpdCAxIHRpbWVcW1xyXG5cXSsuIg0KPj4g Zm9yZWFjaCBvdmxkICRvdmVybG9hZHMgew0KPj4gICAgIGFwcGVuZCBicHRh YmxlIFtmb3JtYXQgIlxbMC05XF0rXFtcdCBcXSticmVha3BvaW50XFtcdCBc XStrZWVwIHlcW1x0IFxdKyRoZXhcW1x0IFxdK2luIGZvbzo6b3ZlcmxvYWQx YXJnXFwoJXNcXCkgYXQuKiRzcmNmaWxlOiVkXFtcclxuXF0rIiAkb3ZsZCBc DQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cCBi L2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHANCj4+IGluZGV4IGVkOWY4OWQ1 YTcuLmMxYjIyNjA5YTYgMTAwNjQ0DQo+PiAtLS0gYS9nZGIvdGVzdHN1aXRl L2xpYi9nZGIuZXhwDQo+PiArKysgYi9nZGIvdGVzdHN1aXRlL2xpYi9nZGIu ZXhwDQo+PiBAQCAtMzI3NiwxMiArMzI3NiwxMiBAQCBwcm9jIGdldF9jb21w aWxlcl9pbmZvIHt7YXJnICIifX0gew0KPj4gCSMgV2UgaGF2ZSB0byB1c2Ug LUUgYW5kIC1vIHRvZ2V0aGVyLCBkZXNwaXRlIHRoZSBjb21tZW50cw0KPj4g CSMgYWJvdmUsIGJlY2F1c2Ugb2YgaG93IERlamFHbnUgaGFuZGxlcyByZW1v dGUgaG9zdCB0ZXN0aW5nLg0KPj4gCXNldCBwcG91dCAiJG91dGRpci9jb21w aWxlci5pIg0KPj4gLQlnZGJfY29tcGlsZSAiJHtpZmlsZX0iICIkcHBvdXQi IHByZXByb2Nlc3MgW2xpc3QgIiRhcmciIHF1aWV0XQ0KPj4gKwlnZGJfY29t cGlsZSAiJHtpZmlsZX0iICIkcHBvdXQiIHByZXByb2Nlc3MgW2xpc3QgIiRh cmciIHF1aWV0IGdldHRpbmdfY29tcGlsZXJfaW5mb10NCj4+IAlzZXQgZmls ZSBbb3BlbiAkcHBvdXQgcl0NCj4+IAlzZXQgY3Bwb3V0IFtyZWFkICRmaWxl XQ0KPj4gCWNsb3NlICRmaWxlDQo+PiAgICAgfSBlbHNlIHsNCj4+IC0Jc2V0 IGNwcG91dCBbIGdkYl9jb21waWxlICIke2lmaWxlfSIgIiIgcHJlcHJvY2Vz cyBbbGlzdCAiJGFyZyIgcXVpZXRdIF0NCj4+ICsJc2V0IGNwcG91dCBbIGdk Yl9jb21waWxlICIke2lmaWxlfSIgIiIgcHJlcHJvY2VzcyBbbGlzdCAiJGFy ZyIgcXVpZXQgZ2V0dGluZ19jb21waWxlcl9pbmZvXSBdDQo+PiAgICAgfQ0K Pj4gICAgIGV2YWwgbG9nX2ZpbGUgJHNhdmVkX2xvZw0KPj4gDQo+PiBAQCAt MzUxOSw2ICszNTE5LDcgQEAgcHJvYyBnZGJfY29tcGlsZSB7c291cmNlIGRl c3QgdHlwZSBvcHRpb25zfSB7DQo+PiAgICAgfQ0KPj4gICAgIHNldCBzaGxp Yl9mb3VuZCAwDQo+PiAgICAgc2V0IHNobGliX2xvYWQgMA0KPj4gKyAgICBz ZXQgZ2V0dGluZ19jb21waWxlcl9pbmZvIDANCj4+ICAgICBmb3JlYWNoIG9w dCAkb3B0aW9ucyB7DQo+PiAgICAgICAgIGlmIHtbcmVnZXhwIHtec2hsaWI9 KC4qKX0gJG9wdCBkdW1teV92YXIgc2hsaWJfbmFtZV0NCj4+IAkgICAgJiYg JHR5cGUgPT0gImV4ZWN1dGFibGUifSB7DQo+PiBAQCAtMzU0OSwxMSArMzU1 MCwyNiBAQCBwcm9jIGdkYl9jb21waWxlIHtzb3VyY2UgZGVzdCB0eXBlIG9w dGlvbnN9IHsNCj4+ICAgICAgICAgICAgIH0NCj4+IAl9IGVsc2VpZiB7ICRv cHQgPT0gInNobGliX2xvYWQiICYmICR0eXBlID09ICJleGVjdXRhYmxlIiB9 IHsNCj4+IAkgICAgc2V0IHNobGliX2xvYWQgMQ0KPj4gKwl9IGVsc2VpZiB7 ICRvcHQgPT0gImdldHRpbmdfY29tcGlsZXJfaW5mbyIgfSB7DQo+PiArCSAg ICAjIElmIHRoaXMgaXMgc2V0LCBjYWxsaW5nIHRlc3RfY29tcGlsZXJfaW5m byB3aWxsIGNhdXNlIHJlY3Vyc2lvbi4NCj4+ICsJICAgIHNldCBnZXR0aW5n X2NvbXBpbGVyX2luZm8gMQ0KPj4gICAgICAgICB9IGVsc2Ugew0KPj4gICAg ICAgICAgICAgbGFwcGVuZCBuZXdfb3B0aW9ucyAkb3B0DQo+PiAgICAgICAg IH0NCj4+ICAgICB9DQo+PiANCj4+ICsgICAgIyBFbnN1cmUgc3RhY2sgcHJv dGVjdG9yIGlzIGRpc2FibGVkIGZvciBHQ0MsIGFzIHRoaXMgd2lsbCBjYXVz ZXMgcHJvYmxlbXMNCj4+ICsgICAgIyB3aXRoIERXQVJGIGxpbmUgbnVtYmVy aW5nLg0KPj4gKyAgICAjIFNlZSBodHRwczovL2djYy5nbnUub3JnL2J1Z3pp bGxhL3Nob3dfYnVnLmNnaT9pZD04ODQzMg0KPj4gKyAgICAjIFRoaXMgb3B0 aW9uIGRlZmF1bHRzIHRvIG9uIGZvciBEZWJpYW4vVWJ1bnR1Lg0KPj4gKyAg ICBpZiB7ICRnZXR0aW5nX2NvbXBpbGVyX2luZm8gPT0gMA0KPj4gKwkgJiYg W3Rlc3RfY29tcGlsZXJfaW5mbyB7Z2NjLSotKn1dDQo+PiArCSAmJiAhKFt0 ZXN0X2NvbXBpbGVyX2luZm8ge2djYy1bMC0zXS0qfV0NCj4+ICsJICAgICAg fHwgW3Rlc3RfY29tcGlsZXJfaW5mbyB7Z2NjLTQtMC0qfV0pIH0gew0KPj4g KyAgICAgICAgIyBQdXQgaXQgYXQgdGhlIGZyb250IHRvIG5vdCBvdmVycmlk ZSBhbnkgdXNlci1wcm92aWRlZCB2YWx1ZQ0KPj4gKyAgICAgICAgbGFwcGVu ZCBuZXdfb3B0aW9ucyAiZWFybHlfZmxhZ3M9LWZuby1zdGFjay1wcm90ZWN0 b3IiDQo+PiArICAgIH0NCj4+ICsNCj4+ICAgICAjIEJlY2F1c2Ugd2UgbGlu ayB3aXRoIGxpYnJhcmllcyB1c2luZyB0aGVpciBiYXNlbmFtZSwgd2UgbWF5 IG5lZWQNCj4+ICAgICAjIChkZXBlbmRpbmcgb24gdGhlIHBsYXRmb3JtKSB0 byBzZXQgYSBzcGVjaWFsIHJwYXRoIHZhbHVlLCB0byBhbGxvdw0KPj4gICAg ICMgdGhlIGV4ZWN1dGFibGUgdG8gZmluZCB0aGUgbGlicmFyaWVzIGl0IGRl cGVuZHMgb24uDQo+PiAtLSANCj4+IDIuMTcuMiAoQXBwbGUgR2l0LTExMykN Cj4gDQo+IC0tIA0KPiBTZXJnaW8NCj4gR1BHIGtleSBJRDogMjM3QSA1NEIx IDAyODcgMjhCRiAwMEVGICAzMUY0IEQwRUIgNzYyOCA2NUZDIDVFMzYNCj4g UGxlYXNlIHNlbmQgZW5jcnlwdGVkIGUtbWFpbCBpZiBwb3NzaWJsZQ0KPiBo dHRwOi8vc2VyZ2lvZGoubmV0Lw0KDQo= >From gdb-patches-return-154062-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Feb 20 15:54:25 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 66429 invoked by alias); 20 Feb 2019 15:54:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 66418 invoked by uid 89); 20 Feb 2019 15:54:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=U*palves, sk:palves, sk:palves@, palvesredhatcom X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Feb 2019 15:54:20 +0000 Received: by mail-wr1-f65.google.com with SMTP id t18so26641206wrx.2 for ; Wed, 20 Feb 2019 07:54:20 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:75e6:857f:3506:a1f4? ([2001:8a0:f913:f700:75e6:857f:3506:a1f4]) by smtp.gmail.com with ESMTPSA id j22sm3894830wre.34.2019.02.20.07.54.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 07:54:18 -0800 (PST) Subject: Re: [PATCH] Prevent overflow in rl_set_screen_size To: Tom Tromey References: <20190214185254.15369a0a@f29-4.lan> <9e42397a-e3a5-0296-d239-70f4c7c0d215@redhat.com> <87wom0yfcb.fsf@tromey.com> Cc: Kevin Buettner , gdb-patches@sourceware.org, Saagar Jha From: Pedro Alves Message-ID: Date: Wed, 20 Feb 2019 15:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87wom0yfcb.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00329.txt.bz2 Content-length: 2235 On 02/15/2019 08:19 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> so if the function takes int parameters without specifying an upper bound, it > Pedro> seems like a readline bug to me to not consider large numbers. > > True, though it doesn't hurt to also check in gdb. Yeah, that's what I meant to imply with "It might be reasonable to have this as workaround" Maybe not the best choice of words. > > What's funny is that readline *does* check for negative values: > > if (rows > 0) > _rl_screenheight = rows; > .. etc .. Yeah, it's implementing what is documented: "Function: void rl_set_screen_size (int rows, int cols) Set Readline's idea of the terminal size to rows rows and cols columns. If either rows or columns is less than or equal to 0, Readline's idea ^^^^^^^^^^^^^^^^^^^^^^^ of that terminal dimension is unchanged." Note the "less than or equal to 0". I would assume that that comes from a "it's obviously bogus to have negative sizes, so we'll just ignore them" perspective. > > So gdb's approach: > > if (rows <= 0) > rows = INT_MAX; > > ... actively works around the existing checks in readline. I'd call it more like mapping different ranges/APIs. gdb uses "0" or UINT_MAX for unlimited: (gdb) help set height Set number of lines in a page for GDB output pagination. This affects the number of lines after which GDB will pause its output and ask you whether to continue. Setting this to "unlimited" or zero causes GDB never pause during output. While negative numbers don't work on the command line: (gdb) set height -1 integer -1 out of range you end up with negative rows/cols in that quoted code if you do "set height/width unlimited", because lines_per_page/chars_per_line are unsigned integers and "unlimited" sets them to UINT_MAX. And also, if you do (gdb) set height 'unsigned number between INT_MAX and UINT_MAX' like: (gdb) set height 0x80000000 then that code: if (rows <= 0) rows = INT_MAX; maps the value to INT_MAX, which is basically the same thing in practice -- a huge number is practically the same as "unlimited" here. Thanks, Pedro Alves