From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88930 invoked by alias); 21 Mar 2016 18:35:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88898 invoked by uid 89); 21 Mar 2016 18:35:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=responds, Issues, quality, again! X-HELO: usplmg21.ericsson.net Received: from usplmg21.ericsson.net (HELO usplmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Mar 2016 18:34:42 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usplmg21.ericsson.net (Symantec Mail Security) with SMTP id 80.3E.22441.E9E30F65; Mon, 21 Mar 2016 19:34:06 +0100 (CET) Received: from EUSAAMB103.ericsson.se ([147.117.188.120]) by EUSAAHC003.ericsson.se ([147.117.188.81]) with mapi id 14.03.0248.002; Mon, 21 Mar 2016 14:34:39 -0400 From: Marc Khouzam To: Pedro Alves , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2 00/25] Towards great frontend GDB consoles Date: Mon, 21 Mar 2016 18:35:00 -0000 Message-ID: References: <1458573675-15478-1-git-send-email-palves@redhat.com> In-Reply-To: <1458573675-15478-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00426.txt.bz2 > From: Pedro Alves [palves@redhat.com] > Sent: March 21, 2016 11:20 AM > To: gdb-patches@sourceware.org > Cc: Marc Khouzam > Subject: [PATCH v2 00/25] Towards great frontend GDB consoles >=20 > Here's an update of the series I first posted here: > https://sourceware.org/ml/gdb-patches/2016-02/msg00067.html >=20 > New in v2: >=20 > - The "Command line input handling TLC" patch [1] has since been split > into a series of its own [2], and pushed in. >=20 > [1] https://sourceware.org/ml/gdb-patches/2016-02/msg00070.html > [2] https://sourceware.org/ml/gdb-patches/2016-02/msg00557.html >=20 > - Currently, if GDB's (main) stdin closes, GDB exits. That logic > carried over to secondary UIs as well, by mistake, so v1, if a > secondary UI's terminal was closed, GDB would just exit as well... > In v2, that's now detected, and GDB just discards the UI. >=20 > - I noticed that if you typed something in a secondary UI, and then > Ctrl-C'd the main UI, GDB would internal error. The problem was > that nothing was making use async signal handlers (in this case, > async_request_quit) always run on the main UI. >=20 > - Added a convenience "info uis" command to list UIs. >=20 > - Some cleanups here and there >=20 > Force-pushed to users/palves/console at sourceware.org. =46rom the previous testing I did, and from the demo I gave, your previous patches were already of very good quality. Thank you for those. Right now, there are only three issues that I can report. They are present in v2. 1- The new-ui command should not be a repeating command 2- Using 'interpreter-exec mi" in the CLI console confuses GDB To reproduce from a shell - start GDB in CLI mode - give a "new-ui mi" command to start an MI channel - start running the inferior =3D> *stopped/*running events are on the MI= channel - in the CLI send command interpreter-exec mi "" - step or resume =3D> *stopped/*running events are now on the CLI channel and not the MI = one 3- Issues when using "set inferior-tty" To reproduce from a shell - start GDB in CLI mode - give a "new-ui mi" command to start an MI channel - use "set inferior-tty" to another tty (like eclipse does) - in the MI channel, use -exec-run =3D> the shell where GDB CLI is running no longer responds to input Feel free to ask for any clarifications. I'll be doing some more thorough testing using this feature with Eclipse, a= s the integration is almost done. I'll communicate any other issues I find. Thanks again! Marc