Re: [PATCH] PR mi/15806: Fix quoting of async events

Tom Tromey
2014-05-16T20:17:33Z

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> As you suggested, quoter == -1 could have a special meaning to modify
Simon> the behavior of printchar. However, I think we are mixing two things
Simon> that are not related. Why should the fact that I want to escape the "
Simon> character influence whether I want to escape \ ? And vice-versa.

I think it's just the normal quoting protocol. It's odd to quote one
character but not also quote the quoting character.

Simon> They seem quite independent to me. And if there are independent,
Simon> it could mean we need two separate parameters, one saying if we
Simon> want to escape a quoting character and another saying if we want
Simon> to escape the backslashes. WDYT?

Another option is to pass '\\' as QUOTER from remote.c.

It occurs to me now that the patch should probably update the comment
before printchar to document the special meaning of QUOTER==0.

Tom