From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10784 invoked by alias); 30 Jan 2014 19:21:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10775 invoked by uid 89); 30 Jan 2014 19:21:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 30 Jan 2014 19:21:44 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 5F.9A.12743.346AAE25; Thu, 30 Jan 2014 20:21:40 +0100 (CET) Received: from EUSAAMB103.ericsson.se ([147.117.188.120]) by EUSAAHC004.ericsson.se ([147.117.188.84]) with mapi id 14.02.0387.000; Thu, 30 Jan 2014 14:21:41 -0500 From: Marc Khouzam To: 'Yao Qi' , "'gdb-patches@sourceware.org'" Subject: RE: [PATCH 0/2] Create inferior fro trace file target Date: Thu, 30 Jan 2014 19:21:00 -0000 Message-ID: References: <1391060652-10870-1-git-send-email-yao@codesourcery.com> In-Reply-To: <1391060652-10870-1-git-send-email-yao@codesourcery.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg01061.txt.bz2 > -----Original Message----- > From: Yao Qi [mailto:yao@codesourcery.com] > Sent: Thursday, January 30, 2014 12:44 AM > To: gdb-patches@sourceware.org > Cc: Marc Khouzam > Subject: [PATCH 0/2] Create inferior fro trace file target >=20 > Marc reported that Eclipse is unable to load trace file with GDB 7.7, but= it > works with GDB 7.6. https://sourceware.org/ml/gdb/2014- > 01/msg00031.html > This change is caused by my patch: >=20 > [RFC] Don't create inferior in tfile target. > https://sourceware.org/ml/gdb-patches/2013-05/msg00068.html >=20 > because I didn't think inferior should be created when a tracefile is loa= ded. >=20 > On 01/30/2014 04:56 AM, Marc Khouzam wrote: > > The trace file processing is based on the core file one, which shows > > the execution tree after the core file is loaded. > > But reading your mail makes me think that it makes sense that when > > loading a trace file there would be no inferior or thread yet. > > However, when selecting a trace record, then we would need to see the > > inferior and thread. This is not the case with 7.7. >=20 > I don't know why trace file processing is based on the core file. They a= re > different, IMO. When starting the debug session, for a user, it is very similar to ask to look at a core file than to look at a trace file. So in Eclipse, it is the same UI except that the user specifies if the file is a trace file or a core file. > > To me, trace records are like a limited core file: > > a snapshot of a specific point of the execution. So, when looking at > > a trace record, just like when looking at a core file, we want to show > > the execution hierarchy, i.e., the process and thread where the record > > was collected. >=20 > The corefile has information about thread and process, but trace file > doesn't. Thread and process is not mentioned in the "Trace File Format" > doc https://sourceware.org/gdb/current/onlinedocs/gdb/Trace-File- > Format.html >=20 > Keeping trace file similar to core file is unspecified, and their code ar= e total > independent to each other. It is not good for Eclipse to assume that, un= less > we can extend trace file format to include the process id and the thread = id > in each trace frame. Eclipse fakes things a bit to make it look similar. Maybe that is not the = best way to go and I'll have to revisit that eventually. > Anyway, it is not a good time to discuss about trace file format and how > Eclipse should handle trace file. Let me focus on this problem and patch= es > at first :). Thank you. > Reverting my patch works, which is included in patch 1/2. > In patch 2/2, I add something similar to ctf target, and a test case. > Patches are regression tested on x86_64-linux. They are also tested on x= 86- > linux with babeltrace installed. I confirmed that things work again with Eclipse once I applied your patches. > In short, Eclipse replies on an undocumented GDB behavior, that GDB > should provide inferior and thread when reading a trace file while I don= 't > think GDB has to. If global maintainers think GDB 7.7 shouldn't break > Eclipse, then we should pick these two patches up. You can guess where I place my vote :) > These two patches bring an issue for multi-target support, say if GDB ope= ns > two trace files in two targets, what is the expected output of "info infe= riors" > and "info threads"? If you are asking about Eclipse, we don't support multi-target, so the prob= lem never presented itself. Maybe this should be part of a bigger discussion a= bout how trace files should be handled. > *** BLURB HERE *** (Out of curiosity, I've wondered why you have the above line in your patch = posts.) Thanks for your quick reply to the issue! Marc > Yao Qi (2): > Create inferior for tfile target > Create inferior for ctf target. >=20 > gdb/ctf.c | 24 ++++++++++++++++++++++++ > gdb/testsuite/gdb.trace/report.exp | 7 ++++++- > gdb/testsuite/gdb.trace/tfile.exp | 3 --- > gdb/tracepoint.c | 19 +++++++++++++++++++ > 4 files changed, 49 insertions(+), 4 deletions(-) >=20 > -- > 1.7.7.6