From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30564 invoked by alias); 29 Jan 2013 20:42:58 -0000 Received: (qmail 30550 invoked by uid 22791); 29 Jan 2013 20:42:57 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Jan 2013 20:42:53 +0000 Received: from EUSAAHC006.ericsson.se (Unknown_Domain [147.117.188.90]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 1B.1D.31450.C4438015; Tue, 29 Jan 2013 21:42:52 +0100 (CET) Received: from EUSAAMB103.ericsson.se ([147.117.188.120]) by EUSAAHC006.ericsson.se ([147.117.188.90]) with mapi id 14.02.0318.004; Tue, 29 Jan 2013 15:42:39 -0500 From: Marc Khouzam To: =?iso-8859-1?Q?=27Andr=E9_P=F6nitz=27?= , 'Mircea Gherzan' CC: "'tromey@redhat.com'" , "'vladimir@codesourcery.com'" , "'gdb-patches@sourceware.org'" Subject: RE: [RFC] Fix the MI result of -break-insert with multiple locations Date: Tue, 29 Jan 2013 20:42:00 -0000 Message-ID: References: <1359470164-32004-1-git-send-email-mircea.gherzan@intel.com> <20130129194520.GA3727@klara.mpi.htwm.de> In-Reply-To: <20130129194520.GA3727@klara.mpi.htwm.de> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00695.txt.bz2 > -----Original Message----- > From: apoe@hrz.tu-chemnitz.de=20 > [mailto:apoe@hrz.tu-chemnitz.de] On Behalf Of Andr=E9 P=F6nitz > Sent: Tuesday, January 29, 2013 2:45 PM > To: Mircea Gherzan > Cc: tromey@redhat.com; vladimir@codesourcery.com; Marc=20 > Khouzam; gdb-patches@sourceware.org > Subject: Re: [RFC] Fix the MI result of -break-insert with=20 > multiple locations >=20 > On Tue, Jan 29, 2013 at 03:36:04PM +0100, Mircea Gherzan wrote: > > The current MI output when printing a breakpoint with=20 > multiple locations > > is not conformant to the MI specification: > >=20 > > bkpt=3D{number=3D"1", ...},{number=3D"1.1", ...},{number=3D"1.2", ...} > >=20 > > This patch fixes this issue by moving the locations to a=20 > list inside the > > first tuple: > >=20 > > bkpt=3D{number=3D"1", ... , locations=3D[{number=3D"1.1", ...}, ...]} >=20 > This seems more like an additional burden for frontends which cannot > rely on a specific gdb version being installed as they have to keep > code to parse both results, for years. Although that is a good point, keeping it forces frontends to deal with that case. I believe this invalid output was introduced with=20 GDB 7.5. If it was fixed, an existing or future frontend may choose=20 not to support the invalid output and rely on GDB 7.6. I don't know yet what we will do in Eclipse but I know that we use GDB 7.5 now even though we don't parse the special broken output for breakpoints. So things are not broken enough to force us to support the invalid output (or at least I haven't realized that they are broken :)). > The fact that the current output might not conform to the documented > grammar has no impact to existing frontends as they have/had to cope > with this kind of slight deviations anyway. >=20 > An alternative approach would be to just make the documentation match > the actual output. This is not unprecedented. >=20 > Andre'